From: "yi1 li" <yi1.li@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config
Date: Tue, 10 May 2022 11:43:54 +0000 [thread overview]
Message-ID: <BL0PR11MB3396E6A7D5C48E42516C0461C5C99@BL0PR11MB3396.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220510104940.6os5ki54xusmeurz@sirius.home.kraxel.org>
Just for convenience.
There are too many places need to configure, so I think putting all the configuration options close together, all in process_file.pl, will be more clear to user ;)
Thank you,
Yi
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
Sent: Tuesday, May 10, 2022 6:50 PM
To: Li, Yi1 <yi1.li@intel.com>
Cc: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config
On Tue, May 10, 2022 at 12:40:13PM +0800, Yi Li wrote:
> Move auto-generated openssl config to opensslconf_generated.h, And
> opensslconf.h will contain both edk2 conditional openssl feature and
> opensslconf_generated.h.
> Will make two part more clear.
> New conditional feture code in opensslconf.h will look like:
>
> /* Autogenerated conditional openssl feature list starts here */
> [.....]
> /* Autogenerated conditional openssl feature list ends here */
Why generate opensslconf.h at all? I think the content doesn't depend on the openssl submodule sources, so there is no good reason to take the extra indirection and write it with process_files.pl. Just commit it ;)
take care,
Gerd
next prev parent reply other threads:[~2022-05-10 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 4:40 [PATCH V2 0/5] CryptoPkg/openssl: Enable EC conditionally yi1 li
2022-05-10 4:40 ` [PATCH V2 1/5] CryptoPkg: Rename PCD about openssl EC configuration yi1 li
2022-05-10 4:40 ` [PATCH V2 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config yi1 li
2022-05-10 10:49 ` Gerd Hoffmann
2022-05-10 11:43 ` yi1 li [this message]
2022-05-11 7:18 ` [edk2-devel] " Gerd Hoffmann
2022-05-11 7:37 ` yi1 li
2022-05-10 4:40 ` [PATCH V2 3/5] CryptoPkg: Update process_files.pl to automatically add PCD config option yi1 li
2022-05-10 4:40 ` [PATCH V2 4/5] CryptoPkg/openssl: update generated files yi1 li
2022-05-10 4:40 ` [PATCH V2 5/5] CryptoPkg/openssl: disable codestyle checks for " yi1 li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3396E6A7D5C48E42516C0461C5C99@BL0PR11MB3396.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox