From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.27352.1592138161600989610 for ; Sun, 14 Jun 2020 05:36:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cqX4Jyv/; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) IronPort-SDR: rfPDwIck5nExB1C5XTkLPexcVy3XCGbTckMIkb8RbSuMHROYHgYwx448RUTuaKpC702RdcaEmN m2BbculmCSWQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2020 05:36:00 -0700 IronPort-SDR: cic1y3btHYPi0FmnImIwU/SwSEvqlxishDi+Kd/Q+rjZQ+2Xj6fiF1nuWGQ6TRjyAmSEy5czpj icUT21mFz68A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,511,1583222400"; d="scan'208";a="272449113" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 14 Jun 2020 05:36:00 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 05:36:00 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 05:35:59 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.55) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 05:35:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFHOesTphb6w+OOFGLcXOiApQ7m2ZmiTQ5m1WwqikUmRAtx4K+KJ/wCkMvKyUdYCjlYJiJcALfC4bjWRSdSNJz/LqSSjJ3x0m5LmmMwyXwjaJekRLGn6Y96vgIw3iDYX/ieWCcL+qHu+srByvBy9GY78MF5KBuEm4hAqDoZsMDgERF0V5HQa1K83oKboXotwBolYfuDDtxeRq5mwF8z3HM/FOREq1il7BVFcko2cL73xcR7DtnB6bblJ3mBkPmJnz60biFuC+gSOLCAKwvfjuR2FibgQjQRLw1nM1AfCVh6tPPrCYSFOCLYnQRwxKnfNUxFheUZuBGE3M1a3lEwrbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4u2O3Rn+vZpfYjsNeZhYlJdeagl/hskB0aeR94DaNoA=; b=kqJSbJhLYshT3ht8XThAxVdRmwpPcdWNwO7ol5tMFF3I4i8qjo4blZyuQfaWLYhXv4FyGlhBbqQ+teQI+XXkaJD12H0aCZ1C1K0Lk9EobBskw84SvsYDo3W2jD/o95kAzGCWpxTy/HCBdtpibPmD9zjKIihX1x/X6Ec1pjZARsUaRI7waXOmqoztQS+YX+KyHPOiGBaSr1GgF1v/P6rlJHknLvs4lsayHHNmPWD1xEEqtAKyiv55gKJG2XK/mf2sToAFvjCybTrOVgyPVVmK03e6Es8wzQbUDgFKL4P7MoJDEjnY4xeBPpRhAC9SCHaQvSfyCWMUq7fVeieQahwOoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4u2O3Rn+vZpfYjsNeZhYlJdeagl/hskB0aeR94DaNoA=; b=cqX4Jyv/0K4dnpFl6Ij41R8mD1G2MGdo/THpYa6jzhHSdoNwtDXBlWeTfJZ1h1lFmCkqY4EVC1qROCngvUcts1e/OkuYway9K/55d51N/vMYbc/U7CgsMEjvzk93KMY6qFPzzg9iJp5fbWSbHDbJle/JpO0hxFPbL0jwjbqmKlo= Received: from BL0PR11MB3412.namprd11.prod.outlook.com (2603:10b6:208:7c::32) by MN2PR11MB4397.namprd11.prod.outlook.com (2603:10b6:208:190::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.24; Sun, 14 Jun 2020 12:35:58 +0000 Received: from BL0PR11MB3412.namprd11.prod.outlook.com ([fe80::a0dd:b860:2661:de87]) by BL0PR11MB3412.namprd11.prod.outlook.com ([fe80::a0dd:b860:2661:de87%6]) with mapi id 15.20.3088.028; Sun, 14 Jun 2020 12:35:58 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "ard.biesheuvel@arm.com" CC: "Kinney, Michael D" , "Gao, Liming" , Sami Mujawar , Ilias Apalodimas Subject: Re: [edk2-devel] [PATCH 2/5] StandaloneMmPkg/Core: fix bogus FV pointer in DEBUG string Thread-Topic: [edk2-devel] [PATCH 2/5] StandaloneMmPkg/Core: fix bogus FV pointer in DEBUG string Thread-Index: AQHWPv+nNJx1Qw/ZQ0uu2EXI1noXtajYEprw Date: Sun, 14 Jun 2020 12:35:58 +0000 Message-ID: References: <20200610081740.54581-1-ard.biesheuvel@arm.com> <20200610081740.54581-3-ard.biesheuvel@arm.com> In-Reply-To: <20200610081740.54581-3-ard.biesheuvel@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDI1MTNjZmItM2UxMy00Mzc2LWJiYzQtNGZjZTM2Mjc3MGRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZjRqbzNKWWJjYTcwOHFBc2NFRUdrc2NGY0hmNTlNQVVDZzFlRjREaU9GZUJGaENkVlF0TEhKcWhiTXZ2YUNOUiJ9 x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16826967-5330-4565-3f3d-08d8105f7d59 x-ms-traffictypediagnostic: MN2PR11MB4397: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04347F8039 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w2DsxV6MG0chOjpY75BavSIlK0JAQi6NPrFnyEjtKJ8P1WUsqu3e/fVefg40KiDlr+zSCZhIlh6ogNj2gLvfNnY6jnZsrfCw4s1YXf7gIsVOrQjkBli12PCKhj1wWWldGfXqoqxMAtudfcgp8/9SReuw/SpnOMENhB+YQH96xcLm2h5UsvMmvNZrv7sMMLiEZEfwoASLed3SdzdCp0YKy8aUTv43aI/jjucKlgPqDJ5cbPSJ3Xrb5K/ORFwkABLFX8FfLXgVdCmU+1H1Ed0ICLPum4f/mJcDpVzL62FpDvkjfagOZDnpp/lofZt8CRsD2U7wg1IWUwriHBKcpQ1e2bAEWK27aI75lpkdZaGFtCt4WGGCjwudxA0B1zhsc7hPIwwKPwTp/uYUkvMgpYW8Qg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3412.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(346002)(366004)(376002)(136003)(39860400002)(396003)(8936002)(9686003)(8676002)(6506007)(66446008)(76116006)(66946007)(966005)(66556008)(66476007)(53546011)(4326008)(478600001)(2906002)(186003)(64756008)(86362001)(55016002)(83380400001)(26005)(71200400001)(33656002)(110136005)(54906003)(7696005)(5660300002)(52536014)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ddd1B1BILhAqrXbDAjsay0lgPmzaXYB6GEhUgOcba3QtL7u2XZLset/TIzTHacfbIzIfn3HblZTQocwlqy8PV5xyGR4n9x/kbvfSE9j5I/dfr4juFQbQvZlSIc+hjuLJPkn2UYOBV9ojK+b55UBIaxsNiD5fzkv99Aj1dV57ekgqM+29tKgj1qf1k1SaBgDpc26fDaR9pjxEGxYIRIkAISOBXZF3pcPa1KdncmPBcKHZuFxWZdpU+7iNtsxOWqe6NiyaaNuVDtJkYzMhvnsHnnPvAAoNU8URJlzEGl/ZgYadfLuGZ3rGTi3sm8ZIe95RWp41ie1vQdnSTmJD4wUKgeILi5Xri+5p4PNlXkkpmdqfMyDDUSVPzHLUJKo9M1ZLydeEu89RPQ1O99GEHAUCa/SSf53033JiypqQWVGWR3oz4clbdLO7JGOYH1Fa/EaRMYLBb6N8VdKiezYzb+PD4OlQq9rPZAD7hsAn+foXG6M= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 16826967-5330-4565-3f3d-08d8105f7d59 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2020 12:35:58.1834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xro1ygfpZcAei55H6Wb2eHMQlZTQPfXqnimAA21DbiX/jhm7Yaxp3yVVQz/f5e4xnNn1a2WxHCj4UsXfxJQKgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4397 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Wednesday, June 10, 2020 4:18 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Gao, Liming ; Yao, > Jiewen ; Sami Mujawar ; > Ilias Apalodimas > Subject: [edk2-devel] [PATCH 2/5] StandaloneMmPkg/Core: fix bogus FV poin= ter > in DEBUG string >=20 > FvIsBeingProcessed () emits a DEBUG print with the intent to print > the memory address of the FV that is being processed, but instead, > it prints the contents of an uninitialized stack variable. >=20 > Signed-off-by: Ard Biesheuvel > --- > StandaloneMmPkg/Core/Dispatcher.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/StandaloneMmPkg/Core/Dispatcher.c > b/StandaloneMmPkg/Core/Dispatcher.c > index 2f795d01dc1f..c99e6c04c8de 100644 > --- a/StandaloneMmPkg/Core/Dispatcher.c > +++ b/StandaloneMmPkg/Core/Dispatcher.c > @@ -816,7 +816,7 @@ FvIsBeingProcessed ( > { >=20 > KNOWN_FWVOL *KnownFwVol; >=20 >=20 >=20 > - DEBUG ((DEBUG_INFO, "FvIsBeingProcessed - 0x%08x\n", KnownFwVol)); >=20 > + DEBUG ((DEBUG_INFO, "FvIsBeingProcessed - 0x%08x\n", FwVolHeader)); >=20 >=20 >=20 > KnownFwVol =3D AllocatePool (sizeof (KNOWN_FWVOL)); >=20 > ASSERT (KnownFwVol !=3D NULL); >=20 > -- > 2.26.2 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#61040): https://edk2.groups.io/g/devel/message/61040 > Mute This Topic: https://groups.io/mt/74792289/1772286 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen.yao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D