From: "Prakashan, Krishnadas Veliyathuparambil" <krishnadas.veliyathuparambil.prakashan@intel.com>
To: "Guo, Gua" <gua.guo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Hsu, VictorX" <victorx.hsu@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"K N, Karthik" <karthik.k.n@intel.com>,
"Chan, Laura" <laura.chan@intel.com>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>, "Lu, James" <james.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
Date: Wed, 3 May 2023 23:54:20 +0000 [thread overview]
Message-ID: <BL0PR11MB3476952726B5953EE020A5B3CF6C9@BL0PR11MB3476.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BL1PR11MB5478B78ED61E937F919CBD2BEF6C9@BL1PR11MB5478.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 8653 bytes --]
Hello @K N, Karthik<mailto:karthik.k.n@intel.com>,
Sorry. As I'm OOO, could you please help to review the same and provide your feedback.
Thanks,
Krishnadas
From: Guo, Gua <gua.guo@intel.com>
Sent: 04 May 2023 02:19 AM
To: devel@edk2.groups.io; Guo, Gua <gua.guo@intel.com>; Hsu, VictorX <victorx.hsu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com>; Chan, Laura <laura.chan@intel.com>
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
Thanks for @K N, Karthik<mailto:karthik.k.n@intel.com> and @Prakashan, Krishnadas Veliyathuparambil<mailto:krishnadas.veliyathuparambil.prakashan@intel.com> help to review it from your side.
Hi Mike
Do we have any stakeholder from Edk2 side also need to them to review it before checking the source code ? I can also cc them into the mail loop.
Thanks,
Gua
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua
Sent: Monday, April 24, 2023 9:38 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>; Chan, Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>
Cc: Chiu, Chasel <chasel.chiu@intel.com<mailto:chasel.chiu@intel.com>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>
Subject: Re: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
@Kinney, Michael D<mailto:michael.d.kinney@intel.com>, @K N, Karthik<mailto:karthik.k.n@intel.com>, @Prakashan, Krishnadas Veliyathuparambil<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>, @Chan, Laura<mailto:laura.chan@intel.com>
Could you share me about your concern ?
If no additional concern, please help to give your review-by we can check in ASAP.
Thanks,
Gua
-----Original Message-----
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua
Sent: Friday, April 21, 2023 10:33 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
Cc: Chiu, Chasel <chasel.chiu@intel.com<mailto:chasel.chiu@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>; Chan, Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>
Subject: Re: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
+ Related folk
I want to let the PR for related stakeholder review it.
And have any open ?
https://github.com/tianocore/edk2/pull/3901
Thanks,
Gua
-----Original Message-----
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>
Sent: Tuesday, April 18, 2023 7:05 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
Subject: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
- TraceHub UniversalPayload Spec: https://github.com/UniversalScalableFirmware/documentation/pull/52 (Industry Standard)
- MipiSysTLib Wrapper: https://github.com/MIPI-Alliance/public-mipi-sys-t.git (Industry Standard)
- TraceHubDebugLib: Intel(R) Trace Hub (TH) — The Linux Kernel documentation (Industry Standard)
Developers Guide: https://cdrdv2-public.intel.com/671536/intel-trace-hub-developers-manual-2-1-2.pdf (Public Document)
VictorX Hsu (4):
MdePkg: Add MipiSysTLib library
MdeModulePkg: Add TraceHubDebugSysTLib library
MdePkg: Add NULL library of TraceHubDebugSysTLib
Maintainers.txt: Update reviewers and maintainers for Trace Hub dbg
lib.
.gitmodules | 5 +-
.pytool/CISettings.py | 2 +
Maintainers.txt | 18 +
.../Include/Guid/TraceHubDebugInfoHob.h | 25 +
.../BaseTraceHubDebugSysTLib.c | 251 ++++++
.../BaseTraceHubDebugSysTLib.inf | 44 +
.../DxeSmmTraceHubDebugSysTLib.c | 247 ++++++
.../DxeSmmTraceHubDebugSysTLib.inf | 50 ++
.../InternalTraceHubApi.c | 82 ++
.../InternalTraceHubApi.h | 46 +
.../InternalTraceHubApiCommon.c | 208 +++++
.../InternalTraceHubApiCommon.h | 119 +++
.../PeiTraceHubDebugSysTLib.c | 290 +++++++
.../PeiTraceHubDebugSysTLib.inf | 50 ++
.../Library/TraceHubDebugSysTLib/Readme.md | 30 +
MdeModulePkg/MdeModulePkg.dec | 21 +
MdeModulePkg/MdeModulePkg.dsc | 3 +
MdeModulePkg/MdeModulePkg.uni | 18 +
MdePkg/Include/Library/MipiSysTLib.h | 66 ++
MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++
MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++
MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++
MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 55 ++
MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++
MdePkg/Library/MipiSysTLib/Platform.h | 138 +++
MdePkg/Library/MipiSysTLib/Readme.md | 25 +
MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 ++++++++++++++++++
MdePkg/Library/MipiSysTLib/mipisyst | 1 +
.../TraceHubDebugSysTLibNull.c | 76 ++
.../TraceHubDebugSysTLibNull.inf | 29 +
MdePkg/MdePkg.ci.yaml | 15 +-
MdePkg/MdePkg.dec | 9 +
MdePkg/MdePkg.dsc | 2 +
ReadMe.rst | 1 +
34 files changed, 3212 insertions(+), 3 deletions(-) create mode 100644 MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.inf
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.c
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.inf
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.h
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.inf
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md
create mode 100644 MdePkg/Include/Library/MipiSysTLib.h
create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h
create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py
create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c
create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf
create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c
create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h
create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md
create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h
create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst
create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c
create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf
--
2.40.0.windows.1
[-- Attachment #2: Type: text/html, Size: 22161 bytes --]
prev parent reply other threads:[~2023-05-03 23:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 11:04 [PATCH 0/4] Trace Hub debug library support victorx.hsu
2023-04-18 11:04 ` [PATCH 1/4] MdePkg: Add MipiSysTLib library victorx.hsu
2023-04-18 11:04 ` [PATCH 2/4] MdeModulePkg: Add TraceHubDebugSysTLib library victorx.hsu
2023-04-18 11:05 ` [PATCH 3/4] MdePkg: Add NULL library of TraceHubDebugSysTLib victorx.hsu
2023-04-18 11:05 ` [PATCH 4/4] Maintainers.txt: Update reviewers and maintainers for Trace Hub dbg lib victorx.hsu
2023-04-21 2:33 ` [edk2-devel] [PATCH 0/4] Trace Hub debug library support Guo, Gua
2023-05-08 0:45 ` Michael D Kinney
2023-05-08 5:18 ` Hsu, VictorX
2023-05-08 5:21 ` Michael D Kinney
[not found] ` <1757D27BA79AB0E1.26256@groups.io>
2023-04-24 1:37 ` Guo, Gua
[not found] ` <1758BB2DE6DD05C7.10313@groups.io>
2023-05-03 20:48 ` Guo, Gua
2023-05-03 23:54 ` Prakashan, Krishnadas Veliyathuparambil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3476952726B5953EE020A5B3CF6C9@BL0PR11MB3476.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox