From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list
Date: Thu, 14 May 2020 23:37:55 +0000 [thread overview]
Message-ID: <BL0PR11MB348910D339A642D5B7F34BF0CDBC0@BL0PR11MB3489.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200512184524.14376-1-ashley.e.desimone@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: Desimone, Ashley E <ashley.e.desimone@intel.com>
> Sent: Tuesday, May 12, 2020 11:45 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of
> manifest_repo_list
>
> Update the manifest_repo_list property to return an empty list if no
> [manifest-repos] section was present in the config file.
>
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
> edkrepo/config/config_factory.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/edkrepo/config/config_factory.py
> b/edkrepo/config/config_factory.py
> index c0b9f68..116cb24 100644
> --- a/edkrepo/config/config_factory.py
> +++ b/edkrepo/config/config_factory.py
> @@ -119,6 +119,8 @@ class BaseConfig():
> """Returns a list of available manifest repos"""
> if self.cfg.has_section('manifest-repos'):
> return self.cfg.options('manifest-repos')
> + else:
> + return []
>
> def manifest_repo_props(self, manifest_repo):
> """
> --
> 2.16.2.windows.1
next prev parent reply other threads:[~2020-05-14 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 18:45 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list Ashley E Desimone
2020-05-12 20:26 ` Bjorge, Erik C
2020-05-12 20:29 ` Agyeman, Prince
2020-05-14 23:37 ` Nate DeSimone [this message]
2020-05-14 23:43 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB348910D339A642D5B7F34BF0CDBC0@BL0PR11MB3489.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox