[edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list
@ 2020-05-12 18:45 Ashley E Desimone
  2020-05-12 20:26 ` Bjorge, Erik C
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Ashley E Desimone @ 2020-05-12 18:45 UTC (permalink / raw)
  To: devel
  Cc: Nate DeSimone, Puja Pandya, Erik Bjorge, Bret Barkelew,
	Prince Agyeman

Update the manifest_repo_list property to return an empty
list if no [manifest-repos] section was present in the config
file.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo/config/config_factory.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index c0b9f68..116cb24 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -119,6 +119,8 @@ class BaseConfig():
         """Returns a list of available manifest repos"""
         if self.cfg.has_section('manifest-repos'):
             return self.cfg.options('manifest-repos')
+        else:
+            return []
 
     def manifest_repo_props(self, manifest_repo):
         """
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list
  2020-05-12 18:45 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list Ashley E Desimone
@ 2020-05-12 20:26 ` Bjorge, Erik C
  2020-05-12 20:29 ` Agyeman, Prince
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Bjorge, Erik C @ 2020-05-12 20:26 UTC (permalink / raw)
  To: Desimone, Ashley E, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew,
	Agyeman, Prince

Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Tuesday, May 12, 2020 11:45 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list

Update the manifest_repo_list property to return an empty list if no [manifest-repos] section was present in the config file.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo/config/config_factory.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index c0b9f68..116cb24 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -119,6 +119,8 @@ class BaseConfig():
         """Returns a list of available manifest repos"""
         if self.cfg.has_section('manifest-repos'):
             return self.cfg.options('manifest-repos')
+        else:
+            return []
 
     def manifest_repo_props(self, manifest_repo):
         """
--
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list
  2020-05-12 18:45 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list Ashley E Desimone
  2020-05-12 20:26 ` Bjorge, Erik C
@ 2020-05-12 20:29 ` Agyeman, Prince
  2020-05-14 23:37 ` Nate DeSimone
  2020-05-14 23:43 ` Nate DeSimone
  3 siblings, 0 replies; 5+ messages in thread
From: Agyeman, Prince @ 2020-05-12 20:29 UTC (permalink / raw)
  To: Desimone, Ashley E, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Pandya, Puja, Bjorge, Erik C,
	Bret Barkelew

Reviewed-by: Prince Agyeman <prince.agyeman@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Tuesday, May 12, 2020 11:45 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list

Update the manifest_repo_list property to return an empty list if no [manifest-repos] section was present in the config file.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo/config/config_factory.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index c0b9f68..116cb24 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -119,6 +119,8 @@ class BaseConfig():
         """Returns a list of available manifest repos"""
         if self.cfg.has_section('manifest-repos'):
             return self.cfg.options('manifest-repos')
+        else:
+            return []
 
     def manifest_repo_props(self, manifest_repo):
         """
--
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list
  2020-05-12 18:45 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list Ashley E Desimone
  2020-05-12 20:26 ` Bjorge, Erik C
  2020-05-12 20:29 ` Agyeman, Prince
@ 2020-05-14 23:37 ` Nate DeSimone
  2020-05-14 23:43 ` Nate DeSimone
  3 siblings, 0 replies; 5+ messages in thread
From: Nate DeSimone @ 2020-05-14 23:37 UTC (permalink / raw)
  To: Desimone, Ashley E, devel@edk2.groups.io
  Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew, Agyeman, Prince

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Desimone, Ashley E <ashley.e.desimone@intel.com>
> Sent: Tuesday, May 12, 2020 11:45 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of
> manifest_repo_list
> 
> Update the manifest_repo_list property to return an empty list if no
> [manifest-repos] section was present in the config file.
> 
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  edkrepo/config/config_factory.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/edkrepo/config/config_factory.py
> b/edkrepo/config/config_factory.py
> index c0b9f68..116cb24 100644
> --- a/edkrepo/config/config_factory.py
> +++ b/edkrepo/config/config_factory.py
> @@ -119,6 +119,8 @@ class BaseConfig():
>          """Returns a list of available manifest repos"""
>          if self.cfg.has_section('manifest-repos'):
>              return self.cfg.options('manifest-repos')
> +        else:
> +            return []
> 
>      def manifest_repo_props(self, manifest_repo):
>          """
> --
> 2.16.2.windows.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list
  2020-05-12 18:45 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list Ashley E Desimone
                   ` (2 preceding siblings ...)
  2020-05-14 23:37 ` Nate DeSimone
@ 2020-05-14 23:43 ` Nate DeSimone
  3 siblings, 0 replies; 5+ messages in thread
From: Nate DeSimone @ 2020-05-14 23:43 UTC (permalink / raw)
  To: Desimone, Ashley E, devel@edk2.groups.io
  Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew, Agyeman, Prince

Pushed: 78a9765d

> -----Original Message-----
> From: Desimone, Ashley E <ashley.e.desimone@intel.com>
> Sent: Tuesday, May 12, 2020 11:45 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of
> manifest_repo_list
> 
> Update the manifest_repo_list property to return an empty list if no
> [manifest-repos] section was present in the config file.
> 
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  edkrepo/config/config_factory.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/edkrepo/config/config_factory.py
> b/edkrepo/config/config_factory.py
> index c0b9f68..116cb24 100644
> --- a/edkrepo/config/config_factory.py
> +++ b/edkrepo/config/config_factory.py
> @@ -119,6 +119,8 @@ class BaseConfig():
>          """Returns a list of available manifest repos"""
>          if self.cfg.has_section('manifest-repos'):
>              return self.cfg.options('manifest-repos')
> +        else:
> +            return []
> 
>      def manifest_repo_props(self, manifest_repo):
>          """
> --
> 2.16.2.windows.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-14 23:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-12 18:45 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list Ashley E Desimone
2020-05-12 20:26 ` Bjorge, Erik C
2020-05-12 20:29 ` Agyeman, Prince
2020-05-14 23:37 ` Nate DeSimone
2020-05-14 23:43 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox