public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer
@ 2020-04-17  0:38 Bjorge, Erik C
  2020-04-19  1:06 ` [edk2-devel] " Nate DeSimone
  2020-04-19  1:15 ` Nate DeSimone
  0 siblings, 2 replies; 3+ messages in thread
From: Bjorge, Erik C @ 2020-04-17  0:38 UTC (permalink / raw)
  To: devel
  Cc: Ashley DeSimone, Nate DeSimone, Puja Pandya, Bret Barkelew,
	Prince Agyeman

When installing packages pip may attempt to download dependencies.  The
installer should contain all dependencies so tell pip where to look
for any dependencies.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo_installer/linux-scripts/install.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo_installer/linux-scripts/install.py b/edkrepo_installer/linux-scripts/install.py
index 099954d..0f10ac6 100755
--- a/edkrepo_installer/linux-scripts/install.py
+++ b/edkrepo_installer/linux-scripts/install.py
@@ -666,7 +666,7 @@ def do_install():
             whl = wheels_to_install[whl_name]['wheel']
             install_whl = wheels_to_install[whl_name]['install']
             if install_whl:
-                install_cmd = [def_python, '-m', 'pip', 'install']
+                install_cmd = [def_python, '-m', 'pip', 'install', '--no-index', '--find-links={}'.format(whl_src_dir)]
                 if install_to_local:
                     install_cmd.append('--user')
                 install_cmd.append(os.path.join(whl_src_dir, whl))
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer
  2020-04-17  0:38 [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer Bjorge, Erik C
@ 2020-04-19  1:06 ` Nate DeSimone
  2020-04-19  1:15 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2020-04-19  1:06 UTC (permalink / raw)
  To: devel@edk2.groups.io, Bjorge, Erik C
  Cc: Desimone, Ashley E, Pandya, Puja, Bret Barkelew, Agyeman, Prince

Reviewed-by: Nate Desimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C
Sent: Thursday, April 16, 2020 5:38 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer

When installing packages pip may attempt to download dependencies.  The installer should contain all dependencies so tell pip where to look for any dependencies.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo_installer/linux-scripts/install.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo_installer/linux-scripts/install.py b/edkrepo_installer/linux-scripts/install.py
index 099954d..0f10ac6 100755
--- a/edkrepo_installer/linux-scripts/install.py
+++ b/edkrepo_installer/linux-scripts/install.py
@@ -666,7 +666,7 @@ def do_install():
             whl = wheels_to_install[whl_name]['wheel']
             install_whl = wheels_to_install[whl_name]['install']
             if install_whl:
-                install_cmd = [def_python, '-m', 'pip', 'install']
+                install_cmd = [def_python, '-m', 'pip', 'install', 
+ '--no-index', '--find-links={}'.format(whl_src_dir)]
                 if install_to_local:
                     install_cmd.append('--user')
                 install_cmd.append(os.path.join(whl_src_dir, whl))
--
2.21.0.windows.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer
  2020-04-17  0:38 [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer Bjorge, Erik C
  2020-04-19  1:06 ` [edk2-devel] " Nate DeSimone
@ 2020-04-19  1:15 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2020-04-19  1:15 UTC (permalink / raw)
  To: devel@edk2.groups.io, Bjorge, Erik C
  Cc: Desimone, Ashley E, Pandya, Puja, Bret Barkelew, Agyeman, Prince

Pushed: https://github.com/tianocore/edk2-staging/commit/14b81a10

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C
Sent: Thursday, April 16, 2020 5:38 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer

When installing packages pip may attempt to download dependencies.  The installer should contain all dependencies so tell pip where to look for any dependencies.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo_installer/linux-scripts/install.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo_installer/linux-scripts/install.py b/edkrepo_installer/linux-scripts/install.py
index 099954d..0f10ac6 100755
--- a/edkrepo_installer/linux-scripts/install.py
+++ b/edkrepo_installer/linux-scripts/install.py
@@ -666,7 +666,7 @@ def do_install():
             whl = wheels_to_install[whl_name]['wheel']
             install_whl = wheels_to_install[whl_name]['install']
             if install_whl:
-                install_cmd = [def_python, '-m', 'pip', 'install']
+                install_cmd = [def_python, '-m', 'pip', 'install', 
+ '--no-index', '--find-links={}'.format(whl_src_dir)]
                 if install_to_local:
                     install_cmd.append('--user')
                 install_cmd.append(os.path.join(whl_src_dir, whl))
--
2.21.0.windows.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-19  1:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-17  0:38 [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer Bjorge, Erik C
2020-04-19  1:06 ` [edk2-devel] " Nate DeSimone
2020-04-19  1:15 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox