From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points
Date: Tue, 21 Apr 2020 20:37:39 +0000 [thread overview]
Message-ID: <BL0PR11MB3489388FA28BF22F08A9F670CDD50@BL0PR11MB3489.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cover.1576282834.git.prince.agyeman@intel.com>
This patch series has gotten very old and the review comments were minor and cosmetic. Since this is a good new feature, I have made the cosmetic fixes and pushed the patch series as 765cbda6~..5a60c2de.
Thanks,
Nate
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Agyeman, Prince
Sent: Friday, December 13, 2019 5:32 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
This patch series implements BDS hook points as defined in the EDK II Minimum Platform Specification. For details, see https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/appendix_a_full_maps/a3_bds_hook_points.html
What was done:
* MinplatformPkg: Three BDS event group PCDs were added
- gBdsEventBeforeConsoleAfterTrustedConsoleGuid
- gBdsEventBeforeConsoleBeforeEndOfDxeGuid
- gBdsEventAfterConsoleReadyBeforeBootOptionGuid
* DxePlatformBootManager: MinplatformPkg's DxePlatformBootManager library instance was modified to signal the three newly added BDS events groups
* BoardBdsHookLib: BDS event callback library was added.
This library implements the callbacks for the three Bds event groups as well as callbacks for already existing gEfiEndOfDxeEventGroupGuid, gEfiPciEnumerationCompleteProtocolGuid and gEfiDxeSmmReadyToLockProtocolGuid event groups
- A default implementation of the board BDS hook library
was added to BoardModulePkg
- A SimicOpenBoardPkg specific implementation of the Board BDS
hook library was also added
* BoardBdsHookDxe: A generic DXE driver that registers the callbacks implemented in the Board BDS hook library was added
* BoardBootManagerLib: A board boot manager library was added.
This library implements PlatformBootManagerWaitCallback and PlatformBootManagerUnableToBoot needed by Minplatform's PlatformBootManager libary instance.
- A null instance of this library was added to MinplatformPkg
- A default instance of this library was added to BoardModulePkg
- A SimicOpenBoardPkg instance was implemented
* Support for the BDS Hook points were added to all the Minplatform boards
Prince Agyeman (11):
MinPlatformPkg: Add BDS Hook Point Guids
BoardModulePkg: Add BDS Hook Library
BoardModulePkg: Add BDS Hook DXE Driver
MinPlatformPkg: Add BDS Board Boot Manager library
MinPlatformPkg: Add BDS Hook Points
BoardModulePkg: Add Generic BoardBootManagerLib
KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver
WhiskeylakeOpenBoardPkg: Add BDS Hook Dxe Driver
SimicsOpenBoardPkg: Add Bds Hook Library
SimicsOpenBoardPkg: Add BDS Board Boot Manager library
SimicsOpenBoardPkg: Add Bds Hook Points
.../BoardBdsHookDxe/BoardBdsHookDxe.c | 121 ++
.../BoardBdsHookDxe/BoardBdsHookDxe.inf | 46 +
.../Include/Library/BoardBdsHookLib.h | 100 +
.../Library/BoardBdsHookLib/BoardBdsHook.h | 211 +++
.../Library/BoardBdsHookLib/BoardBdsHookLib.c | 1390 ++++++++++++++
.../BoardBdsHookLib/BoardBdsHookLib.inf | 95 +
.../BoardBdsHookLib/BoardBootOption.c} | 87 +-
.../BoardBdsHookLib/BoardMemoryTest.c} | 4 +-
.../BoardBootManagerLib/BoardBootManager.c | 103 ++
.../BoardBootManagerLib.inf | 39 +
.../GalagoPro3/OpenBoardPkg.dsc | 7 +
.../GalagoPro3/OpenBoardPkg.fdf | 1 +
.../KabylakeRvp3/OpenBoardPkg.dsc | 6 +
.../KabylakeRvp3/OpenBoardPkg.fdf | 1 +
.../BoardBootManagerLib.c | 38 +
.../BoardBootManagerLibNull.inf | 31 +
.../DxePlatformBootManagerLib/BdsPlatform.c | 1262 +------------
.../DxePlatformBootManagerLib/BdsPlatform.h | 181 +-
.../DxePlatformBootManagerLib.inf | 51 +-
.../Include/Library/BoardBootManagerLib.h | 39 +
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 +
.../BoardX58Ich10/OpenBoardPkg.dsc | 10 +-
.../BoardX58Ich10/OpenBoardPkg.fdf | 1 +
.../Library/BoardBdsHookLib/BoardBdsHook.h | 173 ++
.../Library/BoardBdsHookLib/BoardBdsHookLib.c | 1630 +++++++++++++++++
.../BoardBdsHookLib/BoardBdsHookLib.inf | 81 +
.../BoardBootManagerLib/BoardBootManager.c | 67 +
.../BoardBootManagerLib.inf | 45 +
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 4 +
.../WhiskeylakeURvp/OpenBoardPkg.fdf | 1 +
30 files changed, 4421 insertions(+), 1409 deletions(-) create mode 100644 Platform/Intel/BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.c
create mode 100644 Platform/Intel/BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
create mode 100644 Platform/Intel/BoardModulePkg/Include/Library/BoardBdsHookLib.h
create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook.h
create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf
rename Platform/Intel/{MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/PlatformBootOption.c => BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c} (87%) rename Platform/Intel/{MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/MemoryTest.c => BoardModulePkg/Library/BoardBdsHookLib/BoardMemoryTest.c} (93%) create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBootManagerLib/BoardBootManager.c
create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf
create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLib.c
create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLibNull.inf
create mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h
create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf
create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/BoardBootManager.c
create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf
--
2.19.1.windows.1
next prev parent reply other threads:[~2020-04-21 20:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 1:32 [edk2-platforms] [PATCH 00/11] Add BDS Hook Points Agyeman, Prince
2019-12-14 1:32 ` [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids Agyeman, Prince
2019-12-16 1:31 ` Chiu, Chasel
2019-12-16 8:50 ` [edk2-devel] " Ni, Ray
2019-12-17 23:58 ` Kubacki, Michael A
2019-12-18 0:11 ` Ni, Ray
2019-12-18 1:31 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 02/11] BoardModulePkg: Add BDS Hook Library Agyeman, Prince
2019-12-18 1:19 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 03/11] BoardModulePkg: Add BDS Hook DXE Driver Agyeman, Prince
2019-12-18 1:32 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library Agyeman, Prince
2019-12-17 4:24 ` Chiu, Chasel
2019-12-18 1:33 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 05/11] MinPlatformPkg: Add BDS Hook Points Agyeman, Prince
2019-12-17 5:44 ` Chiu, Chasel
2019-12-18 1:33 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 06/11] BoardModulePkg: Add Generic BoardBootManagerLib Agyeman, Prince
2019-12-18 1:34 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver Agyeman, Prince
2019-12-17 5:44 ` Chiu, Chasel
2019-12-18 1:35 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 08/11] WhiskeylakeOpenBoardPkg: " Agyeman, Prince
2019-12-17 5:45 ` Chiu, Chasel
2019-12-18 1:35 ` Nate DeSimone
2019-12-21 2:36 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 09/11] SimicsOpenBoardPkg: Add Bds Hook Library Agyeman, Prince
2019-12-18 1:29 ` Nate DeSimone
2019-12-21 2:37 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS Board Boot Manager library Agyeman, Prince
2019-12-18 1:35 ` Nate DeSimone
2019-12-21 2:37 ` Kubacki, Michael A
2019-12-14 1:32 ` [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds Hook Points Agyeman, Prince
2019-12-18 1:36 ` Nate DeSimone
2019-12-21 2:37 ` Kubacki, Michael A
2020-04-21 20:37 ` Nate DeSimone [this message]
2020-04-22 10:31 ` [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS " Leif Lindholm
2020-04-22 22:13 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3489388FA28BF22F08A9F670CDD50@BL0PR11MB3489.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox