From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.786.1587501462839252110 for ; Tue, 21 Apr 2020 13:37:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=H9HPrWxa; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: WiEElTCVJEjPuJ+YlnFBG7k9dIYnAin/TfnqV4HjjxXgs08o7isUhRjZutEAbYYpeaODf1pvnK yfuk+Gipp53g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 13:37:41 -0700 IronPort-SDR: s3LDX0HEy4mnwBCmv0cSUyxBDiaDCvn8Gj6ybsoTnP1MnJIHqLAfBPResL1VBa7438wEPIIx15 K5yoZ1jCr2Aw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,411,1580803200"; d="scan'208";a="273649270" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga002.jf.intel.com with ESMTP; 21 Apr 2020 13:37:41 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 13:37:41 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX156.amr.corp.intel.com (10.22.240.22) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 13:37:41 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.55) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 13:37:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAknOrzCn/1F2S0797fGo3yii4ydwSQhTPTnV2cih7fENsxPjQ2vD2pW/4haHvjH79aaXWj8fucdEagGa8bYsXKHx/ujYbqyUE0++p7F9E7XPfwbwkp9yWmV0pCn3SUMCK2xw8/obpn3d/xpkW5UgYG+YdqhKA7/fnsygrjYsDQUY1eStaDaQ9VnxO2qK9VJkQ9G+NPqXlg+gq6+iFPXJMeXgFY0FVFrmJjAeds8arDFOd9Em6qr3AjfpphhIhIFxh8HmzR5wS8wWXheMAQP9nI7r+lGehtBJeia7sFl/LGCQoSSz3/0st7mdbfRmHM1BZK/1XfuF9FVYz+JUxqSrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DGAS3FZ8ma7g1k7QmVn0qQrljiCB4CViIvZUiHg1w2E=; b=iXEW7Oua1N9hGnQTWe5RrqFsKowi1rA969eauUCaBSa56l/MiOdjKXaSnRZOHdGOXJhHIencSNeDcCw1rjwS7Mgz6ehH0sUr6NBha2Syguu0owkuPeZeauBcOt+XfEajEgyfJpHHSWwFTcplShZFepdHrfTcMLUMESzhQJNQOcPBDU4Va6ekqaBdynOpKaPe707Rf/52FC96NirXFeujAck77up/mjEGpfF8rfpOKeByL7X9O9mAPjJehKSdcOHD8ish+WfALlb9XaU/WjkD6cdi3LnxhDfWiznOfD3Eh82+65E87Sp21UF65raCojSb7b9+tnTO7Wocolm9Ze8b4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DGAS3FZ8ma7g1k7QmVn0qQrljiCB4CViIvZUiHg1w2E=; b=H9HPrWxauQejJEWuUnUg9iiedo/gOxUgzJBa6XZqmhiehCRw1TcPE2Hy682qPw/D+hjYWsn9h+tR/gkQXJF/L44jY947UZ9wv/r59OrYHJmB56KtaXdF3Y9MLET9IXYMLFr/L2wid0MfPz68qzii+nVQHsKnqTC+1F4088TvK9g= Received: from BL0PR11MB3489.namprd11.prod.outlook.com (2603:10b6:208:75::29) by BL0PR11MB3459.namprd11.prod.outlook.com (2603:10b6:208:69::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 20:37:39 +0000 Received: from BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42]) by BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42%7]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 20:37:39 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points Thread-Index: AQHVsh5nSbFKW3f4QkaooFSalqtZWKiE07Gw Date: Tue, 21 Apr 2020 20:37:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzU5MWFkNWItM2E1Ni00MmVkLWE0NmMtMmQyNTA3Njk4N2NlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib3o4cE1jQ3hHTnNtSlJ4SFM0VFpuOTlwVHh4YWdpWUJ3ME5XRENNeDR5aUNvTndDcnllVFI2Z3JQRTV3VHVpRSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=nathaniel.l.desimone@intel.com; x-originating-ip: [134.134.136.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 74542f70-a00d-4947-4dcd-08d7e633d596 x-ms-traffictypediagnostic: BL0PR11MB3459: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3489.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(136003)(396003)(346002)(376002)(39860400002)(366004)(76116006)(86362001)(81156014)(5660300002)(55016002)(8676002)(19627235002)(9686003)(7696005)(8936002)(53546011)(186003)(71200400001)(6506007)(478600001)(26005)(66946007)(64756008)(66556008)(66446008)(66476007)(966005)(52536014)(2906002)(33656002)(110136005)(6636002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nRe9YPXiOtsWPfhcvmOji76Iiu4IgXN2WcJxdnK6r38Q0PYueT9iGF4eK+nspg9xlgBy4dEElL7Thxh1lJVs5iPylkb1wS5X/X4XSh7f1926F5UUNO8UJ72J+J5ParqYPzYGjbj96ouEDrrkq9Pilqtf8awVdChGdwZLTQYTWKS1YqbR1f97Xr+4ZqYBXeB9MzmCeE5eJQLxoIDU5TgDz12IQQonlfChg1yFl1gbmmMize/AR1UUONil8HzyyTmlFNNnwgJt9YjpBL3ZRUG0TgAJ+/nZ4pEwEQycOoCH1BGjvLqo59+FCuv6MrCkIVe+VsXyT208IgRb8g1UVWEsRUgwVGM2PlOSE8DDj0yfVAcU9Rf5myl6zq2f4+1eUcdR9PwaNjloImwxZNiQ1obon5M+dpnEZuAOOx3JTj0qMNKVNWWtHPTgCVoodNUbYyFClTASdENRDPaIAob8hMGq3J4+nzorfJ9NplUv9dwGCqcxv/2yFmfr7+NzeJOCe/QuspzREmAw1zUQNEs3cGhMcA== x-ms-exchange-antispam-messagedata: V9YCX14F0PN7StHmgZ8aQjrbW7vcGH9sIjmxAeWVb/TZf93jJhzwtAkhwBECNmkJclCIqeLQcIeQl6XcGR3APQHUj+xO54mH8IR2wW0rF8q9FkbqtYcUrryx5cjLneRQIWmRZMFNTgU35/mHJxs5MQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 74542f70-a00d-4947-4dcd-08d7e633d596 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 20:37:39.3334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SZyJ9oBBdzGjIz47mZBRNee3aX/gjd7aS4Y7r5Q3hniX+o+gW6tOCJjxYZoN/8dPMhdbEXg/WoLN/8lp51a0LpHzCQdtC60aNlbskQ9Y60k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3459 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch series has gotten very old and the review comments were minor an= d cosmetic. Since this is a good new feature, I have made the cosmetic fixe= s and pushed the patch series as 765cbda6~..5a60c2de. Thanks, Nate -----Original Message----- From: devel@edk2.groups.io On Behalf Of Agyeman, Pr= ince Sent: Friday, December 13, 2019 5:32 PM To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 This patch series implements BDS hook points as defined in the EDK II Mini= mum Platform Specification. For details, see https://edk2-docs.gitbooks.io/= edk-ii-minimum-platform-specification/appendix_a_full_maps/a3_bds_hook_poin= ts.html What was done: * MinplatformPkg: Three BDS event group PCDs were added - gBdsEventBeforeConsoleAfterTrustedConsoleGuid - gBdsEventBeforeConsoleBeforeEndOfDxeGuid - gBdsEventAfterConsoleReadyBeforeBootOptionGuid * DxePlatformBootManager: MinplatformPkg's DxePlatformBootManager library = instance was modified to signal the three newly added BDS events groups * BoardBdsHookLib: BDS event callback library was added. This library implements the callbacks for the three Bds event groups as we= ll as callbacks for already existing gEfiEndOfDxeEventGroupGuid, gEfiPciEnu= merationCompleteProtocolGuid and gEfiDxeSmmReadyToLockProtocolGuid event gr= oups - A default implementation of the board BDS hook library was added to BoardModulePkg - A SimicOpenBoardPkg specific implementation of the Board BDS hook library was also added * BoardBdsHookDxe: A generic DXE driver that registers the callbacks imple= mented in the Board BDS hook library was added * BoardBootManagerLib: A board boot manager library was added. This library implements PlatformBootManagerWaitCallback and PlatformBootMa= nagerUnableToBoot needed by Minplatform's PlatformBootManager libary instan= ce. - A null instance of this library was added to MinplatformPkg - A default instance of this library was added to BoardModulePkg - A SimicOpenBoardPkg instance was implemented * Support for the BDS Hook points were added to all the Minplatform boards Prince Agyeman (11): MinPlatformPkg: Add BDS Hook Point Guids BoardModulePkg: Add BDS Hook Library BoardModulePkg: Add BDS Hook DXE Driver MinPlatformPkg: Add BDS Board Boot Manager library MinPlatformPkg: Add BDS Hook Points BoardModulePkg: Add Generic BoardBootManagerLib KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver WhiskeylakeOpenBoardPkg: Add BDS Hook Dxe Driver SimicsOpenBoardPkg: Add Bds Hook Library SimicsOpenBoardPkg: Add BDS Board Boot Manager library SimicsOpenBoardPkg: Add Bds Hook Points .../BoardBdsHookDxe/BoardBdsHookDxe.c | 121 ++ .../BoardBdsHookDxe/BoardBdsHookDxe.inf | 46 + .../Include/Library/BoardBdsHookLib.h | 100 + .../Library/BoardBdsHookLib/BoardBdsHook.h | 211 +++ .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 1390 ++++++++++++++ .../BoardBdsHookLib/BoardBdsHookLib.inf | 95 + .../BoardBdsHookLib/BoardBootOption.c} | 87 +- .../BoardBdsHookLib/BoardMemoryTest.c} | 4 +- .../BoardBootManagerLib/BoardBootManager.c | 103 ++ .../BoardBootManagerLib.inf | 39 + .../GalagoPro3/OpenBoardPkg.dsc | 7 + .../GalagoPro3/OpenBoardPkg.fdf | 1 + .../KabylakeRvp3/OpenBoardPkg.dsc | 6 + .../KabylakeRvp3/OpenBoardPkg.fdf | 1 + .../BoardBootManagerLib.c | 38 + .../BoardBootManagerLibNull.inf | 31 + .../DxePlatformBootManagerLib/BdsPlatform.c | 1262 +------------ .../DxePlatformBootManagerLib/BdsPlatform.h | 181 +- .../DxePlatformBootManagerLib.inf | 51 +- .../Include/Library/BoardBootManagerLib.h | 39 + .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 + .../BoardX58Ich10/OpenBoardPkg.dsc | 10 +- .../BoardX58Ich10/OpenBoardPkg.fdf | 1 + .../Library/BoardBdsHookLib/BoardBdsHook.h | 173 ++ .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 1630 +++++++++++++++++ .../BoardBdsHookLib/BoardBdsHookLib.inf | 81 + .../BoardBootManagerLib/BoardBootManager.c | 67 + .../BoardBootManagerLib.inf | 45 + .../WhiskeylakeURvp/OpenBoardPkg.dsc | 4 + .../WhiskeylakeURvp/OpenBoardPkg.fdf | 1 + 30 files changed, 4421 insertions(+), 1409 deletions(-) create mode 1006= 44 Platform/Intel/BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.c create mode 100644 Platform/Intel/BoardModulePkg/BoardBdsHookDxe/BoardBds= HookDxe.inf create mode 100644 Platform/Intel/BoardModulePkg/Include/Library/BoardBds= HookLib.h create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/= BoardBdsHook.h create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/= BoardBdsHookLib.c create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/= BoardBdsHookLib.inf rename Platform/Intel/{MinPlatformPkg/Bds/Library/DxePlatformBootManagerL= ib/PlatformBootOption.c =3D> BoardModulePkg/Library/BoardBdsHookLib/BoardBo= otOption.c} (87%) rename Platform/Intel/{MinPlatformPkg/Bds/Library/DxePla= tformBootManagerLib/MemoryTest.c =3D> BoardModulePkg/Library/BoardBdsHookLi= b/BoardMemoryTest.c} (93%) create mode 100644 Platform/Intel/BoardModulePk= g/Library/BoardBootManagerLib/BoardBootManager.c create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBootManager= Lib/BoardBootManagerLib.inf create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootMan= agerLibNull/BoardBootManagerLib.c create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootMan= agerLibNull/BoardBootManagerLibNull.inf create mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/BoardBoo= tManagerLib.h create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHook= Lib/BoardBdsHook.h create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHook= Lib/BoardBdsHookLib.c create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHook= Lib/BoardBdsHookLib.inf create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootMan= agerLib/BoardBootManager.c create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootMan= agerLib/BoardBootManagerLib.inf -- 2.19.1.windows.1