From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH v5 0/3] Add initial manifest repository support
Date: Thu, 23 Apr 2020 23:29:21 +0000 [thread overview]
Message-ID: <BL0PR11MB34895180485811365FAB3CF8CDD30@BL0PR11MB3489.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200423230957.38936-1-ashley.e.desimone@intel.com>
For the patch series...
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com>
Sent: Thursday, April 23, 2020 4:10 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v5 0/3] Add initial manifest repository support
V5 updates the imports in patch 3/3 to reflect the change in file names resulting from V4
V4 addresses Nate's comments regarding typo of 'maintenance'
and added edkrepo.common.workspace_maintenance to setup.py in patch 1/3
V3 Addresses Prince's comments regarding typos in patch 2/3
V2 Replaces use of management with maitenance per feedback
V2 Introduces patch 1/1 which removes a circular import between common_repo_functions.py and manifest_repos_maitenance.py by adding workspace_maiteneance.py.
Adds initial support for manifest repository maitenance while retaining support for commands to use the existing edkrepo.cfg format and manifest repo support functions.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Ashley E Desimone (3):
EdkRepo: Initial commit of workspace_maintenance.py
EdkRepo: Add
edkrepo/common/workspace_maintenance/manifest_repos_maintenance
EdkRepo: Update pull_latest_manifest_repo to use
pull_single_manifest_repo
edkrepo/common/common_repo_functions.py | 33 ++----------
edkrepo/common/humble.py | 8 ---
.../humble/manifest_repos_maintenance_humble.py | 23 +++++++++
.../manifest_repos_maintenance.py | 59 ++++++++++++++++++++++
.../workspace_maintenance/workspace_maintenance.py | 30 +++++++++++
setup.py | 5 +-
6 files changed, 119 insertions(+), 39 deletions(-) create mode 100644 edkrepo/common/workspace_maintenance/humble/manifest_repos_maintenance_humble.py
create mode 100644 edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
create mode 100644 edkrepo/common/workspace_maintenance/workspace_maintenance.py
--
2.16.2.windows.1
prev parent reply other threads:[~2020-04-23 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 23:09 [edk2-staging/EdkRepo] [PATCH v5 0/3] Add initial manifest repository support Ashley E Desimone
2020-04-23 23:09 ` [edk2-staging/EdkRepo] [PATCH V5 1/3] EdkRepo: Initial commit of workspace_maintenance.py Ashley E Desimone
2020-04-23 23:09 ` [edk2-staging/EdkRepo] [PATCH V5 2/3] EdkRepo: Add edkrepo/common/workspace_maintenance/manifest_repos_maintenance Ashley E Desimone
2020-04-23 23:09 ` [edk2-staging/EdkRepo] [PATCH V5 3/3] EdkRepo: Update pull_latest_manifest_repo to use pull_single_manifest_repo Ashley E Desimone
2020-04-23 23:29 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB34895180485811365FAB3CF8CDD30@BL0PR11MB3489.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox