public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
	"Bjorge, Erik C" <erik.c.bjorge@intel.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions
Date: Tue, 5 May 2020 07:41:43 +0000	[thread overview]
Message-ID: <BL0PR11MB34897F4B3F234F5FF985ABBDCDA70@BL0PR11MB3489.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200501203946.17620-1-ashley.e.desimone@intel.com>

For the series...

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Friday, May 1, 2020 1:40 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions

Remove the duplicate definition of functions in common_repo_functions.py and update imports to use the definitions in workspace_maintenance.py.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Ashley E Desimone (2):
  EdkRepo: Remove duplicate definition of
    generate_name_for_obsolete_backup
  EdkRepo: Remove duplicate definitions of case_insensitive_single_match
    and case_insensitive_equal

 edkrepo/commands/clone_command.py       |  3 ++-
 edkrepo/commands/sync_command.py        |  3 ++-
 edkrepo/common/common_repo_functions.py | 35 +--------------------------------
 3 files changed, 5 insertions(+), 36 deletions(-)

--
2.16.2.windows.1


  parent reply	other threads:[~2020-05-05  7:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 20:39 [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions Ashley E Desimone
2020-05-01 20:39 ` [edk2-staging/EdkRepo] [PATCH 1/2] EdkRepo: Remove duplicate definition of generate_name_for_obsolete_backup Ashley E Desimone
2020-05-01 20:39 ` [edk2-staging/EdkRepo] [PATCH 2/2] EdkRepo: Remove duplicate definitions of case_insensitive_single_match and case_insensitive_equal Ashley E Desimone
2020-05-05  7:41 ` Nate DeSimone [this message]
2020-05-05  8:06 ` [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR11MB34897F4B3F234F5FF985ABBDCDA70@BL0PR11MB3489.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox