From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.10763.1589091718169295415 for ; Sat, 09 May 2020 23:21:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=h4+u8HeL; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: BJQAPxuvqvkXvjZzZl036deog+RiMlh2nHfumzP/i0YArNXPT8nhCaadNO4SBqYlm2YatbFd/R t74rXb8hbygQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2020 23:21:57 -0700 IronPort-SDR: 4T+qLDcliBd15oVg1tkitmqXuQpW7+X/utxC0kVFLKZOM87phKZPXM/5KTjv7yKfDS2oz5yujQ KmqGEOZtOCWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,374,1583222400"; d="scan'208";a="408566569" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 09 May 2020 23:21:57 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 23:21:56 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 23:21:56 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.56) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 23:21:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bvQbeC1Q9fmRI1ILvVwsynCDiyv2fKFdENkosuCZilIGAKUW/U5cpaNMZaIOCRuJnPNyhiAvuBkm/uF/aEMlXbuVfkIp0/bNspYWhpNng82AmMyO5AiKqFFMa+P0WZF39El2WNFzZQ77lo2RS5mbsPC8ibUbCMO6qO+OT7Vq8/u7NizbfIxYFWsTB54u36xY6DfHovTZu8SxGAI+iX4X21R5SDRiA2+jYX+D6cF161hlCUja6LganZH4V5fJev/xbWz2fJ7xnKsjh2H4C8O6/gKx2z621CInqO1yaNe0M9uahmhhMjo0XXs4aDM0IqDavb36Ch3SoDlU/Za7XPkkxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NIPnxXM5hj45uxIaFZJyvNE5HWHGec5qFBU/5gpd1fU=; b=IbGJkB8j4GsqpKmoRY23ri4lwMwUB99o9e13uAIkO5u+QuFtMg4Idc60MOLiboWA9xkADOy8ZRSSIMPEzhL+KTmg7Cc7uCAWtD4o+P459zb7KvoEuFnz18Q3szq61qroptRIhCpeA6Kn4QC0N7Rnl1NtwYs7IEbmi/K5WxWtesUfcskzbPifW6315W5/8Hov80zC5Kujq3hu0gyKtIXd1DmVBWDunP6u/HminQcvrxDvfNEQniViO4DW5zvdm3g5UFlCREifJ3PTKXPvGISAtXs19d4SNLxQVnpil9OpYv4CJe6yNtyAQvBdm5SWHv+ydV12KpVQfZsNGmCmL9pvUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NIPnxXM5hj45uxIaFZJyvNE5HWHGec5qFBU/5gpd1fU=; b=h4+u8HeLbY59O5YQ0E7MeNKWvy4rR2euy1uV1xYZkiY0QSlisQ9d3GhwQHvZVCxJqkCC0MBdbmGYlK33cE+k97fW2Fh/pe6dF1EogD6qYpvH/cPGBB9VOMsLwOBFSbdp9Na6usotDVrjmuN5bU63J8agGQfXFaERNeHJKvGzklA= Received: from BL0PR11MB3489.namprd11.prod.outlook.com (2603:10b6:208:75::29) by BL0PR11MB3426.namprd11.prod.outlook.com (2603:10b6:208:32::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Sun, 10 May 2020 06:21:55 +0000 Received: from BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42]) by BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42%7]) with mapi id 15.20.2979.033; Sun, 10 May 2020 06:21:54 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Zeng, Star" Subject: Re: [edk2-platforms: PATCH v4] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers. Thread-Topic: [edk2-platforms: PATCH v4] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers. Thread-Index: AQHWJNgn/uMhY9lf4EqM5q9J8LuDcKig1qZw Date: Sun, 10 May 2020 06:21:54 +0000 Message-ID: References: <20200508012900.8216-1-chasel.chiu@intel.com> In-Reply-To: <20200508012900.8216-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY2MDZlNGYtN2YyZi00NDJiLTgyNTktNWUxMjY0MzQ4NmEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidlwvN29iTlBtWEIxakhwRXlZQjdybWptRkhpQXhqamhhcU9QUlpJZ1hLdnRCeVpIRGh5czhSdVZnSmJEUjhESEMifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e5ba221e-a2d0-4c2b-e2b8-08d7f4aa6f8e x-ms-traffictypediagnostic: BL0PR11MB3426: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 039975700A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5LE27cKlb+UIMrgWYGRln0TnyfqG/4GiLGybUgDy4+oans0Ke3HtGu+Acc1VVUXUye6TEfl4zo1WzKK3lhP/vqK/1pHHwIY+nyMkynLevxNsctcjKb/joL1swEOSdy3K73Ky1i/A4HRWBd35YaVq3tLKrCjNjyTOufTTwTVFzN2FMot1yL5VZNIeiNdpAA2zUFP/Yyd9jxv2lFBcTCXY5mpdQwTSSJkdU6kIA2IaUbV3dxa54+lxQLqzKvmott37YlMQKw9HMzOH6VRd7d6xRbanB48tw6Zu+RMdeC+8mwFQJgsbP9b6MbzYynzaa6wmxY5G006xW77qpXyVgTf8fqbP+0P4sjV8KkKOmcUPtIP0zfuZugSWmcCfSZCirrCFbKejtnUgM1Vyar4Sp5KExLrcOsyiLr7fDz20OiZxF49cuPMXbrfvWQi2YsQ+Llzaah95T431GAeCZqOwPm5dmpYYqOEgt35CT7y/0e1syvKH3NlHQYkIO9y3Yh4WMsJXw6L+sxR025sIdL/NwhyrXPkAdce3XFGJKp0j1VvRsYTAytE26baK7IPgH4gmdhh6xsSMCJSXe06F5DEGmOWUvH2LtsaLgPg+xb63aDhRkZw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3489.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(376002)(136003)(346002)(39860400002)(366004)(396003)(33430700001)(966005)(2906002)(478600001)(316002)(54906003)(52536014)(30864003)(76116006)(5660300002)(4326008)(9686003)(55016002)(110136005)(19627235002)(107886003)(33656002)(86362001)(71200400001)(64756008)(66946007)(8936002)(33440700001)(8676002)(26005)(66476007)(53546011)(7696005)(66446008)(66556008)(6506007)(186003)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 2LPQKnrbWM46J2JCAEPyjPYOQglCFhJiOC+rCcQgksLSO/Ljeel2p88VkSflUCA3/43LF/bzpo4SLwfdFNbwLmwLu3wuE6uRwth3EXCUQX3xKpn2P6sK6hGroiW/q5pPePv/NBEzffOWskyKXjAasnqvOG6CeK8qy2RQwvpKYpfHVmDtWY0GEir7irNQjjTz7yP2afIGzDoYAiZPJ/kF7koqXD/MmU8CVmavMYHvGWlwh3wVX1AZJ3MMMYJAr1SnL+fj5zeLMVnPC9r8PcsuPpyuREhf5decryLH0GxhIgVg7oYeHWmrLxewzNf0iz3c+2Wg/rAKwG+E8EzuMi4s0uHlI7pCFMkJu7WugxIjoLA/5I611Pc3DI7Stm91RwlMYG625tlwD3CknFaChdBsvRKvOCseyk7xZNJ/f/armemzfl4rev0IdM+kZkROqRxQGZ4t59FxOMvEJ/01GbtN/I9l2bmjIfKzINGS9PQY2gNKBZw0AOdpnJMSa+8rK/ub MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e5ba221e-a2d0-4c2b-e2b8-08d7f4aa6f8e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2020 06:21:54.3780 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ASDSI1WCCQZxPswUu+v9Hq2yXRGCMSQab72auOUJT535tOZerJqdFPqSE0IYz5FZU8vVDB/YkQREW08P3TsTNWZhpMICcMYWmnoqaCf9Jd0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3426 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Chasel, A few comments: #1) FspApi.h The references to the FSP/PI spec sections in the comments are a bit odd. N= one of the existing comments in FspApi.h make references to sections in spe= cs. Particularly weird are these ones: * See Section 11.10 Appendix A - Data Structures for the definition of EFI_= STATUS_CODE_TYPE. * See Section 11.10 Appendix A - Data Structures for the definition of EFI_= STATUS_CODE_VALUE. This is code... why not point the reader to PiStatusCode.h directly? #2) FspApi.h This seems overly verbose: @retval UINT32 The return value will be passed back th= rough the EAX register. The return value indicates the number o= f bytes actually written to the debug log. If the return value is l= ess than MessageLength, an error occurred. I think it can be shortened to: @retval UINT32 The return value indicates the number o= f bytes actually written to the debug log. If the return value is l= ess than MessageLength, an error occurred. #3) Please rename FspSecCoreSS.inf to Fsp22SecCoreS.inf and FspApiEntrySS.n= asm to Fsp22ApiEntryS.nasm #4) Any reason why the entry points for FspSiliconInit() and NotifyPhase() = are absent from FspApiEntrySS.nasm/Fsp22ApiEntry.nasm? Are we going to need= 2 FspSecCoreS drivers now instead of 1? Not sure how that would work... on= ly 1 SecCore is allowed per FV. Thanks, Nate > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, May 7, 2020 6:29 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-platforms: PATCH v4] IntelFsp2Pkg: Support Multi-Phase SiI= nit > and debug handlers. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2698 >=20 > To enhance FSP silicon initialization flexibility an optional Multi-Phase= API is > introduced and FSP header needs update for new API offset. Also new > SecCore module created for FspMultiPhaseSiInit API >=20 > New ARCH_UPD introduced for enhancing FSP debug message flexibility now > bootloader can pass its own debug handler function pointer and FSP will c= all > the function to handle debug message. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/FspSecCore/SecFspApiChk.c | 6= +++--- > IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c | 19 > ++++++++++++++++++- > IntelFsp2Pkg/FspSecCore/FspSecCoreSS.inf | 48 > ++++++++++++++++++++++++++++++++++++++++++++++++ > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm | 5 > ++++- > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntrySS.nasm | 68 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++ > IntelFsp2Pkg/Include/FspEas/FspApi.h | 124 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++-- > IntelFsp2Pkg/Include/FspGlobalData.h | 3= ++- > IntelFsp2Pkg/Include/Guid/FspHeaderFile.h | 10= ++++++++-- > IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h | 16 > +++++++++++++++- > 9 files changed, 288 insertions(+), 11 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c > b/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c > index 8e0595fe9a..1334959005 100644 > --- a/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c > +++ b/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2016 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -59,7 +59,7 @@ FspApiCallingCheck ( > Status =3D EFI_UNSUPPORTED; > } > } > - } else if (ApiIdx =3D=3D FspSiliconInitApiIndex) { > + } else if ((ApiIdx =3D=3D FspSiliconInitApiIndex) || (ApiIdx =3D=3D > + FspMultiPhaseSiInitApiIndex)) { > // > // FspSiliconInit check > // > @@ -68,7 +68,7 @@ FspApiCallingCheck ( > } else { > if (FspData->Signature !=3D FSP_GLOBAL_DATA_SIGNATURE) { > Status =3D EFI_UNSUPPORTED; > - } else if (EFI_ERROR (FspUpdSignatureCheck (ApiIdx, ApiParam))) { > + } else if (EFI_ERROR (FspUpdSignatureCheck > + (FspSiliconInitApiIndex, ApiParam))) { > Status =3D EFI_INVALID_PARAMETER; > } > } > diff --git > a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c > b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c > index f7945b5240..df8c5d121f 100644 > --- a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c > +++ b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c > @@ -1,7 +1,7 @@ > /** @file > Null instance of Platform Sec Lib. >=20 > - Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -25,3 +25,20 @@ FspUpdSignatureCheck ( { > return EFI_SUCCESS; > } > + > +/** > + This function handles FspMultiPhaseSiInitApi. > + > + @param[in] ApiIdx Internal index of the FSP API. > + @param[in] ApiParam Parameter of the FSP API. > + > +**/ > +EFI_STATUS > +EFIAPI > +FspMultiPhaseSiInitApiHandler ( > + IN UINT32 ApiIdx, > + IN VOID *ApiParam > + ) > +{ > + return EFI_SUCCESS; > +} > diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreSS.inf > b/IntelFsp2Pkg/FspSecCore/FspSecCoreSS.inf > new file mode 100644 > index 0000000000..184101c7d3 > --- /dev/null > +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreSS.inf > @@ -0,0 +1,48 @@ > +## @file > +# Sec Core for FSP to support MultiPhase (SeparatePhase) SiInitializati= on. > +# > +# Copyright (c) 2020, Intel Corporation. All rights reserved.
# # > +SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D FspSecCoreSS > + FILE_GUID =3D DF0FCD70-264A-40BF-BBD4-06C76DB19CB= 1 > + MODULE_TYPE =3D SEC > + VERSION_STRING =3D 1.0 > + > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES =3D IA32 > +# > + > +[Sources] > + SecFspApiChk.c > + SecFsp.h > + > +[Sources.IA32] > + Ia32/Stack.nasm > + Ia32/FspApiEntrySS.nasm > + Ia32/FspApiEntryCommon.nasm > + Ia32/FspHelper.nasm > + > +[Binaries.Ia32] > + RAW|Vtf0/Bin/ResetVec.ia32.raw |GCC > + > +[Packages] > + MdePkg/MdePkg.dec > + IntelFsp2Pkg/IntelFsp2Pkg.dec > + > +[LibraryClasses] > + BaseMemoryLib > + DebugLib > + BaseLib > + PciCf8Lib > + SerialPortLib > + FspSwitchStackLib > + FspCommonLib > + FspSecPlatformLib > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm > index bb4451b145..26ae7d9fd3 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm > @@ -1,7 +1,7 @@ > ;; @file > ; Provide FSP API entry points. > ; > -; Copyright (c) 2016, Intel Corporation. All rights reserved.
> +; Copyright (c) 2016 - 2020, Intel Corporation. All rights > +reserved.
> ; SPDX-License-Identifier: BSD-2-Clause-Patent ;; >=20 > @@ -62,6 +62,9 @@ FspApiCommon2: > cmp eax, 3 ; FspMemoryInit API > jz FspApiCommon3 >=20 > + cmp eax, 6 ; FspMultiPhaseSiInitApiIndex API > + jz FspApiCommon3 > + > call ASM_PFX(AsmGetFspInfoHeader) > jmp ASM_PFX(Loader2PeiSwitchStack) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntrySS.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntrySS.nasm > new file mode 100644 > index 0000000000..e6956277a9 > --- /dev/null > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntrySS.nasm > @@ -0,0 +1,68 @@ > +;; @file > +; Provide FSP API entry points. > +; > +; Copyright (c) 2020, Intel Corporation. All rights reserved.
; > +SPDX-License-Identifier: BSD-2-Clause-Patent ;; > + > + SECTION .text > + > +; > +; Following functions will be provided in C ; extern > +ASM_PFX(FspApiCommon) extern > ASM_PFX(FspMultiPhaseSiInitApiHandler) > + > +;---------------------------------------------------------------------- > +------ > +; FspMultiPhaseSiInitApi API > +; > +; This FSP API provides multi-phase silicon initialization, which > +brings greater ; modularity beyond the existing FspSiliconInit() API. > +; Increased modularity is achieved by adding an extra API to FSP-S. > +; This allows the bootloader to add board specific initialization steps > +throughout ; the SiliconInit flow as needed. > +; > +;---------------------------------------------------------------------- > +------ > +global ASM_PFX(FspMultiPhaseSiInitApi) > +ASM_PFX(FspMultiPhaseSiInitApi): > + mov eax, 6 ; FSP_API_INDEX.FspMultiPhaseSiInitApiIndex > + jmp ASM_PFX(FspApiCommon) > + > +;---------------------------------------------------------------------- > +------ > +; FspApiCommonContinue API > +; > +; This is the FSP API common entry point to resume the FSP execution ; > +;---------------------------------------------------------------------- > +------ > +global ASM_PFX(FspApiCommonContinue) > +ASM_PFX(FspApiCommonContinue): > + ; > + ; Handle FspMultiPhaseSiInitApiIndex API > + ; > + pushad > + push DWORD [esp + (4 * 8 + 4)] ; push ApiParam > + push eax ; push ApiIdx > + call ASM_PFX(FspMultiPhaseSiInitApiHandler) > + add esp, 8 > + mov dword [esp + (4 * 7)], eax > + popad > + ret > + > +;---------------------------------------------------------------------- > +------ > +; TempRamInit API > +; > +; Empty function for WHOLEARCHIVE build option ; > +;---------------------------------------------------------------------- > +------ > +global ASM_PFX(TempRamInitApi) > +ASM_PFX(TempRamInitApi): > + jmp $ > + ret > + > +;---------------------------------------------------------------------- > +------ > +; Module Entrypoint API > +;---------------------------------------------------------------------- > +------ > +global ASM_PFX(_ModuleEntryPoint) > +ASM_PFX(_ModuleEntryPoint): > + jmp $ > + > diff --git a/IntelFsp2Pkg/Include/FspEas/FspApi.h > b/IntelFsp2Pkg/Include/FspEas/FspApi.h > index dcf489dbe6..ca908b0198 100644 > --- a/IntelFsp2Pkg/Include/FspEas/FspApi.h > +++ b/IntelFsp2Pkg/Include/FspEas/FspApi.h > @@ -2,7 +2,7 @@ > Intel FSP API definition from Intel Firmware Support Package External > Architecture Specification v2.0. >=20 > - Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -10,6 +10,8 @@ > #ifndef _FSP_API_H_ > #define _FSP_API_H_ >=20 > +#include > + > /// > /// FSP Reset Status code > /// These are defined in FSP EAS v2.0 section 11.2.2 - OEM Status Code @= @ - > 24,6 +26,60 @@ > #define FSP_STATUS_RESET_REQUIRED_8 0x40000008 > /// @} >=20 > +/* > + FSP may optionally include the capability of generating events message= s to > aid in the debugging of firmware issues. > + These events fall under three catagories: Error, Progress, and Debug. > +The event reporting mechanism follows the > + status code services described in section 6 and 7 of the PI Specificat= ion v1.7 > Volume 3. > + > + @param[in] Type Indicates the type of event being re= ported. > + See Section 11.10 Appendix A - Data = Structures for the > definition of EFI_STATUS_CODE_TYPE. > + @param[in] Value Describes the current status of a ha= rdware or > software entity. > + This includes information about the = class and subclass that > is used to classify the entity as well as an operation. > + For progress events, the operation i= s the current activity. > For error events, it is the exception. > + For debug events, it is not defined = at this time. > + See Section 11.10 Appendix A - Data = Structures for the > definition of EFI_STATUS_CODE_VALUE. > + @param[in] Instance The enumeration of a hardware or sof= tware > entity within the system. > + A system may contain multiple entiti= es that match a > class/subclass pairing. The instance differentiates between them. > + An instance of 0 indicates that inst= ance information is > unavailable, not meaningful, or not relevant. > + Valid instance numbers start with 1. > + @param[in] *CallerId This parameter can be used to identi= fy the > sub-module within the FSP generating the event. > + This parameter may be NULL. > + @param[in] *Data This optional parameter may be used = to pass > additional data. The contents can have event-specific data. > + For example, the FSP provides a > EFI_STATUS_CODE_STRING_DATA instance to this parameter when sending > debug messages. > + This parameter is NULL when no addit= ional data is > provided. > + > + @retval EFI_SUCCESS The event was handled successfully. > + @retval EFI_INVALID_PARAMETER Input parameters are invalid. > + @retval EFI_DEVICE_ERROR The event handler failed. > +*/ > +typedef > +EFI_STATUS > +(EFIAPI *FSP_EVENT_HANDLER) ( > + IN EFI_STATUS_CODE_TYPE Type, > + IN EFI_STATUS_CODE_VALUE Value, > + IN UINT32 Instance, > + IN OPTIONAL EFI_GUID *CallerId, > + IN OPTIONAL EFI_STATUS_CODE_DATA *Data > + ); > + > +/* > + Handler for FSP-T debug log messages, provided by the bootloader. > + > + @param[in] DebugMessage A pointer to the debug message to be > written to the log. > + @param[in] MessageLength Number of bytes to written to the de= bug > log. > + > + @retval UINT32 The return value will be passed back= through the > EAX register. > + The return value indicates the numbe= r of bytes actually > written to > + the debug log. If the return value i= s less than > MessageLength, > + an error occurred. > +*/ > +typedef > +UINT32 > +(EFIAPI *FSP_DEBUG_HANDLER) ( > + IN CHAR8* DebugMessage, > + IN UINT32 MessageLength > + ); > + > #pragma pack(1) > /// > /// FSP_UPD_HEADER Configuration. > @@ -77,7 +133,13 @@ typedef struct { > /// Current boot mode. > /// > UINT32 BootMode; > - UINT8 Reserved1[8]; > + /// > + /// A function pointer of type FSP_EVENT_HANDLER. > + /// Optional event handler for the bootloader to be informed of events > occurring during FSP execution. > + /// Refer to Section 8.5 for more details. This value is only valid if= Revision is > >=3D 2. > + /// > + FSP_EVENT_HANDLER *FspEventHandler; > + UINT8 Reserved1[4]; > } FSPM_ARCH_UPD; >=20 > /// > @@ -147,6 +209,40 @@ typedef struct { > FSP_INIT_PHASE Phase; > } NOTIFY_PHASE_PARAMS; >=20 > +/// > +/// Action definition for FspMultiPhaseSiInit API /// typedef enum { > + EnumMultiPhaseGetNumberOfPhases =3D 0x0, > + EnumMultiPhaseExecutePhase =3D 0x1 > +} FSP_MULTI_PHASE_ACTION; > + > +/// > +/// Data structure returned by FSP when bootloader calling /// > +FspMultiPhaseSiInit API with action 0 > (EnumMultiPhaseGetNumberOfPhases) > +/// typedef struct { > + UINT32 NumberOfPhases; > + UINT32 PhasesExecuted; > +} FSP_MULTI_PHASE_GET_NUMBER_OF_PHASES_PARAMS; > + > +/// > +/// FspMultiPhaseSiInit function parameter. > +/// > +/// For action 0 (EnumMultiPhaseGetNumberOfPhases): > +/// - PhaseIndex must be 0. > +/// - MultiPhaseParamPtr should point to an instance of > FSP_MULTI_PHASE_GET_NUMBER_OF_PHASES_PARAMS. > +/// > +/// For action 1 (EnumMultiPhaseExecutePhase): > +/// - PhaseIndex will be the phase that will be executed by FSP. > +/// - MultiPhaseParamPtr shall be NULL. > +/// > +typedef struct { > + IN FSP_MULTI_PHASE_ACTION MultiPhaseAction; > + IN UINT32 PhaseIndex; > + IN OUT VOID *MultiPhaseParamPtr; > +} FSP_MULTI_PHASE_PARAMS; > + > #pragma pack() >=20 > /** > @@ -279,4 +375,28 @@ EFI_STATUS > IN VOID *FspsUpdDataPtr > ); >=20 > +/** > + This FSP API is expeted to be called after FspSiliconInit but before > FspNotifyPhase. > + This FSP API provides multi-phase silicon initialization; which > +brings greater modularity > + beyond the existing FspSiliconInit() API. Increased modularity is > +achieved by adding an > + extra API to FSP-S. This allows the bootloader to add board specific > +initialization steps > + throughout the SiliconInit flow as needed. > + > + @param[in,out] FSP_MULTI_PHASE_PARAMS For action - > EnumMultiPhaseGetNumberOfPhases: > + FSP_MULTI_PHASE_PARAMS->Mult= iPhaseParamPtr > will contain > + how many phases supported by= FSP. > + For action - EnumMultiPhaseExe= cutePhase: > + FSP_MULTI_PHASE_PARAMS->Mult= iPhaseParamPtr > shall be NULL. > + @retval EFI_SUCCESS FSP execution environment was = initialized > successfully. > + @retval EFI_INVALID_PARAMETER Input parameters are invalid. > + @retval EFI_UNSUPPORTED The FSP calling conditions wer= e not > met. > + @retval EFI_DEVICE_ERROR FSP initialization failed. > + @retval FSP_STATUS_RESET_REQUIREDx A reset is required. These > status codes will not be returned during S3. > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *FSP_MULTI_PHASE_SI_INIT) ( > + IN FSP_MULTI_PHASE_PARAMS *MultiPhaseSiInitParamPtr > +); > + > #endif > diff --git a/IntelFsp2Pkg/Include/FspGlobalData.h > b/IntelFsp2Pkg/Include/FspGlobalData.h > index 1896b0240a..02df8463ed 100644 > --- a/IntelFsp2Pkg/Include/FspGlobalData.h > +++ b/IntelFsp2Pkg/Include/FspGlobalData.h > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -22,6 +22,7 @@ typedef enum { > FspMemoryInitApiIndex, > TempRamExitApiIndex, > FspSiliconInitApiIndex, > + FspMultiPhaseSiInitApiIndex, > FspApiIndexMax > } FSP_API_INDEX; >=20 > diff --git a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > index 16f43a1273..3474bac1de 100644 > --- a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > +++ b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > @@ -1,8 +1,8 @@ > /** @file > Intel FSP Header File definition from Intel Firmware Support Package > External > - Architecture Specification v2.0. > + Architecture Specification v2.0 and above. >=20 > - Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -110,6 +110,12 @@ typedef struct { > /// Byte 0x44: The offset for the API to initialize the CPU and chipse= t. > /// > UINT32 FspSiliconInitEntryOffset; > + /// > + /// Byte 0x48: Offset for the API for the optional Multi-Phase process= or > and chipset initialization. > + /// This value is only valid if FSP HeaderRevision is >=3D = 5. > + /// If the value is set to 0x00000000, then this API is not= available in > this component. > + /// > + UINT32 FspMultiPhaseSiInitEntryOffset; > } FSP_INFO_HEADER; >=20 > /// > diff --git a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > index 4d01b5f6d9..51a0309aed 100644 > --- a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > +++ b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2015 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -79,4 +79,18 @@ FspUpdSignatureCheck ( > IN VOID *ApiParam > ); >=20 > +/** > + This function handles FspMultiPhaseSiInitApi. > + > + @param[in] ApiIdx Internal index of the FSP API. > + @param[in] ApiParam Parameter of the FSP API. > + > +**/ > +EFI_STATUS > +EFIAPI > +FspMultiPhaseSiInitApiHandler ( > + IN UINT32 ApiIdx, > + IN VOID *ApiParam > + ); > + > #endif > -- > 2.13.3.windows.1