From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.6637.1589947956378265618 for ; Tue, 19 May 2020 21:12:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EEahS+QV; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: dUr2urwF8xiIBexemURaGSxMbenB2IlcMKGM7RhJzrhYKAQsE2ELu3Ij8SiaGmZMH8al1kSlGk NZ1N7yRiiWJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 21:12:35 -0700 IronPort-SDR: aAkyAIoMyupx+SbByWX0xAUywFeoHFruHMdJTL8t4deqPjXriPDtXl3TrcVJYBnF95czqDx0GT Uz5mB+4kqn6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,412,1583222400"; d="scan'208";a="300321348" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga008.jf.intel.com with ESMTP; 19 May 2020 21:12:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 21:12:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 21:12:34 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 19 May 2020 21:12:34 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.53) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 21:12:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7nlu0Szz013l6+QxDw9QmMl7Rftqj5J9wLZHdGU40ZhvcdFnsllWJD2k8Y9TcBW2Pt291NRjpfqopwNI5x8hsDmIH6dXVSEa56iZMhFbSPKW6c/BkX3nDgswjOtf0/C+Kyp5hd+kxl+PxmiPDCL9s/4YlUDsUAnrDFVsuieKGswWhsSfx/FOUmi446pWDVuZ5yE4si5nEUApd8ZVHNuOC1gkVUry56BBUu0udVMyoun65qxgGZmNZqG+BVlD58hhEKq9B9ziKo47mbPwSm55fzqvgVm0abg+zR8RXfV4Z9cJCrt4a9q5ZqePMidX6mxtWMLdTnzVe1K43IV2Sqdkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pcgg+8ALdj17dXf7ROKmyjJbmGBbXQYwbl2Ma+QoLyc=; b=lUBxc6l7Ua0tYGUt0UiCO1tizeRpcBHRyQjRQkMciVv2AV0YoX4z4bDx5zZRZOTAB68oKj7fuAoH2V5CZkSs93P6U6zqYftjf2HTQAN6vSAOol+K2BdtKfFfeJNdxvseQnp0DMc0iB62jxYoA3qk3oq0M3EKTs731FmpTdBlk1ASI4WSeNwIDCko5UEjN2okKIUjNBr0C71LBAaJrLX3SvWo337kerf0zZoMBuDHq6yoIJlMmB2PWcUu9jtyVsvmt1rQR18u7PlzWBJQMf22S9MRwUezkTROuFY8dLoq1fnoXp8njSvHeQe9ZRD6SfG8/imsT2+0spQBnN9EWsExSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pcgg+8ALdj17dXf7ROKmyjJbmGBbXQYwbl2Ma+QoLyc=; b=EEahS+QVRZd8M+vQpZ7tJs9udoG3Xr3FUXNCGHRiv16y5DZ7JIHptSRknGxwNpxxfXg45CeOcuTCLse/zaplWBvgRmc4VQkmUzj6I7QVns2X/utsvj+gjBMibhDkoCC5V7VR4BqSvps5ZxgJ7Cd+Tcinpxc5z1jwiC3o/WCQCTg= Received: from BL0PR11MB3489.namprd11.prod.outlook.com (2603:10b6:208:75::29) by BL0PR11MB3458.namprd11.prod.outlook.com (2603:10b6:208:6a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Wed, 20 May 2020 04:12:13 +0000 Received: from BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42]) by BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42%7]) with mapi id 15.20.3000.034; Wed, 20 May 2020 04:12:13 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData. Thread-Topic: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData. Thread-Index: AQHWLleNYkwnKfAwkk+6ugAt8DiPSaiwXOeg Date: Wed, 20 May 2020 04:12:12 +0000 Message-ID: References: <20200520033356.5708-1-chasel.chiu@intel.com> In-Reply-To: <20200520033356.5708-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGUxYTE4MmUtNzBmMS00ZTRiLTkzNWUtZGEwM2YwZWMzOTBkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWm1XSHJDc21PNU9wQmppR0pKU3FBZFlQQXBORFIwemRNTUl0Z2xTV3BldnFRc3RiYktEeTh6MmxKQjM2MVdIYiJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6f59c9ce-dbf4-45c4-0484-08d7fc73f966 x-ms-traffictypediagnostic: BL0PR11MB3458: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5EfkqqXQXnBwx0dexFh11oUtbpmCh5Y3weFhArX8dBaG/06Rk2CBpxSMLtLtON6S8mif5Fal4k0eCR3vbYurzjNVHyMXh3BCZ6kQfceGj4YqDk4WZBmXzD2EaP5F3MKS33CtEsCF7XmZ5QNCv3q1AkfQdv93jn9Sw2h2QohKk0Jk+4fVa7WrE2+O7EdhI+EsxPxPDUnO4aOLkdWE6/gzaq3jnjLYnkz22cQLgfsb5dzVqGP3RlrxD5zeE4KGHPS5uoGz9DO8z/S+NHjc2jUEQkHLe0cfkDKrObNIdYqfkt9MIHSKVxVi9sEHEO98JkW89aS3ATv5c/YceTecjuGUKpmMcNd+dQrlDPXzVWGdmtrYQztT05CF6p6w1p/m3mNwE6aLfsn7ubU6zsM7yUOmNXhUBwfR80H0LmqUpGaV7gMJM9xsyPfxdT2FsrFkg4JVq+nizgHbp+m5u8MoV6EkAtjpB+occojQzJhnN3PzpVaE6FBHqxd8YabD/jInYYfEdNqWHboKb3a7+hHah6Kl/A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3489.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(366004)(396003)(376002)(346002)(55016002)(9686003)(8676002)(53546011)(4326008)(6506007)(33656002)(2906002)(19627235002)(7696005)(107886003)(71200400001)(5660300002)(26005)(8936002)(110136005)(52536014)(316002)(966005)(66476007)(66556008)(478600001)(66446008)(76116006)(64756008)(54906003)(86362001)(66946007)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: QVYNBb3PiwG35RavOk0VmmAsIAK83iczK07Kqc11IBa1TWqFY7hivhVeuftAaPIkbFXO6TFQM+qbLhniIin1oux2XFidKzllZqjCyy0ZD52MPUnjlYIYLWsVpyqCsmJXiynLg91DqeQEgh25tu9mZCtTUhXqcUZkZZIXqhTJMzD4nNtY2nWHyaA8VdpT98mEmytC6/ybovhQP3Ai0G0yV3VtvoscsSbA/hXCb3FaYIH+5CXmKz8wO4qRnnM/yGLGpzbPAQ75E3eqmnucgKnVck4eTFc3QIZBGL9QH8EgmwGaMDtCQW0WmEpcj1Xl2okrLuuxNhohLR/YurWH8ZbEZuJ9JwvszWfU7KqB1uqJc9fyE3WX0ZEoaZLCiQBlh+0pLwQI+dpHQ+SsBZesGLtF86Ubkta7kz15jcxucjFzMzOrIULF3LGiTaDbPgA9NfX6wwHiqCABFABiVhw//JfEMX5CouwUJlXKXYvTHEVDQo1meYM/Q9F3YfHucRpTZCt4 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6f59c9ce-dbf4-45c4-0484-08d7fc73f966 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 04:12:12.9736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UQY9HJU96EpKpzxJLyypHkS9xU3gzV05u89RyR2y2icTTm9gyo6z8fquVlVS+Qqu77p3ysVVPILaN+UK860mmSptpS4SSJDsQlY9JXiX/tU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3458 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Chiu, Chasel > Sent: Tuesday, May 19, 2020 8:34 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2726 >=20 > When FSP switching stack and calling bootloader functions, the function > parameter in stack may not be accessible easily. > We can store the function parameter pointer to FspGlobalData and retrieve= it > after stack switched. >=20 > Also need to add Loader2PeiSwitchStack () to header file as public functi= on > for platform FSP code to consume. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Include/FspGlobalData.h | 12 ++++++++++-- > IntelFsp2Pkg/Include/Library/FspSwitchStackLib.h | 18 > +++++++++++++++++- > 2 files changed, 27 insertions(+), 3 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Include/FspGlobalData.h > b/IntelFsp2Pkg/Include/FspGlobalData.h > index 5bde316893..dba9b48e1a 100644 > --- a/IntelFsp2Pkg/Include/FspGlobalData.h > +++ b/IntelFsp2Pkg/Include/FspGlobalData.h > @@ -52,12 +52,20 @@ typedef struct { > VOID *MemoryInitUpdPtr; > VOID *SiliconInitUpdPtr; > UINT8 ApiIdx; > - UINT8 FspMode; // 0: FSP in API mode; 1: FSP in DISPATCH= mode > + /// > + /// 0: FSP in API mode; 1: FSP in DISPATCH mode > + /// > + UINT8 FspMode; > UINT8 OnSeparateStack; > UINT8 Reserved3; > UINT32 NumberOfPhases; > UINT32 PhasesExecuted; > - UINT8 Reserved4[20]; > + /// > + /// To store function parameters pointer > + /// so it can be retrieved after stack switched. > + /// > + VOID *FunctionParameterPtr; > + UINT8 Reserved4[16]; > UINT32 PerfSig; > UINT16 PerfLen; > UINT16 Reserved5; > diff --git a/IntelFsp2Pkg/Include/Library/FspSwitchStackLib.h > b/IntelFsp2Pkg/Include/Library/FspSwitchStackLib.h > index 0c76e9f022..bed2a5d677 100644 > --- a/IntelFsp2Pkg/Include/Library/FspSwitchStackLib.h > +++ b/IntelFsp2Pkg/Include/Library/FspSwitchStackLib.h > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2014, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -36,4 +36,20 @@ Pei2LoaderSwitchStack ( > VOID > ); >=20 > +/** > + > + This function is equilivant to Pei2LoaderSwitchStack () but just > + indicates the stack after switched is FSP stack. > + > + @return ReturnKey After switching to the saved stack, > + this value will be saved in eax before retu= rning. > + > + > +**/ > +UINT32 > +EFIAPI > +Loader2PeiSwitchStack ( > + VOID > + ); > + > #endif > -- > 2.13.3.windows.1