From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.1843.1588651169368951294 for ; Mon, 04 May 2020 20:59:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nT1ZJ5Uj; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: vrhG6/1wLBKMcs8QHwOylcIaks+59BTy0Gvn9OmYvCpf1pY7wcp+eK/WwVeYN+XfnF7Aqts7gZ 1LxGkgHmn9Qg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2020 20:59:29 -0700 IronPort-SDR: lrC2eejsSxAX4pGgirI7Q4Km93A3RK0jKBIwA4ZdqiTQCunhmmDp4N5f1TSCqf9pFJYBwbj3cN ABURjERVeZJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,354,1583222400"; d="scan'208";a="338527315" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga001.jf.intel.com with ESMTP; 04 May 2020 20:59:28 -0700 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 May 2020 20:59:28 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX115.amr.corp.intel.com (10.22.240.11) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 May 2020 20:59:28 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 May 2020 20:59:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hmUhCRSNaHIeV5vPs5HVoPyhz4v6CPya1rf1DXgqSCAwslEgD68b3bio2qkntKYJOpq/mWs1quRVdXEZDTCfRi8jZM1LXG41yEbZmUvDqNyDv5JR0dKQtvBK97dhOMhqaVlvxRvO/Vop6zkcNMB10vN23w1STI5toexZ/UvQ1lZnmGYchFSVRdMAIUz7CInHuX2Bu2TPKEalS/SuVhDur1LuOMa9LtolVq6faQbmijmgVw/e2szwvBlHsuCAjx5qJnkz1lSJKSL02gPShaiCcp/1GXIRm3msums6m+n9ZEuzZQtWr8dNFu1BFSMvaEggbJBcPnsy7NTsh/oGRxXigw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7Q8pEyyCqLPA0DTWkQ9N3aNdBqo+kyQdMMfcOVQ31Q=; b=SmvNaGkMrKi03VYijRa+eO4S/HLzYc2gLuUDKh9UEdRHRv2dlPdbixigESjUcAgzTynQVh7dFecBi3znPpKpnwSQWkusstKZ4r4kaC/7ss01CJ9Rg8HgdHBhxib3Z810MmNkap6TJfINeZaSdeLUUmsKCbltB091bOAdRMvWrT+PKjWzC+v5XwMeEer5aH9pwSVBHR/Dnli79BFtqrTkfuj3h4UUdLN9TtSH/4bOQw+GdFrl4jDtaKVfwZkGMMP0IgHYAmXlefZKLDkyE0F59YR2xqgezQlS20Ll488NGFXIH33vr9SAD5EnNGlinEh/2iVRfz+oUkX2ggp5JWTlNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7Q8pEyyCqLPA0DTWkQ9N3aNdBqo+kyQdMMfcOVQ31Q=; b=nT1ZJ5UjquY4iph763v2Hf2DV6Jpc0Q/a/0yT8+XrZCZvSMUdm6L6ix9th3Xs44XwEuBtQIuvF5E4fkH+5v8HIu/yoRWRbWuC/fftADg8tHkLsTMyj6k+oBhhLEMAtNTh5arj3mXG3p0jt1pB4d2wE/dBhrp2WGKE66s88MxMbU= Received: from BL0PR11MB3489.namprd11.prod.outlook.com (2603:10b6:208:75::29) by BL0PR11MB3458.namprd11.prod.outlook.com (2603:10b6:208:6a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Tue, 5 May 2020 03:59:27 +0000 Received: from BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42]) by BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42%7]) with mapi id 15.20.2958.030; Tue, 5 May 2020 03:59:27 +0000 From: "Nate DeSimone" To: "Bjorge, Erik C" , "devel@edk2.groups.io" CC: "Desimone, Ashley E" , "Pandya, Puja" , Bret Barkelew , "Agyeman, Prince" Subject: Re: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup Thread-Topic: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup Thread-Index: AQHWH0I17so0GDgQU0SxOHxnM1bcxaiY5ByQ Date: Tue, 5 May 2020 03:59:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjlhZTVhZWEtOGMxZi00Y2JiLWJiYmUtZTQ1MTdiNmQ0YjMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibnN0bXBwcFhtQlJTSXJJQWY0aXNhcDFJK1wvQlY0eEJXV2NxdVZoZ3E5NXNoZ1NQYksyd2E5Q2NLSDRaS3diMEsifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3380e204-deff-408b-8a5b-08d7f0a8b4a0 x-ms-traffictypediagnostic: BL0PR11MB3458: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 0394259C80 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lt8yq3jimoJScyE4mOD33YShkRuKzrdagZVUST91fI7nqMnZiqKr6aDmn+ndG3gtixamAXkm1q49A3MIoyTsDPRGYd+oK83lIfgjMSbDX3JNC4KSKFJ53oFHn/QbxiCdSC88C6aRNMb9l5SUqdppewbdNlOii2A3PdI6Q3d59ORIRZgmeSNmtdx62jUEAzEsn9McH2dPDv3uRzytsGfCQ5NgKCry33ooAS2EtpxThB36upm+6lALOPQefBTef/+TTv+qXl0+5AiaJNppkbPhOeXW0b5XGB4IS2hCNMz5dKq8HXTft8QeyLD4/HhRSly67beivpjRK99CsHu4WRg21VpUshHi4u7OmgUoaO8qI3SFGw9YCp874J9HxTTeAK6oJ7OD5+LSXfatOl/GDnbvtWgNNUWjMwslYXVYekG7mXMeXdGJUuRRZMzQW3XowyfIS83vDvco3HFxF8YaX9sEPQ3vkKwjEpnXlVx8LONiuw+xVSIaH5nv3/ldDDLcWZRoH10XjyHU2ZE5Nd4YWRn8eA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3489.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(396003)(346002)(366004)(136003)(376002)(33430700001)(55016002)(86362001)(4326008)(66946007)(6506007)(76116006)(64756008)(66446008)(66556008)(316002)(66476007)(53546011)(110136005)(33440700001)(8676002)(54906003)(52536014)(8936002)(4744005)(7696005)(478600001)(5660300002)(2906002)(71200400001)(33656002)(9686003)(186003)(26005)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: f4uxUtrO2dMlTHV9QhWTROa09o9LhRADWrqs+6qKuCkZ/bmcvIk+TBUteC+imcgeShajbaImyV4JzK2gsDmmDnJPwrNk4F6yPLFxyAJsU0H78VVCbvOVxqbrU4zE10Rg0JZj8Tbpu8VD1NLWko5LZ2g7jH7U9BXAi1wwZcG/RSxlfFfh6ENjsW8coaCdk1cenVSv0lGPy5LzmIy+PWo5r89EC5x0h19DOwJM88usf0EFghzdnHvgCpG70F3igiYx6j8m+GFSmrm40XyWUcNOzkYgsSRYOByVhM9dxWcAxk0EQxR+n/c1cY351y1OF33g3vTmycNv6ydrtAH/fyIk4q5WqP57wZrUxw2jescx0EVnNK7lcKdizcY9MpppqXxLsOsg/0OTZC6qhrbGQyuaU+VwSSfVm2ekv6qyJ+NtwblbczO3tVW/gXfVmNzHFcrRmMAjNVzdA+ODXUD9/dmPFG/L6HcvLSmRThisuOhHZoXI3zFe7t9uF+W7UUZQhScBXOu4eduou1oV38xtpc3LU9yKcuraGdGIoYMekgx5Hi2mZruUsWNr+KgAdFgbAkYxcsOOJedGLCE/z1JQasHIy/wSnRSn1la07vNJ+/Z3Ti6TNplSxl6Pg+NWdNyPXaEFQFu6aa83MvpHB/RXpNG7FlRTlFFzbY9Morl98+vI2DEpsMkZlq/LKRB2o4nLXd5VNzi2RoGC7NUVjZh33U23++2J651JfKLrWjsbM3Gte6UT+SqWv0NXWozrd6cBh65JO6TzzttZyglXeneaEH5b/Cnk9X9nT74Cttcb1SDMYOA= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3380e204-deff-408b-8a5b-08d7f0a8b4a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2020 03:59:26.9617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZZHU12Q5NVDSNjgGc059SYKwiuAx2cc6c3XQqK+YlJMtIDNEh7fqLA9h3CS+d5MqIrI29Nh003+k+28GKKOq3Fa5sjFcFKqYb62nmYPwegs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3458 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable After a some rebasing pain... Pushed as f2f6f5a2~.. 6153e4a2 -----Original Message----- From: Bjorge, Erik C =20 Sent: Thursday, April 30, 2020 3:53 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L= ; Pandya, Puja ; Br= et Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup General cleanup of the manifest parser and minor improvements to make the c= ode more flexible. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Erik Bjorge (3): EdkRepo: Flake8 cleanup EdkRepo: Improve error message with invalid XML EdkRepo: Refactoring private class members edkrepo_manifest_parser/edk_manifest.py | 249 +++++++++++++----------- 1 file changed, 139 insertions(+), 110 deletions(-) -- 2.21.0.windows.1