From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Desimone, Ashley E" <ashley.e.desimone@intel.com>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
Date: Tue, 21 Apr 2020 03:40:17 +0000 [thread overview]
Message-ID: <BL0PR11MB3489B5422983B186D67227C7CDD50@BL0PR11MB3489.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200420222059.45416-1-ashley.e.desimone@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashley E Desimone
Sent: Monday, April 20, 2020 3:21 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
Remote the 'delimeters='=' from the instantation of config parser objects in the BaseConfig class and update the manifest-repos section of the edkrepo.cfg to remove the '=' from after the manifest repo name.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/config/config_factory.py | 2 +-
edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 90f393c..6d56ee6 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -82,7 +82,7 @@ class BaseConfig():
self.read_only = read_only
self.filename = filename
self.global_data_dir = global_data_dir
- self.cfg = configparser.ConfigParser(allow_no_value=True, delimiters='=')
+ self.cfg = configparser.ConfigParser(allow_no_value=True)
if os.path.isfile(self.filename):
self.cfg.read(self.filename)
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 97ebdd2..38d7b35 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -1,5 +1,5 @@
[manifest-repos]
-edk2-staging =
+edk2-staging
[edk2-staging]
URL = https://github.com/tianocore/edk2-staging.git
--
2.16.2.windows.1
prev parent reply other threads:[~2020-04-21 3:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 22:20 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class Ashley E Desimone
2020-04-20 23:20 ` [edk2-devel] " Bjorge, Erik C
2020-04-21 3:40 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3489B5422983B186D67227C7CDD50@BL0PR11MB3489.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox