* [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
@ 2020-04-20 22:20 Ashley E Desimone
2020-04-20 23:20 ` [edk2-devel] " Bjorge, Erik C
2020-04-21 3:40 ` Nate DeSimone
0 siblings, 2 replies; 3+ messages in thread
From: Ashley E Desimone @ 2020-04-20 22:20 UTC (permalink / raw)
To: devel
Cc: Nate DeSimone, Puja Pandya, Erik Bjorge, Bret Barkelew,
Prince Agyeman
Remote the 'delimeters='=' from the instantation of
config parser objects in the BaseConfig class and update
the manifest-repos section of the edkrepo.cfg to remove the
'=' from after the manifest repo name.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/config/config_factory.py | 2 +-
edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 90f393c..6d56ee6 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -82,7 +82,7 @@ class BaseConfig():
self.read_only = read_only
self.filename = filename
self.global_data_dir = global_data_dir
- self.cfg = configparser.ConfigParser(allow_no_value=True, delimiters='=')
+ self.cfg = configparser.ConfigParser(allow_no_value=True)
if os.path.isfile(self.filename):
self.cfg.read(self.filename)
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 97ebdd2..38d7b35 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -1,5 +1,5 @@
[manifest-repos]
-edk2-staging =
+edk2-staging
[edk2-staging]
URL = https://github.com/tianocore/edk2-staging.git
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
2020-04-20 22:20 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class Ashley E Desimone
@ 2020-04-20 23:20 ` Bjorge, Erik C
2020-04-21 3:40 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Bjorge, Erik C @ 2020-04-20 23:20 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Ashley E
Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew,
Agyeman, Prince
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashley E Desimone
Sent: Monday, April 20, 2020 3:21 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
Remote the 'delimeters='=' from the instantation of config parser objects in the BaseConfig class and update the manifest-repos section of the edkrepo.cfg to remove the '=' from after the manifest repo name.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/config/config_factory.py | 2 +-
edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 90f393c..6d56ee6 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -82,7 +82,7 @@ class BaseConfig():
self.read_only = read_only
self.filename = filename
self.global_data_dir = global_data_dir
- self.cfg = configparser.ConfigParser(allow_no_value=True, delimiters='=')
+ self.cfg = configparser.ConfigParser(allow_no_value=True)
if os.path.isfile(self.filename):
self.cfg.read(self.filename)
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 97ebdd2..38d7b35 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -1,5 +1,5 @@
[manifest-repos]
-edk2-staging =
+edk2-staging
[edk2-staging]
URL = https://github.com/tianocore/edk2-staging.git
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
2020-04-20 22:20 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class Ashley E Desimone
2020-04-20 23:20 ` [edk2-devel] " Bjorge, Erik C
@ 2020-04-21 3:40 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2020-04-21 3:40 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Ashley E
Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew, Agyeman, Prince
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashley E Desimone
Sent: Monday, April 20, 2020 3:21 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class
Remote the 'delimeters='=' from the instantation of config parser objects in the BaseConfig class and update the manifest-repos section of the edkrepo.cfg to remove the '=' from after the manifest repo name.
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/config/config_factory.py | 2 +-
edkrepo_installer/Vendor/edkrepo.cfg | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 90f393c..6d56ee6 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -82,7 +82,7 @@ class BaseConfig():
self.read_only = read_only
self.filename = filename
self.global_data_dir = global_data_dir
- self.cfg = configparser.ConfigParser(allow_no_value=True, delimiters='=')
+ self.cfg = configparser.ConfigParser(allow_no_value=True)
if os.path.isfile(self.filename):
self.cfg.read(self.filename)
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 97ebdd2..38d7b35 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -1,5 +1,5 @@
[manifest-repos]
-edk2-staging =
+edk2-staging
[edk2-staging]
URL = https://github.com/tianocore/edk2-staging.git
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21 3:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-20 22:20 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class Ashley E Desimone
2020-04-20 23:20 ` [edk2-devel] " Bjorge, Erik C
2020-04-21 3:40 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox