From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1855.1588650969783559444 for ; Mon, 04 May 2020 20:56:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Rt8Q2Fc2; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: +ioyr3BXjxGT8m5OPT8tAObP1RlR/hR2dIFfGAjn3l40qrXRApRaax1I7eeD3KIcOgFgwZIg8L 5Bwpu1MIEW0g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2020 20:56:09 -0700 IronPort-SDR: Ag+flu/Qq+IFdXCel9H0EHVt2KsMK+ZonWNAeEgHqAelqCuPC5eQT5YDUy72xa1rjSJEIoqTGr 7Uwtup0dACMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,354,1583222400"; d="scan'208";a="369288776" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga001.fm.intel.com with ESMTP; 04 May 2020 20:56:08 -0700 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 May 2020 20:56:07 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX122.amr.corp.intel.com (10.22.225.227) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 May 2020 20:56:07 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 May 2020 20:56:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YeQm4XgQ8wnQlR1Gx0nwHTg2UF+Xdc1zDp95Bf6E8hvhuS8Q+rPwoO5rfdVWkwyRCifkqhs/FD2fDENKFL9Br1HsdvGRARaM/fw7W22ZBGF0vw6JnS7w/nlDHj3/ZVEZxZheNJ8lV65ZvAYEobnA/l4Zj42vcvJU7uNim84mkkbe4XMM20aeGN3a1GkuSaq+6ROi32q2AIuTzH7dAe7gQDtnDxekVhKPP4HrpgzWc326FlvJj6Yy5E2tVVaOkJYmytAeGrfCoFcpi/LdxktZtAUvwylzVRTk3in0PV2GEXeIWvSdnVbEGMOUGdduFiFOQ29JeCxyi+8eLJ0tBnj3Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=roXYwoLE4Usdmx75tD6QqgiAh3IGL/wS0oz1Z8BSFE8=; b=N061Fw3bdDeyNmxQ09W42a0xnNDa7K4gUNZbv2KzZUJrfVcHki4hgXqREdzBKAS1Qa2e4gRFYiGQc8doafklDKu21BuyVudVK3Iaabxg6T0bkKReY3Kmvx+9Q6GBQbXU/3BoEhcFpQmR4W9QSDpidYDh7B5+Pqs8G4cuLO47NwacAhZ8XAwLSslQMBlSSSKUKuiCcFiOskng+9yQOvCEQJcVBJ/+uwQF7N8Ze+OL/u9h2H4Fg3YypMQvD0UuhHkUy4EcgZYzxi2FGaH8SX1zeFnm4r4z7XrsoNTStl38wtIWJonr/iFa0i8zBs7AyVhXOM2swJZn1pkrDsdY4w31kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=roXYwoLE4Usdmx75tD6QqgiAh3IGL/wS0oz1Z8BSFE8=; b=Rt8Q2Fc2SndXAzT2+arNuZAqM2WF2KDJLiFSxYZ4Oju7MXI7WRxVRUfE/WObE0LSsdAOVDOxI/TnCEkkNx4/xptjsi84K/D+xRw+/ukUscwiyoQTd0mfs0RU6VQfo66PKEICQDpjR/QQQwtToqFW8dDOGpdXoC0/K6NswjE4aYs= Received: from BL0PR11MB3489.namprd11.prod.outlook.com (2603:10b6:208:75::29) by BL0PR11MB3458.namprd11.prod.outlook.com (2603:10b6:208:6a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Tue, 5 May 2020 03:56:05 +0000 Received: from BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42]) by BL0PR11MB3489.namprd11.prod.outlook.com ([fe80::d0f8:bfd7:bae2:3e42%7]) with mapi id 15.20.2958.030; Tue, 5 May 2020 03:56:05 +0000 From: "Nate DeSimone" To: "Bjorge, Erik C" , "devel@edk2.groups.io" CC: "Desimone, Ashley E" , "Pandya, Puja" , Bret Barkelew , "Agyeman, Prince" Subject: Re: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup Thread-Topic: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup Thread-Index: AQHWH0I17so0GDgQU0SxOHxnM1bcxaiY45Qg Date: Tue, 5 May 2020 03:56:05 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Y4NDQ1NjQtYzdjYi00NTFmLTgwYTYtZmI0NTI5MDhjOTY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZlZPKzRYSFliaWZlZmRtUVVxazQ3RmNjeUlsRm1tMXgwRVpqNWNYVnhpaWxjNThuSlpTMTExZmhTR3lVcDQ0TiJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7cfb6e3-8c90-4c16-acbc-08d7f0a83c7e x-ms-traffictypediagnostic: BL0PR11MB3458: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0394259C80 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EfAjdfsqi0stPHUUn7YqQ43SeJXFC6Vc5waNFcEjBZbr9yFyNWg2JL9ZhZgHGOMAhYkrX4o4k6Hazd32AWECPbJLcGo7L3GvFNnsIwtIzNSlDQMNem8UICsClibCHruqhJfyet9aYZ4K4fiIbI4bbdVp957G1yDR+JuJORcrYsjz12JUed8X+xJq0VNeKcwO2B5hZH3a5roxiSZ1OqzRzzC8/qm9mFSUnQ6y+nt0SgEhStj6U1jFZ99or1WtiY0C3fquIdKTdQ27ERg+SYZjlRja5jbELyHX1oVAq6qWeaYp3dYqs7ABdaRfq7fCuJ4SnbP7lz8YKlXjr1L2CJ1aFwByJ3UBy+cA7qF4f1TIRVff4oFUe1Q2h66+5QTdwca4w9cSxvHsYeWwWkE7WYTHEHt7ZVvwVIesUONpZW5fVvkHuv7N/elE8ZAuLGY2rMuG6XYhT1XGDYuykhJdmYmbA9TRcGc27T+Zs7l0Mk/IX2nAuI77pLqVYH10cueeG4SfrI2YNBhNzigNIGrhTkgamQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3489.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(396003)(346002)(366004)(136003)(376002)(33430700001)(55016002)(86362001)(4326008)(66946007)(6506007)(76116006)(64756008)(66446008)(66556008)(316002)(66476007)(53546011)(110136005)(33440700001)(8676002)(54906003)(52536014)(8936002)(4744005)(7696005)(478600001)(5660300002)(2906002)(71200400001)(33656002)(9686003)(186003)(26005)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: KhQcy4Zfh2Xf4i89UOeIPJ1dp7dMwdBQJ6F6lhltwga1xKVZUPPmWXe/1S1OUzOZCpdv/vnf+IIqugF5xb9LBOFfc4aQaHaK5FO1ajMfLE8prBCMbKqI/twMJMwwAyIproHrDAR67vWQIkE0vWv6jxijwztezpruhcx88iZqMofSnY9QeNmh5+VjSW9OZCSjYZ7jvO3SDbV4CGFyvVvhTKHSHHdoRHWpnwhyNqOJVTeezmjIcNFK2cY9SF04HjF1E7f+n2BVU06XCEMtqUjqivp2NFw35UMvLoD/dX4aKBCjDXuVao4cl9FJfO15bJ5yV9K2TKzLX1Dm9xdmcp9mWtEkGvTV0xLlY5IDSw+FTLmvKnV6xAXC1ezyOnO67XyktbcpXkbKi79ubJYA8dp4FH69OJunWsrUyL+22a8NJjfM0Z7bnWaVLIFXgDuJYwRh8ZpAkwxu2a+idignVM6RpbHFV2JW0m+CEX4wyZZd5HSNeT72rKWc779HhrlOSCgTprh3vWHP3J1xaC+c36fWeEMs5bZFSm5S+uqHdfvn4ZnrHzopZyIbd0/jiaN9d3r+ZDgoz+Qa5ZJFk5BXNbGry6zDp0M3TvZrn7xYnVUOHhS/ynujuoiVgS86j03HxMnN8xJGyqAFsnmS9rThiHm+9y2EhOoLCHWeoN2dnqllm/6XRACUur/n+tkoe+fakwletxcpSie5paUJXEJ5QswdV1F+hqbe+IRsD63FRIIZuo9Wc1uVMs+GzC1MY8M29EMX+Mw8pVOCoEiNyX7uNUKRWyuu8z0SmzYWT7Rcg3DYYe4= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d7cfb6e3-8c90-4c16-acbc-08d7f0a83c7e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2020 03:56:05.4462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 55D0XIDRucgXb4SWaol3i84HrKsvhMDCH9Bci1/HhIBYxL9xmWoMvDaxHsRSqzcF3YCiLXNbxMzdftxZcbh1ckjMlEoef7ohhKiKWmD6jV8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3458 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the series... Reviewed-by: Nate DeSimone -----Original Message----- From: Bjorge, Erik C =20 Sent: Thursday, April 30, 2020 3:53 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L= ; Pandya, Puja ; Br= et Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup General cleanup of the manifest parser and minor improvements to make the c= ode more flexible. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Erik Bjorge (3): EdkRepo: Flake8 cleanup EdkRepo: Improve error message with invalid XML EdkRepo: Refactoring private class members edkrepo_manifest_parser/edk_manifest.py | 249 +++++++++++++----------- 1 file changed, 139 insertions(+), 110 deletions(-) -- 2.21.0.windows.1