From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Gao, Liming" <liming.gao@intel.com>,
Leif Lindholm <leif@nuviainc.com>,
"afish@apple.com" <afish@apple.com>
Subject: Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci
Date: Mon, 6 Jul 2020 01:15:08 +0000 [thread overview]
Message-ID: <BL0PR11MB350643353375F8D6E4573F7B8C690@BL0PR11MB3506.namprd11.prod.outlook.com> (raw)
In-Reply-To: <737e5880-aadb-5f08-cd91-9f13dcbf9bf0@redhat.com>
Hi Lazslo,
Looks like I missed your ACK. I will add it in latter versions.
Thanks,
Shenglei
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Saturday, July 4, 2020 12:02 AM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Zhang,
> Shenglei <shenglei.zhang@intel.com>; Leif Lindholm <leif@nuviainc.com>;
> afish@apple.com
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues
> for edk2 on open ci
>
> Hi Liming,
>
> On 07/03/20 17:13, Gao, Liming wrote:
> > Include more people and collect the comments.
> >
> > ECC is the source file coding style checker. Here is its wiki page
> https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool.
> > If the changed code doesn't follow edk2 coding style, ECC will report the
> error.
> >
> > This patch set enables ECC checker in open CI for each patch coming into
> edk2 repo. That means new changes need to follow edk2 coding style.
> > Otherwise, new changes can't be merged.
> >
> > If you have some comments for ECC checker in open CI, please reply this
> mail.
>
>
> (1) The ArmVirtPkg (v6 04/16) and OvmfPkg (v6 11/16) patches already
> carry my ACKs; from here:
>
> https://edk2.groups.io/g/devel/message/61154
> https://edk2.groups.io/g/devel/message/61155
>
>
> (2) The UefiCpuPkg patch (v6 15/16) *should* also carry my ACK, from here:
>
> https://edk2.groups.io/g/devel/message/61156
>
> Shenglei picked up my ACK for v4 and v5:
>
> https://edk2.groups.io/g/devel/message/61283
> https://edk2.groups.io/g/devel/message/61852
>
> but then dropped it for v6:
>
> https://edk2.groups.io/g/devel/message/61894
>
> Shenglei, can you please explain why you dropped my ACK from the
> UefiCpuPkg patch, in v6?
>
>
> (3) The initial discussion between Shenglei and myself are under the v2
> posting:
>
> https://edk2.groups.io/g/devel/message/60665
> https://edk2.groups.io/g/devel/message/60711
> https://edk2.groups.io/g/devel/message/60961
>
> I'm happy with this work because it lets package maintainers tailor ECC
> as they see appropriate.
>
> Thanks,
> Laszlo
prev parent reply other threads:[~2020-07-06 1:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 1:55 [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 01/16] pip-requirements.txt: Add Ecc required lib Zhang, Shenglei
2020-07-02 2:22 ` Liming Gao
2020-07-01 1:55 ` [PATCH v6 02/16] .pytool/Plugin: Add a plugin EccCheck Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 03/16] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 05/16] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 2:14 ` Wang, Jian J
2020-07-01 1:55 ` [PATCH v6 06/16] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 07/16] FatPkg/FatPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 08/16] FmpDevicePkg/FmpDevicePkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 09/16] MdePkg/MdePkg.ci.yaml: " Zhang, Shenglei
2020-07-02 2:23 ` [edk2-devel] " Liming Gao
2020-07-01 1:55 ` [PATCH v6 10/16] NetworkPkg/NetworkPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 11/16] OvmfPkg/OvmfPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 12/16] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 13/16] SecurityPkg/SecurityPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 2:13 ` [edk2-devel] " Wang, Jian J
2020-07-01 1:55 ` [PATCH v6 14/16] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
2020-07-01 1:55 ` [PATCH v6 15/16] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
2020-07-02 0:50 ` [edk2-devel] " Dong, Eric
2020-07-01 1:55 ` [PATCH v6 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file Zhang, Shenglei
2020-07-02 2:30 ` [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci Liming Gao
2020-07-02 7:57 ` Zhang, Shenglei
2020-07-03 15:13 ` Liming Gao
2020-07-03 16:01 ` Laszlo Ersek
2020-07-06 1:15 ` Zhang, Shenglei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB350643353375F8D6E4573F7B8C690@BL0PR11MB3506.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox