From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.8464.1594088661731664193 for ; Mon, 06 Jul 2020 19:24:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QAbse6Bi; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: shenglei.zhang@intel.com) IronPort-SDR: z9CferOHIkmW2zirQQexm7VajvKgls+eBGLtNhcwsP7J7f3CmJV/eb9ufo1r6xpLxiTTldUYk7 xg7o16tM5VfA== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="145629190" X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="145629190" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 19:24:21 -0700 IronPort-SDR: /EWrB1ttf1JfwsWxAM7ABgQ6MFlKfiaErDan4Zz05LIz/gZzGnTx8EmG60PyxnBDumyVkz/2+j ufE2Iwj6DAbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="297198792" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2020 19:24:20 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jul 2020 19:24:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jul 2020 19:24:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZL4O05QxUOPxa5NkaPlDGvNq6+S1ZciMJCjaaWfmiAY+PfuLaosc3iH1yBNrkq8o6wZfxf6OPIGSswzFG5q0NMfZkVyb1x7yVbiNBBfcexnUtgGAT1qkMKX0PKyexfXDcBZjjycBCYSxJxvxkvpvLBqolHHhgCWz9Pzw57U5n+WvgeSv+yBZz1gyc6Jl0hC79bMg7vN+EWpWV9uSx0qi+yKqRkqC8qhGBkGhMZj2YxkcQAQtDn9Ts4GbXidZSP93onSCWkeoupBBHHXF/TnKKYYTjsOGrn08ED34YrmS0LUUKr5i4+rID+clOTzWz9WL/TusZ7q4vyk7ZeDqFuOYww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dOYciXZKJ/EcIbJcSShBLmUMmRkXGlWSbXKGLMfTzLs=; b=dXitkfKrIsKG1IBIgOTYNzmrvQjXlzOPC3VblOzsxGgsP/EAM1ScEE4/wrc1wzaWPXWtb623qR/zNR+pbvKaisBGgjIWX5Zr04IwpXHAJzwIQx5i4UD/++Di4w0jiUcy7WE7vQSd869TmeiLYjukAsCjCJDgaDyq662Qa4f5fNyCiEs2172lM+TAIDxJHBPCgzm1qbjRB81ftFHbPDRfTm5Wi0MpJqsUDVjr2DKo0Jq8I6xTyrvafDLv3x/cevupkbSsDLjgOHZTwFEoygVM+2Iren+RQqrgadb9YqkV9AY7D5xNyAhl4xdVrTlrekJh9h3cIHPn9bVopO7oye/pyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dOYciXZKJ/EcIbJcSShBLmUMmRkXGlWSbXKGLMfTzLs=; b=QAbse6Bih1jcEWnvrBkxbC6obG4TeF2nKdk1wdLen7f7sqEETamOECKhCQkbk/drdhwBX05xuAnWtiS/igBMh5rFscCjn79bMYjrW67oxy3+10fvMqM7/CKP9VbI8vOydYPDRKg+SIGlHpSG26QkldLA/HQVyBzGsOFXnpHQAyI= Received: from BL0PR11MB3506.namprd11.prod.outlook.com (2603:10b6:208:31::24) by BL0PR11MB3458.namprd11.prod.outlook.com (2603:10b6:208:6a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24; Tue, 7 Jul 2020 02:24:15 +0000 Received: from BL0PR11MB3506.namprd11.prod.outlook.com ([fe80::b805:cb86:230a:6a1]) by BL0PR11MB3506.namprd11.prod.outlook.com ([fe80::b805:cb86:230a:6a1%6]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 02:24:14 +0000 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" , "leif@nuviainc.com" CC: "Feng, Bob C" , Bret Barkelew , "Kinney, Michael D" , "Gao, Liming" , "Sean Brogan" Subject: Re: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Topic: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Index: AQHWU3MxGryFzf81P0qmv+BD0acUMqj7Y+3w Date: Tue, 7 Jul 2020 02:24:14 +0000 Message-ID: References: <20200706084846.12748-1-shenglei.zhang@intel.com> <20200706085508.GA12303@vanye> In-Reply-To: <20200706085508.GA12303@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: abdd30fc-c20a-443a-26d1-08d8221cd788 x-ms-traffictypediagnostic: BL0PR11MB3458: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0457F11EAF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E7C3i9EPnlArKPgeNfae9Y6mERSqyJUjuoo9aFnonC8IBEdpMBHXSJ4y8mn+QWyDOIm3zQ3WziTD/aCoRTJjXQ03VfjpBwsTZisAgIo5z0jWCK9rXaAYo+DNBeqYQmM4rewDjhNtNkbtgHPQrho94wiU7GNfI9gOM5sVQjpaLd8EIuRemzDKVgY0qQmTgpMpaW4kPU54TqFXhQJZCZKwORIhMKVGPqAFxP8oaY+vVSOxKMCXn5CjLOIL+mqtoGmorrimBj4VMWhhB4CW2v3nxcn4avLscjHYrvYF8APjva1nCTR4ZaTVy9BJ1qLbTgWu+O+SZCtNMHc3tKfMD5F37ly2uZvsz3j6iiZA/pzj+VqEF3ufMdr1ba3DttKtveUgt0EMmWmZZG6HLZcG7u+yPA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3506.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(366004)(136003)(396003)(39860400002)(66446008)(76116006)(966005)(26005)(66556008)(66946007)(64756008)(66476007)(86362001)(83380400001)(8936002)(8676002)(5660300002)(52536014)(4326008)(33656002)(55016002)(110136005)(478600001)(54906003)(71200400001)(2906002)(186003)(6506007)(53546011)(7696005)(9686003)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: hB1hYu/0tGnBjMu6eCY0ChxiqmH4lYYgOK5ykjkPxOs/EXfiyXe4RVP0fVkqAYGllmAnfgYx8HGf73uoJcwKPKblQiO18PtRxNHDqFyOHwHi/uiPG/qVg5mmMEK5HdnG1z5oCDKXum62U/lOo4X2M8t7xYpwbKH+dazBuBJVu+Mrigwagpa6ulswnSTttAU8ZJa+0rBRtDVULNc0REDRGRFq0pII22GXpnyBvMwhqiLBoeUADIz7khyxpLDUH/py0DbANIpl97kBYDzkn+feslX+5oXzlScjVyJGVwa0JLeBhZ8ab7fWuLGx+nheKua4KEHPFxFEFxRjZc+uzGMha8ca0D7DEtTNiNc8VbTVu+lzqNOcecKIvdDLNopBNIXCLSQz9/Vnzi18m1UDWo1V0BClGWbFj7o3pyUeHKCTAqB4upar3d9yvQZ22bZKxOigkIG2rxW8OpGreo2+Pyqvqy/JLp0ddCbZzL+oYbw3uH78/PDnt+Q4FQ/LLgJ6jtsX MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3506.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abdd30fc-c20a-443a-26d1-08d8221cd788 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 02:24:14.1439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lHTbimj7Qc8Qzj3IroOOOdCiny6y3m9MwWNH+sk67W15/XZthJ42fxjm6JcKKuAlMVfx8ZLubJs8uaYj+4lU8oCt23ujJ5cqg0chwAzAFrA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3458 Return-Path: shenglei.zhang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Comments below. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm > Sent: Monday, July 6, 2020 4:55 PM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Feng, Bob C ; Bret Barkelew > ; Kinney, Michael D > ; Gao, Liming ; Sean > Brogan > Subject: Re: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc iss= ues > for edk2 on open ci >=20 > On Mon, Jul 06, 2020 at 16:48:30 +0800, Zhang, Shenglei wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2606 > > As planed we will enable Ecc check for edk2 on open ci. And they are > > ready now. I appreciate receiving feedback and comments if someone > > find errors or false positive issues. > > > > I created a pipline of EccCheck for my forked edk2. Welcome everyone t= o > > create pull request to test the quality of this plugin. > > My forked tree: https://github.com/shenglei10/edk2 > > > > And I also created some test cases for ECC plugin. Below are test case= s. > > https://github.com/shenglei10/edk2/tree/ECC > > Results can be view in below azure server. > > > https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=3D= 12 > &_a=3Dsummary > > > > Patches > > 1/16: It's a lib necessary for py3 to run Ecc on azure servers. > > > > 2/16: EccCheck.py is a plugin to report Ecc issues for commits. It can= be run > > on azure servers for open ci, or a local virtual environment. > > > > 3/16~16/16: We consider some cases that will report out Ecc issues but= they > won't > > be fixed, like submodule and industry standard related things. So= we > > add two configuration fields "Exception" and "IgnoreFiles" for pe= ople > > to use. These patches add configuration in yaml files for Ecc che= ck. > > > > Cc: Bob Feng > > Cc: Bret Barkelew > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Sean Brogan > > > > v2: Update 1/17, fix the bug that the script can't hanlde multiple com= mits. > > > > v3: Update 1/17, set the only workalbe workspace is edk2 root director= y. > > Update 2/17, designate the version of antlr4 is 4.7.1. > > Add 4/17~17/17. > > > > v4. Update 1/17, remove the function EdksetupRebuild(), instead add > > function SetupEnvironment(). Update variables' format and type hin= ts > > to pass flake8 and mypy. > > > > v5. Conver the former method to plugin solution, to align with > > other check points on open ci. > > > > v6. The 1/16 patch is missed in v5 series. Now add it in v6. > > > > v7. Fix a bug that Ecc plugin can not be run correctly under Linux OS. >=20 > What is the bug? Where is it fixed? V6 plugin pipeline link: https://dev.azure.com/shengleizhang/shengleizhang/_build/results?buildId= =3D282&view=3Dlogs&j=3D9b8d87a5-bd93-5358-8ffa-588e312c4376&t=3D282a77bb-d= a29-5801-6299-2bbe15d5aabb v7 plugin pipeline link: https://dev.azure.com/shengleizhang/shengleizhang/_build/results?buildId= =3D316&view=3Dlogs&j=3D5e3952f2-9c8a-5394-82c1-a803bcab3ca3&t=3D7ea9e85e-5= c3d-5fcf-865e-8449f16cc745 For the same pull request, v6 plugin can't report out the Ecc issues under= Linux OS. Thanks, Shenglei >=20 > / > Leif >=20 > > Shenglei Zhang (16): > > pip-requirements.txt: Add Ecc required lib > > .pytool/Plugin: Add a plugin EccCheck > > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check > > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check > > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check > > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check > > FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check > > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check > > MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check > > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check > > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc che= ck > > SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check > > ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check > > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check > > UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file > > > > .pytool/Plugin/EccCheck/EccCheck.py | 267 +++++++++++++++++= + > > .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 + > > .pytool/Plugin/EccCheck/Readme.md | 15 + > > ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 + > > CryptoPkg/CryptoPkg.ci.yaml | 11 + > > EmulatorPkg/EmulatorPkg.ci.yaml | 11 + > > FatPkg/FatPkg.ci.yaml | 11 + > > FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 + > > MdeModulePkg/MdeModulePkg.ci.yaml | 11 + > > MdePkg/MdePkg.ci.yaml | 11 + > > NetworkPkg/NetworkPkg.ci.yaml | 11 + > > OvmfPkg/OvmfPkg.ci.yaml | 11 + > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 + > > SecurityPkg/SecurityPkg.ci.yaml | 11 + > > ShellPkg/ShellPkg.ci.yaml | 11 + > > UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 + > > .../UnitTestFrameworkPkg.ci.yaml | 10 + > > pip-requirements.txt | 1 + > > 18 files changed, 447 insertions(+) > > create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py > > create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml > > create mode 100644 .pytool/Plugin/EccCheck/Readme.md > > > > -- > > 2.18.0.windows.1 > > > > > > > > >=20 >=20