From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.12984.1595308843925852818 for ; Mon, 20 Jul 2020 22:20:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=abtFIpTl; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: shenglei.zhang@intel.com) IronPort-SDR: eQVwgMB4v9g1wdvJbOsM4NlmZD+FhS5taq2T23c1c6CSE/w0gfml7h7QaExj9rvkIqmKTBZUrf k1ZU6WH6rLxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="149220511" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="149220511" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 22:20:43 -0700 IronPort-SDR: EU5foqF1pQ4MVtfDsu6STi3IAwS0Ct1EFYFX1XZG+jkL4TgxzKdimeQ9a0zo4pg/XyoiqaWfiS 8LdJsvfDwYSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="461948786" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga005.jf.intel.com with ESMTP; 20 Jul 2020 22:20:43 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 22:20:43 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX163.amr.corp.intel.com (10.22.240.88) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 22:20:42 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 22:20:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKbVNXmoVI76RQ3ivUzr9kJZAEkbuKATbVMvXZladzRjPXfJPFArWTIkHnoxVWqLSa/xDuOB4VOG3CXnvL7l4HPBtzVRR3l3Q3VL27OKFULgI0Vz5ktbV8lZ/uXpf9OG27DKXaCXlc4YdYWcrKLe4EHAo88hG5WzbBP4PRf1jQ4bzmGlg5GsI5gLimDNxO4az4vhmhKfQGbdGO42HQWXb/+ts7pv5+r7Q9y2e6M3Dd8t4uAEl9+n6R4ysHEJY1B76NqQC9daPL/A2Jx7lBDYE6pT7+8UVbm3zrwSjN1ZSJMSR5MSCQ1Xirmf55BIRHB94FcfIfkE+qM0KeyLrivIeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NtaCdWlA7etJE4FGaqvrDhZrhjFYIQdGgnrloItz3J4=; b=VF73rWoHl4+3vNoxeyCYXyIY45uGS/MUzvlgBYiX2VjPSxlWUX/LNorJjXzeMAX450VE01Gs/E3JIzo79tbeXbh4oxNUtRWNrUT6wL1L8bRXaeVuGhg/Kuh1KdHY3DLar9Z7luV9v/N2FVm2zxtp3E5NO5Lj+DK/MipgjUaQV7v/hYItOiPYcih6FS9Cpvu4PNV6RIqkOQf0AO7/m2DvfIiVxoFgXyqp+CsgbvVemnC6bCH5ODKhMOmSUhs84uPrq19fuEOJ6YHGtI3cGOeMQj5KCtr2rNK2X4TSRJz3KokD4TvYak5zuvykHWUYwTINcDqEqWo/pptfLwQB6/a1hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NtaCdWlA7etJE4FGaqvrDhZrhjFYIQdGgnrloItz3J4=; b=abtFIpTl2bjXaFoqOrC+ZNVVu5za6qQgaAMhDBnQvO+1CG1rRq40MpSoFrtv3yqvEvGVPEuh0tv96qkKkc71A2cW0g9d1D5G8m+AaxAb31CMJ2XvqoeeS9StGDPCrEmU3Ql9vrUfvl2dUFVSza8ysEUD+Z8ZvCtZbxzU86sHZCA= Received: from BL0PR11MB3506.namprd11.prod.outlook.com (2603:10b6:208:31::24) by BL0PR11MB3025.namprd11.prod.outlook.com (2603:10b6:208:79::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Tue, 21 Jul 2020 05:20:41 +0000 Received: from BL0PR11MB3506.namprd11.prod.outlook.com ([fe80::b805:cb86:230a:6a1]) by BL0PR11MB3506.namprd11.prod.outlook.com ([fe80::b805:cb86:230a:6a1%6]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 05:20:41 +0000 From: "Zhang, Shenglei" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Topic: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Index: AQHWXxBpl+JVP2umBky5YMNoJ8up+6kRfvZQ Date: Tue, 21 Jul 2020 05:20:40 +0000 Message-ID: References: <20200716031346.40160-1-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08f6c3fa-2183-4918-edf3-08d82d35cf8a x-ms-traffictypediagnostic: BL0PR11MB3025: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sWXhO8KZ0FxrO2DmyWeJBK1GxDAQ/Pqu5yuIaJH9BV1XzIxe2TWM5xhEqXSvZ6YZWwgnRTogpqZJcGxpQRqYB4vHCWA3BGtVVlS4uBeKclsSIfjtZQQ45RaJVjT8M2MzWi3bp9ZedIgzA0AB+iPcwleuLBd3/U1uGFWv2mWQGf7NIt5yLGiJTVsdniBVjtpWDiYF1gDn1CBrkjuCbnGnXfF3sfJQFCe2UZAZB0BtyGVCaXYjSJ6sl3dfwdA1CtFd3FBq/hLOwZKkMFSY7AYiPUl1982dbin8hTG7nb90Ml4qnep6Qaq1pukEs4N5wZY+Mn7Zz8GDTZJfP0L1xRqjPVlgv/+csBVp45XndLD3vOS1Pp84Blw9CZIWVdXFRDQw0EKW0PNyvoYYia44/Gux9aPdMErJxfqEmcrzSe3xp0UXMpCLwWGn4soU8WWs4V+kq5GZR7i+McSs/zJqNvoVBbAl3MNwMP3fhyZXIWoNT7Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3506.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(110136005)(316002)(33656002)(86362001)(26005)(186003)(107886003)(478600001)(9686003)(55016002)(71200400001)(966005)(64756008)(66556008)(66476007)(66946007)(7696005)(4326008)(76116006)(8936002)(8676002)(5660300002)(52536014)(6506007)(53546011)(2906002)(83380400001)(66446008)(13513002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 5jlsbPjxqcXAwHQ9mMSDl81J+EXOv9P2qEErDe5ZqJoIPEhIVQMO36A8akq2ktq7nkBJeg6+07L3FzAWgrvrcCWrUs0q56MzGBgyYYusrbIC/xDDNzOLwWcsG+w8I+YaIXPLN5MTZp3ITcnVPW4GDRbi9BgLYY5rRgF4rW3+tNOPfZAT09M2x9mJ35XkzIJnwakMwhDCaVSCck6uSZ2fTj2t08WutQzrDHzoRvS/TBLvvtNOrUezqlykQ5z1/CHPj1dIwHrnBSFGiY26AtygutyjZW/kU6/2+ygbdFWz9Z8mJGCBJNeKpdq734EgfF4iLLjsRJ4plPRlo1sXkrJHkdb3zl04O6g9xySNXkz4WqgKnox2taPmgIB0frtKSLFRDjaq0u7ZOKFPgrmnqk8vrvcRqVbIl5+TQ6wkjY2AlQ5YkOxh81+pepEry4MbxngPaU8Fqt3KVRi5/DBUZn9O0t558hXllIFQ9/nAMpTHCKUlj314bTQgGkLAtH8swucH MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3506.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08f6c3fa-2183-4918-edf3-08d82d35cf8a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 05:20:40.9971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oA0mbUAfV+TBs8w05XjChXOnanFjWg9iBEZg19/Nt4l2mjhpOY/m+J4bk2q/addJ06gfeFkuI9CshARMiPR+WVz5h5eTXHQFj7jIuA2DMNg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3025 Return-Path: shenglei.zhang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob, Code review is for our internal use. Should I append it on Bugzilla? Thanks, Shenglei > -----Original Message----- > From: Feng, Bob C > Sent: Tuesday, July 21, 2020 11:39 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for user > name in xxx-by >=20 > Shenglei, >=20 > After you send out the patch for review, please update the Bugzilla statu= s as > in-progress and provide the code review link. >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name > in xxx-by >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2836 > Current PatchCheck.py checks each line to ensure line's length is not lar= ger > than 76. But there's a case that length of user's name is much longer tha= n > that number. So enhance the script to handle this case. >=20 > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > BaseTools/Scripts/PatchCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -268,7 +268,14 @@ class CommitMessageCheck: > for i in range(2, count): > if (len(lines[i]) >=3D 76 and > len(lines[i].split()) > 1 and > - not lines[i].startswith('git-svn-id:')): > + not lines[i].startswith('git-svn-id:') and > + not lines[i].startswith('Reviewed-by') and > + not lines[i].startswith('Acked-by:') and > + not lines[i].startswith('Tested-by:') and > + not lines[i].startswith('Reported-by:') and > + not lines[i].startswith('Suggested-by:') and > + not lines[i].startswith('Signed-off-by:') and > + not lines[i].startswith('Cc:')): > # > # Print a warning if body line is longer than 75 charact= ers > # > -- > 2.18.0.windows.1