* [PATCH v9 01/16] pip-requirements.txt: Add Ecc required lib
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 02/16] .pytool/Plugin: Add a plugin EccCheck Zhang, Shenglei
` (16 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 574dac43b1a6..0fecd37f2a83 100644
--- a/pip-requirements.txt
+++ b/pip-requirements.txt
@@ -14,3 +14,4 @@
edk2-pytool-library==0.10.*
edk2-pytool-extensions~=0.13.3
+antlr4-python3-runtime==4.7.1
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 02/16] .pytool/Plugin: Add a plugin EccCheck
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 01/16] pip-requirements.txt: Add Ecc required lib Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 03/16] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check Zhang, Shenglei
` (15 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in source code files. And Ecc issues
about comments can also be handled.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.pytool/Plugin/EccCheck/EccCheck.py | 302 ++++++++++++++++++
.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 +
.pytool/Plugin/EccCheck/Readme.md | 15 +
3 files changed, 328 insertions(+)
create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py
create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/EccCheck/Readme.md
diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/EccCheck.py
new file mode 100644
index 000000000000..249a16a7dddf
--- /dev/null
+++ b/.pytool/Plugin/EccCheck/EccCheck.py
@@ -0,0 +1,302 @@
+# @file EccCheck.py
+#
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+import os
+import shutil
+import re
+import csv
+import xml.dom.minidom
+from typing import List, Dict, Tuple
+import logging
+from io import StringIO
+from edk2toolext.environment import shell_environment
+from edk2toolext.environment.plugintypes.ci_build_plugin import ICiBuildPlugin
+from edk2toolext.environment.var_dict import VarDict
+from edk2toollib.utility_functions import RunCmd
+
+
+class EccCheck(ICiBuildPlugin):
+ """
+ A CiBuildPlugin that finds the Ecc issues of newly added code in pull request.
+
+ Configuration options:
+ "EccCheck": {
+ "ExceptionList": [],
+ "IgnoreFiles": []
+ },
+ """
+
+ ReModifyFile = re.compile(r'[B-Q,S-Z]+[\d]*\t(.*)')
+ FindModifyFile = re.compile(r'\+\+\+ b\/(.*)')
+ LineScopePattern = (r'@@ -\d*\,*\d* \+\d*\,*\d* @@.*')
+ LineNumRange = re.compile(r'@@ -\d*\,*\d* \+(\d*)\,*(\d*) @@.*')
+
+ def GetTestName(self, packagename: str, environment: VarDict) -> tuple:
+ """ Provide the testcase name and classname for use in reporting
+ testclassname: a descriptive string for the testcase can include whitespace
+ classname: should be patterned <packagename>.<plugin>.<optionally any unique condition>
+
+ Args:
+ packagename: string containing name of package to build
+ environment: The VarDict for the test to run in
+ Returns:
+ a tuple containing the testcase name and the classname
+ (testcasename, classname)
+ """
+ return ("Check for efi coding style for " + packagename, packagename + ".EccCheck")
+
+ ##
+ # External function of plugin. This function is used to perform the task of the ci_build_plugin Plugin
+ #
+ # - package is the edk2 path to package. This means workspace/packagepath relative.
+ # - edk2path object configured with workspace and packages path
+ # - PkgConfig Object (dict) for the pkg
+ # - EnvConfig Object
+ # - Plugin Manager Instance
+ # - Plugin Helper Obj Instance
+ # - Junit Logger
+ # - output_stream the StringIO output stream from this plugin via logging
+ def RunBuildPlugin(self, packagename, Edk2pathObj, pkgconfig, environment, PLM, PLMHelper, tc, output_stream=None):
+ edk2_path = Edk2pathObj.WorkspacePath
+ python_path = os.path.join(edk2_path, "BaseTools", "Source", "Python")
+ env = shell_environment.GetEnvironment()
+ env.set_shell_var('PYTHONPATH', python_path)
+ env.set_shell_var('WORKSPACE', edk2_path)
+ self.ECC_PASS = True
+ self.ApplyConfig(pkgconfig, edk2_path, packagename)
+ modify_dir_list = self.GetModifyDir(packagename)
+ patch = self.GetDiff(packagename)
+ ecc_diff_range = self.GetDiffRange(patch, packagename, edk2_path)
+ self.GenerateEccReport(modify_dir_list, ecc_diff_range, edk2_path)
+ ecc_log = os.path.join(edk2_path, "Ecc.log")
+ if self.ECC_PASS:
+ tc.SetSuccess()
+ self.RemoveFile(ecc_log)
+ return 0
+ else:
+ with open(ecc_log, encoding='utf8') as output:
+ ecc_output = output.readlines()
+ for line in ecc_output:
+ logging.error(line.strip())
+ self.RemoveFile(ecc_log)
+ tc.SetFailed("EccCheck failed for {0}".format(packagename), "Ecc detected issues")
+ return 1
+
+ def GetDiff(self, pkg: str) -> List[str]:
+ return_buffer = StringIO()
+ params = "diff --unified=0 origin/master HEAD"
+ RunCmd("git", params, outstream=return_buffer)
+ p = return_buffer.getvalue().strip()
+ patch = p.split("\n")
+ return_buffer.close()
+
+ return patch
+
+ def RemoveFile(self, file: str) -> None:
+ if os.path.exists(file):
+ os.remove(file)
+ return
+
+ def GetModifyDir(self, pkg: str) -> List[str]:
+ return_buffer = StringIO()
+ params = "diff --name-status" + ' HEAD' + ' origin/master'
+ RunCmd("git", params, outstream=return_buffer)
+ p1 = return_buffer.getvalue().strip()
+ dir_list = p1.split("\n")
+ return_buffer.close()
+ modify_dir_list = []
+ for modify_dir in dir_list:
+ file_path = self.ReModifyFile.findall(modify_dir)
+ if file_path:
+ file_dir = os.path.dirname(file_path[0])
+ else:
+ continue
+ if pkg in file_dir and file_dir != pkg:
+ modify_dir_list.append('%s' % file_dir)
+ else:
+ continue
+
+ modify_dir_list = list(set(modify_dir_list))
+ return modify_dir_list
+
+ def GetDiffRange(self, patch_diff: List[str], pkg: str, workingdir: str) -> Dict[str, List[Tuple[int, int]]]:
+ IsDelete = True
+ StartCheck = False
+ range_directory: Dict[str, List[Tuple[int, int]]] = {}
+ for line in patch_diff:
+ modify_file = self.FindModifyFile.findall(line)
+ if modify_file and pkg in modify_file[0] and not StartCheck and os.path.isfile(modify_file[0]):
+ modify_file_comment_dic = self.GetCommentRange(modify_file[0], workingdir)
+ IsDelete = False
+ StartCheck = True
+ modify_file_dic = modify_file[0]
+ modify_file_dic = modify_file_dic.replace("/", os.sep)
+ range_directory[modify_file_dic] = []
+ elif line.startswith('--- '):
+ StartCheck = False
+ elif re.match(self.LineScopePattern, line, re.I) and not IsDelete and StartCheck:
+ start_line = self.LineNumRange.search(line).group(1)
+ line_range = self.LineNumRange.search(line).group(2)
+ if not line_range:
+ line_range = '1'
+ range_directory[modify_file_dic].append((int(start_line), int(start_line) + int(line_range) - 1))
+ for i in modify_file_comment_dic:
+ if int(i[0]) <= int(start_line) <= int(i[1]):
+ range_directory[modify_file_dic].append(i)
+ return range_directory
+
+ def GetCommentRange(self, modify_file: str, workingdir: str) -> List[Tuple[int, int]]:
+ modify_file_path = os.path.join(workingdir, modify_file)
+ with open(modify_file_path) as f:
+ line_no = 1
+ comment_range: List[Tuple[int, int]] = []
+ Start = False
+ for line in f:
+ if line.startswith('/**'):
+ start_no = line_no
+ Start = True
+ if line.startswith('**/') and Start:
+ end_no = line_no
+ Start = False
+ comment_range.append((int(start_no), int(end_no)))
+ line_no += 1
+
+ if comment_range and comment_range[0][0] == 1:
+ del comment_range[0]
+ return comment_range
+
+ def GenerateEccReport(self, modify_dir_list: List[str], ecc_diff_range: Dict[str, List[Tuple[int, int]]],
+ edk2_path: str) -> None:
+ ecc_need = False
+ ecc_run = True
+ config = os.path.join(edk2_path, "BaseTools", "Source", "Python", "Ecc", "config.ini")
+ exception = os.path.join(edk2_path, "BaseTools", "Source", "Python", "Ecc", "exception.xml")
+ report = os.path.join(edk2_path, "Ecc.csv")
+ for modify_dir in modify_dir_list:
+ target = os.path.join(edk2_path, modify_dir)
+ logging.info('Run ECC tool for the commit in %s' % modify_dir)
+ ecc_need = True
+ ecc_params = "-c {0} -e {1} -t {2} -r {3}".format(config, exception, target, report)
+ return_code = RunCmd("Ecc", ecc_params, workingdir=edk2_path)
+ if return_code != 0:
+ ecc_run = False
+ break
+ if not ecc_run:
+ logging.error('Fail to run ECC tool')
+ self.ParseEccReport(ecc_diff_range, edk2_path)
+
+ if not ecc_need:
+ logging.info("Doesn't need run ECC check")
+
+ revert_params = "checkout -- {}".format(exception)
+ RunCmd("git", revert_params)
+ return
+
+ def ParseEccReport(self, ecc_diff_range: Dict[str, List[Tuple[int, int]]], edk2_path: str) -> None:
+ ecc_log = os.path.join(edk2_path, "Ecc.log")
+ ecc_csv = "Ecc.csv"
+ file = os.listdir(edk2_path)
+ row_lines = []
+ ignore_error_code = self.GetIgnoreErrorCode()
+ if ecc_csv in file:
+ with open(ecc_csv) as csv_file:
+ reader = csv.reader(csv_file)
+ for row in reader:
+ for modify_file in ecc_diff_range:
+ if modify_file in row[3]:
+ for i in ecc_diff_range[modify_file]:
+ line_no = int(row[4])
+ if i[0] <= line_no <= i[1] and row[1] not in ignore_error_code:
+ row[0] = '\nEFI coding style error'
+ row[1] = 'Error code: ' + row[1]
+ row[3] = 'file: ' + row[3]
+ row[4] = 'Line number: ' + row[4]
+ row_line = '\n *'.join(row)
+ row_lines.append(row_line)
+ break
+ break
+ if row_lines:
+ self.ECC_PASS = False
+
+ with open(ecc_log, 'a') as log:
+ all_line = '\n'.join(row_lines)
+ all_line = all_line + '\n'
+ log.writelines(all_line)
+ return
+
+ def ApplyConfig(self, pkgconfig: Dict[str, List[str]], edk2_path: str, pkg: str) -> None:
+ if "IgnoreFiles" in pkgconfig:
+ for a in pkgconfig["IgnoreFiles"]:
+ a = os.path.join(edk2_path, pkg, a)
+ a = a.replace(os.sep, "/")
+
+ logging.info("Ignoring Files {0}".format(a))
+ if os.path.exists(a):
+ if os.path.isfile(a):
+ self.RemoveFile(a)
+ elif os.path.isdir(a):
+ shutil.rmtree(a)
+ else:
+ logging.error("EccCheck.IgnoreInf -> {0} not found in filesystem. Invalid ignore files".format(a))
+
+ if "ExceptionList" in pkgconfig:
+ exception_list = pkgconfig["ExceptionList"]
+ exception_xml = os.path.join(edk2_path, "BaseTools", "Source", "Python", "Ecc", "exception.xml")
+ try:
+ logging.info("Appending exceptions")
+ self.AppendException(exception_list, exception_xml)
+ except Exception as e:
+ logging.error("Fail to apply exceptions")
+ raise e
+ return
+
+ def AppendException(self, exception_list: List[str], exception_xml: str) -> None:
+ error_code_list = exception_list[::2]
+ keyword_list = exception_list[1::2]
+ dom_tree = xml.dom.minidom.parse(exception_xml)
+ root_node = dom_tree.documentElement
+ for error_code, keyword in zip(error_code_list, keyword_list):
+ customer_node = dom_tree.createElement("Exception")
+ keyword_node = dom_tree.createElement("KeyWord")
+ keyword_node_text_value = dom_tree.createTextNode(keyword)
+ keyword_node.appendChild(keyword_node_text_value)
+ customer_node.appendChild(keyword_node)
+ error_code_node = dom_tree.createElement("ErrorID")
+ error_code_text_value = dom_tree.createTextNode(error_code)
+ error_code_node.appendChild(error_code_text_value)
+ customer_node.appendChild(error_code_node)
+ root_node.appendChild(customer_node)
+ with open(exception_xml, 'w') as f:
+ dom_tree.writexml(f, indent='', addindent='', newl='\n', encoding='UTF-8')
+ return
+
+ def GetIgnoreErrorCode(self) -> set:
+ """
+ Below are kinds of error code that are accurate in ecc scanning of edk2 level.
+ But EccCheck plugin is partial scanning so they are always false positive issues.
+ The mapping relationship of error code and error message is listed BaseTools/Sourc/Python/Ecc/EccToolError.py
+ """
+ ignore_error_code = {
+ "10000",
+ "10001",
+ "10002",
+ "10003",
+ "10004",
+ "10005",
+ "10006",
+ "10007",
+ "10008",
+ "10009",
+ "10010",
+ "10011",
+ "10012",
+ "10013",
+ "10015",
+ "10016",
+ "10017",
+ "10022",
+ }
+ return ignore_error_code
diff --git a/.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml b/.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
new file mode 100644
index 000000000000..0d121ecb1861
--- /dev/null
+++ b/.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
@@ -0,0 +1,11 @@
+## @file
+# CiBuildPlugin used to check Ecc issues
+#
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "scope": "cibuild",
+ "name": "EccCheck Test",
+ "module": "EccCheck"
+}
diff --git a/.pytool/Plugin/EccCheck/Readme.md b/.pytool/Plugin/EccCheck/Readme.md
new file mode 100644
index 000000000000..85c439a5edf1
--- /dev/null
+++ b/.pytool/Plugin/EccCheck/Readme.md
@@ -0,0 +1,15 @@
+# EFI Coding style Check Plugin
+
+This CiBuildPlugin finds the Ecc issues of newly added code in pull request.
+
+## Configuration
+
+The plugin can be configured to ignore certain files and issues.
+
+"EccCheck": {
+ "ExceptionList": [],
+ "IgnoreFiles": []
+ },
+ """
+
+OPTIONAL List of file to ignore.
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 03/16] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 01/16] pip-requirements.txt: Add Ecc required lib Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 02/16] .pytool/Plugin: Add a plugin EccCheck Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
` (14 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Hao A Wu
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdeModulePkg/MdeModulePkg.ci.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index 0fc8c3633878..1a7e955185d8 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -2,6 +2,7 @@
# CI configuration for MdeModulePkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -9,6 +10,19 @@
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ "Library/BrotliCustomDecompressLib/brotli",
+ "Universal/RegularExpressionDxe/oniguruma"
+ ]
+ },
## options defined ci/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "MdeModulePkg.dsc"
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (2 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 03/16] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 8:14 ` Ard Biesheuvel
2020-08-11 7:01 ` [PATCH v9 05/16] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
` (13 subsequent siblings)
17 siblings, 1 reply; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Ard Biesheuvel, Leif Lindholm
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
index 27bb7ff49011..8b2c0305c175 100644
--- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
+++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
@@ -5,6 +5,7 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -12,6 +13,17 @@
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "" # Don't support this test
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 ` [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 8:14 ` Ard Biesheuvel
0 siblings, 0 replies; 23+ messages in thread
From: Ard Biesheuvel @ 2020-08-11 8:14 UTC (permalink / raw)
To: Shenglei Zhang, devel; +Cc: Laszlo Ersek, Leif Lindholm
On 8/11/20 9:01 AM, Shenglei Zhang wrote:
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
> ArmVirtPkg/ArmVirtPkg.ci.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index 27bb7ff49011..8b2c0305c175 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -5,6 +5,7 @@
> # used for code analysis.
> #
> # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> {
> @@ -12,6 +13,17 @@
> "LicenseCheck": {
> "IgnoreFiles": []
> },
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": [
> + ]
> + },
> ## options defined .pytool/Plugin/CompilerPlugin
> "CompilerPlugin": {
> "DscPath": "" # Don't support this test
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v9 05/16] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (3 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 11:21 ` [edk2-devel] " Guomin Jiang
2020-08-11 7:01 ` [PATCH v9 06/16] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
` (12 subsequent siblings)
17 siblings, 1 reply; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Xiaoyu Lu
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
CryptoPkg/CryptoPkg.ci.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index e73b79e01fef..e2d190a90c51 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -2,12 +2,25 @@
# CI configuration for CryptoPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ "Library/OpensslLib/openssl"
+ ]
+ },
"CompilerPlugin": {
"DscPath": "CryptoPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [edk2-devel] [PATCH v9 05/16] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 ` [PATCH v9 05/16] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 11:21 ` Guomin Jiang
0 siblings, 0 replies; 23+ messages in thread
From: Guomin Jiang @ 2020-08-11 11:21 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Wang, Jian J, Lu, XiaoyuX
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
Thanks
Guomin
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang,
> Shenglei
> Sent: Tuesday, August 11, 2020 3:02 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v9 05/16] CryptoPkg/CryptoPkg.ci.yaml: Add
> configuration for Ecc check
>
> Add configuration ExceptionList and IgnoreFiles for package config files. So
> users can rely on this to ignore some Ecc issues.
> Besides, add submodule path in IgnoreFiles section.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> CryptoPkg/CryptoPkg.ci.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index e73b79e01fef..e2d190a90c51 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -2,12 +2,25 @@
> # CI configuration for CryptoPkg
> #
> # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent ## {
> "LicenseCheck": {
> "IgnoreFiles": []
> },
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": [
> + "Library/OpensslLib/openssl"
> + ]
> + },
> "CompilerPlugin": {
> "DscPath": "CryptoPkg.dsc"
> },
> --
> 2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v9 06/16] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (4 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 05/16] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 07/16] FatPkg/FatPkg.ci.yaml: " Zhang, Shenglei
` (11 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Jordan Justen, Andrew Fish, Ray Ni
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
EmulatorPkg/EmulatorPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml b/EmulatorPkg/EmulatorPkg.ci.yaml
index dead82f69745..980844c1fdd4 100644
--- a/EmulatorPkg/EmulatorPkg.ci.yaml
+++ b/EmulatorPkg/EmulatorPkg.ci.yaml
@@ -5,6 +5,7 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -12,6 +13,17 @@
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "" # Don't support this test
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 07/16] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (5 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 06/16] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 08/16] FmpDevicePkg/FmpDevicePkg.ci.yaml: " Zhang, Shenglei
` (10 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Ray Ni
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
FatPkg/FatPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml
index 489c4614e9e1..fe95f481b50c 100644
--- a/FatPkg/FatPkg.ci.yaml
+++ b/FatPkg/FatPkg.ci.yaml
@@ -2,12 +2,24 @@
# CI configuration for FatPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "FatPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 08/16] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (6 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 07/16] FatPkg/FatPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 09/16] MdePkg/MdePkg.ci.yaml: " Zhang, Shenglei
` (9 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Liming Gao, Michael D Kinney
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/FmpDevicePkg/FmpDevicePkg.ci.yaml b/FmpDevicePkg/FmpDevicePkg.ci.yaml
index d498ad7d21e1..1b3e2187356d 100644
--- a/FmpDevicePkg/FmpDevicePkg.ci.yaml
+++ b/FmpDevicePkg/FmpDevicePkg.ci.yaml
@@ -2,12 +2,24 @@
# CI configuration for FmpDevicePkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "FmpDevicePkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 09/16] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (7 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 08/16] FmpDevicePkg/FmpDevicePkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 10/16] NetworkPkg/NetworkPkg.ci.yaml: " Zhang, Shenglei
` (8 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
MdePkg/MdePkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index b088a4344908..15931eaccabf 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -2,6 +2,7 @@
# CI configuration for MdePkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -9,6 +10,17 @@
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
## options defined ci/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "MdePkg.dsc"
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 10/16] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (8 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 09/16] MdePkg/MdePkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:01 ` [PATCH v9 11/16] OvmfPkg/OvmfPkg.ci.yaml: " Zhang, Shenglei
` (7 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Maciej Rabeda, Jiaxin Wu, Siyuan Fu
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
NetworkPkg/NetworkPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/NetworkPkg/NetworkPkg.ci.yaml b/NetworkPkg/NetworkPkg.ci.yaml
index aa536830fc27..1a3ab71792d1 100644
--- a/NetworkPkg/NetworkPkg.ci.yaml
+++ b/NetworkPkg/NetworkPkg.ci.yaml
@@ -2,12 +2,24 @@
# CI configuration for NetworkPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "NetworkPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 11/16] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (9 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 10/16] NetworkPkg/NetworkPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:01 ` Zhang, Shenglei
2020-08-11 7:02 ` [PATCH v9 12/16] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
` (6 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:01 UTC (permalink / raw)
To: devel; +Cc: Jordan Justen, Laszlo Ersek, Ard Biesheuvel
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
OvmfPkg/OvmfPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
index ed342d7a3d08..3128aefe9ed1 100644
--- a/OvmfPkg/OvmfPkg.ci.yaml
+++ b/OvmfPkg/OvmfPkg.ci.yaml
@@ -5,6 +5,7 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -12,6 +13,17 @@
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "" # Don't support this test
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 12/16] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (10 preceding siblings ...)
2020-08-11 7:01 ` [PATCH v9 11/16] OvmfPkg/OvmfPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:02 ` Zhang, Shenglei
2020-08-11 7:02 ` [PATCH v9 13/16] SecurityPkg/SecurityPkg.ci.yaml: " Zhang, Shenglei
` (5 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:02 UTC (permalink / raw)
To: devel; +Cc: Ray Ni
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
index 5543d15c3248..61f3fd7b5074 100644
--- a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
+++ b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
@@ -2,12 +2,25 @@
# CI configuration for PcAtChipsetPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
+ ## options defined .pytool/Plugin/LicenseCheck
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "PcAtChipsetPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 13/16] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (11 preceding siblings ...)
2020-08-11 7:02 ` [PATCH v9 12/16] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:02 ` Zhang, Shenglei
2020-08-11 7:02 ` [PATCH v9 14/16] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
` (4 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:02 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Jian J Wang, Chao Zhang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
SecurityPkg/SecurityPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.ci.yaml b/SecurityPkg/SecurityPkg.ci.yaml
index 1ef1d2e67ead..03be2e94ca97 100644
--- a/SecurityPkg/SecurityPkg.ci.yaml
+++ b/SecurityPkg/SecurityPkg.ci.yaml
@@ -2,12 +2,24 @@
# CI configuration for SecurityPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "SecurityPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 14/16] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (12 preceding siblings ...)
2020-08-11 7:02 ` [PATCH v9 13/16] SecurityPkg/SecurityPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:02 ` Zhang, Shenglei
2020-08-11 7:02 ` [PATCH v9 15/16] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
` (3 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:02 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Zhichao Gao
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
ShellPkg/ShellPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
index 565e08596b2f..30894d44bc3a 100644
--- a/ShellPkg/ShellPkg.ci.yaml
+++ b/ShellPkg/ShellPkg.ci.yaml
@@ -2,12 +2,24 @@
# CI configuration for ShellPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "ShellPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 15/16] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (13 preceding siblings ...)
2020-08-11 7:02 ` [PATCH v9 14/16] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:02 ` Zhang, Shenglei
2020-08-11 7:02 ` [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file Zhang, Shenglei
` (2 subsequent siblings)
17 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:02 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Ray Ni, Laszlo Ersek
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Acked-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
index d54651d43800..48ab710438a9 100644
--- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
+++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
@@ -2,12 +2,24 @@
# CI configuration for UefiCpuPkg
#
# Copyright (c) Microsoft Corporation
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
"CompilerPlugin": {
"DscPath": "UefiCpuPkg.dsc"
},
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (14 preceding siblings ...)
2020-08-11 7:02 ` [PATCH v9 15/16] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
@ 2020-08-11 7:02 ` Zhang, Shenglei
2020-08-14 1:58 ` Michael D Kinney
2020-08-11 15:35 ` [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Laszlo Ersek
2020-08-12 1:07 ` Liming Gao
17 siblings, 1 reply; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-11 7:02 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Sean Brogan, Bret Barkelew
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
index fc5b3b387664..9e9ffc1af113 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
@@ -9,6 +9,18 @@
"LicenseCheck": {
"IgnoreFiles": []
},
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ "Library/CmockaLib/cmocka"
+ ]
+ },
## options defined .pytool/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "UnitTestFrameworkPkg.dsc"
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
2020-08-11 7:02 ` [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file Zhang, Shenglei
@ 2020-08-14 1:58 ` Michael D Kinney
0 siblings, 0 replies; 23+ messages in thread
From: Michael D Kinney @ 2020-08-14 1:58 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io, Kinney, Michael D
Cc: Sean Brogan, Bret Barkelew
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Tuesday, August 11, 2020 12:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
>
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
> Besides, add submodule path in IgnoreFiles section.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> index fc5b3b387664..9e9ffc1af113 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> @@ -9,6 +9,18 @@
> "LicenseCheck": {
> "IgnoreFiles": []
> },
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": [
> + "Library/CmockaLib/cmocka"
> + ]
> + },
> ## options defined .pytool/Plugin/CompilerPlugin
> "CompilerPlugin": {
> "DscPath": "UnitTestFrameworkPkg.dsc"
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (15 preceding siblings ...)
2020-08-11 7:02 ` [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file Zhang, Shenglei
@ 2020-08-11 15:35 ` Laszlo Ersek
2020-08-12 1:23 ` Zhang, Shenglei
2020-08-12 1:07 ` Liming Gao
17 siblings, 1 reply; 23+ messages in thread
From: Laszlo Ersek @ 2020-08-11 15:35 UTC (permalink / raw)
To: devel, shenglei.zhang
Cc: Bob Feng, Bret Barkelew, Michael D Kinney, Liming Gao,
Sean Brogan, Ard Biesheuvel (ARM address)
Hello Shenglei,
(+Ard)
On 08/11/20 09:01, Zhang, Shenglei wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
> As planed we will enable Ecc check for edk2 on open ci. And they are
> ready now. I appreciate receiving feedback and comments if someone
> find errors or false positive issues.
>
> I created a pipline of EccCheck for my forked edk2. Welcome everyone to
> create pull request to test the quality of this plugin.
> My forked tree: https://github.com/shenglei10/edk2
>
> And I also created some test cases for ECC plugin. Below are test cases.
> https://github.com/shenglei10/edk2/tree/ECC
> Results can be view in below azure server.
> https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=12&_a=summary
>
> Patches
> 1/16: It's a lib necessary for py3 to run Ecc on azure servers.
>
> 2/16: EccCheck.py is a plugin to report Ecc issues for commits. It can be run
> on azure servers for open ci, or a local virtual environment.
>
> 3/16~16/16: We consider some cases that will report out Ecc issues but they won't
> be fixed, like submodule and industry standard related things. So we
> add two configuration fields "Exception" and "IgnoreFiles" for people
> to use. These patches add configuration in yaml files for Ecc check.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
>
> v2: Update 1/17, fix the bug that the script can't hanlde multiple commits.
>
> v3: Update 1/17, set the only workalbe workspace is edk2 root directory.
> Update 2/17, designate the version of antlr4 is 4.7.1.
> Add 4/17~17/17.
>
> v4. Update 1/17, remove the function EdksetupRebuild(), instead add
> function SetupEnvironment(). Update variables' format and type hints
> to pass flake8 and mypy.
>
> v5. Conver the former method to plugin solution, to align with
> other check points on open ci.
>
> v6. The 1/16 patch is missed in v5 series. Now add it in v6.
>
> v7. Fix a bug that Ecc plugin can not be run correctly under Linux OS.
>
> v8. Enable error code config section to ignore certain kinds of issues,
> which are always false positive in partial Ecc scaning.
> All patches except 2/16 have been R-B and are not updated in v8 series.
> To avoid making noise in community, I only send cover letter and 2/16 patch.
2/16: ".pytool/Plugin: Add a plugin EccCheck"
>
> v9. Update 2/16, 3/16, 5/16 and 16/16.
2/16: ".pytool/Plugin: Add a plugin EccCheck"
3/16: "MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check"
5/16: "CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check"
16/16: "UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file"
So no changes to the ArmVirtPkg and OvmfPkg patches since v7.
In v7, my Acked-by was present on both patches 04/16
("ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check"):
http://mid.mail-archive.com/20200706084846.12748-5-shenglei.zhang@intel.com
https://edk2.groups.io/g/devel/message/62075
and 11/16 ("OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check"):
http://mid.mail-archive.com/20200706084846.12748-12-shenglei.zhang@intel.com
https://edk2.groups.io/g/devel/message/62082
Why did you drop my A-b from the ArmVirtPkg patch in v9?
Thanks,
Laszlo
> 1. Enable directory path for "IgnoreFiles" section in xxxPkg.yaml. So that
> users can skip a certain directory and don't need to fill in with file names.
> 2. Add submodule pathes in "IgnoreFiles" in MdeModulePkg.ci.yaml,
> CryptoPkg.ci.yaml and UnitTestFrameworkPkg.ci.yaml.
>
> Shenglei Zhang (16):
> pip-requirements.txt: Add Ecc required lib
> .pytool/Plugin: Add a plugin EccCheck
> MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check
> ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
> CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check
> EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
> FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
> FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
> MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check
> NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
> OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check
> PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
> SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check
> ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
> UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
> UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
>
> .pytool/Plugin/EccCheck/EccCheck.py | 302 ++++++++++++++++++
> .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 +
> .pytool/Plugin/EccCheck/Readme.md | 15 +
> ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +
> CryptoPkg/CryptoPkg.ci.yaml | 13 +
> EmulatorPkg/EmulatorPkg.ci.yaml | 11 +
> FatPkg/FatPkg.ci.yaml | 12 +
> FmpDevicePkg/FmpDevicePkg.ci.yaml | 12 +
> MdeModulePkg/MdeModulePkg.ci.yaml | 13 +
> MdePkg/MdePkg.ci.yaml | 11 +
> NetworkPkg/NetworkPkg.ci.yaml | 12 +
> OvmfPkg/OvmfPkg.ci.yaml | 11 +
> PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 12 +
> SecurityPkg/SecurityPkg.ci.yaml | 12 +
> ShellPkg/ShellPkg.ci.yaml | 12 +
> UefiCpuPkg/UefiCpuPkg.ci.yaml | 12 +
> .../UnitTestFrameworkPkg.ci.yaml | 11 +
> pip-requirements.txt | 1 +
> 18 files changed, 494 insertions(+)
> create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py
> create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
> create mode 100644 .pytool/Plugin/EccCheck/Readme.md
>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci
2020-08-11 15:35 ` [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Laszlo Ersek
@ 2020-08-12 1:23 ` Zhang, Shenglei
0 siblings, 0 replies; 23+ messages in thread
From: Zhang, Shenglei @ 2020-08-12 1:23 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Feng, Bob C, Bret Barkelew, Kinney, Michael D, Gao, Liming,
Sean Brogan, Ard Biesheuvel (ARM address)
Hi Laszlo,
Sorry for that. I removed it by mistake. I'll re-add it into the patch.
Thanks,
Shenglei
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, August 11, 2020 11:36 PM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Ard Biesheuvel (ARM address)
> <ard.biesheuvel@arm.com>
> Subject: Re: [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues
> for edk2 on open ci
>
> Hello Shenglei,
>
> (+Ard)
>
> On 08/11/20 09:01, Zhang, Shenglei wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
> > As planed we will enable Ecc check for edk2 on open ci. And they are
> > ready now. I appreciate receiving feedback and comments if someone
> > find errors or false positive issues.
> >
> > I created a pipline of EccCheck for my forked edk2. Welcome everyone to
> > create pull request to test the quality of this plugin.
> > My forked tree: https://github.com/shenglei10/edk2
> >
> > And I also created some test cases for ECC plugin. Below are test cases.
> > https://github.com/shenglei10/edk2/tree/ECC
> > Results can be view in below azure server.
> >
> https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=12
> &_a=summary
> >
> > Patches
> > 1/16: It's a lib necessary for py3 to run Ecc on azure servers.
> >
> > 2/16: EccCheck.py is a plugin to report Ecc issues for commits. It can be run
> > on azure servers for open ci, or a local virtual environment.
> >
> > 3/16~16/16: We consider some cases that will report out Ecc issues but they
> won't
> > be fixed, like submodule and industry standard related things. So we
> > add two configuration fields "Exception" and "IgnoreFiles" for people
> > to use. These patches add configuration in yaml files for Ecc check.
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> >
> > v2: Update 1/17, fix the bug that the script can't hanlde multiple commits.
> >
> > v3: Update 1/17, set the only workalbe workspace is edk2 root directory.
> > Update 2/17, designate the version of antlr4 is 4.7.1.
> > Add 4/17~17/17.
> >
> > v4. Update 1/17, remove the function EdksetupRebuild(), instead add
> > function SetupEnvironment(). Update variables' format and type hints
> > to pass flake8 and mypy.
> >
> > v5. Conver the former method to plugin solution, to align with
> > other check points on open ci.
> >
> > v6. The 1/16 patch is missed in v5 series. Now add it in v6.
> >
> > v7. Fix a bug that Ecc plugin can not be run correctly under Linux OS.
> >
> > v8. Enable error code config section to ignore certain kinds of issues,
> > which are always false positive in partial Ecc scaning.
> > All patches except 2/16 have been R-B and are not updated in v8 series.
> > To avoid making noise in community, I only send cover letter and 2/16
> patch.
>
> 2/16: ".pytool/Plugin: Add a plugin EccCheck"
>
> >
> > v9. Update 2/16, 3/16, 5/16 and 16/16.
>
> 2/16: ".pytool/Plugin: Add a plugin EccCheck"
> 3/16: "MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc
> check"
> 5/16: "CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check"
> 16/16: "UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file"
>
> So no changes to the ArmVirtPkg and OvmfPkg patches since v7.
>
> In v7, my Acked-by was present on both patches 04/16
> ("ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check"):
>
> http://mid.mail-archive.com/20200706084846.12748-5-
> shenglei.zhang@intel.com
> https://edk2.groups.io/g/devel/message/62075
>
> and 11/16 ("OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check"):
>
> http://mid.mail-archive.com/20200706084846.12748-12-
> shenglei.zhang@intel.com
> https://edk2.groups.io/g/devel/message/62082
>
> Why did you drop my A-b from the ArmVirtPkg patch in v9?
>
> Thanks,
> Laszlo
>
> > 1. Enable directory path for "IgnoreFiles" section in xxxPkg.yaml. So that
> > users can skip a certain directory and don't need to fill in with file names.
> > 2. Add submodule pathes in "IgnoreFiles" in MdeModulePkg.ci.yaml,
> > CryptoPkg.ci.yaml and UnitTestFrameworkPkg.ci.yaml.
> >
> > Shenglei Zhang (16):
> > pip-requirements.txt: Add Ecc required lib
> > .pytool/Plugin: Add a plugin EccCheck
> > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check
> > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
> > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check
> > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
> > FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
> > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
> > MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check
> > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
> > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check
> > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
> > SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check
> > ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
> > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
> > UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
> >
> > .pytool/Plugin/EccCheck/EccCheck.py | 302 ++++++++++++++++++
> > .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 +
> > .pytool/Plugin/EccCheck/Readme.md | 15 +
> > ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +
> > CryptoPkg/CryptoPkg.ci.yaml | 13 +
> > EmulatorPkg/EmulatorPkg.ci.yaml | 11 +
> > FatPkg/FatPkg.ci.yaml | 12 +
> > FmpDevicePkg/FmpDevicePkg.ci.yaml | 12 +
> > MdeModulePkg/MdeModulePkg.ci.yaml | 13 +
> > MdePkg/MdePkg.ci.yaml | 11 +
> > NetworkPkg/NetworkPkg.ci.yaml | 12 +
> > OvmfPkg/OvmfPkg.ci.yaml | 11 +
> > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 12 +
> > SecurityPkg/SecurityPkg.ci.yaml | 12 +
> > ShellPkg/ShellPkg.ci.yaml | 12 +
> > UefiCpuPkg/UefiCpuPkg.ci.yaml | 12 +
> > .../UnitTestFrameworkPkg.ci.yaml | 11 +
> > pip-requirements.txt | 1 +
> > 18 files changed, 494 insertions(+)
> > create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py
> > create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
> > create mode 100644 .pytool/Plugin/EccCheck/Readme.md
> >
>
>
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci
2020-08-11 7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
` (16 preceding siblings ...)
2020-08-11 15:35 ` [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Laszlo Ersek
@ 2020-08-12 1:07 ` Liming Gao
17 siblings, 0 replies; 23+ messages in thread
From: Liming Gao @ 2020-08-12 1:07 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Cc: Feng, Bob C, Bret Barkelew, Kinney, Michael D, Sean Brogan
Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang@intel.com>
Sent: 2020年8月11日 15:02
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
Subject: [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are ready now. I appreciate receiving feedback and comments if someone find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2. Welcome everyone to create pull request to test the quality of this plugin.
My forked tree: https://github.com/shenglei10/edk2
And I also created some test cases for ECC plugin. Below are test cases.
https://github.com/shenglei10/edk2/tree/ECC
Results can be view in below azure server.
https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=12&_a=summary
Patches
1/16: It's a lib necessary for py3 to run Ecc on azure servers.
2/16: EccCheck.py is a plugin to report Ecc issues for commits. It can be run
on azure servers for open ci, or a local virtual environment.
3/16~16/16: We consider some cases that will report out Ecc issues but they won't
be fixed, like submodule and industry standard related things. So we
add two configuration fields "Exception" and "IgnoreFiles" for people
to use. These patches add configuration in yaml files for Ecc check.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
v2: Update 1/17, fix the bug that the script can't hanlde multiple commits.
v3: Update 1/17, set the only workalbe workspace is edk2 root directory.
Update 2/17, designate the version of antlr4 is 4.7.1.
Add 4/17~17/17.
v4. Update 1/17, remove the function EdksetupRebuild(), instead add
function SetupEnvironment(). Update variables' format and type hints
to pass flake8 and mypy.
v5. Conver the former method to plugin solution, to align with
other check points on open ci.
v6. The 1/16 patch is missed in v5 series. Now add it in v6.
v7. Fix a bug that Ecc plugin can not be run correctly under Linux OS.
v8. Enable error code config section to ignore certain kinds of issues,
which are always false positive in partial Ecc scaning.
All patches except 2/16 have been R-B and are not updated in v8 series.
To avoid making noise in community, I only send cover letter and 2/16 patch.
v9. Update 2/16, 3/16, 5/16 and 16/16.
1. Enable directory path for "IgnoreFiles" section in xxxPkg.yaml. So that
users can skip a certain directory and don't need to fill in with file names.
2. Add submodule pathes in "IgnoreFiles" in MdeModulePkg.ci.yaml,
CryptoPkg.ci.yaml and UnitTestFrameworkPkg.ci.yaml.
Shenglei Zhang (16):
pip-requirements.txt: Add Ecc required lib
.pytool/Plugin: Add a plugin EccCheck
MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check
ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check
EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check
FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check
NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check
ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
.pytool/Plugin/EccCheck/EccCheck.py | 302 ++++++++++++++++++
.pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 +
.pytool/Plugin/EccCheck/Readme.md | 15 +
ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +
CryptoPkg/CryptoPkg.ci.yaml | 13 +
EmulatorPkg/EmulatorPkg.ci.yaml | 11 +
FatPkg/FatPkg.ci.yaml | 12 +
FmpDevicePkg/FmpDevicePkg.ci.yaml | 12 +
MdeModulePkg/MdeModulePkg.ci.yaml | 13 +
MdePkg/MdePkg.ci.yaml | 11 +
NetworkPkg/NetworkPkg.ci.yaml | 12 +
OvmfPkg/OvmfPkg.ci.yaml | 11 +
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 12 +
SecurityPkg/SecurityPkg.ci.yaml | 12 +
ShellPkg/ShellPkg.ci.yaml | 12 +
UefiCpuPkg/UefiCpuPkg.ci.yaml | 12 +
.../UnitTestFrameworkPkg.ci.yaml | 11 +
pip-requirements.txt | 1 +
18 files changed, 494 insertions(+)
create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py
create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/EccCheck/Readme.md
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 23+ messages in thread