Re: [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

[Jeff Brasen <jbrasen@nvidia.com>]

For defining it as a BASE type i changed that to that as there is a MemoryAllocationLib defined for the various phases. For example, SEC uses EmbeddedPkg/Library/PrePiMemoryAllocationLib (other patch in this series implements the AllocateZeroPool that is needed for this).


I am not opposed to an allocation-less SortLib but was trying to enable this capability without impact to other users of this library.


Thanks,

Jeff

________________________________
From: Ni, Ruiyu <ruiyu.ni@intel.com>
Sent: Wednesday, October 31, 2018 2:56:42 AM
To: Jeff Brasen; edk2-devel@lists.01.org
Cc: Gao, Liming; Kinney, Michael D
Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

SortLib depends on MemoryAllocationLib.
How can it be a BASE type library?

Can we do it in two options?
1. Change the SortLib API to accept a temporary buffer from caller. So the MemoryAllocationlIb dependency can be removed.
2. Do not change SortLibAPI but uses a fixed-size temporary buffer internally. E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE];


Thanks/Ray

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Jeff
> Brasen
> Sent: Wednesday, October 31, 2018 5:31 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen <jbrasen@nvidia.com>
> Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all
> module types
>
> Expose BaseSortLib for use in SEC and PEI phases.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> index f807cd7..5bd1aa1 100644
> --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> @@ -18,9 +18,9 @@
>    BASE_NAME                      = BaseSortLib
>    MODULE_UNI_FILE                = BaseSortLib.uni
>    FILE_GUID                      = 03F3331B-F12D-494f-BF37-E55A657F2497
> -  MODULE_TYPE                    = UEFI_DRIVER
> +  MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = SortLib|DXE_DRIVER DXE_RUNTIME_DRIVER
> UEFI_APPLICATION UEFI_DRIVER
> +  LIBRARY_CLASS                  = SortLib
>
>  #
>  #  VALID_ARCHITECTURES           = IA32 X64 EBC
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------