From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=203.18.50.4; helo=nat-hk.nvidia.com; envelope-from=jbrasen@nvidia.com; receiver=edk2-devel@lists.01.org Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F4D821188C4D for ; Wed, 31 Oct 2018 23:25:30 -0700 (PDT) Received: from hkpgpgate102.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 01 Nov 2018 14:25:28 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate102.nvidia.com (PGP Universal service); Wed, 31 Oct 2018 23:25:28 -0700 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Wed, 31 Oct 2018 23:25:28 -0700 Received: from DRBGMAIL104.nvidia.com (10.18.16.23) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 1 Nov 2018 06:25:27 +0000 Received: from HKMAIL102.nvidia.com (10.18.16.11) by DRBGMAIL104.nvidia.com (10.18.16.23) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 1 Nov 2018 06:25:26 +0000 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (216.32.180.181) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 1 Nov 2018 06:25:25 +0000 Received: from BL0PR12MB2435.namprd12.prod.outlook.com (52.132.11.29) by BL0PR12MB2419.namprd12.prod.outlook.com (52.132.11.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.25; Thu, 1 Nov 2018 06:25:23 +0000 Received: from BL0PR12MB2435.namprd12.prod.outlook.com ([fe80::d842:8832:3265:ceae]) by BL0PR12MB2435.namprd12.prod.outlook.com ([fe80::d842:8832:3265:ceae%3]) with mapi id 15.20.1294.021; Thu, 1 Nov 2018 06:25:23 +0000 From: Jeff Brasen To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Thread-Index: AQHUcJfr7Ou3fNpG1U2HbsI8IVcXD6U5DhkAgAFnG1M= Date: Thu, 1 Nov 2018 06:25:23 +0000 Message-ID: References: , <734D49CCEBEEF84792F5B80ED585239D5BEE8DCE@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BEE8DCE@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jbrasen@nvidia.com; x-originating-ip: [71.196.137.152] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BL0PR12MB2419; 6:lliMCmm60mazS44iDp2wkrAcFk7Mrc6a/a6XW/q4IG0bbz8fw/JQF7SM71/fL2pzeku+oat/sAuIZS9dFnYd8Jz9EzINY15g03EAGs+VRPa/u10RYduwmXY12e2plJHIPMar85SIBTcDvfxJdqRAUtXk7wIUchn6tA93UOg2voLCNRuAE3O1y79ujVPPXBQNBdSaUJuF4pvcJXLBjbqaUb9zyqB00XHjfuLF4ju/EizE6ShSM7GDLtMMRz/uXH3dQT2rQQlzrfbHA8MFiJ2UuFWQIXFCe1/uQvjXhldWdSnqty2A6AJlUQkmUW7fah1AnResFh/DqOkD5w/M5RoRfh3Pj+CBRbsXO11aJMe3qjTqISzRe4ORXNaaslNCG2fh0c1Kk7jwU05jlp6g/cvoUwvD9WQqVUl5yrgpU2iCDsUyzytMfMqa/gErHBLnLOU411E4W3epc0kyusCH2sYdPA==; 5:YsCskP61ljXxfp9yPnNBPh+I1r/Y2cJIGrbPLG7lkzskgPZpnIHrm6Utrcb1V1197bd4XOHUl/ZzQ3CLKDMFg1/Rn86gpiMJB0XXx9tx3xlEpJfAHtdoOwy+VqPk+5hShWuJ2DZPXt9BuuRvI5fJeCZrpgTge9mtS40WTo0d80I=; 7:URqEK1fXGeXehSjJQPmnZpM/3KaIPGyVQynGBVHK9UxbWZIH/kuqZPtMCPdFzDvJVBidGlSY8amj4sWwaeUvO9kzTZKvG/a03RhymkeEGsVZEEvNkY/1YOncPyUk9a8WiSsaaZh9emApChg6dckZHw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: c0d9a161-9025-4c91-43a8-08d63fc2ce23 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BL0PR12MB2419; x-ms-traffictypediagnostic: BL0PR12MB2419: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699)(162533806227266)(18589796830644); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231382)(944501410)(52105095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:BL0PR12MB2419; BCL:0; PCL:0; RULEID:; SRVR:BL0PR12MB2419; x-forefront-prvs: 0843C17679 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(136003)(39860400002)(396003)(13464003)(199004)(189003)(106356001)(186003)(105586002)(66066001)(6116002)(76176011)(966005)(316002)(446003)(7696005)(3846002)(476003)(81166006)(2906002)(54906003)(14454004)(6506007)(486006)(99286004)(11346002)(110136005)(74316002)(606006)(33656002)(19627405001)(81156014)(102836004)(71200400001)(2501003)(53546011)(26005)(256004)(55016002)(5250100002)(68736007)(53936002)(6246003)(6606003)(25786009)(7736002)(54896002)(97736004)(9686003)(8676002)(236005)(14444005)(86362001)(2900100001)(71190400001)(4326008)(6306002)(5660300001)(478600001)(8936002)(229853002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR12MB2419; H:BL0PR12MB2435.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Mvk0kn1GJ5WI+KiKiyhzITVLbNYvzViLz56ntav7E0OD+NTAvQQkbS2H9kIDsp0OfyHENl8IkZfIfBo+q1gaglFr57wgAEDjWDol4UmTHGVoADKqwKviLHPvTyH6Xb84Cq1z1IFpX+ph1Z/uvyCf2dQwF/SKfCcMtxKkoKRGtvuH5CAoZSHHDkVXMFggoi8XQ51MGJMocSEn0XL21m41jITb0s8R4u2Hquj6XYmrKyZ4qoywSkocyNE1R4ZhT48LoQeeSxQKZCQGDTTYzzNGxPgRGNUotIuK4Ib+d1Ls9nhHSflU2+DbUt+lg5olFynS0xQx/djESgysoZK4BMLazwE7gKeEk25DS587zJJJyko= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c0d9a161-9025-4c91-43a8-08d63fc2ce23 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2018 06:25:23.3176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2419 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1541053528; bh=6oLuDB7hdS1aM9C9KJ0kfu5R/UeKE4NTef6p9cnTZfM=; h=X-PGP-Universal:From:To:CC:Subject:Thread-Topic:Thread-Index:Date: Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-microsoft-exchange-diagnostics: x-ms-exchange-antispam-srfa-diagnostics: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-exchange-antispam-report-test:x-ms-exchange-senderadcheck: x-exchange-antispam-report-cfa-test:x-forefront-prvs: x-forefront-antispam-report:received-spf: x-microsoft-antispam-message-info:spamdiagnosticoutput: spamdiagnosticmetadata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type; b=rR6ARDeJyO3RQdWhV52Qx14VrvbcPYS4oipHTfxsTmFwCICdIYYdy4F7KM3TfGSe8 XhqqJhcoG10SqFaLmEtgqCGHr1NFAiD0XRHmusbq0R0g/TSxiPJv4N6H+46AnQBhy3 mWuljNAyVEcNPjRwuXN+V/5cYQD7zsAniZiSsm5puiaVPNRXx60Ki/O0vlBM5k5IpW MZsxy3i4jbbugINDuLb/a9TWbVFqqJxvkOW8rcYJ6BrZV5b82EkeuiIqMgCV1WC9MY cHcYMZU9GLw/vGP8z6pRddXHDymo1xh2rhwy6q2m4CMrui6xekzBaddmgUdUHZJ5Et RTyxtFmtV3QAA== X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 06:25:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For defining it as a BASE type i changed that to that as there is a Memor= yAllocationLib defined for the various phases. For example, SEC uses Embe= ddedPkg/Library/PrePiMemoryAllocationLib (other patch in this series impl= ements the AllocateZeroPool that is needed for this). I am not opposed to an allocation-less SortLib but was trying to enable t= his capability without impact to other users of this library. Thanks, Jeff ________________________________ From: Ni, Ruiyu Sent: Wednesday, October 31, 2018 2:56:42 AM To: Jeff Brasen; edk2-devel@lists.01.org Cc: Gao, Liming; Kinney, Michael D Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all = module types SortLib depends on MemoryAllocationLib. How can it be a BASE type library? Can we do it in two options? 1. Change the SortLib API to accept a temporary buffer from caller. So th= e MemoryAllocationlIb dependency can be removed. 2. Do not change SortLibAPI but uses a fixed-size temporary buffer intern= ally. E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE]; Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of Jeff > Brasen > Sent: Wednesday, October 31, 2018 5:31 AM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all > module types > > Expose BaseSortLib for use in SEC and PEI phases. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jeff Brasen > --- > MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > index f807cd7..5bd1aa1 100644 > --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > @@ -18,9 +18,9 @@ > BASE_NAME =3D BaseSortLib > MODULE_UNI_FILE =3D BaseSortLib.uni > FILE_GUID =3D 03F3331B-F12D-494f-BF37-E55A657F2= 497 > - MODULE_TYPE =3D UEFI_DRIVER > + MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D SortLib|DXE_DRIVER DXE_RUNTIME_DR= IVER > UEFI_APPLICATION UEFI_DRIVER > + LIBRARY_CLASS =3D SortLib > > # > # VALID_ARCHITECTURES =3D IA32 X64 EBC > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel -------------------------------------------------------------------------= ---------- This email message is for the sole use of the intended recipient(s) and m= ay contain confidential information. Any unauthorized review, use, disclosure or di= stribution is prohibited. If you are not the intended recipient, please contact the= =20sender by reply email and destroy all copies of the original message. -------------------------------------------------------------------------= ----------