* [PATCH] remove GCC build warning @ 2022-09-26 1:13 JessyX Wu 2022-10-02 15:15 ` Bob Feng 0 siblings, 1 reply; 3+ messages in thread From: JessyX Wu @ 2022-09-26 1:13 UTC (permalink / raw) To: devel; +Cc: JessyX Wu, Bob Feng, Liming Gao, Yuwei Chen Fix gcc: warning: -x c after last input file has no effect Change-Id: I743d47ed0cb9d2c0c099af461fa1d5e9024d9526 Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Signed-off-by: JessyX Wu <jessyx.wu@intel.com> --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template index 5895b48fd8..af4819de92 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -463,7 +463,7 @@ <Command.GCC> "$(ASLCC)" $(DEPS_FLAGS) -c -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src} - "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) + "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS) <Command.CLANGPDB> -- 2.37.3.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] remove GCC build warning 2022-09-26 1:13 [PATCH] remove GCC build warning JessyX Wu @ 2022-10-02 15:15 ` Bob Feng 2022-10-03 2:01 ` JessyX Wu 0 siblings, 1 reply; 3+ messages in thread From: Bob Feng @ 2022-10-02 15:15 UTC (permalink / raw) To: Wu, JessyX, devel@edk2.groups.io; +Cc: Gao, Liming, Chen, Christine Hi Jessy, Could you provide more details in the commit message? Also, please remove "Change-Id: I743d47ed0cb9d2c0c099af461fa1d5e9024d9526" from the commit message. Thanks, Bob -----Original Message----- From: Wu, JessyX <jessyx.wu@intel.com> Sent: Monday, September 26, 2022 9:15 AM To: devel@edk2.groups.io Cc: Wu, JessyX <jessyx.wu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: [PATCH] remove GCC build warning Fix gcc: warning: -x c after last input file has no effect Change-Id: I743d47ed0cb9d2c0c099af461fa1d5e9024d9526 Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Signed-off-by: JessyX Wu <jessyx.wu@intel.com> --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template index 5895b48fd8..af4819de92 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -463,7 +463,7 @@ <Command.GCC> "$(ASLCC)" $(DEPS_FLAGS) -c -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src} - "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) + "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS) <Command.CLANGPDB> -- 2.37.3.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] remove GCC build warning 2022-10-02 15:15 ` Bob Feng @ 2022-10-03 2:01 ` JessyX Wu 0 siblings, 0 replies; 3+ messages in thread From: JessyX Wu @ 2022-10-03 2:01 UTC (permalink / raw) To: Feng, Bob C, devel@edk2.groups.io; +Cc: Gao, Liming, Chen, Christine Hi Bob GCC_ASLCC_FLAGS be defined to "-x c" and CC_FLAGS be defined to "-g -Os -....." in BaseTools/Conf/tools_def.template. These kind of flag can only affect the source code after them. For the build command in build_rule.template, we have no other source code or object after these two flag. It would show the warning message "-x c after last input file has no effect." It seems we don't need them here. -----Original Message----- From: Feng, Bob C <bob.c.feng@intel.com> Sent: Sunday, October 2, 2022 11:16 PM To: Wu, JessyX <jessyx.wu@intel.com>; devel@edk2.groups.io Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: RE: [PATCH] remove GCC build warning Hi Jessy, Could you provide more details in the commit message? Also, please remove "Change-Id: I743d47ed0cb9d2c0c099af461fa1d5e9024d9526" from the commit message. Thanks, Bob -----Original Message----- From: Wu, JessyX <jessyx.wu@intel.com> Sent: Monday, September 26, 2022 9:15 AM To: devel@edk2.groups.io Cc: Wu, JessyX <jessyx.wu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com> Subject: [PATCH] remove GCC build warning Fix gcc: warning: -x c after last input file has no effect Change-Id: I743d47ed0cb9d2c0c099af461fa1d5e9024d9526 Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Signed-off-by: JessyX Wu <jessyx.wu@intel.com> --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template index 5895b48fd8..af4819de92 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -463,7 +463,7 @@ <Command.GCC> "$(ASLCC)" $(DEPS_FLAGS) -c -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src} - "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) + "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS) <Command.CLANGPDB> -- 2.37.3.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-03 2:01 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-26 1:13 [PATCH] remove GCC build warning JessyX Wu 2022-10-02 15:15 ` Bob Feng 2022-10-03 2:01 ` JessyX Wu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox