From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web08.42.1628217148772882493 for ; Thu, 05 Aug 2021 19:32:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vpTB3qBI; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: dandan.bi@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="201479868" X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="201479868" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 19:32:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="523238330" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 05 Aug 2021 19:32:27 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 19:32:27 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 19:32:26 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 19:32:26 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 19:32:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hk1Uh1ScFm1EOtbbkChsUdLYU9k/Q6nf3CMU8OK4drwgBnuvuJrN49VxUK+y+WskFTTkctMWQk6tNIK3lDGz+XYDWiRhQRhgageoH8j6N8oGyCqeWo0VzDwS6SnYsK74GApkew3gjWbJ1ZClrV5E43tzIjUdU3KrMJl7BZGK3Cs223IPKjfRN5gsmYOhBiQ69y7MdFBVi59L34NHw/7G0USpXl7fIUZu4cX7/u1nFTZJCnRFE5zs/B/hOnZfHWjwdBvCisU6Hh9eKj8hgtcTvy332kY4bXVW1b8EOn0Pd7XE7I6hdwDbuDrHgHXBKK5dEJYVtE6YKSAdiFbvj2NsxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzlqDSO/XkfuZgS5/2pPhy/NpboH7jqPw17doX2/+ng=; b=eKqsJ0qbr6wkby/qUXbByfFAIl75KQgPu5qx2/ZLbR0XUCYNBm/f90J0yQZjflY8/TgUXz/S8TuJm2939u2n2gp5HVJVWG4C6nqQUfSE52fCd+af+tN0dEBxI5dOkMSuUyQMYo1gIn+pfSzpTZrnxPVwWsgKga6MKCb4K4xnK7Vj2r1zeWNCl6SvZl2eVoYrlStavBH/f7q5c8FFcv60BaJnpaLjhseyv4US1XN5AFJXt35aS15abNaP480Fz+F8p3WEImSZucl4pSvi8PWB+YPlR2qy3+MnKincDE40DnespddCEvLSmgqVKtrSeFyKEoA6sb2ho+GZUjZgPU5nkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzlqDSO/XkfuZgS5/2pPhy/NpboH7jqPw17doX2/+ng=; b=vpTB3qBI+asaAD5rDIcUWAbsqqycxSQ1RNv4z5lgQe9ItXPjrGpUNwP66RZ/WWxkNrwNtw2daYxrQljwSHMENaV3YAR1yhWiJO2w4fpyVQjCG0uROj4HeXaXmiN+6REIGIDWtpnxHyiGqdSji6z8LffjuXRhTbIpvGX3nYSNibE= Received: from BL1PR11MB5446.namprd11.prod.outlook.com (2603:10b6:208:31e::23) by MN2PR11MB3791.namprd11.prod.outlook.com (2603:10b6:208:f9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Fri, 6 Aug 2021 02:32:24 +0000 Received: from BL1PR11MB5446.namprd11.prod.outlook.com ([fe80::888d:d35a:7aa3:88d5]) by BL1PR11MB5446.namprd11.prod.outlook.com ([fe80::888d:d35a:7aa3:88d5%7]) with mapi id 15.20.4394.018; Fri, 6 Aug 2021 02:32:24 +0000 From: "Dandan Bi" To: Kun Qin , "devel@edk2.groups.io" , "kun.q@outlook.com" CC: "Wu, Hao A" , "Wang, Jian J" , gaoliming , "Yao, Jiewen" , Bret Barkelew , 'Sean Brogan' Subject: Re: [edk2-devel] Is there any use case of FirmwarePerformanceStandaloneMm.inf now? Thread-Topic: [edk2-devel] Is there any use case of FirmwarePerformanceStandaloneMm.inf now? Thread-Index: AdeJ7OKxbanYfrbbRCmTrRGRw00jcwAXyYUAAAafc/A= Date: Fri, 6 Aug 2021 02:32:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15b86479-90d1-45be-2f46-08d958826d1e x-ms-traffictypediagnostic: MN2PR11MB3791: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SXx/ICQJmEdONf6JlZIrLVYrb9lU+i0yBWu3mPrgidY1UrG8VnSnwC4H9YbbRt9WXCgn9WTJvUYl3gMOhxE525cKMh44GFofvhYes9aKHIDHFOzuYKyxvBd+hi4968Ky2nFLc5mP49/HkTs9QZ/CiRrkCe4vBkJoxFYMPCcbpey2seflxcVv4mIHAYkDAa4uEtSBwY8mLwiYeioLAQMkmNkQ2mwjw94YN9EeuvGalIvLBiIT5/blJbpEu0bVVhyQCwlEREA+h7RlPufVA01GWPttCeX+phOIQ9KTK6jRzSGVR8VtvodHrNDY/OWMNZSAk3R1aLLIGK9t3NjTK9f/cWXPCKCCpya0bYGzUR9V+9ZMACg90KUdiYpy1gAjMwDl9kzqo7pl6sL50IQcs9eDF912Sg326u82EiLWIPaPXJwgQxJr0t5NqB+LUl4fV/bDuCldwh0tly3jQQBVyQ5Wig0f0ZFz3ffOYrJ6612tfm48muBGUxhWopjdm6LdZgfNDrUAAcnhPxhfKYBXeqVy1lsxMvznaL23Z2yzJbbxfhb2A5TJwWsB4Steat9RekaUNZqxX+zngJ7wSE0hWVnVx/eY+m25YJwd0jnN8i+BAcaiThtqVzsR3rgIEeZQLBFZMsvym95BQfqhC5Ro+dnnNyINnOMYfr/eV7tX8lXiOnOS7SOIgoaJo1hBtJIco9lwHMntwzYpRC+DJPL9gUIBhFp1TmB2l1YmOPJXD13TSKp94Lg1QEBryJmlSuETK1d1u1IPZcfetyW8GcKJHMQE5K1+9LtOiHOSI7QZjzXORVCEGqUK5bOm1ie17mSwvkI6JYIFVTNJQLDU4ZV455oDlw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5446.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(71200400001)(2906002)(186003)(83380400001)(7696005)(66476007)(66556008)(64756008)(66446008)(53546011)(66946007)(86362001)(52536014)(26005)(76116006)(54906003)(33656002)(6506007)(55016002)(5660300002)(110136005)(316002)(45080400002)(9686003)(478600001)(4326008)(8676002)(122000001)(38100700002)(8936002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lvb5oSY2uUAkuOoz63T+6uaqZnP7puMiQ6p3+9RENw7MCiCoLPSLbHejc61Z?= =?us-ascii?Q?lnUmzS8RSwK45Aek5SN+yp8IW6OsD/nYWwEPpSdH7T++PMehKCP15WCVbpgt?= =?us-ascii?Q?rXOydjnAnOlBGAb6l/W+KOVfXT9S4V4y+C17N/4UNtIzDzCt1Gl0mHCf27tb?= =?us-ascii?Q?KaylXJjHs4gDMR+cTOHepwDF8AwwfEpAH/lT1Y9WuVgFf7Jem/pZe5scSs8Y?= =?us-ascii?Q?HBWccMe2+IlvBP8bkkvV3idSZ1r+wmQSYTu/fRYPPOSNf+7YjMvgnWzar5jp?= =?us-ascii?Q?/HYnJuJyYXx4xT+Rcw7jZ+6vtOFe54zg8//9QBgN6S3gXXCL2Xbm2tp/Gsbp?= =?us-ascii?Q?8Qgv1GiAzz8pZ05OzZwXW2GZ4OJzJ7xalNChrSjh8OUDFD+XmOJsMgifHnZw?= =?us-ascii?Q?DItjuZYN2byec8f4YSPbG1BOOtOnvfAPa1U1Zw2uASqlkZreEj3RU24OwbJ9?= =?us-ascii?Q?rsk00hJo3ERqIe86AaJvqBi844j/QZB1APuuPTimNhpf5g5XRcxjvLKsq/JQ?= =?us-ascii?Q?kZsVjHwQcTD1zLNYKj5u7UoXRX1k981858vHHnO7Prr07ayqxZsyNP8PvBFR?= =?us-ascii?Q?nd+mfawN0TA0f80lJUCV/lI3hDbUatx5Y0cvwN+hTxeMHhm03UIBp4BZARbo?= =?us-ascii?Q?GavtP95ar9hGjuHoaDHIRRLd3VW2cHangOsHWmigQOBmV9KTcaDbZMjnTQu+?= =?us-ascii?Q?Rj8dmwq06e/juaTfW25pTI/czxIpnplLi5ygVnr9iwSfFJk2LhBmoIOPFLwo?= =?us-ascii?Q?8JyTR2lWHXWKAgDIbhK47oPY6nSwlaFgUF8gb2WZVh/vIXhyCs0u+T3hLMrH?= =?us-ascii?Q?W0Yx+huP/jSzK+SZ56PA1oyl7949ZcMaJtKks+qijcnAqZgMl/qXfnRGsS8U?= =?us-ascii?Q?mz+xkBBMiyYzDsVNhWUbUK3xYJWpxzBBk0mE2IsQOLE92fArCmMOYnDQ8bmI?= =?us-ascii?Q?DlDiA6Dvccv93AARzzIAN8C34uHvtrI7d11LVgniHio9hzis9rcGkEBKJFZx?= =?us-ascii?Q?JGcNprqUWrm4unHsk/5w1EqVVUQU60tSyuHdY7Eqf12283nbmUQMT1DW8p5T?= =?us-ascii?Q?BcUWjpiqVVQIM4GMpIG6gf5z8w8YF4lCoUYHDhXkMh6OfQfIiMM8n+Pe7o2H?= =?us-ascii?Q?js8j2QxXq4ae+vgKKhtreQTRzl4nGD1RuUoOhKSPJXDENfUkhbV9KYPOzJr7?= =?us-ascii?Q?Q/nqOJjstvs8hVqp0/k476V2qd6FcuENZgf9PhmQ5ebyeF/2xjL+pJcovOu9?= =?us-ascii?Q?a3VkZ1CHGu27VD0QjN/d9GddrQLVK0zCxvMiwkf5TMEKcAE0SO+tkv7qOPs/?= =?us-ascii?Q?dIc/ojCm2/bNLpBKiMQVKDXk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5446.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15b86479-90d1-45be-2f46-08d958826d1e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2021 02:32:24.5699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xOGh1LP5msZpLJHULA5E2SJZmQXpYSTtUfJTYq9T35QaizW+p2jQ5LtIm23sPl/DJeCPNxfSIUVgIXzhgbDDbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3791 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Kun, Thank you for the information. Yes, the idea is to centralize the SMM performance report collection job to= SmmCorePerformanceLib, and DxeCorePerformanceLib could communicate with Sm= mCorePerformanceLib for all SMM performance data rather than through Firmwa= rePerformance**Mm driver. But we will not remove FirmwarePerformance**Mm driver, just remove the cod= e logic related to **MM performance data which will be covered by **mmCoreP= erformanceLib. FirmwarePerformance**Mm driver will still collect some performance data in = S3 like the S3SuspendStart, S3SuspendEnd. We don't introduce any incompati= ble change. If now StandaloneMm Core does not report performance data to FirmwarePerfor= manceStandaloneMm module, I think it should be ok to remove the handling of= **MM performance data both in FirmwarePerformanceSmm and FirmwarePerforman= ceStandaloneMm now. For SMM, the removed logic will be handled by SmmCorePerformanceLib For StandaloneMm, I think we can submit an Edk2 feature to add a Standalone= MmCore instance with the same functionality of SmmCorePerformanceLib. As no= w the functionality of collecting StandaloneMm performance data is missing = in Edk2. =20 Thanks,=09 Dandan > -----Original Message----- > From: Kun Qin > Sent: Friday, August 6, 2021 6:49 AM > To: devel@edk2.groups.io; Bi, Dandan ; > kun.q@outlook.com > Cc: Wu, Hao A ; Wang, Jian J ; > gaoliming ; Yao, Jiewen > ; Bret Barkelew ; > 'Sean Brogan' > Subject: Re: [edk2-devel] Is there any use case of > FirmwarePerformanceStandaloneMm.inf now? >=20 > Hi Dandan, >=20 > Thanks for letting me know. I added Bret and Sean to the thread for broad= er > view in our scope. >=20 > But currently our StandaloneMm Core does not report performance data to > FirmwarePerformanceStandaloneMm module. >=20 > Is the idea to centralize the performance report collection job to > SmmCorePerformanceLib and remove the FirmwarePerformance**Mm > driver? Is there any plan to support a Standalone instance once the > traditional MM version is functional? >=20 > Thanks, > Kun >=20 >=20 > On 08/05/2021 04:44, Dandan Bi wrote: > > Hi Kun, > > > > I plan to make some change for FirmwarePerformanceSmm.inf, may also > > update the behavior of FirmwarePerformanceStandaloneMm.inf as they > are > > sharing codes now. > > > > And I saw you are the submitter of this driver. Could you help clarify > > following questions ? Thanks in advance. > > > > 1. Do you have the use case to leverage > > FirmwarePerformanceStandaloneMm.inf to collect Standalone MM > > performance data now? > > 2. Do you have any Library/module used by StandaloneMmCore to collect > > Standalone MM performance data and report the data to > > FirmwarePerformanceStandaloneMm like the SmmCorePerformanceLib > used > > for SMM core? > > 3. I plan to move some logic from FirmwarePerformanceDataTableSmm to > > SmmCorePerformanceLib as below. Do you think is it ok just to remov= e > > them from FirmwarePerformanceStandaloneMm.inf now? > > > > If there is not any module to report Standalone MM performance data to > > FirmwarePerformanceStandaloneMm.inf, I think it should be OK to remove > > them from FirmwarePerformanceStandaloneMm now. > > > > Change: > > > > SMM performance data collection now: > > > > 1. SmmCorePerformanceLib collect all the performance data in SMM and > > report the data to FirmwarePerformanceDataTableSmm through status > > code. ** > > 2. DxeCorePerformanceLib will communicate with > > FirmwarePerformanceDataTableSmm to get the SMM performance data > and > > allocate performance table to store all the performance data. > > > > Now I want to simplify the process to make DxeCorePerformanceLib > > communicate with SmmCorePerformanceLib directly to collect SMM > > performance data, so FirmwarePerformanceDataTableSmm don't need to > get > > the SMM performance data from SmmCorePerformanceLib and register > SMI > > handler for the communication with DxeCorePerformanceLib. > > > > For FirmwarePerformanceStandaloneMm.inf, just remove this logic if > > there is no module to prepare MM performance data to it now. > > > > Thanks, > > > > Dandan > > > >=20