From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 85DAA940F3F for ; Wed, 22 May 2024 03:41:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ha5QCBPrDIjuUX5JctY/rE/YzqDb912wVIfihKe2KxE=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716349291; v=1; b=eCflIkgpYa5CvyU/O0DVHSlsX69U3L1pXrzu9D7j3PeqeHIepNEqLNeJd3Obn9DBOTHRpROx XQfTvXYX9QugPJCJVi0OjckcXOh6c1/6N2GLrjj2b7ETNSaakAsftNV/yXFVZrHaZhHslaFDw+V 4Ol3amHpaQbSlwhkMPJoVdwOnf8zUXIaFV28lwi3UqeSD91svAEy1JMAgq8eeqDJhPmUusi+RWO uyvrlra/J4kGRZUkGMQKdDmDw9lqfOSbaVNKOpCR4YzUwIs8ICihtc/YU04LdioasOIdGN7Dmnn ffGN/GoJP+xM60vPbVmFPQt/UyZ0bh0pnih5Z5p6pGqLg== X-Received: by 127.0.0.2 with SMTP id e4OZYY7687511xIuF6DqD5Nz; Tue, 21 May 2024 20:41:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mx.groups.io with SMTP id smtpd.web11.1756.1716349290953522426 for ; Tue, 21 May 2024 20:41:31 -0700 X-CSE-ConnectionGUID: x2yGFsT7SvaqQloYhTG3AA== X-CSE-MsgGUID: stE0kVQASrWFveu8Pty4pw== X-IronPort-AV: E=McAfee;i="6600,9927,11079"; a="16365982" X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="16365982" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2024 20:40:58 -0700 X-CSE-ConnectionGUID: Gbo8YlQTTgezObbZCh4yIg== X-CSE-MsgGUID: UGKyEUKmSN2j7ARFJi/eiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="64386216" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 May 2024 20:40:57 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 May 2024 20:40:57 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 21 May 2024 20:40:57 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 21 May 2024 20:40:57 -0700 X-Received: from BL1PR11MB5463.namprd11.prod.outlook.com (2603:10b6:208:315::23) by IA0PR11MB8336.namprd11.prod.outlook.com (2603:10b6:208:490::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Wed, 22 May 2024 03:40:55 +0000 X-Received: from BL1PR11MB5463.namprd11.prod.outlook.com ([fe80::fc3c:306c:1d14:5d48]) by BL1PR11MB5463.namprd11.prod.outlook.com ([fe80::fc3c:306c:1d14:5d48%4]) with mapi id 15.20.7611.016; Wed, 22 May 2024 03:40:55 +0000 From: "Du Lin" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: Liming Gao , "Kinney, Michael D" , "Ni, Ray" , "Lin, Du" Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute Thread-Topic: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute Thread-Index: AQHaqL7tBg/HvYYWyEKrCOgykK65XbGinQBA Date: Wed, 22 May 2024 03:40:55 +0000 Message-ID: References: <20240518005757.1639-1-mikuback@linux.microsoft.com> In-Reply-To: <20240518005757.1639-1-mikuback@linux.microsoft.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5463:EE_|IA0PR11MB8336:EE_ x-ms-office365-filtering-correlation-id: 9364a449-b35a-4fb0-cd19-08dc7a10fc5d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?EmDzXFaGaHmeuAG5a06JgDowtMX7VOm9ZtiIGYPll3twGHmmeFYPf0bG5JDr?= =?us-ascii?Q?xYL1E7vzbvKonSI07wRTFEs2X3Q4dvsI51xxGLIx2dRiYSh9+jf958YQ6Hke?= =?us-ascii?Q?1odB2wlSN/wB8XgHPfGtSCuYqIgSeiQitJUYBUkIz+9RF7NDO9IL5twY8e5T?= =?us-ascii?Q?105t1K9rodh5u4uep+MLptuIVrHOQSUnHxOCGhNTCo7rfXecsa/JHp3GkzmN?= =?us-ascii?Q?kJqRanm4r1qwTdqr+OzTkNxWOV40/D7CNtCyAV9dK3OYA6CoZfiGb3ylLcf7?= =?us-ascii?Q?wQG/H6wY52jG7jydHeycToI2UPW3tTevdL//wJOiSkbYx4mTQvbMhWi3ibO7?= =?us-ascii?Q?OIu/bh1b9I1Cb01z0mXLN2ObtiUeYlNKlwO/nCyp9wQbYFK/+M2qxhMIsWl6?= =?us-ascii?Q?PTsP27Slo+QpvuGOUQt2N3swdXhxV3Ss7ibxKp9uoss4fthn2dPOs8dYjdU+?= =?us-ascii?Q?xNX9B1jmXXD7rWSueTtXyLUBiWjU5Gy1Q2yt/HkStDy3xHRlh/SjqDVjuROY?= =?us-ascii?Q?jwrqrLtYazBnJSvJxaQbTmODe/S/KaZHeZbM3ZHLhHCbiuMYgbnrLWjpvl3q?= =?us-ascii?Q?3PD++gI4lpWqMU+jHTa05J602YhISMsBivSL42xkspTT+yl0tRJzPtuehad5?= =?us-ascii?Q?VklrTKbRIXo5Vy/YQtNa1nD8Zhw54hWzpVQZoIPq1q1B2FNlaxA8J/bSO2KX?= =?us-ascii?Q?/8vysFV9dfa+ET7TNiDHpaNsNowOti/YxNvargLP0ObbV+IHOLkeE88LpRGS?= =?us-ascii?Q?N1Wdg1OVoQv1ISFIPnuc4e+OsxSwWTwuN75wfHqFxNUnKoNcxo8ol0N4rFbA?= =?us-ascii?Q?4ZxIyrXErzJR42H6Lr7dq714OE22mqq1MEw5jsU2AIUCv18beEKtnX8+Ro2w?= =?us-ascii?Q?E5E3bH/hwyKVIil4zaYUW8fXX30sxvgJHDWbn9KrUrXN1iumM4SxBETRtNQY?= =?us-ascii?Q?QTNjHj5d65ug0tjY5aeOJZAl4LWeOzgw6ubuYz71Sls97ZKg9CxRQRgQRSXD?= =?us-ascii?Q?QRTw2otwYTb4aqaoJPNHUc1V1OGKNF2rvwIMDinYeHwbtYluZlnEUITpFoSm?= =?us-ascii?Q?zQEZdmbRYu5y4nmINB7vkZQbdx/dFSE+s4+tJLs9YCxkQwsu9BbIgubOw3rn?= =?us-ascii?Q?w3JgjZ8IwWJSySg7dManKXX4tUb8+ImTEFs0WZRdNxh16PRED9yS+wBH5wPS?= =?us-ascii?Q?SONq+tc46nSe3LjDE87MlSkFbg1lOPwy6UFRkNbUf/tJb6VRgzctjArdPYeu?= =?us-ascii?Q?Q9MWcCBDNGyz4Utegy5aGjmO8TwwnH84KCPoBn8RIkCMz8FXMIEeGHYIyAdF?= =?us-ascii?Q?eeM=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+nLp0mBGKjVT71D/aeS7ublYq8v3Cv8s1eNz7q5eiIc+bCxQkmqsq4iafV6F?= =?us-ascii?Q?qyf6bSddxgggsII3frFe360dhM0m9XaIT9PMUdMXdO7t8tIWcHNLmUy4MlJQ?= =?us-ascii?Q?9M+iF3u3fbApWyYTta8Um8QxBvzJxaTw5LSmEQ2L+zHPNMVi+jFHK3IXjzyn?= =?us-ascii?Q?eboQoCXVMbIe6SqUQLt5LNmMFR004yaO++o9RWhZfmc9XPazZhaWDo5QnFb0?= =?us-ascii?Q?qFbrUYDrBoyLx9fTchwsxM+8Sx+RuGXqP5l6EdSnmCpe6xWTGtxdKzI6bQ+O?= =?us-ascii?Q?kSomyAPkbLp6Mg6uuTuMispvaGI9X7lQGU+S8ufVF6t6SXJVFv2CK0p3Dthf?= =?us-ascii?Q?OWwDxkQVaDJNo8gvSXsQu+/ZnLC3AQ63OzHKOx8/ouHUSoNGoT4SXlMuzY0t?= =?us-ascii?Q?qVw3914alLWAkKZFbhelm/ZRKPd76Arfd30AtqeH7qCB60NVXbrbLjLJi9DV?= =?us-ascii?Q?U7C8I2Z4+kI5ubDXaqVKYoIo25qU/cUZ7TyMDMW2HM9e8C5pw0OCq0vMfqn6?= =?us-ascii?Q?1jfEBW1dQyhRe0sGknHr6xx930ihh0SnZilucfhN2eR4waldINutRAGtl/QO?= =?us-ascii?Q?dXbdxRhbrdkCJj2naupNsiBHR9HuoBXIQ19YFJ8ey+1v+hsJujkIxvYFuDg2?= =?us-ascii?Q?iJaCFTOOG7LgQUXrZVpoLcsB+dycUdnU6vBK7UvTf3uMWF8hoOaTfi7PgIiJ?= =?us-ascii?Q?pRsrK73e/Vi62xHnLtfVkAG7VnxTJwxxl2BFsYcXJFq4quV7i0vB9ACE+eVQ?= =?us-ascii?Q?eFJJycV+CaS4Zv9lcbaGI2Lk+TEGremM6UPmQ+htuLiiV9SnpwMiWIOqq7qQ?= =?us-ascii?Q?Wa5KyaJ+RKgi5oooi9s2NuqO5lg5ElEweSAwsi02s/4U64MpR19k3/HoQ2Yn?= =?us-ascii?Q?JMTY61ZL09/NYBgYKRagZkI6W/wYYIBFNovgO/ZsKffi+6pRyXS76WZoJfti?= =?us-ascii?Q?s6YOaczJCpqfg9zc9C7XxJ5X1aR4hV/KqrYg8qSweT9VjrRUexOXaxFSkC65?= =?us-ascii?Q?C4Os2hvazJ/0u7Q/o+OvbLRX2ippwW9RsKovSUvCZ341QPZ/dsxRV5qWoJey?= =?us-ascii?Q?0RLfm33/FIbe/6PaOBgijUl+bc6TfqD1e2ifGYAl4KnQvdaiQtMx1iET/6Aa?= =?us-ascii?Q?f5DIdCFn/LJ8REqL9G/f4dFKZwmVIdioS3LyzDwQ8OBVcoRRjae6z0z/lvUi?= =?us-ascii?Q?/PKV6Rs8r1ktWj1WNJamXpWmW17HCU36K7IHLRXFH8L0EEG1D72prZRPt1L+?= =?us-ascii?Q?NxAXYZ6DvaeC13enISmaqhIUGjM1sYdYWgmo+fFyegSZ6ftDg3rY3uT2iS8q?= =?us-ascii?Q?ZsBLYFUAGKU8IiDbo3APKN4QfeMfb1PheA6LSVm2LpfDfoUl9CUWCI/r6SX7?= =?us-ascii?Q?K/yh/4PrXDpKZPASrw+8Ql8fnXEqv+oDUx5D1K0MutnM66/NHNt4MbIFe32a?= =?us-ascii?Q?77tXNJ1B4cfDiuBJF5wCEMA1a05rIi6O74bWDwr5bwsJvQOA8fnL5/n8MTJv?= =?us-ascii?Q?ajFJaAbDL3/cCCD9IPNJK8UhPeKbTf+aNoXgyFrFhWgceCPJkf9WyclxlT8e?= =?us-ascii?Q?92eEfjZPSttf0NFRceg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5463.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9364a449-b35a-4fb0-cd19-08dc7a10fc5d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2024 03:40:55.1383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xaFlRs1Lzk4w89HIS0PKfkZQf9+RiydyU5nSG31bSafd1tdVvH7cBUs/UcaMCTd55hjaRTtZMZWrvZy0JuYyLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8336 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 21 May 2024 20:41:31 -0700 Resent-From: du.lin@intel.com Reply-To: devel@edk2.groups.io,du.lin@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JpZLEEa1fqh6MD1D44hyt8zfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=eCflIkgp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Coherent Device Attribute Table (CDAT) specification defines a EFI memory t= ype and attribute "EfiConventionalMemory Type with EFI_MEMORY_SP Attribute"= . Can we still support this type if assigning the GCD memory type "EfiGcdMemo= ryTypeReserved" for resource HOBs with the SPECIAL_PURPOSE attribute set? CDAT 1.04 specification: https://uefi.org/sites/default/files/resources/Coh= erent%20Device%20Attribute%20Table_1.04%20published_0.pdf BRs, Lin, Du -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Saturday, May 18, 2024 8:58 AM To: devel@edk2.groups.io Cc: Liming Gao ; Kinney, Michael D Subject: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATT= RIBUTE_SPECIAL_PURPOSE attribute From: Patrick Payne Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as per th= e PI 1.8 spec. This flag is used to indicate that the memory should be trea= ted as special purpose memory (SPM). Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- Notes: V3: Assign the GCD memory type for resource HOBs with the SPECIAL_PURPOSE attribute set prior to assigning the GCD memory type for the PERSISTENT attribute. =20 Assign the GCD memory type EfiGcdMemoryTypeReserved instead of EfiGcdMemoryTypeSystemMemory for resource HOBs with the SPECIAL_PURPOSE attribute set. =20 V2: Adds package name to commit subject and updates Signed-off-by. MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gc= d.c index fe1bbd6974b7..4cc0940c0a7d 100644 --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c @@ -26,7 +26,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent EFI_RESOURCE_ATTRIBUTE_16_BIT_IO = | \ EFI_RESOURCE_ATTRIBUTE_32_BIT_IO = | \ EFI_RESOURCE_ATTRIBUTE_64_BIT_IO = | \ - EFI_RESOURCE_ATTRIBUTE_PERSISTENT = ) + EFI_RESOURCE_ATTRIBUTE_PERSISTENT = | \ + EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURP= OSE ) =20 #define TESTED_MEMORY_ATTRIBUTES (EFI_RESOURCE_ATTRIBUTE_PRESENT | = \ EFI_RESOURCE_ATTRIBUTE_INITIALIZED = | \ @@ -92,6 +93,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY mAttributeConversionT= able[] =3D { { EFI_RESOURCE_ATTRIBUTE_TESTED, EFI_MEMORY_TESTED, = FALSE }, { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV, = TRUE }, { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE, EFI_MEMORY_MORE_RELIAB= LE, TRUE }, + { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP, = TRUE }, { 0, 0, = FALSE } }; =20 @@ -691,6 +693,10 @@ ConverToCpuArchAttributes ( CpuArchAttributes |=3D EFI_MEMORY_WP; } =20 + if ((Attributes & EFI_MEMORY_SP) =3D=3D EFI_MEMORY_SP) { + CpuArchAttributes |=3D EFI_MEMORY_SP; } + return CpuArchAttributes; } =20 @@ -2656,6 +2662,10 @@ CoreInitializeGcdServices ( GcdMemoryType =3D EfiGcdMemoryTypeReserved; } =20 + if ((ResourceHob->ResourceAttribute & EFI_RESOURCE_ATTRIBUTE_SPE= CIAL_PURPOSE) =3D=3D EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE) { + GcdMemoryType =3D EfiGcdMemoryTypeReserved; + } + if ((ResourceHob->ResourceAttribute & EFI_RESOURCE_ATTRIBUTE_PER= SISTENT) =3D=3D EFI_RESOURCE_ATTRIBUTE_PERSISTENT) { GcdMemoryType =3D EfiGcdMemoryTypePersistent; } -- 2.45.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119065): https://edk2.groups.io/g/devel/message/119065 Mute This Topic: https://groups.io/mt/106165072/8327890 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [du.lin@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119111): https://edk2.groups.io/g/devel/message/119111 Mute This Topic: https://groups.io/mt/106165072/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-