From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AEFCB74005A for ; Fri, 12 Jan 2024 08:50:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=442yu4352ANHjXmHn9smIoM/1dKepmucFqFKh0VlL3g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705049414; v=1; b=WxuNx/ynASQu6hl1PEjOZTCfdt3SQy3VeyTMrt8sQF5JRWvTNAbVCjyVLvQ5zZ3g8ynno1v/ x8jt7UXMX3yCtuP6yBo5c46hHhFWA/e00RVs3K8hKRF4Jv3nhWryla6Tj6a4ym5ySHzso37AVn6 nznxgWD9qrrnmkkYCwpDclmA= X-Received: by 127.0.0.2 with SMTP id gLVWYY7687511xGc0i6ZEjUt; Fri, 12 Jan 2024 00:50:14 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.3273.1705049413936055752 for ; Fri, 12 Jan 2024 00:50:13 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="430295293" X-IronPort-AV: E=Sophos;i="6.04,189,1695711600"; d="scan'208";a="430295293" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 00:49:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="782964435" X-IronPort-AV: E=Sophos;i="6.04,189,1695711600"; d="scan'208";a="782964435" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Jan 2024 00:49:58 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Jan 2024 00:49:57 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Jan 2024 00:49:57 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 12 Jan 2024 00:49:57 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 12 Jan 2024 00:49:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BCNR2y+CzF/N8T6xKj5dB8Z0Kq0qoIChrdnmaSes1WLc8Dxtu5Fm6qrRDSWG5RrF38X5xaDzwYqdRH4TrZtJoUMdmkM0mYVcKeJrau6hObHLHg3UuBpdyjSo4zKYZCfHneXL8Axva5/+KMkIEYgigDBncbGodMw7ne3hsEbZAoUjBx7xw4PiQ6GvCdHEX+8vbKITjwOutE9cNQwefG9NT4bgfxOtx87KJbV1piX8poauvoJHeqrd55YDsn/ugpubNuCLZDhOXg274oIubVc16GGm6JOylBGvqXdeAZjmlVr4DL7i9oBTVBbatiY5ZH4aw99xyvlppDuOvQuBUGYsag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8G2rgz+2rmI2cwf31S8GwrwCl7/4dib/BfVS3V4JJg4=; b=VVJDiLF8cmvCReLJFxx+N5wEUWJ9I7mrz52X4yoe76RWc27txs2szkF1QAlyXdmr6SG/ookqI7r65kynj/7uBLbEnSllbSaLMHKGCMMy3fsZx1wdUCoYVgXBN0H9qP8qDycHHpXwl/NAU5jYF23E2RmbeBHRBimfv9u9gxpKptBh6cbapHmTDgWSKdumGVBP7MkPvnrieuPgaNPV5cWkOOZryIt3cACUCVWPvjpmtX56//3LSqmQ7kfW2EmixjHcWduo7CiRVjUFZxkC4pEsM3VaatIO/9Ey/jOyN9oOCF+rfUiur15uzKzNXX+9Y+Pmg8NTOQGvFC91+2yWSUJZLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BL1PR11MB5477.namprd11.prod.outlook.com (2603:10b6:208:31f::19) by SJ0PR11MB5198.namprd11.prod.outlook.com (2603:10b6:a03:2ad::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.19; Fri, 12 Jan 2024 08:49:54 +0000 X-Received: from BL1PR11MB5477.namprd11.prod.outlook.com ([fe80::d06a:e525:cbb6:9712]) by BL1PR11MB5477.namprd11.prod.outlook.com ([fe80::d06a:e525:cbb6:9712%7]) with mapi id 15.20.7181.020; Fri, 12 Jan 2024 08:49:53 +0000 From: "duntan" To: "devel@edk2.groups.io" , "Tan, Dun" CC: "Ni, Ray" , Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V4] UefiCpuPkg:Limit PhysicalAddressBits in special case Thread-Topic: [edk2-devel] [Patch V4] UefiCpuPkg:Limit PhysicalAddressBits in special case Thread-Index: AQHaRTHSr/1En2uTUkiJVx/qdRqeKrDV29wg Date: Fri, 12 Jan 2024 08:49:53 +0000 Message-ID: References: <17A98C68C98872BA.16441@groups.io> In-Reply-To: <17A98C68C98872BA.16441@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5477:EE_|SJ0PR11MB5198:EE_ x-ms-office365-filtering-correlation-id: fac18a44-5044-42f2-d840-08dc134b71f2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: U8EmKOyMek1dUh5W0ek0znioOX6Vy9r7jrCcQorliYnATX/f0YcOvt+0YJdkyJZDYnBPkNu1eJbgkbZcOD68xv8HI8Jus05OdAYopa47xmNKk4M7bUcYQ5nnNvIff7PyecnHCsXDVEWCLjrW/mn1tPxL00mp8IGmWIe43CG5XZSIgh29Vb90rA1FsjgBNLfAhMVK9BnMGXFYXAs2OtaQWgLzMCoGVG4PPkrV2EicnaqbM//g3durlJBGQGiPcCgP3qKG7sdgmyWAAPXh01zzFDgZWC7IqIbp5JIRG8sBNqaBVG19C7Mi1nv0bf7nK2mo/nUU8rm0G00Eb5pFWKvQqSiVMgf9MB1dRxZ/7j2zql1jSEfPbQgx+h2SFVi5TGJ03GbyQUrT5KN2IT/oRC22s8wi0hhmRNiVYpHVh4kQkVWJdlXilT2rd8rPFwe5r/yum5JVSm4l+3gy340zUBAjwQkOUmwxLwHFSL+BJcTI7pc9jgzF8oX5++ndDsrWAS/c24VBVVd10ci6HmFX7bMgipB+h4LIJ9hdoY4Ls9ftZRUEo7p3/2DmHSSHhpbcj0KbupFh3ExJQNsqQ17BKOSY81NcmpMeLd0eL/ciO3/Viz3tgBgDwkJ5suuO3tthyeFh+x91m2pljRd5MSZz7eikHA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8dpDLTaAeAmgSng8sLBmcsyc1t1jYWjIfJ6ZII0q4ooy7cEirSNDHPXOZVDp?= =?us-ascii?Q?YqA5s7FB+f+9gtG957D0o9dpFnsT6pVoLo9GTSSbQ4OYgPyscB/YQMFACIsm?= =?us-ascii?Q?/avsv1btQUJYh1/ENeABPtfTTN/ceF571/GKdKgx/83Xv2P4LZbxZC1Db7Zt?= =?us-ascii?Q?0zDvIUq9DG3siH8E+72Glkl0Po0uyPLZAUQQq9JUUyernf3hKb4FfimYGyMg?= =?us-ascii?Q?MOT9pnqUS4/N4x+bUD9+kbZl8jWcuTxXp011KvC/u5bLF8L3tm6x8efosq0n?= =?us-ascii?Q?zxG522aiAqlwBzH9c6jBbL5RKWMitekNwYRbL54Bt7s9z/edB6u52Qgl0Hev?= =?us-ascii?Q?5vBaX3gR12WY1DR3sFiL8fzoFV6uzbS4FsjnQtT9ynRQhOgaVOlaQDH8nL45?= =?us-ascii?Q?DbpGu/IrP7jXASHh9xg4sQ9rsCjmuRaQRgE3VcY6WX2uCx3hl2aMSFz4SM8s?= =?us-ascii?Q?vJjFIDEH5y0NR6mpXn1YD1VvUC7W74XucWYmuG9KX4yDCF81jxSNokhy1+MM?= =?us-ascii?Q?Z5NOQFbnGkR6CU+cYLTyQg63hC0c74wSkmNkCJPhg/Cju7eQKzGo70Gg8szm?= =?us-ascii?Q?j5ooLeDHdnct+7xyygswA7L+12v+bsVeeSFFObeyip4HFNYdHJ8pbp11kvYo?= =?us-ascii?Q?mX/qRfh257wvx2dXx9gnPDrDQ8VuzO+yhjYx/2rmNLTYSyumM1u1U2L83wX+?= =?us-ascii?Q?ebRAIygtgwiRG9aae3sGLVyPI9GiGsGerne7Um2qxr4ocVAB/Wp1c0qlSUYL?= =?us-ascii?Q?Y/Jh6NwUpwICc8gy2O67YLUo3U2fTd5G6eDlyXeaveaqrcc7BAOaBxpRDBEX?= =?us-ascii?Q?7L/Q7DbcaxDqQIkojgXNnYXkr6fivb6bKEH9L3CDRgWuyQMiYEwjRcOt2o7A?= =?us-ascii?Q?oimx2X02ya04mMftfSUyO35xfRrRYfUkcK5+nusWQqMXudi+5Cy2ayybEX4X?= =?us-ascii?Q?+gIaiRqFkV6R5QUngxq19MnlypMo3XrFFo3SBkV6lGPX0HeW0PIfkPI/sTXd?= =?us-ascii?Q?qmVRNT+AQUNadQI/y08utgk00E2IHa52xjgcPUiAqtQnYOPaufFpS9klXHm8?= =?us-ascii?Q?U1reLt2ikV+tqTWsQX2UvLBPtUOe22SFjrtFIeEdZjA2KYqqA68eGj4EcUjL?= =?us-ascii?Q?yzZhiS3lWfxk2F82lbuTBflgNSzKIZCGXs4nLpZTzjQj5Tw2t0IeSQCMV8Ok?= =?us-ascii?Q?E8c9u19KMEKkl0L7XoxhRCCWLnsqcmrQZ0BkxNp6KrJVf6oLrJpkTVJrDnZN?= =?us-ascii?Q?OLbBCSGfUzy5SPfZznlUm/KWAuZAIJqMjfn0v1poPGOuU/lC5M0L3LWVCyZK?= =?us-ascii?Q?4/hGvsrm+zistRSdCOgC0nGQUvwA0ANW+3VAHBbYThSrS0BBcVhMb+p8i6LS?= =?us-ascii?Q?5lvELGpBGlyar60cW+4uKPsDUIu8rMBrNlQ83R5Q+BcsIWmm/ruZWT+ZQODr?= =?us-ascii?Q?mLPf4GKeeIi1vp8nlGzy4uC9yrccj8CnYyEMbsvqxMOlRqyVuJeP6+s4PyvR?= =?us-ascii?Q?yXgbc7fOdq5WaKlcRRtf3O11SfzrDmU411LN62+MufQs77MtD0gaU+3q98XB?= =?us-ascii?Q?Ie4+bN5hDfQd4dpJfGA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5477.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fac18a44-5044-42f2-d840-08dc134b71f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2024 08:49:53.4903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ee+opAcp8YwQRMNZJeWx+jTNPWw7CKdebMUSYgNX58DSmtql/4gVLsOo22+RgnqZq6i+Z0R1KOWU5IiAykM2lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5198 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0jjyG7YdZEuiYFdBRsaxCkR3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="WxuNx/yn"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Gerd, I've refined the comments and the commit message. Could you please help to = review again? Thanks, Dun -----Original Message----- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday, January 12, 2024 4:32 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Ra= hul R ; Gerd Hoffmann Subject: [edk2-devel] [Patch V4] UefiCpuPkg:Limit PhysicalAddressBits in sp= ecial case When creating smm page table, limit maximum supported physical addresses bi= ts returned by CalculateMaximumSupportAddress() to 47 if 5-Level Paging is disabled. This commit is to avoid issue that more than 47-bit physical addresses are = requested in smm page table when 5-level paging is disabled. 4-level paging supports translating 48-bit linear addresses to 52-bit physi= cal addresses. Since linear addresses are sign-extended, linear-address space of 4-level p= aging is: [0, 2^47-1] and [0xffff8000_00000000, 0xffffffff_ffffffff]. So only [0, 2^47-1] linear-address range maps to the identical physical-add= ress range when 5-Level paging is disabled. Signed-off-by: Dun Tan Reviewed-by: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuD= xeSmm/X64/PageTbl.c index ddd9be66b5..5964884762 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c @@ -137,11 +137,13 @@ GetSubEntriesNum ( /** Calculate the maximum support address. =20 + @param[in] Is5LevelPagingNeeded If 5-level paging enabling is needed. + @return the maximum support address. **/ UINT8 CalculateMaximumSupportAddress ( - VOID + BOOLEAN Is5LevelPagingNeeded ) { UINT32 RegEax; @@ -164,6 +166,18 @@ CalculateMaximumSupportAddress ( } } =20 + // + // 4-level paging supports translating 48-bit linear addresses to 52-bit= physical addresses. + // Since linear addresses are sign-extended, the linear-address space of= 4-level paging is: + // [0, 2^47-1] and [0xffff8000_00000000, 0xffffffff_ffffffff]. + // So only [0, 2^47-1] linear-address range maps to the identical=20 + physical-address range when // 5-Level paging is disabled. + // + ASSERT (PhysicalAddressBits <=3D 52); + if (!Is5LevelPagingNeeded && (PhysicalAddressBits > 47)) { + PhysicalAddressBits =3D 47; + } + return PhysicalAddressBits; } =20 @@ -197,7 +211,7 @@ SmmInitPageTable ( mCpuSmmRestrictedMemoryAccess =3D PcdGetBool (PcdCpuSmmRestrictedMemoryA= ccess); m1GPageTableSupport =3D Is1GPageSupport (); m5LevelPagingNeeded =3D Is5LevelPagingNeeded (); - mPhysicalAddressBits =3D CalculateMaximumSupportAddress (); + mPhysicalAddressBits =3D CalculateMaximumSupportAddress (m5Leve= lPagingNeeded); PatchInstructionX86 (gPatch5LevelPagingNeeded, m5LevelPagingNeeded, 1); if (m5LevelPagingNeeded) { mPagingMode =3D m1GPageTableSupport ? Paging5Level1GB : Paging5Level; -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113695): https://edk2.groups.io/g/devel/message/113695 Mute This Topic: https://groups.io/mt/103679520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-