From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 000BF941482 for ; Mon, 8 Jan 2024 07:29:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bIv7CuuFgMU02sLHrVJ8dj501d4CZKybXFI4TlUAt7o=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704698994; v=1; b=lIhrYTU57e8TEIeskBC82pPZFCcuXHNJ/AQnTU2IiP2LIU3g0GV9AxTHC+JNnFKBpM9/NVXk FOWSgvbXY2Z0hxDWgqR2+brK0JxIykhfRx0JnRmVlKDJGbSI2TJ5A06s4Zr++4hYNDoh/0JZFqU oyfchzrDEm0RJCuLOxyNqd5g= X-Received: by 127.0.0.2 with SMTP id Ok9AYY7687511x8NOudvLY8h; Sun, 07 Jan 2024 23:29:54 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.1951.1704698994103677810 for ; Sun, 07 Jan 2024 23:29:54 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="462104901" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="462104901" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 23:29:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="904721505" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="904721505" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Jan 2024 23:29:53 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 7 Jan 2024 23:29:53 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 7 Jan 2024 23:29:53 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Jan 2024 23:29:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kc5Huqwgl3pEhPrbS6B4a++SLpbUhSvGgFc0nqv2uPfNc/El7SxZTP1ct5wIRtnWEGgG7PK5nYTMhbjqrM5eTihbcTioait08VU8IYpyusCF+0VP3mJHKetcU5p0AOc7PqdI+0r+dBvuWL0CgyvmCGWcGhKes3m6jhnArHwoTuaQHe18ZtZ83pHBCpfRYefvJCbALBqcG/Qj88oaa6/8kgApfd2vXOtWhgCW9txbBM/cIDG/1rlAEbIFWxF1PGVsgvuJzZMNhDIo2hwRXhzCpZahI3zYB2Gfvw/PfKlWs7T9VKIyRgp6Jqm4crtQNaM3Zbbwkh+KNZ/FmMIqPnxgbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GQzF4hAsxtUzrZVpoZ82s2Uc17/om713txufikW74jU=; b=ESSu0Vvv+KM2n3WYHCjD+9ZQmP8nmyIf5OwVfQDruxqvJEWyQ88u9MKUJljEjMvNRmTtX67H1A0Mb6VIj/pWfGZlTi7VXhUFZC36vWsiFZMdcuB3XWWjwwKBYp8VvF8DtiKgYBbfzZVpjHYZoPPDwhokcJzYA7JbqkwV2W/VH/9ZFrEVs7mK4hCQQVGnGlIXsRrRVaZJp/1pqXuyraWWNPDDoGtEfAXvweO0RUpPJM3nDYyRTnVzZOXJcMZy20Vu2whVUp7TOOS5V3f9JEyEPDZMRe0n5wJR7XjmzNjC8HleGQVkzfBYgE90ZyyKXBcodYQEPkTk+JUifaMGnzhAwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by PH7PR11MB5817.namprd11.prod.outlook.com (2603:10b6:510:13a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 07:29:45 +0000 X-Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::6ecf:1f93:d602:b443]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::6ecf:1f93:d602:b443%5]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 07:29:44 +0000 From: "Guo, Gua" To: "Chen, Gang C" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Lu, James" , "Rhodes, Sean" Subject: Re: [edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check Thread-Topic: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check Thread-Index: AQHaQgO4dybSstnXg0aQiaS1W0dGkrDPhMYQ Date: Mon, 8 Jan 2024 07:29:44 +0000 Message-ID: References: <20240108072531.3344290-1-gang.c.chen@intel.com> <20240108072531.3344290-4-gang.c.chen@intel.com> In-Reply-To: <20240108072531.3344290-4-gang.c.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|PH7PR11MB5817:EE_ x-ms-office365-filtering-correlation-id: cb63d947-34c7-4b1a-c011-08dc101b95b9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 8IgfpG8ThgeRon90Cw4LKFjTxEJJdRunRouDNsR9h5T2JaaigIjOnoTJ7PSfPs8JAwdHkjCnxnWvMgF5vEcL6XDQ6eAK9+F2/OQ329UBnkgHlXp2CiiG8BIE1MQuHEanBPUTESKUa85EESzF1TrkLogu0jwtjXWTOdc2GOfKsXOHF4nviyFLXRWNqIg24fLATYPVtUzRSOYqbbI6KxJSoacMbkS4z7aZKWOkeG51gbe6G+NXJ+ahvzcFR/msWhySpnx35vcjTq8sxOA2InORvbmRf9FLqbhkghYx4Z8DK13xr2O5CBvy3Xaa1OS6myOifMSJTnKftG0kZGl03pprtDToLMBTqN7dTloP9Y/HULCY65LiJQmhRv8n59sLKZmn2JrZM3esWYIeLGnotKNjoTMIsq9JBUv68RUwJT5cdpJUo77zCUekMhfeBdpVTCUStWdMC8MyHU17tABuDbBBQBf0pDJ8C34GbbhnGZ0CayQIU68XF7Ag21a8Chan26aET9nY7jX5mReQxPcP7t63ZONsCnTzJI9C7TN+6lE2uSeIid78pNeEjanpHYfy5Arb5ubUIslzaetEHZ2/4wOYIHCmu2wgIEvfNr5RMrL8i26VrLwksg0b/NWfr8DFxE6G x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q/Xcr/5UvJDYCbq+NWZsBWd2TY5Uqog7xNPoQTuHn9M4ZEpT29TaKUtOycay?= =?us-ascii?Q?eHciCzIvmaqjlysPwZwSZxzl/ISy2lQHLlR6z9I52HYnHPtjK6qBg7hkQY4H?= =?us-ascii?Q?Rs2PCHFdjXoSiQ4GxI6Jmw/LG1nGgNhmpBnn4OcGlH7JjYYcyhWFSZiVeiMl?= =?us-ascii?Q?XUgVIiVVilOqnDSxntqCm4tROZblgCnwnCqLzuzegKSHxNIc85wGO8OJH5Qp?= =?us-ascii?Q?sP3AkrjEBzTTRF0HOEowxg3FuqvukDqBuwzI2duxC0G97DsLXD7RTcTyT8d7?= =?us-ascii?Q?MW3sCdt4PrATkuOodWPnIXwA7izhEuX+1sOCx9ji+SuocDPkLqrYL8PIeqJ2?= =?us-ascii?Q?0cqSzoC+oWBDYS6KC+ZtT4fNdHnuc6ym10vkOlq7RbABDbWdY9xG0cGpCNAZ?= =?us-ascii?Q?wJMmlehPxrRNCGmADSnYdbi6ZfjQLojHUvllLiEBuK9QkK3kzwqq7Sf5tuQu?= =?us-ascii?Q?T2RDP+cLZ1AJTsJ0VrBcvXrORSci332Y9IqTrLDHWHhhYLf1w+OBW9jIKuLg?= =?us-ascii?Q?/5IAvf1s5afr80woJZUHnxj1gGrnGsUz21QxnH/eDKIM43NCGDDSVKA1No5i?= =?us-ascii?Q?h7pJVVpZ8lhjxcXIAXb08+A1UNJwZzyVtgSb7kZYpsAK0IqHty2ZaMw8hgf2?= =?us-ascii?Q?DfTDXAX63rqYq9gUAzFXsNU9UjN3x2QrCKCqgq95ydoKoeh/GdvmzMevi4V6?= =?us-ascii?Q?YiH28sNl1tcfBihWj0agQtpUdCFrXiuz9FQHTOXt4L/hJHkwVscGjlxl8Nkf?= =?us-ascii?Q?g+nV9FVVJp+rdTSjtCPRVLv6UHmVnP88gKTDartAFVVr9az8EUNl+P+Ia2ly?= =?us-ascii?Q?UljG3C8YdJihdshAv+tdjQHB31oJBRz+6xSxyuc87kt9+rFhvekIzcXnH7cJ?= =?us-ascii?Q?QMXVF6McbvgDTs0raJMnFELKkpvY9VAi3ZcjXLODm2DLiu7woskSG68XvnIM?= =?us-ascii?Q?s0RGHs+1Rmt3bxAw3Trv6rLk50kZNfPkBtUDBhdDrmGU4UJrlFoyr0XcvPYW?= =?us-ascii?Q?BpizWAIFeydqa90Uua8aaMIc+MoCw4xI0Xowu6vClftr2miXVdM4Xqu02Qf7?= =?us-ascii?Q?SN1mntYfyGVcQg/E6qTyR+lkOUPJq1g0Zlq2fMhct3APm/uuTpEagP9aRacM?= =?us-ascii?Q?IOA4QjCBNxTFo7wF2D+rbLpFSxlAuXEPp3T7VnDaau8IpoD5naX2dWRoPHnN?= =?us-ascii?Q?2he3pB9JH14pZAyEyNqW0rg8szE/R4F02DRtoB8WvdiBfmNDyvDov4mSFicp?= =?us-ascii?Q?mYMc6/xa76BJWL9l8urMQDldKPkqcq6GcpiZrdIOlVAbpRqxdYdl6bp09+yr?= =?us-ascii?Q?EbZVHGqMLdEUjSUHBmVzCr3ssK1Rhp7/0MkkBhddrbbJtrDsy/lLFA387vTc?= =?us-ascii?Q?BcMON+3NcyQaKMJOaPq7cTWd1f028aXZvb8Xr578w6cBIt86tjyQ9aCuilo9?= =?us-ascii?Q?UB3prB0BLhIGAc5X9C7Hby/DW739HwGj32HZ6nlxkth8qKNJs+oIYOWcHapL?= =?us-ascii?Q?KZAUuc6n/xhznCPa+HmirmHdWqWmgmVO77PEge/ZwztOrF52bSm7N1aeTygK?= =?us-ascii?Q?Fgg0Da6u+O3CEtbgHgEk9HUpc8AmKS28fvod2EPf?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb63d947-34c7-4b1a-c011-08dc101b95b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 07:29:44.1273 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wvh17tlsGNXYVcmr2nuv+/xt6tR8XzAEgVMlrPKWaCo8DgXMGt8zJ+MSQkP5EiD5S3zcrCBjv5rL+ahFgzoDDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5817 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gua.guo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KEHs4kRbdcBKRMx4vzlfk9FMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lIhrYTU5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Gua Guo -----Original Message----- From: Chen, Gang C =20 Sent: Monday, January 8, 2024 3:26 PM To: devel@edk2.groups.io Cc: Guo, Gua ; Dong, Guo ; Lu, James= ; Rhodes, Sean ; Chen, Gang C <= gang.c.chen@intel.com> Subject: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling c= heck It's too early to check the SCI enable status, which is set in the BDS phas= e ususally. Remove the check from UPL. Signed-off-by: Gang Chen Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes --- UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 --------------------- 1 file changed, 38 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c b/UefiPayloadPkg/U= efiPayloadEntry/AcpiTable.c index 1b9208b6d3..748728981a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c +++ b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c @@ -134,44 +134,6 @@ Done: ASSERT (Fadt->Pm1aEvtBlk !=3D 0); ASSERT (Fadt->Gpe0Blk !=3D 0); - DE= BUG_CODE_BEGIN ();- BOOLEAN SciEnabled;-- //- // Check the consistency = of SCI enabling- //-- //- // Get SCI_EN value- //- if (Fadt->Pm1CntLen= =3D=3D 4) {- SciEnabled =3D (IoRead32 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE= : FALSE;- } else {- //- // if (Pm1CntLen =3D=3D 2), use 16 bit IO r= ead;- // if (Pm1CntLen !=3D 2 && Pm1CntLen !=3D 4), use 16 bit IO read a= s a fallback- //- SciEnabled =3D (IoRead16 (Fadt->Pm1aCntBlk) & BIT0)= ? TRUE : FALSE;- }-- if (!(Fadt->Flags & EFI_ACPI_5_0_HW_REDUCED_ACPI) &= &- (Fadt->SmiCmd =3D=3D 0) &&- !SciEnabled)- {- //- // The= ACPI enabling status is inconsistent: SCI is not enabled but ACPI- // t= able does not provide a means to enable it through FADT->SmiCmd- //- = DEBUG ((- DEBUG_ERROR,- "ERROR: The ACPI enabling status is incon= sistent: SCI is not"- " enabled but the ACPI table does not provide a = means to enable it through FADT->SmiCmd."- " This may cause issues in = OS.\n"- ));- }-- DEBUG_CODE_END ();- return RETURN_SUCCESS; } --= =20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113366): https://edk2.groups.io/g/devel/message/113366 Mute This Topic: https://groups.io/mt/103593439/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-