From: "Guo, Gua" <gua.guo@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD
Date: Wed, 24 May 2023 08:37:04 +0000 [thread overview]
Message-ID: <BL1PR11MB547810CAF140EC803852999BEF419@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN6PR11MB824417950F365DC65A5190578C419@MN6PR11MB8244.namprd11.prod.outlook.com>
Thank for the review, will update v4 to take care it.
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Wednesday, May 24, 2023 4:14 PM
To: devel@edk2.groups.io; Guo, Gua <gua.guo@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [PATCH v2 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD
>
> -extern UINTN mRtcIndexRegister;
>
> -extern UINTN mRtcTargetRegister;
>
> -
>
> +extern UINTN mRtcIndexRegister;
>
> +extern UINTN mRtcTargetRegister;
>
> +extern UINTN mRtcIndexRegisterIo;
>
> +extern UINTN mRtcTargetRegisterIo;
Can you avoid adding the mRtcIndexRegisterIo/ mRtcTargetRegisterIo?
Can you just use the old variables mRtcIndexRegister/ mRtcTargetRegister.
prev parent reply other threads:[~2023-05-24 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 12:00 [PATCH v2 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD Guo, Gua
2023-05-22 12:00 ` [PATCH v2 1/1] " Guo, Gua
2023-05-24 8:13 ` [edk2-devel] " Ni, Ray
2023-05-24 8:37 ` Guo, Gua [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR11MB547810CAF140EC803852999BEF419@BL1PR11MB5478.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox