From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.30284.1683754449960300155 for ; Wed, 10 May 2023 14:34:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C5UVci1+; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683754449; x=1715290449; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=w204828c3htRnglLsj4L1lUJSW8YujSFCc0CqxRbs/A=; b=C5UVci1+ULY9uyQ1OETwju/c5JPyUiY3XSeEGK5cLa3Y4JUgFXGHwdi2 tlS7H8mHiKrkSy+prIYP/TnH3VtUgBeglm2T7RTk9pb5k9UGHkGhLzS/9 AaBwGTIg4DTIi1PmK0rTsY9ZOuoudXDMsM9fl0qiTH+FkqKA0iHAjx1/6 WL4uC6j6P5/MaoUPlwsuuIUcCJ2WUnd8avZvJk4ipiRVjthYN5gmuL8h+ 6tUyuuslfbGV5lh5FwMBv/0JNVJkbCKgbSohZndkzUZEprCFD/1wKtU9v p7wvTn6VLquRXkh8y+3IHkayEmZ0dGhekyeC4tR92s31U1L7dXgKfarWR A==; X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="334798553" X-IronPort-AV: E=Sophos;i="5.99,265,1677571200"; d="scan'208";a="334798553" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2023 14:34:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="823694428" X-IronPort-AV: E=Sophos;i="5.99,265,1677571200"; d="scan'208";a="823694428" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 10 May 2023 14:34:09 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 10 May 2023 14:34:08 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 10 May 2023 14:34:08 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 10 May 2023 14:34:08 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 10 May 2023 14:34:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZfely8aL6OeY3eo+orAIijxYGYT5V8m6WDUgeAjCoN/+650HfaMec2DsktAcycveS2n5ovYe1CT917rML8pPXFmorNmHVutMNjc9s4R2wFc55Elt6rEpO7QT6a8SSc8vw6MBBe4y+yyfHWxgzh93iJlvYXRCs5lcVPjTzU6LU1JUCOVb3Hd8Z1m0ulV7AbIEP+EnbUW8Ei3bSdttCEvT3z53ReccKT5+k1rMa6mClk2A7Yi66CZu/lNNTe3Ee2ut20EQ/Yd8wIhuv4v9jFzLkfHgJsYYqlBPJlfeqgre9vERKnCZ+Hn7jgG81EkkDDoLe1XY110mAvZmML1SMY07Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8xw4h21QszxLoqooJihJK6wtYIdRnDlwNC+Rf/NKSw4=; b=EE1OtoDymHSfennom4PbEm5a0BPHMZEzViVR7hSDnPvWy97AbryMtWirtox6Ks6FSbinQZXZ/j7gsgdBijoFefHTTANZRvHNJL+YyxAvWDZHX/OZ9SlG7jYUJ9lGaKNVyZA9STTgQ4f1kounKKoYL7MpgrFEihALv76Xv95c66Nn17m8vbY86iUziekF1tiDP30mkFGlNO0TkLUYymsL8fL6Fuqwi9lFhC1vn4coA02kcQSIRJI1WO4xopMiiIkXoT5F+xJFL02zGUdvQbjb1kdtM+hb5/9vGp482Mp63wv3Y2CsjOMvv2jPMzqC+tuKeX17EG05rrXVXAgYaDMltg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by PH8PR11MB6997.namprd11.prod.outlook.com (2603:10b6:510:223::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.20; Wed, 10 May 2023 21:34:05 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::f50b:35fe:b26f:ec5d]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::f50b:35fe:b26f:ec5d%6]) with mapi id 15.20.6387.018; Wed, 10 May 2023 21:34:05 +0000 From: "Guo, Gua" To: "Kinney, Michael D" , "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" CC: "Hsu, VictorX" , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update reviewers and maintainers for TraceHubDebugLib. Thread-Topic: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update reviewers and maintainers for TraceHubDebugLib. Thread-Index: AQHZgufs3ICstTzHWUWoxPRGY73Ezq9T1jmAgAAGegCAACIaYIAABjSAgAADU/A= Date: Wed, 10 May 2023 21:34:05 +0000 Message-ID: References: <20230510023355.1467-1-gua.guo@intel.com> <20230510023355.1467-5-gua.guo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|PH8PR11MB6997:EE_ x-ms-office365-filtering-correlation-id: 5e304837-d288-494c-8723-08db519e47d6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sk/O1Nw3hUt3H0EpmVlxH0C0tB+69Zz9ByA2QNbaMYI+/6Gor3G89ZjI4fFJ0VdhVJodOGiqXfL7HXgZoyoB1E+h76WlXIkh6//Yf6UMOKTXtDP749GBAK3CcfGR+LrOCRKdlKR0YCHl3qoQoTbHR1fLOWr8PUQwelozi1rqHbglDPFL80rvSM2PpeWtIPD/LMD0eM13Io7LfAvN59MX8YCscJS1duqh0pKniq4Mmvl2QnVeCrsiCYkg5jmqNQf62+0EUqwZ/t8ijVneUJnSRCuS4/orvZAq9IscIY7uLyKAVM1rLgSLr+gIJ0bAjqLcrI5IpHki5Ox3X2+gk27ldZ8uy/NT68ZVMaGMEuzwbgJEZQ1kTkOAWkwlavS9GzFD773m0L7cxCziGWDBPPqi23dxdaDEXhTEwR2VXcPtaDqCcLDiPPDsmT1SMW3Wgy78aCSUVpTbYS23YTSxW1d1+A9Jgpye0h9e15Ce8x0T57+OfkDAoCn8Xq4RyXSBcooJscrMvg+gk0cdDFjHHjFO1OLPneS4/apIvfBfiGBADqCB/o2BplTVz0o0CcAzU3PLLqur/CNRyH5UCAsKyKFClHA632tgnX/N3bfUrGtm8bPpwBImY4Ji5rRA1HNDAwGwmKH2aW2jx0rFOINE0+S9BA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(39860400002)(136003)(346002)(366004)(451199021)(186003)(9686003)(53546011)(6506007)(478600001)(107886003)(83380400001)(26005)(33656002)(66899021)(966005)(7696005)(71200400001)(8936002)(5660300002)(316002)(122000001)(86362001)(52536014)(38070700005)(38100700002)(41300700001)(55016003)(8676002)(110136005)(66946007)(76116006)(4326008)(99936003)(66556008)(66476007)(66446008)(64756008)(15650500001)(2906002)(82960400001)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wrc16eq3zopaztA2Q8Ng8DDpsxKIKp2UO6Jq2NOjhMapx//2cwuCMo7bij8T?= =?us-ascii?Q?5IGM6+ouV6c90vYu55LUCqogmFEpjX501mJ2r0wZ6fZCBTL1M9fIIGnys27m?= =?us-ascii?Q?oqHdVRDXGxPO8/QuMqSMm/Mpa+ey7yBo/ql1WakIowieOeDOG2fDrIL1aMgm?= =?us-ascii?Q?sneyy8dzo16sGV/NumDouCRclORHVB1gnICALSjEk1z5DPdejADW66qU3klo?= =?us-ascii?Q?U+JN0hJGin80xIdPW4dqRjPjpPZO3/aEY+5H0rkwnArBlhE8NPmarq6Wj4S5?= =?us-ascii?Q?XaVeoMiW1bL6L2tuzoEVDS8EnfWCewrMj/vAd6SKE1HtpZ7fm9Xd8ve5r6J6?= =?us-ascii?Q?iWJk4UhtmlR4ARr8P0cHM1FRwUZuPRfH+0Nvr1PSPqkR5fwEBL7Spdiyd7Lg?= =?us-ascii?Q?S2Bi2kuCGAhRqxDNtGlxkBf7bP+Zn9qMVlQbP4kP/ZfFRrbazh3mcdN4PYPD?= =?us-ascii?Q?NtykXYNZg/7RYOtglnkNyE/CgMi7YAVmiGkrK3MMzhRwy2RcsS+BaETAkdUr?= =?us-ascii?Q?zY73hA/DNfyKSZKbMkM5izXGtljQMRw1+WN10xiE2SYivRV6XfVPgShVPJTx?= =?us-ascii?Q?VPLwtsf1bl7kFOV6ndIqMKeEBZZvh3BmwLNMXJU7e1uU3nVsrj7LXNowV8hO?= =?us-ascii?Q?ers7WGiR03bjK+7zk8w79DvCt6aYAhkPTLWvkCHybCMvb6mB++XF0A2o71UT?= =?us-ascii?Q?j9QuwwaI+QE3sJSK6AonCRWGIkiH39PDFIn6NKmQt50PMWAFRuKOKw5rN+sC?= =?us-ascii?Q?KkiL2iCDmgbfH9u27mYZjmGT/VIJ/MIVVxxbIoLUHyy44qEVUz0UET805LMG?= =?us-ascii?Q?xqfGsdmlZY6svNnfRlSN1tO2QlpxXy3f0oJP5++AUx/2edrkaV9TSPfJ++CB?= =?us-ascii?Q?uGyv2QlnG214ikyPAOEvbcxuPrnAoobBTCCFO/99CrEnkKOM1I0J9dHemM/Y?= =?us-ascii?Q?cpt7Umzj0KgmmdGMajWwyzOXr8faUns7uJXZo6Od2MD8uoE2i7Y7qUf1BWLN?= =?us-ascii?Q?xUC29P3jPc3s9zgSlQoL2+IcaXryGZ3Bo7F4E7uvyh1kSr7rXjHx0NSiaTyn?= =?us-ascii?Q?7Kz8gbqS+uteI23sOi0UIwFSn6QRyPUm2NNdu6z2feiy1HD84KCDEoyEASBb?= =?us-ascii?Q?nIoaroJUWxnX1xnHJ5TdBsT3BztvLoNXHvg+Jh5MrL3DIzvsdL60wR9zrcsX?= =?us-ascii?Q?HRNrM9EWwz6ZhjEXmWmJJxNXB7PpDFTWA+lvpA82VsdAijO9bTlQfNdSMnT9?= =?us-ascii?Q?1y15VyzHG6T1CpplEA4v1gcve08a8oLF4v2wXuL+fYcdOLqnW1el0Bfnkyu2?= =?us-ascii?Q?VyNTJToNsJpAFE1d2q+tCxSF6mNPSHzev3UVw4h7hHF5IIymqxF+rujVMl9h?= =?us-ascii?Q?U9l4T1O2dxZuxww2kuo9OmP5vM5lU+qTX3dstDF2acpmTvlFbyXQCfszUb2z?= =?us-ascii?Q?BH7ZzqJg0fNIvqDr5Rqfb64/6flO05lpHZvhfw1J5vRjPpSbMP9YpoX+7nFo?= =?us-ascii?Q?9W+bAyzoStWIRenmexeIYcBAKFpXpYwPz4b9v/iZDalSrxVNijYx8m/3pclS?= =?us-ascii?Q?bE1i3wDo3cvJNj0CNyg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e304837-d288-494c-8723-08db519e47d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2023 21:34:05.4383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BzRbckaQSbXus/NCrt+WCJmP2jQ1Rv7T72Q1oLnlv/FMcVbeCLalGgKbo7WNol1Y/GzTsvvxacNGnqr4AFgKpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6997 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com X-Groupsio-MsgNum: 104616 Content-Language: en-US Content-Type: multipart/mixed; boundary="_002_BL1PR11MB5478174E631306D02D1557AAEF779BL1PR11MB5478namp_" --_002_BL1PR11MB5478174E631306D02D1557AAEF779BL1PR11MB5478namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure, can track this one. -----Original Message----- From: Kinney, Michael D =20 Sent: Thursday, May 11, 2023 5:22 AM To: Guo, Gua ; devel@edk2.groups.io; quic_llindhol@quici= nc.com Cc: Hsu, VictorX ; Chiu, Chasel ; Kinney, Michael D Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update reviewers = and maintainers for TraceHubDebugLib. Hi Gua, Can you please resend the email patches for the series and make sure the Au= thor and Signed-off-by are correct on your local branch before sending. Thanks, Mike > -----Original Message----- > From: Guo, Gua > Sent: Wednesday, May 10, 2023 2:02 PM > To: Kinney, Michael D ;=20 > devel@edk2.groups.io; quic_llindhol@quicinc.com > Cc: Hsu, VictorX ; Chiu, Chasel=20 > > Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update=20 > reviewers and maintainers for TraceHubDebugLib. >=20 > @Leif Lindholm and @Kinney, Michael D >=20 > I've locate Leif and update on the PR. >=20 > - Split submodule into new patch > - Fix formatting issue > - Add Review-by message > - Offline check with Victor to use my sign-off name. > https://github.com/tianocore/edk2/pull/3901 >=20 > Thanks, > Gua > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, May 11, 2023 2:57 AM > To: devel@edk2.groups.io; quic_llindhol@quicinc.com; Guo, Gua=20 > > Cc: Hsu, VictorX ; Kinney, Michael D=20 > > Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update=20 > reviewers and maintainers for TraceHubDebugLib. >=20 > Hi Leif, >=20 > The original patch series was sent by Victor in January and has=20 > Signed-off-by from Victor. >=20 > https://edk2.groups.io/g/devel/message/99333 >=20 > Subsequent updates to the patch series based on feedback were sent by Gua= . >=20 > With this background, who should be Signed-off-by and the Author in=20 > the final patch series? >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Leif=20 > > Lindholm > > Sent: Wednesday, May 10, 2023 11:34 AM > > To: devel@edk2.groups.io; Guo, Gua > > Cc: Hsu, VictorX > > Subject: Re: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update=20 > > reviewers and maintainers for TraceHubDebugLib. > > > > On Wed, May 10, 2023 at 10:33:55 +0800, Guo, Gua wrote: > > > From: Gua Guo > > > > > > Update reviewers and maintainers for TraceHubDebugSysTlib. > > > > > > Signed-off-by: VictorX Hsu > > > > The DCO is a legal statement about the contribution. Only the person=20 > > posting the patches can make that statement. > > If VictorX is the author, that should be covered by the From: tag. > > I notice this applies to the whole set. Please address. > > > > Once addressed: > > Reviewed-by: Leif Lindholm > > > > / > > Leif > > > > > --- > > > Maintainers.txt | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index=20 > > > 09d04af27a..30e2d2686d 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -437,6 +437,14 @@ R: Zhiguang Liu > > [LiuZhiguang001] > > > R: Ray Ni [niruiyu] > > > R: Gua Guo [gguo11837463] > > > > > > +MdeModulePkg: Trace Hub debug message related library instance > > > +F: MdeModulePkg/Library/TraceHubDebugSysTLib/ > > > +F: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > > > +M: Gua Guo [gguo11837463] > > > +M: Prakashan Krishnadas Veliyathuparambil > > [kprakas2] > > > +R: Chan Laura [lauracha] > > > +R: K N Karthik [karthikkabbigere1] > > > + > > > MdePkg > > > F: MdePkg/ > > > W: https://github.com/tianocore/tianocore.github.io/wiki/MdePkg > > > @@ -444,6 +452,16 @@ M: Michael D Kinney=20 > > > > > [mdkinney] > > > M: Liming Gao [lgao4] > > > R: Zhiguang Liu [LiuZhiguang001] > > > > > > +MdePkg: Trace Hub debug message related library instance > > > +F: MdePkg/Library/TraceHubDebugSysTLibNull/ > > > +F: MdePkg/Library/MipiSysTLib/ > > > +F: MdePkg/Include/Library/TraceHubDebugSysTLib.h > > > +F: MdePkg/Include/Library/MipiSysTLib.h > > > +M: Gua Guo [gguo11837463] > > > +M: Prakashan Krishnadas Veliyathuparambil > > [kprakas2] > > > +R: Chan Laura [lauracha] > > > +R: K N Karthik [karthikkabbigere1] > > > + > > > NetworkPkg > > > F: NetworkPkg/ > > > W:=20 > > > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg > > > -- > > > 2.39.2.windows.1 > > > > > > > > > > > > > > > > > > > > > > > >=20 > > --_002_BL1PR11MB5478174E631306D02D1557AAEF779BL1PR11MB5478namp_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Wed, 10 May 2023 21:33:59 GMT"; modification-date="Wed, 10 May 2023 21:34:04 GMT" Received: from PH7PR11MB6452.namprd11.prod.outlook.com (2603:10b6:510:1f3::12) by BL1PR11MB5478.namprd11.prod.outlook.com with HTTPS; Wed, 10 May 2023 21:32:11 +0000 Received: from DS7PR03CA0185.namprd03.prod.outlook.com (2603:10b6:5:3b6::10) by PH7PR11MB6452.namprd11.prod.outlook.com (2603:10b6:510:1f3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Wed, 10 May 2023 21:32:10 +0000 Received: from DM3NAM02FT031.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b6:cafe::26) by DS7PR03CA0185.outlook.office365.com (2603:10b6:5:3b6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.20 via Frontend Transport; Wed, 10 May 2023 21:32:09 +0000 Received: from edgegateway.intel.com (192.55.55.71) by DM3NAM02FT031.mail.protection.outlook.com (10.13.4.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.21 via Frontend Transport; Wed, 10 May 2023 21:32:09 +0000 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by edgegateway.intel.com (10.1.192.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 10 May 2023 14:32:01 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 10 May 2023 14:32:01 -0700 Received: from orsmga004.jf.intel.com (10.7.209.38) by fmsmsx602.amr.corp.intel.com (10.18.84.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 10 May 2023 14:32:01 -0700 Received: from gguo-desk.gar.corp.intel.com ([10.5.215.23]) by orsmga004.jf.intel.com with ESMTP; 10 May 2023 14:32:00 -0700 From: "Guo, Gua" To: "devel@edk2.groups.io" CC: "Guo, Gua" Subject: [PATCH v7 0/5] Trace Hub debug library support Thread-Topic: [PATCH v7 0/5] Trace Hub debug library support Thread-Index: AQHZg4bh+GpA4fGUukO0RwkU1UwuUQ== Date: Wed, 10 May 2023 21:31:49 +0000 Message-ID: <20230510213154.1994-1-gua.guo@intel.com> Content-Language: en-US X-MS-Exchange-Organization-AuthMechanism: 10 X-MS-Exchange-Organization-AuthSource: fmsmsx602.amr.corp.intel.com X-MS-Exchange-Organization-ComplianceLabelId: 12ee4da9-25d2-4141-a122-b55133cf49dd X-MS-Has-Attach: X-MS-Exchange-Organization-Network-Message-Id: ed107d4d-bf98-4ba0-9885-08db519e02f9 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 x-ms-exchange-organization-originalclientipaddress: 10.7.209.38 x-ms-exchange-organization-originalserveripaddress: 10.13.4.184 received-spf: Fail (protection.outlook.com: domain of intel.com does not designate 192.55.55.71 as permitted sender) receiver=protection.outlook.com; client-ip=192.55.55.71; helo=edgegateway.intel.com; x-ms-publictraffictype: Email authentication-results: spf=fail (sender IP is 192.55.55.71) smtp.mailfrom=intel.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=intel.com; x-ms-office365-filtering-correlation-id: ed107d4d-bf98-4ba0-9885-08db519e02f9 x-ms-traffictypediagnostic: DM3NAM02FT031:EE_|PH7PR11MB6452:EE_|BL1PR11MB5478:EE_ x-ms-exchange-transport-crosstenantheadersstamped: PH7PR11MB6452 x-forefront-antispam-report: CIP:192.55.55.71;CTRY:US;LANG:en;SCL:-1;SRV:;IPV:NLI;SFV:SKI;H:edgegateway.intel.com;PTR:edgegateway.intel.com;CAT:NONE;SFS:;DIR:INT; x-microsoft-antispam: BCL:0; x-ms-exchange-crosstenant-originalarrivaltime: 10 May 2023 21:32:09.8245 (UTC) x-ms-exchange-crosstenant-network-message-id: ed107d4d-bf98-4ba0-9885-08db519e02f9 x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-fromentityheader: HybridOnPrem x-ms-exchange-transport-endtoendlatency: 00:00:01.3208376 x-ms-exchange-processed-by-bccfoldering: 15.20.6387.018 x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: fmsmsx602.amr.corp.intel.com X-Microsoft-Antispam-Mailbox-Delivery: ucf:0;jmr:0;auth:0;dest:I;ENG:(910001)(944506478)(944626604)(920097)(425001)(930097); X-Microsoft-Antispam-Message-Info: ayIof+++nRd1xwsTuPTcad1zmV037oKmjZVbv9GNyVwj3bh/JF1muIz2RL4xeJYds8BXZYKvW3rgRDlF/Ob8l0gAhPxQxfAycuRylf+IwPNrxKYDS+4SKmAip2lqdWO5TGofQsrD0zca4cFNln3+iZATsjqMF5NnR+f99d1jeKJZ9Oh5g+Aw7QLLSD0E/K5LuRXxxGLQv9zP95661JwTR7rQIM36IYII2LYpe88pZOtZjo+GrERL3Tfqso00gYT1jCl9TvNBMVamQgt3NhK6zKeGsxXqVVRVCwZYOOpHMIu7rdUYg4SjjCbloOGkyiTr0Dk6NFIbY9sCGLd8XLSftx0Hqe30pF4o9OrAjhZMp6SHEVUhRhBzpK75WngkPIGOG7gTYz1bRXSEHGkDaQRLAbv1WAZelj+btLnZAEtIx/3EQ/3zjtg2Ui9uu4deQ41xFtYATsSBWrR1sIiVr42DIrBNOoKfwDq1uWWtpaWRFE7pmYlQ0e7fQGIkC6fyq5l2USAmG9AxPyrZSvlQsCRRLj1KSvqdnCQZi3BQd4hCzi61G9M9A+1fDcNXonbP5HpDBChVlJ5mJlvbkBe+aQVMUCxzJ9DoPgwafZZqkCoZYWeLyucerGpG9nMPqPTiGLsQ4+ea1F0ELhSJtulu+ucwhxTRTnkgEZv3VzhXEVf+RzqepxhFvmMdT2X4yTyEoNFBIBsmS0gv/r9Ol165cj1JfImEtVk9miOPHo9v3HXkb3OwY7XsWvj2d0qiYKmrI0Lm Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 From: Gua Guo V7: Miss one patch on V6 V6: - https://github.com/tianocore/edk2/pull/3901 Split submodule into new patch Fix formatting issue Add Review-by message Offline check with Victor to use my sign-off name. V5: if no other open, it will be final change - https://github.com/tianocore/edk2/pull/3901 Fix random exception when long run catalog debug message V4 - https://github.com/tianocore/edk2/pull/3901 - Done Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make impleme= nt code more simple. V3 - https://github.com/tianocore/edk2/pull/3901 - Done - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why MAX_TRACE_H= UB_DEBUG_INSTANCE hardcoded to 5? Solution: Remove this macro, use Library Constructor to allocate it dyn= amiclly. - Open: MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiComm= on.c: SwapBytesGuid () algorithm wrong. Solution: Follow correct algorithm to implement it. VOID EFIAPI SwapBytesGuid ( IN GUID *Guid, <----------- In PreMem, guid is global da= ta so region is readonly, add output data to support it. OUT GUID *ConvertedGuid ); - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D Solution: use *_*_*_CC_FLAGS =3D -DMIPI_SYST_STATIC to unified both. V2 - https://github.com/tianocore/edk2/pull/3901 - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why MAX_TRACE_H= UB_DEBUG_INSTANCE hardcoded to 5? - Open: MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiComm= on.c: SwapBytesGuid () algorithm wrong. - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D V1 Previous PR: - https://github.com/tianocore/edk2/pull/3613 - TraceHubDebugLib without submodule - Reject - https://github.com/tianocore/edk2/pull/3793 - TraceHubDebugLib with submodule and without seperate into MipiSysTLib a= nd TraceHubDebugLib - Reject Gua Guo (5): MdePkg: Add mipisyst submodule MdePkg: Add MipiSysTLib library MdePkg: Add NULL library of TraceHubDebugSysTLib MdeModulePkg: Add TraceHubDebugSysTLib library Maintainers.txt: Update reviewers and maintainers for TraceHubDebugLib. .gitmodules | 3 + .pytool/CISettings.py | 2 + Maintainers.txt | 18 + .../Include/Guid/TraceHubDebugInfoHob.h | 24 + .../BaseTraceHubDebugSysTLib.c | 245 ++++++ .../BaseTraceHubDebugSysTLib.inf | 44 + .../DxeSmmTraceHubDebugSysTLib.c | 263 ++++++ .../DxeSmmTraceHubDebugSysTLib.inf | 51 ++ .../InternalTraceHubApi.c | 74 ++ .../InternalTraceHubApi.h | 37 + .../InternalTraceHubApiCommon.c | 200 +++++ .../InternalTraceHubApiCommon.h | 119 +++ .../PeiTraceHubDebugSysTLib.c | 282 +++++++ .../PeiTraceHubDebugSysTLib.inf | 50 ++ .../Library/TraceHubDebugSysTLib/Readme.md | 26 + MdeModulePkg/MdeModulePkg.dec | 21 + MdeModulePkg/MdeModulePkg.dsc | 3 + MdeModulePkg/MdeModulePkg.uni | 18 + MdePkg/Include/Library/MipiSysTLib.h | 66 ++ MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++ MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++ MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++ MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 52 ++ MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++ MdePkg/Library/MipiSysTLib/Platform.h | 138 +++ MdePkg/Library/MipiSysTLib/Readme.md | 25 + MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 ++++++++++++++++++ MdePkg/Library/MipiSysTLib/mipisyst | 1 + .../TraceHubDebugSysTLibNull.c | 76 ++ .../TraceHubDebugSysTLibNull.inf | 29 + MdePkg/MdePkg.ci.yaml | 12 +- MdePkg/MdePkg.dec | 9 + MdePkg/MdePkg.dsc | 2 + ReadMe.rst | 1 + 34 files changed, 3177 insertions(+), 3 deletions(-) create mode 100644 MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubD= ebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubD= ebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHu= bDebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHu= bDebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTrace= HubApi.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTrace= HubApi.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTrace= HubApiCommon.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTrace= HubApiCommon.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDe= bugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDe= bugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md create mode 100644 MdePkg/Include/Library/MipiSysTLib.h create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSy= sTLibNull.c create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSy= sTLibNull.inf -- 2.39.2.windows.1 --_002_BL1PR11MB5478174E631306D02D1557AAEF779BL1PR11MB5478namp_--