@Ni, Ray
Below url is pull request link. May I get your help to add push label ? Have any concern, please also share for me.
URL:
https://github.com/tianocore/edk2/pull/3015
Thanks,
Gua
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, June 27, 2022 2:53 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Monday, June 27, 2022 1:03 PM
> To: Ni, Ray <ray.ni@intel.com>;
devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL
> spec
>
> Yes, #2 is chosen in by the python interpreter.
>
> -----Original Message-----
> From: Guo, Gua
> Sent: Monday, June 27, 2022 12:07 PM
> To: Ni, Ray <ray.ni@intel.com>;
devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL
> spec
>
> The python logic will like for below
>
> > upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
> =========>
> > if BuildTarget == "DEBUG":
> > upld_info_hdr.Attribute |= 1
> > else:
> > upld_info_hdr.Attribute |= 0
>
> Thanks,
> Gua
>
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Monday, June 27, 2022 11:44 AM
> To: Guo, Gua <gua.guo@intel.com>;
devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL
> spec
>
> > + upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
>
>
> I am not python expert. Above statement might be interpreted as:
> 1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2.
> upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0)
>
> Are we sure that the #2 is chosen in by the python interpreter?