From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.38754.1656315098614718692 for ; Mon, 27 Jun 2022 00:31:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=USEZXmX7; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656315098; x=1687851098; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Ty6iTniAcaVrYS+evVs6nzZdNaTobfgq6NEb1GcPuGQ=; b=USEZXmX71NNVDJ333qWoIQu0xpjRxbyuWiufOQuJuFaTaeJMR6BQWcdf Dz/USSmnFTsTX5pkIT4bCzS58MXtwBDBLlIU/g+SJzqGBF/60kqXlKxZC xXRVnvkbJaYiuo9voXnnmhjQ0/H1oq3+T+abTxIec++sRPAXJwHa9JMuu sTeUOR/nzZ9K1oVQbjQF8O1c4A04Gp5rE/yBYfbFxo8+t7ad9QcbNOPeI LJ74b9SqvN5ZoN9+5j5wa9A5Yt3PTJd0tKuUAEt/MmRLmekgtozmQ7iFJ BgIHQS1zK6iaRuAI17UYng7mdvNJ8UBfwIZ3KW+C2/mStH4RvZzSrGRFf g==; X-IronPort-AV: E=McAfee;i="6400,9594,10390"; a="261798536" X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208,217";a="261798536" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 00:27:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208,217";a="732206831" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 27 Jun 2022 00:27:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 27 Jun 2022 00:27:31 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 27 Jun 2022 00:27:31 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 27 Jun 2022 00:27:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRp5aTw3fQqjYaiUiSQDkwcswdLWKXnhBm8KXWfopXPku8XRu+OSyhuibLivOh3ETjBGqcYcx51Ns9CKnTxHNqILo8I+lSYcYcx+GhfE+OzKP2bAQW5ZPMS46rwdwj00PC0d4lyAgSSbusKZmotq+HUYwx5/C2J1dFvfdbbFOIGgHTfdcuNSDFUnVb+sDeBy5W7p4oXTs4HxoeMHKvCOTU6FHxzD8aDC33dEIu4p47OHO3gvz+YQsxDDk4KzLWIehWv4OghumSyD0KIph98XUfRdbA0fV2z6fxsQWXEsMEOnd18LDTHoJApkkr7hz15Ut/ccHwXlBohCUHY8deNJKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+fwmbAx+YoTIeJiGLEewebT7qQE8XRqHy4Xrar1LkYA=; b=hMK9IlvrAkJCH11SQBvoATJ5pR9voaYBxQ4ear+G6R3Tif1Gd2/lHYtUiPzDhM7ZzBeAq7AGJqZpsRfAHIlf5U+wjYRrTMxULSTd2ZEO8Y5XU9tJM55YBcQZ+5ho8XizftafBQqf+HFAvRVxUK+ieFe6JgcA0ETFcjOYzU136wl0cyR+tnV/NzoqhJpP/kMPzmV/7r+4eHg3/3KBdeTpwh9dJgb3Tp741VdXkooocEVBhf9zB9MKNeSo9tCx8FQO3AcsW7sd0zQ9FQvXpeBf/uaWVyoGVq8wwo4kRAG7kSOet7hXvzmG+QjVUWzYN99oyRQIN/UCu3ahDEXOgbqapQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by CY5PR11MB6281.namprd11.prod.outlook.com (2603:10b6:930:23::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Mon, 27 Jun 2022 07:27:29 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::5c7b:2e99:cc21:ae28]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::5c7b:2e99:cc21:ae28%4]) with mapi id 15.20.5373.018; Mon, 27 Jun 2022 07:27:28 +0000 From: "Guo, Gua" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Lu, James" Subject: Re: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec Thread-Topic: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec Thread-Index: AQHYidNYFqtq0Jfue0OFnPJvGiCUba1inJgAgAAFO7CAAA/NQIAAH6uAgAAJVOA= Date: Mon, 27 Jun 2022 07:27:28 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-Mentions: ray.ni@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 993e66ad-6046-44b8-ecf4-08da580e7d83 x-ms-traffictypediagnostic: CY5PR11MB6281:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Nbq0c4bZYLrHk3p9Mi74SFOnzqTk6Bkrg90JxNHYIWC+YRizGXgDg/ZMxCGaKT99v+plEf36Hy1Q0ktC61Pg2/JC3hrrzfjKOywQBPojHEXuI9hA8eH5P2RE742VevpGVFUFZS5aaBfc55n4pFr4nVsf5yLr+8nxe70DxNFtx1W8Blvy6P3ji7Hcq768ZxI0Blfv4YP8CnGwrsCEilPdaPrHptipi9SOP3ooluTPz4cAsS7F560MoJ2xpeKIOl/9udsdWtrZJog/DwEYAxJyO5eYwKyPKi5GGmrw3GPvIO1oOsPTA/6c07KKMA2pvDMuCzYREuGkkAZBFJfzEIF1muSlbOOlsUenHBvtuB5Ptb0/NCqtxikZnA+51T4I+B/ezDArnqXDpjnKc1wVH3DkpayhQkguYDd4TPklOIENkvJZ57DH9G6GXVfLvx5Vyf+5xIPP55QpDXd/13F0wqA7Nfeura4AGf+R5EFzU60KcNtrA4sMP2AR06I133ary294EwGvZxK+832iQeS5iOqIIytf/t1t/mqDVqHLa+Vhsca7+MaZabqFfDY3k+cK2ri34DQ8hwQudsoJJziKor/qcdE4pvNwxzrZ9Li32AJAvsghr6hVi4iIRxvpESjczn/RX8ben8oB8gDhcy69DTJi9iZkfZzq/bkaHl5DDFefd5JABrmN6eahusgKB6KwS3VzZVnKz9x0CeQ2QfRGdTOQM2Bjh6M0IuepPwQPDaC9XFyQUXh0bm9qeaN0ZXO3qKCjZaBsoW2HYV7Uha5aaay7iTytvgu0r9a0hlfUHa8WpSTQU6gpsBntXJK8hSB0zCYmFCsv2hV2aONNEtA18jRKJQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(136003)(39860400002)(366004)(41300700001)(86362001)(7696005)(6506007)(38100700002)(8936002)(82960400001)(55016003)(5660300002)(110136005)(53546011)(54906003)(122000001)(83380400001)(186003)(2906002)(107886003)(966005)(478600001)(52536014)(38070700005)(76116006)(66446008)(4326008)(64756008)(66556008)(66476007)(66946007)(8676002)(9686003)(316002)(26005)(33656002)(166002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KFt73sDb97oPrNNH3nxhiEuh44XylJd47SOGc1Zi14qCbHO0VHvcNe6BrPI+?= =?us-ascii?Q?8zx0IlcutlB8LxeFHj6UmQsztmFhEcAPJYlS+iGCtXEIKE+pHj4G+4YsRPLW?= =?us-ascii?Q?Pb8eD+c6wdiHg4N51lVd1N/RwT9Ar+0kRmp3uOnSYX7r1JPHYceJd1TJyu3d?= =?us-ascii?Q?cKp884FM4zpzlFTyGJymbQ5uUgxFd84ih2uui/uGjiC6Oo1lIMmBPi09mzRe?= =?us-ascii?Q?43XzBocxIltwcm9UEb7eq/vaEUsIhsvYJp9T5WRfDh7wqqKicNFGVyJIHwkO?= =?us-ascii?Q?mb3fow9rdTD/9aIcG/VOsj7mtz4G8n2Xo2yKUb1mvcBdT7a/n5rId3xqhl+/?= =?us-ascii?Q?8AcaTSb+ULkLVLrE7PwwbSk3gyQUFg9pgHCAPbhqKhL6h4mN+EVCHcGRc/wp?= =?us-ascii?Q?9RI5vhE6/ZKvMkVtnYMA44p2ndTn41XToD9sunBDRXSBzffmn+ZRWeEHwyZO?= =?us-ascii?Q?AbP5Uhsnh08CLwO2qY+p4NEn/3m0izcd9NbddotmRAZe21Mb73LH2UcouoyQ?= =?us-ascii?Q?BXA9yK15hJrefnoKsSXFldtg54WUXN61F3nov9wH8DlX/+QjXQKWeF4eqNk6?= =?us-ascii?Q?QRiEPawHx2Un9p1/BsE9nDsVQcxiFyO09xgthKrTQQGlCq55QtHyvPgOCZ7k?= =?us-ascii?Q?Bl2J3PQGqrPyXraSp8HByRVIP4tmeJDq5y2k+q/CJj3aG1r/aVLQoKicqiUi?= =?us-ascii?Q?Ib1XmTFFM/wvPlBQ0eVHtychhzYAawoZVS8RvFDm50HXDQh50XZqiS/3fmR7?= =?us-ascii?Q?G2yq+i5/V0H0LnIhusGnb9BC/vbOg6iwoZTvEbYneHzKrA26QG+un81osc7f?= =?us-ascii?Q?/wA0r1ieIboKBn/cpGBtDRlGnOO2e9tphCLcvyY+XQwIjodA254tH1dN1W23?= =?us-ascii?Q?zDC1mt5IiXmhpDxFdbkUr/IzqM31Xqwa4V66TvN7/Ar52Mu+DCQD8tV7U8iQ?= =?us-ascii?Q?MYcV3jZf+RYZsQdyooDgldlRotUe6uncOcD0vtoIpwIhyDBbRVqBE9g+VK/C?= =?us-ascii?Q?GrCB3p4h0v1CYqI+6wVp8TrhnvG3Y+QWGeWCldwfW0rKsO/CbwLDckonHFar?= =?us-ascii?Q?CtcE67RNZlkUPI0enmjS86cmVxGsWQyi3feMAPC/WZWpQTF7pz7W0XDvTgSH?= =?us-ascii?Q?3xTbkosdivRTd1cWFXbTt4ikTCVuq0pHgrIeUEdyS6AZM5rv0nmyOrHNy5Ed?= =?us-ascii?Q?UQL4hatmvjtSYRRkJLz2ae58u4Ud1AlkK+8hoYIfMxMlmCuEQmAuPiO5GPax?= =?us-ascii?Q?xypleIm1Bpu7sQHg5fBDbvxImsbU7Tz8EkA2bDzYbipZvv93tojc+FPCGMU6?= =?us-ascii?Q?F9SLrJIR7MNDl8ECn86/F0hl1fESLjI9Sgo3ULa6wd1ira5R9pcCFC7SYZHz?= =?us-ascii?Q?U0YHk6R0opU8Ds8GJpIn6GKQgIW0sggk2g9xPm+8yjLADdF6UIpStt4GDFrQ?= =?us-ascii?Q?JnsKOZ6N3/Oyua201NNXTj4wDX9I1Z9KALMoW26FHzCNmn9PrTlmLInHXL8B?= =?us-ascii?Q?4yDGu5p5oEj9C1GpzkjyMAYzRatfLrQ8nTQ5KP5vJFmEY0QCQkTpwfwsO2xG?= =?us-ascii?Q?WxQG7Kbq1bou8PKVUZA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 993e66ad-6046-44b8-ecf4-08da580e7d83 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2022 07:27:28.4462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZEcf0UTdtkp8FgRMErAj7BO0SNm5eP0YeLv6cCfWTsucXWmPUTzgm5sORoFle1bXdZ8GfgoS9FYD/gvM7pv8Fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6281 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BL1PR11MB547819223EACD7D99FC1AD87EFB99BL1PR11MB5478namp_" --_000_BL1PR11MB547819223EACD7D99FC1AD87EFB99BL1PR11MB5478namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable @Ni, Ray Below url is pull request link. May I get your help to add push label ? Ha= ve any concern, please also share for me. URL: https://github.com/tianocore/edk2/pull/3015 Thanks, Gua -----Original Message----- From: Ni, Ray Sent: Monday, June 27, 2022 2:53 PM To: Guo, Gua ; devel@edk2.groups.io Cc: Dong, Guo ; Lu, James Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec Reviewed-by: Ray Ni > > -----Original Message----- > From: Guo, Gua > > Sent: Monday, June 27, 2022 1:03 PM > To: Ni, Ray >; devel@edk2.group= s.io > Cc: Dong, Guo >; Lu, James = > > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL > spec > > Yes, #2 is chosen in by the python interpreter. > > -----Original Message----- > From: Guo, Gua > Sent: Monday, June 27, 2022 12:07 PM > To: Ni, Ray >; devel@edk2.group= s.io > Cc: Dong, Guo >; Lu, James = > > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL > spec > > The python logic will like for below > > > upld_info_hdr.Attribute |=3D 1 if BuildTarget =3D=3D "DEBUG" else 0 > =3D=3D=3D=3D=3D=3D=3D=3D=3D> > > if BuildTarget =3D=3D "DEBUG": > > upld_info_hdr.Attribute |=3D 1 > > else: > > upld_info_hdr.Attribute |=3D 0 > > Thanks, > Gua > > -----Original Message----- > From: Ni, Ray > > Sent: Monday, June 27, 2022 11:44 AM > To: Guo, Gua >; devel@edk2.gr= oups.io > Cc: Dong, Guo >; Lu, James = > > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL > spec > > > + upld_info_hdr.Attribute |=3D 1 if BuildTarget =3D=3D "DEBUG" else = 0 > > > I am not python expert. Above statement might be interpreted as: > 1. (upld_info.hdr.Attribute |=3D 1) if BuildTarget =3D=3D "DEBUG" else 0 = 2. > upld_info_hdr.Attribute |=3D (1 if BuildTarget =3D=3D "DEBUG" else 0) > > Are we sure that the #2 is chosen in by the python interpreter? --_000_BL1PR11MB547819223EACD7D99FC1AD87EFB99BL1PR11MB5478namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

@Ni, Ray

Below url is pull request link.  May I get your help to add push label= ? Have any concern, please also share for me.

URL: https://github.com/tianocore/edk2/pull/3015

Thanks,
Gua

 

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, June 27, 2022 2:53 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com&= gt;
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

 

Reviewed-by: Ray Ni <ray.ni@int= el.com>

 

> -----Original Message-----

> From: Guo, Gua <gua.guo@i= ntel.com>

> Sent: Monday, June 27, 2022 1:03 PM

> To: Ni, Ray <ray.ni@intel.= com>; devel@edk2.groups.io

> Cc: Dong, Guo <guo.dong@= intel.com>; Lu, James <james.lu@intel.com= >

> Subject: RE: [PATCH] UefiPayloadPkg: Align A= ttribute value with UPL

> spec

>

> Yes, #2 is chosen in by the python interpret= er.

>

> -----Original Message-----

> From: Guo, Gua

> Sent: Monday, June 27, 2022 12:07 PM

> To: Ni, Ray <ray.ni@intel.= com>; devel@edk2.groups.io

> Cc: Dong, Guo <guo.dong@= intel.com>; Lu, James <james.lu@intel.com= >

> Subject: RE: [PATCH] UefiPayloadPkg: Align A= ttribute value with UPL

> spec

>

> The python logic will like for below

>

> > upld_info_hdr.Attribute |=3D 1 if Build= Target =3D=3D "DEBUG" else 0

> =3D=3D=3D=3D=3D=3D=3D=3D=3D>

> > if BuildTarget =3D=3D "DEBUG"= :

> >   upld_info_hdr.Attribute |= =3D 1

> > else:

> >   upld_info_hdr.Attribute |= =3D 0

>

> Thanks,

> Gua

>

> -----Original Message-----

> From: Ni, Ray <ray.ni@inte= l.com>

> Sent: Monday, June 27, 2022 11:44 AM

> To: Guo, Gua <gua.guo@int= el.com>; devel@edk2.groups.io

> Cc: Dong, Guo <guo.dong@= intel.com>; Lu, James <james.lu@intel.com= >

> Subject: RE: [PATCH] UefiPayloadPkg: Align A= ttribute value with UPL

> spec

>

> > +    upld_info_hdr.Attri= bute |=3D 1 if BuildTarget =3D=3D "DEBUG" else 0

>

>

> I am not python expert. Above statement migh= t be interpreted as:

> 1. (upld_info.hdr.Attribute |=3D 1) if Build= Target =3D=3D "DEBUG" else 0 2.

> upld_info_hdr.Attribute |=3D (1 if BuildTarg= et =3D=3D "DEBUG" else 0)

>

> Are we sure that the #2 is chosen in by the = python interpreter?

--_000_BL1PR11MB547819223EACD7D99FC1AD87EFB99BL1PR11MB5478namp_--