public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo, Gua" <gua.guo@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"benjamin.doron00@gmail.com" <benjamin.doron00@gmail.com>,
	"Hsieh, PaytonX" <paytonx.hsieh@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true
Date: Thu, 27 Apr 2023 22:38:56 +0000	[thread overview]
Message-ID: <BL1PR11MB5478207EA1D0A40196DBBD89EF6A9@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8437.1682616986321607120@groups.io>

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

Hi Payton

For BaseSerialPortLibHob.inf please use BaseSerialPortLibHob.c
For DxeSerialPortLibHob.inf please use BaseSerialPortLibHob.c and DxeSerialPortLibHob.c and remove redundant code.

Have any limitation, please share for us.

Thanks,
Gua

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron
Sent: Friday, April 28, 2023 1:36 AM
To: Hsieh, PaytonX <paytonx.hsieh@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

Hi,
Can you deduplicate this code by moving the functions into a common, or "base" file, and DXE's constructor and event into a separate file? As I see it, it should be alright to reuse DXE's functions for other phases, the `mBaseSerialPortLibHobAtRuntime` variable will never be changed in this case.

Regards,
Benjamin


[-- Attachment #2: Type: text/html, Size: 3943 bytes --]

  reply	other threads:[~2023-04-27 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27  6:13 [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true paytonx.hsieh
2023-04-27  6:17 ` Guo, Gua
2023-04-27 17:36 ` [edk2-devel] " Benjamin Doron
2023-04-27 22:38   ` Guo, Gua [this message]
2023-04-28  2:33   ` Hsieh, PaytonX
2023-04-28 13:54     ` Benjamin Doron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL1PR11MB5478207EA1D0A40196DBBD89EF6A9@BL1PR11MB5478.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox