public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo, Gua" <gua.guo@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	"Barkelew, Bret" <bret.barkelew@microsoft.com>,
	Michael Kubacki <mikuback@linux.microsoft.com>
Subject: Re: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
Date: Tue, 13 Sep 2022 15:20:15 +0000	[thread overview]
Message-ID: <BL1PR11MB547832580F92894924FE48D7EF479@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB4929F4E9D3B461D185A27F5DD2479@CO1PR11MB4929.namprd11.prod.outlook.com>

Sure, thanks for replying quickly, let me update readme.md file in my next patch.

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Tuesday, September 13, 2022 11:10 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret <bret.barkelew@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>
Subject: RE: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

Hi,

This change looks safe because it is scoped to host-based unit tests that include this file in the DSC file that builds host-based tests.

Can you also update the UnitTestFrameworkPkg/ReadMe.md to describe how a developer can enable/use the code coverage feature for GCC host-based tests?

Mike

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Tuesday, September 13, 2022 6:24 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; 
> Barkelew, Bret <bret.barkelew@microsoft.com>; Michael Kubacki 
> <mikuback@linux.microsoft.com>
> Subject: [PATCH] UnitTestFrameworkPkg: Add code coverage support for 
> GCC
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> In order to collect code coverage after running executable file, 
> generate *.gcda and *.gcno file that require by lcov tool to generate 
> code coverage report.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc 
> b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> index 4dd8d4ac67..8623aecb33 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> @@ -19,7 +19,7 @@
>    
> MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocatio
> nLibPosix/MemoryAllocationLibPosix.inf
> 
> 
> 
>  [BuildOptions]
> 
> -  GCC:*_*_*_CC_FLAGS = -fno-pie
> 
> +  GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs
> 
>  !ifdef $(UNIT_TESTING_DEBUG)
> 
>    MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1
> 
>    GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1
> 
> --
> 2.31.1.windows.1


      reply	other threads:[~2022-09-13 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 13:24 [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC Guo, Gua
2022-09-13 13:28 ` Guo, Gua
2022-09-13 15:11   ` Michael D Kinney
2022-09-13 15:19     ` Guo, Gua
2022-09-13 15:10 ` Michael D Kinney
2022-09-13 15:20   ` Guo, Gua [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL1PR11MB547832580F92894924FE48D7EF479@BL1PR11MB5478.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox