From: "Guo, Gua" <gua.guo@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>, "Lu, James" <james.lu@intel.com>
Subject: Re: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Date: Mon, 27 Jun 2022 05:03:05 +0000 [thread overview]
Message-ID: <BL1PR11MB547842CA78123EFC56E2D383EFB99@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BL1PR11MB54784DA2F70BEB692253D496EFB99@BL1PR11MB5478.namprd11.prod.outlook.com>
Yes, #2 is chosen in by the python interpreter.
-----Original Message-----
From: Guo, Gua
Sent: Monday, June 27, 2022 12:07 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
The python logic will like for below
> upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
=========>
> if BuildTarget == "DEBUG":
> upld_info_hdr.Attribute |= 1
> else:
> upld_info_hdr.Attribute |= 0
Thanks,
Gua
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, June 27, 2022 11:44 AM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
> + upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
I am not python expert. Above statement might be interpreted as:
1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2. upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0)
Are we sure that the #2 is chosen in by the python interpreter?
next prev parent reply other threads:[~2022-06-27 5:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 3:09 [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec gua.guo
2022-06-27 3:43 ` Ni, Ray
2022-06-27 4:06 ` Guo, Gua
2022-06-27 5:03 ` Guo, Gua [this message]
2022-06-27 6:52 ` Ni, Ray
2022-06-27 7:27 ` Guo, Gua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR11MB547842CA78123EFC56E2D383EFB99@BL1PR11MB5478.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox