From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.14772.1671428054212869054 for ; Sun, 18 Dec 2022 21:34:14 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jAe8I/BU; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671428054; x=1702964054; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/32Oc+Ta3kPleDothHbbZGqORt6MnyYlV+UAzWgS6ds=; b=jAe8I/BUslUsG2pdPdXxcMcayi1RhlnV4dQ9NzBFj3MO7CVX6bEUFmzs oNoM/fDvfB3XpLoTi7m24Hl1p/88Ktvp6TrMOaMU3qxF2y7bL6gVqYZaM 0+Pg2cK/tzAAaT6bYSFMk7I9b39GHz66eh/CtUAHe7BV5vr0HWdBEBOAA sJ0pZduNqMh1hDcCM4Gl4pxEE4alJ2d/b/D3WYa9n8IEa+pC2YcSu7E7h 4LV5nMnuETdDIInB+Y9muLDYAxcVGDYou/aUF8rweS/RQwXbn8Jolxy/9 WYVzhtji75+O49VvgFmC3himuIBRpSSZjuQnrfoWIPsyaFPHfNcihcURi Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="320445826" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="320445826" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 21:34:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="718985061" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="718985061" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 18 Dec 2022 21:34:12 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:34:12 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:34:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 21:34:11 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 21:34:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfByBkl/yV/IAJx3+U+btEqy2Kw9lanWPl5/52JjmIVpu2v+ubNEKKvMKoYZPsI8az+oiBWf/p5Ep/IS09DwyLRm3YP4s7ssVGG4YYqhSCfFLXFDBPIx0yhZ4PJPZX6XHmOFL3U3w2JFoMQkUXed8VD16+i3cct9wpjg0EpdbsmzJENJe+APnejDImrx4MUqAxXnfvdVWqHOD02d3D2jc37XaOguUdqZLG7im6oUPqXuKhBIyVz9yEYRebdRn6LVzGgoSVAy5r5CIBwxc1SMMkkAF0SZ3VDRoFBmYFsIkQG2yM0I+V6NeILOjhCsEapoqhQyYMujqeK0zz0qn9GGeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zgqq/fGTCfTJFG7GROEDN9ZvZ7OkSCUrLNx+wzfNob4=; b=FDpzRReHDLZudOZUNFWK7FPiPho9ChwBm1DQiAn2SOg6MHg2T1mWyWLYjPjt5DyQ9bRD0AE4u5ietH7Xj2V/JeszJgZB+m4XiHyHUbKsaWz2oTscLlX5dO0orFl+Tt9gylmxBqJxwpgpaDX4gdOHqxtktnlk7W8kpzpjzpV4tTonLaH02VJzZvtCJfBWDnFX2iW14H6nSrfQaat1Kr9FH/b7z5PLpSnagQQJYsTsq0J0+ogtZcb75mB0YjufW7LCXEthIufP9YHYEtVhBkCv/T9e45MHWLe3aJCrg2XGVuI94y+TMQtmGE7QIIquoLs4f3JDC+gUf7/jcCNWRKAOCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by DS0PR11MB8232.namprd11.prod.outlook.com (2603:10b6:8:15d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 05:34:08 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::eb2d:a316:8bcd:3fb6]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::eb2d:a316:8bcd:3fb6%8]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 05:34:08 +0000 From: "Guo, Gua" To: "Liu, KasimX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ni, Ray" , "Lu, James" Subject: Re: [PATCH] UefiPayloadPkg: Remove RTC_INDEX/TARGET from UplBuild macro list Thread-Topic: [PATCH] UefiPayloadPkg: Remove RTC_INDEX/TARGET from UplBuild macro list Thread-Index: AQHZD5U9BaWHgiOPCUCT+DIDRMOtBK50t04Q Date: Mon, 19 Dec 2022 05:34:08 +0000 Message-ID: References: <9259691a5fbc572a4852e9c3e3a5a4f04927f609.1671005803.git.kasimx.liu@intel.com> In-Reply-To: <9259691a5fbc572a4852e9c3e3a5a4f04927f609.1671005803.git.kasimx.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|DS0PR11MB8232:EE_ x-ms-office365-filtering-correlation-id: 546a1ed3-4f29-4571-1973-08dae182a676 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qql+uRxjn3A/H43EFIE0eFMd9czMOIEencjJBFfP5IecpQ4yJP0ER5JjA+g4exi97I6oMSn67ThKvd8Lk8AgW/VIppBuFi3uO1JVArz0ieicL68+R7TNraXUpYA9mypMVilWMYWf7253rjBgG716t/hvV0Rl6tIDxfT+RsRj6vw2sBZgGCmHgG9E05DEiA4YySntlU02yB6sf/kd0r4h5P/ZL7SGyDhI7BGLyPqn2ybny3prUrAdhgBRl7GIBueTnpBjou92mJZHzmZd8Jp5ziTEoNzVvix9W1ryKmRmNT32buEKtKZsQ+CYRilleRs0QOAM8R8c1f3Cgtw7yCuz5R0mgTB13rTYmvsp5BKr/ZVAjsON/UjnODEYf/eFGBx8d3DNPjcPAbGzLOzHoPUWxO2nd6uzcDUKYH+Z8DP6vZvXyjEwVZOzh0K0KvGPtoF/XMi63WhzwgQv36BSy2cjhzpmtchUvfo8cSudlcYIzDk73IYosJEX7XDCcCtLo1mS68UMkql1GGKY9pKD9g7fW03oUmrZ39f0hrFuqQHmm11LOxyn/jpnLdF3n0yS5xbiePYy0nTBqL0T1OKiicy88oNHf1e7xY9Hu4lYyYFCZRmtuvUcdvVtfsjKknytPJE+CsPrm0YM5yLEGkY9+vDMP5QMpKM8NwVW2xa47n2f9iPwUIXbBBBcob5eW3qIyWF3nrr2XeZXmu6RSn7VEb1KRlhL+TCcQ5F3w/8tw5dv6Lw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(376002)(396003)(39860400002)(451199015)(2906002)(38100700002)(82960400001)(55016003)(122000001)(54906003)(110136005)(478600001)(966005)(52536014)(316002)(8936002)(5660300002)(66446008)(66476007)(86362001)(66556008)(64756008)(66946007)(76116006)(8676002)(4326008)(83380400001)(26005)(38070700005)(71200400001)(53546011)(33656002)(41300700001)(107886003)(6506007)(9686003)(7696005)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CcPTYN9AB8QBIxO1k8hGYxIYeSobq+IUic12l6cSMTmHrtWubAmzgTDjFUki?= =?us-ascii?Q?aeozz5sBuR/p2jR/MjllpwwIpUJMvwLM7ktjziDkv1auwWMh6h4NlTi6DoTs?= =?us-ascii?Q?3EYBjSVIH4s4+yiShL+TMxmlP/mKpwxLgZof1hyh6I62dCM0f1ypzfn4KmHr?= =?us-ascii?Q?s93WcSKYnQ7h8cObOdPLICSFt+reiYoY1kiVWpwg3sKibF0+2smV0K3OPCEg?= =?us-ascii?Q?sQsMVKcQgsph9/GuxbNCFIJ0kcS6zZMWbbysFsFDjTOsXpq14orsSgeMVrLm?= =?us-ascii?Q?Q7tGX4O7ATotgd5Tat0lvroW8Cova4Sx09FLrisZH3wOdhB3aqMdeQe4zXa7?= =?us-ascii?Q?phCfLuwAxY/wJC6UssNXdgmLIyOfqu5jPkUNTP8f0ZcegiMdW4pYFqPRdl+X?= =?us-ascii?Q?ZBg3yWvVBSQP24etz9jMMgnKHSlDj8kT8oDL5YdLkpWvPg6CGgkzK0ugsecq?= =?us-ascii?Q?N0C/G1MmfxJ7f8ngHzOIzuMM8m1q3fMpHGxLFrf5u3TvGo7QXRtLNTyOrp4t?= =?us-ascii?Q?o5+EQgf58iEPRselO8wysTxa3FlQyIkEjinkU0eLNFN8WbcdELaRvuBO2+Yr?= =?us-ascii?Q?B1gTArvMFj5Y+xEo+WAgM03Gtp2n7a5jaHrHPoqlqbAHjRPVNwpID8KR88ds?= =?us-ascii?Q?6Uza+DSDmZ6i32b8cuf86+ceyh704WQMzvoLJoyY2U9Pk6ehdrKSBgtIr17n?= =?us-ascii?Q?4C6xMtQSjEg/p14sy6aPnu8R2dS45hn6ZaVHtYWvwlatIddQ+jiIYYwduhTk?= =?us-ascii?Q?/o6S50GyrLhG9Y4StSKVY9+iKXpg45EZqb2rKtL3E3MtYS46P6w8ZrtxgITj?= =?us-ascii?Q?gb2IwylqXJerkGq7LFXdYUOcgQSLzZ+ZpL0IIsXJrCfPMYFZqr0HYvMQJB+l?= =?us-ascii?Q?/prm8igGsZbitD5lq/szwaFxF82Jm957ZU5StwpMbLt9QNKxdfFwk3ewOlEM?= =?us-ascii?Q?CB3eECgJvuGv18pVVcl8heqI/7cIvErmwZLdBAyrdZzWyse3M6XmXe0n+ofn?= =?us-ascii?Q?QtKHxecpOvXw/SwFExC5X5ZRA0f6Yab1Sd4GTK9PgN0kQVzuqepXpzn44JlB?= =?us-ascii?Q?aLlPt6EcgcELi/sX3uOkXcpPGR/xGgpdp9tPbYJMDRcQKc/8dgVGioO6DnF1?= =?us-ascii?Q?q7+0mpdyPvAqMfOWPPyeUf1/ZZAa2T47RH32qQVQXU2VjZCnhJW0ZjlefBvp?= =?us-ascii?Q?NMHmnHLWEUp6CcBxL3B0hmSRtdpe7dy+jU960ODbfcmGHFKm3MMa9J9wCjD4?= =?us-ascii?Q?WmEuOoB6v7vGEX0iWnPOGt8v08XdtM2Lj7aD802rAbtuAYtPU3HCrkRMdCLp?= =?us-ascii?Q?j6T/w8wmqm1CqpIrVY+7kG9o9XdAEucsTtaegPShVJ7iG1Kx274W7cAXcE7j?= =?us-ascii?Q?LKjd/wQSreNPu9wz5dvznETcwq0dDJpLkjXnbcfFNpXSyiEe5gFPvDig3uD4?= =?us-ascii?Q?OwSNEPtqDcC9WSGxifpE+YOmaLXUZ2T16wj19KBbE3yH8JzIc73/OpbwXXwx?= =?us-ascii?Q?G6NzktLCF8vq2jTqJ4cEAyGNscMTPI4xT7c7U/EuyylhCSEeVgwJOCEr5t6k?= =?us-ascii?Q?oPHbl8d/PFUOqK9vpjY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 546a1ed3-4f29-4571-1973-08dae182a676 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 05:34:08.0633 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 34mVQE7b3oU5lPRu6NswpupNUnIEz6ORfBXpkhbSVjyb3JKggEztQVRRjFa1PKOt+UC/I1OyDoaiOU3yaGpGhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8232 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Gua Guo =20 Please send two commits into one PR. First commit "PcAtChipsetPkg: Move RTC PCD to dynamic PCD" Second commit "UefiPayloadPkg: Move RTC PCD to dynamic PCD" -----Original Message----- From: Liu, KasimX =20 Sent: Wednesday, December 14, 2022 4:22 PM To: devel@edk2.groups.io Cc: Liu, KasimX ; Dong, Guo ; Ni,= Ray ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Remove RTC_INDEX/TARGET from UplBuild macr= o list From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4193 In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change= the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX Liu --- PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- UefiPayloadPkg/Ue= fiPayloadPkg.dsc | 5 +++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec b/PcAtChipsetPkg/PcAtChipset= Pkg.dec index ed2d95550b..a53ca777e8 100644 --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec @@ -84,6 +84,14 @@ # @Prompt RTC Target Register address gPcAtChipsetPkgTokenSpaceGuid.Pc= dRtcTargetRegister64|0x0|UINT64|0x00000023 + ## Specifies RTC Index Regist= er address in I/O space.+ # @Prompt RTC Index Register address+ gPcAtChip= setPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001E++ ## Specif= ies RTC Target Register address in I/O space.+ # @Prompt RTC Target Regist= er address+ gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|= 0x0000001F+ [PcdsFixedAtBuild, PcdsPatchableInModule] ## Defines the ACPI= register set base address. # The invalid 0xFFFF is as its default value= . It must be configured to the real value.@@ -146,14 +154,6 @@ # @Prompt Initial value for Register_D in RTC. gPcAtChipsetPkgTokenSpa= ceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0x0000001D - ## Specifies RT= C Index Register address in I/O space.- # @Prompt RTC Index Register addre= ss- gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001= E-- ## Specifies RTC Target Register address in I/O space.- # @Prompt RTC= Target Register address- gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegist= er|0x71|UINT8|0x0000001F- ## RTC Update Timeout Value(microsecond). # @= Prompt RTC Update Timeout Value. gPcAtChipsetPkgTokenSpaceGuid.PcdRealTim= eClockUpdateTimeout|100000|UINT32|0x00000020diff --git a/UefiPayloadPkg/Uef= iPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 723a50a422..82cff41780 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -471,8 +471,6 @@ !endif [PcdsPatchableInModule.X64]- gPcAtChipsetPkgTokenSpaceGuid.PcdRtc= IndexRegister|$(RTC_INDEX_REGISTER)- gPcAtChipsetPkgTokenSpaceGuid.PcdRtcT= argetRegister|$(RTC_TARGET_REGISTER) !if $(NETWORK_DRIVER_ENABLE) =3D=3D TR= UE gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE !endif@@ -57= 9,6 +577,9 @@ gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|0 gEfiMdeModulePkgTokenSpa= ceGuid.PcdPciDisableBusEnumeration|TRUE + gPcAtChipsetPkgTokenSpaceGuid.Pc= dRtcIndexRegister|$(RTC_INDEX_REGISTER)+ gPcAtChipsetPkgTokenSpaceGuid.Pcd= RtcTargetRegister|$(RTC_TARGET_REGISTER)+ #################################= ############################################### # # Components Section - li= st of all EDK II Modules needed by this Platform.--=20 2.32.0.windows.2