From: "Guo, Gua" <gua.guo@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v3 0/2] Add more google mock library
Date: Tue, 9 May 2023 22:56:13 +0000 [thread overview]
Message-ID: <BL1PR11MB54785BEE3D35E421C94ECB4AEF769@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR11MB4944280E9CD39930C39E7F3DD2769@SJ0PR11MB4944.namprd11.prod.outlook.com>
Add Reviewed-by message on https://github.com/tianocore/edk2/pull/4335/commits
Wait for push label. It can be checked in.
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Tuesday, May 9, 2023 8:17 AM
To: devel@edk2.groups.io; Guo, Gua <gua.guo@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [PATCH v3 0/2] Add more google mock library
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo,
> Gua
> Sent: Monday, May 8, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>
> Subject: [edk2-devel] [PATCH v3 0/2] Add more google mock library
>
> From: Gua Guo <gua.guo@intel.com>
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4443
>
> PR: https://github.com/tianocore/edk2/pull/4335
>
> V3
> Remove EBC and fix some coding rule
>
> V2:
> Fixed Azure build failure
>
> V1:
> Add google mock support for HobLib
> Add google mock support for PciHostBridgeLib Add google mock support
> for PeiServicesLib
>
> Gua Guo (2):
> MdeModulePkg: Add more PciHostBridgeLib gmock support
> MdePkg: Add more HobLib/PeiServicesLib gmock support
>
> MdeModulePkg/MdeModulePkg.dec | 1 +
> MdeModulePkg/Test/MdeModulePkgHostTest.dsc | 5 +
> .../GoogleTest/Library/MockPciHostBridgeLib.h | 40 ++++
> .../MockPciHostBridgeLib.cpp | 14 ++
> .../MockPciHostBridgeLib.inf | 35 ++++
> MdePkg/Test/MdePkgHostTest.dsc | 2 +
> .../Include/GoogleTest/Library/MockHobLib.h | 150 ++++++++++++++
> .../GoogleTest/Library/MockPeiServicesLib.h | 189 ++++++++++++++++++
> .../GoogleTest/MockHobLib/MockHobLib.cpp | 30 +++
> .../GoogleTest/MockHobLib/MockHobLib.inf | 33 +++
> .../MockPeiServicesLib/MockPeiServicesLib.cpp | 36 ++++
> .../MockPeiServicesLib/MockPeiServicesLib.inf | 32 +++
> 12 files changed, 567 insertions(+)
> create mode 100644
> MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib
> .h
> create mode 100644
> MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockP
> ciHostBridgeLib.cpp
> create mode 100644
> MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockP
> ciHostBridgeLib.inf
> create mode 100644
> MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h
> create mode 100644
> MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h
> create mode 100644
> MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp
> create mode 100644
> MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.inf
> create mode 100644
> MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServices
> Li
> b.cpp
> create mode 100644
> MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServices
> Li
> b.inf
>
> --
> 2.39.2.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2023-05-09 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 0:03 [PATCH v3 0/2] Add more google mock library Guo, Gua
2023-05-09 0:03 ` [PATCH v3 1/2] MdeModulePkg: Add more PciHostBridgeLib gmock support Guo, Gua
2023-05-09 0:03 ` [PATCH v3 2/2] MdePkg: Add more HobLib/PeiServicesLib " Guo, Gua
2023-05-09 0:17 ` [edk2-devel] [PATCH v3 0/2] Add more google mock library Michael D Kinney
2023-05-09 22:56 ` Guo, Gua [this message]
2023-05-10 0:42 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR11MB54785BEE3D35E421C94ECB4AEF769@BL1PR11MB5478.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox