public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo, Gua" <gua.guo@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"pierre.gondois@arm.com" <pierre.gondois@arm.com>
Cc: "Dong, Guo" <guo.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	"Rhodes, Sean" <sean@starlabs.systems>
Subject: Re: [edk2-devel] [PATCH v2 16/17] UefiPayloadPkg: Remove duplicated words
Date: Mon, 12 Sep 2022 04:26:01 +0000	[thread overview]
Message-ID: <BL1PR11MB547874BA662893BFB01E0692EF449@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220906082912.81795-17-Pierre.Gondois@arm.com>

Reviewed-by: Gua Guo <gua.guo@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois
Sent: Tuesday, September 6, 2022 4:29 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois <pierre.gondois@arm.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: [edk2-devel] [PATCH v2 16/17] UefiPayloadPkg: Remove duplicated words

From: Pierre Gondois <pierre.gondois@arm.com>

In an effort to clean the documentation of the above package, remove duplicated words.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 UefiPayloadPkg/Include/Library/SpiFlashLib.h        | 2 +-
 UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.c    | 2 +-
 UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c  | 2 +-  UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c  | 2 +-  UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c  | 2 +-  UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c | 6 +++---
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/UefiPayloadPkg/Include/Library/SpiFlashLib.h b/UefiPayloadPkg/Include/Library/SpiFlashLib.h
index 07f40502f251..8906dad043b0 100644
--- a/UefiPayloadPkg/Include/Library/SpiFlashLib.h
+++ b/UefiPayloadPkg/Include/Library/SpiFlashLib.h
@@ -194,7 +194,7 @@ SpiConstructor (
 /**
   Get the SPI region base and size, based on the enum type
 
-  @param[in] FlashRegionType      The Flash Region type for for the base address which is listed in the Descriptor.
+  @param[in] FlashRegionType      The Flash Region type for the base address which is listed in the Descriptor.
   @param[out] BaseAddress         The Flash Linear Address for the Region 'n' Base
   @param[out] RegionSize          The size for the Region 'n'
 
diff --git a/UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.c b/UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.c
index 22639a748c04..58c86ade8997 100644
--- a/UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.c
+++ b/UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.c
@@ -807,7 +807,7 @@ WaitForSpiCycleComplete (
 /**
   Get the SPI region base and size, based on the enum type
 
-  @param[in] FlashRegionType      The Flash Region type for for the base address which is listed in the Descriptor.
+  @param[in] FlashRegionType      The Flash Region type for the base address which is listed in the Descriptor.
   @param[out] BaseAddress         The Flash Linear Address for the Region 'n' Base
   @param[out] RegionSize          The size for the Region 'n'
 
diff --git a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c
index cb915e7142eb..6df421bcf99e 100644
--- a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c
+++ b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c
@@ -467,7 +467,7 @@ LoadElf32Image (
   }
 
   //
-  // Relocate when new new image base is not the preferred image base.
+  // Relocate when new image base is not the preferred image base.
   //
   if (ElfCt->ImageAddress != ElfCt->PreferredImageAddress) {
     RelocateElf32Sections (ElfCt);
diff --git a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c
index c8dbb887340b..e95b31d82671 100644
--- a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c
+++ b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c
@@ -476,7 +476,7 @@ LoadElf64Image (
   }
 
   //
-  // Relocate when new new image base is not the preferred image base.
+  // Relocate when new image base is not the preferred image base.
   //
   if (ElfCt->ImageAddress != ElfCt->PreferredImageAddress) {
     RelocateElf64Sections (ElfCt);
diff --git a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c b/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c
index c66e56aee15a..43f53d4cfae9 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c
@@ -131,7 +131,7 @@ Create4GPageTablesIa32Pae (
   for (IndexOfPdpEntries = 0; IndexOfPdpEntries < NumberOfPdpEntriesNeeded; IndexOfPdpEntries++, PageDirectoryPointerEntry++) {
     //
     // Each Directory Pointer entries points to a page of Page Directory entires.
-    // So allocate space for them and fill them in in the IndexOfPageDirectoryEntries loop.
+    // So allocate space for them and fill them in the IndexOfPageDirectoryEntries loop.
     //
     PageDirectoryEntry = (VOID *)PageAddress;
     PageAddress       += SIZE_4KB;
diff --git a/UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c b/UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c
index 1899404b244c..ec942ead3445 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c
@@ -822,7 +822,7 @@ CreateIdentityMappingPageTables (
   {
     //
     // Each PML5 entry points to a page of PML4 entires.
-    // So lets allocate space for them and fill them in in the IndexOfPml4Entries loop.
+    // So lets allocate space for them and fill them in the IndexOfPml4Entries loop.
     // When 5-Level Paging is disabled, below allocation happens only once.
     //
     PageMapLevel4Entry = (VOID *)BigPageAddress; @@ -844,7 +844,7 @@ CreateIdentityMappingPageTables (
     {
       //
       // Each PML4 entry points to a page of Page Directory Pointer entires.
-      // So lets allocate space for them and fill them in in the IndexOfPdpEntries loop.
+      // So lets allocate space for them and fill them in the IndexOfPdpEntries loop.
       //
       PageDirectoryPointerEntry = (VOID *)BigPageAddress;
       BigPageAddress           += SIZE_4KB;
@@ -879,7 +879,7 @@ CreateIdentityMappingPageTables (
         {
           //
           // Each Directory Pointer entries points to a page of Page Directory entires.
-          // So allocate space for them and fill them in in the IndexOfPageDirectoryEntries loop.
+          // So allocate space for them and fill them in the IndexOfPageDirectoryEntries loop.
           //
           PageDirectoryEntry = (VOID *)BigPageAddress;
           BigPageAddress    += SIZE_4KB;
--
2.25.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93207): https://edk2.groups.io/g/devel/message/93207
Mute This Topic: https://groups.io/mt/93496614/6998960
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [gua.guo@intel.com]
-=-=-=-=-=-=



  reply	other threads:[~2022-09-12  4:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06  8:28 [PATCH v2 00/17] Remove duplicated words PierreGondois
2022-09-06  8:28 ` [PATCH v2 01/17] .pytool: " PierreGondois
2022-09-06  8:28 ` [PATCH v2 02/17] BaseTools: " PierreGondois
2022-10-01 15:08   ` [edk2-devel] " Bob Feng
2022-10-03  7:59     ` PierreGondois
2022-10-08  2:22       ` 回复: " gaoliming
     [not found]   ` <1719FA81E323AB08.30932@groups.io>
2022-10-02  3:25     ` Bob Feng
2022-09-06  8:28 ` [PATCH v2 03/17] CryptoPkg: " PierreGondois
2022-09-06  8:28 ` [PATCH v2 04/17] DynamicTablesPkg: " PierreGondois
2022-12-13 14:37   ` Sami Mujawar
2022-09-06  8:29 ` [PATCH v2 05/17] EmulatorPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 06/17] FatPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 07/17] MdeModulePkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 08/17] MdePkg: " PierreGondois
2022-09-06 18:50   ` Michael D Kinney
2022-09-06  8:29 ` [PATCH v2 09/17] NetworkPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 10/17] PcAtChipsetPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 11/17] RedfishPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 12/17] SecurityPkg: " PierreGondois
2022-09-06  8:37   ` Yao, Jiewen
2022-09-06  8:29 ` [PATCH v2 13/17] ShellPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 14/17] SourceLevelDebugPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 15/17] UefiCpuPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 16/17] UefiPayloadPkg: " PierreGondois
2022-09-12  4:26   ` Guo, Gua [this message]
2022-09-06  8:29 ` [PATCH v2 17/17] UnitTestFrameworkPkg: " PierreGondois
2022-09-06 18:47   ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL1PR11MB547874BA662893BFB01E0692EF449@BL1PR11MB5478.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox