public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo, Gua" <gua.guo@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Ni, Ray" <ray.ni@intel.com>,
	"Hsu, VictorX" <victorx.hsu@intel.com>
Cc: 'Chan Laura' <laura.chan@intel.com>,
	"Prakashan,
	Krishnadas Veliyathuparambil"
	<krishnadas.veliyathuparambil.prakashan@intel.com>,
	"K N, Karthik" <karthik.k.n@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg
Date: Mon, 26 Jun 2023 03:42:03 +0000	[thread overview]
Message-ID: <BL1PR11MB547898C3E735B5AB3E369C78EF26A@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <03ab01d9a703$74a6f6e0$5df4e4a0$@byosoft.com.cn>


[-- Attachment #1.1: Type: text/plain, Size: 9822 bytes --]

@Gao, Liming<mailto:gaoliming@byosoft.com.cn>

It’s defined on  https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information
[cid:image001.png@01D9A823.21E0E990]

Thanks,
Gua
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Sunday, June 25, 2023 9:22 AM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com>
Cc: 'Chan Laura' <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com>
Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

Guo:
 MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob?

Thanks
Liming
发件人: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>
发送时间: 2023年6月21日 22:25
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
抄送: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

Hi Victor

Could you help to move below header file to MdePkg on Maintainer.txt ?

[cid:image002.png@01D9A823.21E0E990]


Thanks,
Gua

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua
Sent: Wednesday, June 21, 2023 9:27 PM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB.
________________________________
From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Sent: Wednesday, June 21, 2023 9:25:08 PM
To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg


I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg.



From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Sent: Wednesday, June 21, 2023 9:23 PM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg



Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg.

________________________________

From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Sent: Wednesday, June 21, 2023 9:20:23 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg



Why is this GUID moved to MdePkg?

> -----Original Message-----
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua
> Sent: Wednesday, June 21, 2023 3:02 PM
> To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura
> <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil
> <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik
> <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move
> gTraceHubDebugInfoHobGuid to MdePkg
>
> Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
>
> -----Original Message-----
> From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
> Sent: Wednesday, June 21, 2023 3:01 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming
> <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura
> <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil
> <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik
> <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
> Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg
>
> From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486
>
> Move gTraceHubDebugInfoHobGuid to MdePkg.
>
> Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
> Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>
> Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>
> Cc: Prakashan Krishnadas Veliyathuparambil
> <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>
> Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>>
> Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>
> ---
>  MdeModulePkg/MdeModulePkg.dec                               | 3 ---
>  .../Include/Guid/TraceHubDebugInfoHob.h                     | 0
>  MdePkg/MdePkg.dec                                           | 6 ++++++
>  3 files changed, 6 insertions(+), 3 deletions(-)  rename {MdeModulePkg =>
> MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -439,9 +439,6 @@
>    ## Include/UniversalPayload/SerialPortInfo.h
> gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e,
> 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } -  ##
> Include/Guid/TraceHubDebugInfoHob.h-  gTraceHubDebugInfoHobGuid =
> { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08,
> 0x35 } }-   ## GUID used for Boot Discovery Policy FormSet guid and related
> variables.   gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c,
> 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git
> a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
> b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h
> similarity index 100%
> rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
> rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> b85614992b..3b5d1bac13 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -875,6 +875,12 @@
>    ## Include/Protocol/CcMeasurement.h   gEfiCcFinalEventsTableGuid     =
> { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4,
> 0x46 }} +  #+  # GUID used to store Trace Hub Debug information+  #+  ##
> Include/Guid/TraceHubDebugInfoHob.h+  gTraceHubDebugInfoHobGuid =
> { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08,
> 0x35 } }+ [Guids.IA32, Guids.X64]   ## Include/Guid/Cper.h
> gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de,
> { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}--
> 2.40.0.windows.1
>
>
>
>
>


[-- Attachment #1.2: Type: text/html, Size: 19338 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 39448 bytes --]

[-- Attachment #3: image002.png --]
[-- Type: image/png, Size: 240189 bytes --]

  reply	other threads:[~2023-06-26  3:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  7:00 [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg victorx.hsu
2023-06-21  7:01 ` Guo, Gua
2023-06-21 13:20   ` [edk2-devel] " Ni, Ray
2023-06-21 13:22     ` Guo, Gua
2023-06-21 13:25       ` Ni, Ray
2023-06-21 13:27         ` Guo, Gua
     [not found]         ` <176AAF9465ECA5FA.18647@groups.io>
2023-06-21 14:24           ` Guo, Gua
2023-06-25  1:22             ` 回复: " gaoliming
2023-06-26  3:42               ` Guo, Gua [this message]
2023-06-26  3:55                 ` Guo, Gua
2023-06-27  1:12                 ` 回复: " gaoliming
2023-06-27  1:17                   ` Guo, Gua
     [not found]                   ` <176C5F37E374D57C.4004@groups.io>
2023-06-27  1:24                     ` Guo, Gua
2023-06-29  8:57                       ` 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL1PR11MB547898C3E735B5AB3E369C78EF26A@BL1PR11MB5478.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox