* [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg
@ 2023-06-21 7:00 victorx.hsu
2023-06-21 7:01 ` Guo, Gua
0 siblings, 1 reply; 14+ messages in thread
From: victorx.hsu @ 2023-06-21 7:00 UTC (permalink / raw)
To: devel
Cc: VictorX Hsu, Liming Gao, Guo Gua, Chan Laura,
Prakashan Krishnadas Veliyathuparambil, K N Karthik
From: VictorX Hsu <victorx.hsu@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486
Move gTraceHubDebugInfoHobGuid to MdePkg.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Guo Gua <gua.guo@intel.com>
Cc: Chan Laura <laura.chan@intel.com>
Cc: Prakashan Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>
Cc: K N Karthik <karthik.k.n@intel.com>
Signed-off-by: VictorX Hsu <victorx.hsu@intel.com>
---
MdeModulePkg/MdeModulePkg.dec | 3 ---
.../Include/Guid/TraceHubDebugInfoHob.h | 0
MdePkg/MdePkg.dec | 6 ++++++
3 files changed, 6 insertions(+), 3 deletions(-)
rename {MdeModulePkg => MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 95dd077e19..5b022b1f9f 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -439,9 +439,6 @@
## Include/UniversalPayload/SerialPortInfo.h
gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } }
- ## Include/Guid/TraceHubDebugInfoHob.h
- gTraceHubDebugInfoHobGuid = { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, 0x35 } }
-
## GUID used for Boot Discovery Policy FormSet guid and related variables.
gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } }
diff --git a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h
similarity index 100%
rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index b85614992b..3b5d1bac13 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -875,6 +875,12 @@
## Include/Protocol/CcMeasurement.h
gEfiCcFinalEventsTableGuid = { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, 0x46 }}
+ #
+ # GUID used to store Trace Hub Debug information
+ #
+ ## Include/Guid/TraceHubDebugInfoHob.h
+ gTraceHubDebugInfoHobGuid = { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, 0x35 } }
+
[Guids.IA32, Guids.X64]
## Include/Guid/Cper.h
gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}
--
2.40.0.windows.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-21 7:00 [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg victorx.hsu @ 2023-06-21 7:01 ` Guo, Gua 2023-06-21 13:20 ` [edk2-devel] " Ni, Ray 0 siblings, 1 reply; 14+ messages in thread From: Guo, Gua @ 2023-06-21 7:01 UTC (permalink / raw) To: Hsu, VictorX, devel@edk2.groups.io Cc: Gao, Liming, Chan Laura, Prakashan, Krishnadas Veliyathuparambil, K N, Karthik Reviewed-by: Gua Guo <gua.guo@intel.com> -----Original Message----- From: Hsu, VictorX <victorx.hsu@intel.com> Sent: Wednesday, June 21, 2023 3:01 PM To: devel@edk2.groups.io Cc: Hsu, VictorX <victorx.hsu@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Guo, Gua <gua.guo@intel.com>; Chan Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg From: VictorX Hsu <victorx.hsu@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 Move gTraceHubDebugInfoHobGuid to MdePkg. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Guo Gua <gua.guo@intel.com> Cc: Chan Laura <laura.chan@intel.com> Cc: Prakashan Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com> Cc: K N Karthik <karthik.k.n@intel.com> Signed-off-by: VictorX Hsu <victorx.hsu@intel.com> --- MdeModulePkg/MdeModulePkg.dec | 3 --- .../Include/Guid/TraceHubDebugInfoHob.h | 0 MdePkg/MdePkg.dec | 6 ++++++ 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -439,9 +439,6 @@ ## Include/UniversalPayload/SerialPortInfo.h gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h similarity index 100% rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index b85614992b..3b5d1bac13 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -875,6 +875,12 @@ ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- 2.40.0.windows.1 ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-21 7:01 ` Guo, Gua @ 2023-06-21 13:20 ` Ni, Ray 2023-06-21 13:22 ` Guo, Gua 0 siblings, 1 reply; 14+ messages in thread From: Ni, Ray @ 2023-06-21 13:20 UTC (permalink / raw) To: devel@edk2.groups.io, Guo, Gua, Hsu, VictorX Cc: Gao, Liming, Chan Laura, Prakashan, Krishnadas Veliyathuparambil, K N, Karthik Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com>; devel@edk2.groups.io > Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura > <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik > <karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io > Cc: Hsu, VictorX <victorx.hsu@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Guo, Gua <gua.guo@intel.com>; Chan Laura > <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik > <karthik.k.n@intel.com> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Guo Gua <gua.guo@intel.com> > Cc: Chan Laura <laura.chan@intel.com> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com> > Cc: K N Karthik <karthik.k.n@intel.com> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-21 13:20 ` [edk2-devel] " Ni, Ray @ 2023-06-21 13:22 ` Guo, Gua 2023-06-21 13:25 ` Ni, Ray 0 siblings, 1 reply; 14+ messages in thread From: Guo, Gua @ 2023-06-21 13:22 UTC (permalink / raw) To: Ni, Ray, devel@edk2.groups.io, Hsu, VictorX Cc: Gao, Liming, Chan Laura, Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1: Type: text/plain, Size: 4387 bytes --] Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Guo, Gua <gua.guo@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com>; devel@edk2.groups.io > Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura > <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik > <karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io > Cc: Hsu, VictorX <victorx.hsu@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Guo, Gua <gua.guo@intel.com>; Chan Laura > <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik > <karthik.k.n@intel.com> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Guo Gua <gua.guo@intel.com> > Cc: Chan Laura <laura.chan@intel.com> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com> > Cc: K N Karthik <karthik.k.n@intel.com> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #2: Type: text/html, Size: 6331 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-21 13:22 ` Guo, Gua @ 2023-06-21 13:25 ` Ni, Ray 2023-06-21 13:27 ` Guo, Gua [not found] ` <176AAF9465ECA5FA.18647@groups.io> 0 siblings, 2 replies; 14+ messages in thread From: Ni, Ray @ 2023-06-21 13:25 UTC (permalink / raw) To: Guo, Gua, devel@edk2.groups.io, Hsu, VictorX Cc: Gao, Liming, Chan Laura, Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1: Type: text/plain, Size: 6024 bytes --] I don't think that's the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Hsu, VictorX <victorx.hsu@intel.com> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> > Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>> > Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #2: Type: text/html, Size: 10666 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-21 13:25 ` Ni, Ray @ 2023-06-21 13:27 ` Guo, Gua [not found] ` <176AAF9465ECA5FA.18647@groups.io> 1 sibling, 0 replies; 14+ messages in thread From: Guo, Gua @ 2023-06-21 13:27 UTC (permalink / raw) To: Ni, Ray, devel@edk2.groups.io, Hsu, VictorX Cc: Gao, Liming, Chan Laura, Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1: Type: text/plain, Size: 6681 bytes --] SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. ________________________________ From: Ni, Ray <ray.ni@intel.com> Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Hsu, VictorX <victorx.hsu@intel.com> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> > Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>> > Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #2: Type: text/html, Size: 10488 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <176AAF9465ECA5FA.18647@groups.io>]
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg [not found] ` <176AAF9465ECA5FA.18647@groups.io> @ 2023-06-21 14:24 ` Guo, Gua 2023-06-25 1:22 ` 回复: " gaoliming 0 siblings, 1 reply; 14+ messages in thread From: Guo, Gua @ 2023-06-21 14:24 UTC (permalink / raw) To: devel@edk2.groups.io, Guo, Gua, Ni, Ray, Hsu, VictorX Cc: Gao, Liming, Chan Laura, Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1.1: Type: text/plain, Size: 7874 bytes --] Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? [cid:image001.png@01D9A48F.2A55E090] Thanks, Gua From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Hsu, VictorX <victorx.hsu@intel.com> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don't think that's the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> > Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>> > Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 14316 bytes --] [-- Attachment #2: image001.png --] [-- Type: image/png, Size: 98081 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-21 14:24 ` Guo, Gua @ 2023-06-25 1:22 ` gaoliming 2023-06-26 3:42 ` Guo, Gua 0 siblings, 1 reply; 14+ messages in thread From: gaoliming @ 2023-06-25 1:22 UTC (permalink / raw) To: 'Guo, Gua', devel, 'Ni, Ray', 'Hsu, VictorX' Cc: 'Chan Laura', 'Prakashan, Krishnadas Veliyathuparambil', 'K N, Karthik' [-- Attachment #1.1: Type: text/plain, Size: 8935 bytes --] Guo: MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com> 发送时间: 2023年6月21日 22:25 收件人: devel@edk2.groups.io; Guo, Gua <gua.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Chan Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas. veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? Thanks, Gua From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. _____ From: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> > Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. _____ From: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> > Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura > <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik > <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com <mailto:gua.guo@intel.com> > > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> >; Gao, Liming > <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Chan Laura > <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik > <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > > Cc: Guo Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > > Cc: Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> > > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> > > Cc: K N Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 16793 bytes --] [-- Attachment #2: image002.png --] [-- Type: image/png, Size: 240189 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-25 1:22 ` 回复: " gaoliming @ 2023-06-26 3:42 ` Guo, Gua 2023-06-26 3:55 ` Guo, Gua 2023-06-27 1:12 ` 回复: " gaoliming 0 siblings, 2 replies; 14+ messages in thread From: Guo, Gua @ 2023-06-26 3:42 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming, Ni, Ray, Hsu, VictorX Cc: 'Chan Laura', Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1.1: Type: text/plain, Size: 9822 bytes --] @Gao, Liming<mailto:gaoliming@byosoft.com.cn> It’s defined on https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information [cid:image001.png@01D9A823.21E0E990] Thanks, Gua From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io Sent: Sunday, June 25, 2023 9:22 AM To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> Cc: 'Chan Laura' <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> 发送时间: 2023年6月21日 22:25 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> 抄送: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? [cid:image002.png@01D9A823.21E0E990] Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> > Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>> > Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 19338 bytes --] [-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --] [-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-26 3:42 ` Guo, Gua @ 2023-06-26 3:55 ` Guo, Gua 2023-06-27 1:12 ` 回复: " gaoliming 1 sibling, 0 replies; 14+ messages in thread From: Guo, Gua @ 2023-06-26 3:55 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming, Ni, Ray, Hsu, VictorX Cc: 'Chan Laura', Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1.1: Type: text/plain, Size: 11305 bytes --] @Gao, Liming<mailto:gaoliming@byosoft.com.cn> HOB defined on Spec: https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information * HOB defined on MdePkg (Silicon Code Provider) * Function Implementation on MdeModulePkg (Platform Code and FSP Code consumer) Linux Spec Function Description: Intel(R) Trace Hub (TH) — The Linux Kernel documentation<https://www.kernel.org/doc/html/v4.17/trace/intel_th.html> USF Spec Function Description: 6. Debug — Universal Scalable Firmware (USF) documentation<https://universalscalablefirmware.github.io/documentation/6_debug.html> Developer Guide: https://cdrdv2-public.intel.com/671536/intel-trace-hub-developers-manual-2-1-2.pdf Thanks, Gua From: Guo, Gua Sent: Monday, June 26, 2023 11:42 AM To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> Cc: 'Chan Laura' <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg @Gao, Liming<mailto:gaoliming@byosoft.com.cn> It’s defined on https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information [cid:image001.png@01D9A824.E31FA050] Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of gaoliming via groups.io Sent: Sunday, June 25, 2023 9:22 AM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: 'Chan Laura' <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> 发送时间: 2023年6月21日 22:25 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> 抄送: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? [cid:image002.png@01D9A824.E31FA050] Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> > Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>> > Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 25238 bytes --] [-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --] [-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-26 3:42 ` Guo, Gua 2023-06-26 3:55 ` Guo, Gua @ 2023-06-27 1:12 ` gaoliming 2023-06-27 1:17 ` Guo, Gua [not found] ` <176C5F37E374D57C.4004@groups.io> 1 sibling, 2 replies; 14+ messages in thread From: gaoliming @ 2023-06-27 1:12 UTC (permalink / raw) To: 'Guo, Gua', devel, 'Ni, Ray', 'Hsu, VictorX' Cc: 'Chan Laura', 'Prakashan, Krishnadas Veliyathuparambil', 'K N, Karthik' [-- Attachment #1.1: Type: text/plain, Size: 10952 bytes --] Guo: Now, UniversalPayload definitions are in MdeModulePkg\Include\UniversalPayload directory. For example, PCI Root Bridges HOB is defined in MdeModulePkg\Include\UniversalPayload\PciRootBridges.h. So, I think this definition should be placed in the same place. Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com> 发送时间: 2023年6月26日 11:42 收件人: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> 抄送: 'Chan Laura' <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg <mailto:gaoliming@byosoft.com.cn> @Gao, Liming It’s defined on https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information Thanks, Gua From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of gaoliming via groups.io Sent: Sunday, June 25, 2023 9:22 AM To: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: 'Chan Laura' <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > 发送时间: 2023年6月21日 22:25 收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > 抄送: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? Thanks, Gua From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. _____ From: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> > Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. _____ From: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> > Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura > <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik > <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com <mailto:gua.guo@intel.com> > > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> >; Gao, Liming > <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Chan Laura > <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik > <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > > Cc: Guo Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > > Cc: Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> > > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> > > Cc: K N Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 22187 bytes --] [-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --] [-- Attachment #3: image003.png --] [-- Type: image/png, Size: 240189 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-27 1:12 ` 回复: " gaoliming @ 2023-06-27 1:17 ` Guo, Gua [not found] ` <176C5F37E374D57C.4004@groups.io> 1 sibling, 0 replies; 14+ messages in thread From: Guo, Gua @ 2023-06-27 1:17 UTC (permalink / raw) To: Gao, Liming, devel@edk2.groups.io, Ni, Ray, Hsu, VictorX Cc: 'Chan Laura', Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1.1: Type: text/plain, Size: 11768 bytes --] In past, we discuss it with Mike, TraceHub can support UPL enable case and UPL disable case. So recommend us to put it into common area. It’s background. Thanks, Gua From: gaoliming <gaoliming@byosoft.com.cn> Sent: Tuesday, June 27, 2023 9:12 AM To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> Cc: 'Chan Laura' <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: Now, UniversalPayload definitions are in MdeModulePkg\Include\UniversalPayload directory. For example, PCI Root Bridges HOB is defined in MdeModulePkg\Include\UniversalPayload\PciRootBridges.h. So, I think this definition should be placed in the same place. Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> 发送时间: 2023年6月26日 11:42 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> 抄送: 'Chan Laura' <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg @Gao, Liming<mailto:gaoliming@byosoft.com.cn> It’s defined on https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information [cid:image001.png@01D9A8D8.2ACD7310] Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of gaoliming via groups.io Sent: Sunday, June 25, 2023 9:22 AM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: 'Chan Laura' <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> 发送时间: 2023年6月21日 22:25 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> 抄送: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? [cid:image002.png@01D9A8D8.2ACD7310] Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> > Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>> > Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 23836 bytes --] [-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --] [-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <176C5F37E374D57C.4004@groups.io>]
* Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg [not found] ` <176C5F37E374D57C.4004@groups.io> @ 2023-06-27 1:24 ` Guo, Gua 2023-06-29 8:57 ` 回复: " gaoliming 0 siblings, 1 reply; 14+ messages in thread From: Guo, Gua @ 2023-06-27 1:24 UTC (permalink / raw) To: devel@edk2.groups.io, Guo, Gua, Gao, Liming, Ni, Ray, Hsu, VictorX Cc: 'Chan Laura', Prakashan, Krishnadas Veliyathuparambil, K N, Karthik [-- Attachment #1.1: Type: text/plain, Size: 13663 bytes --] @Gao, Liming<mailto:gaoliming@byosoft.com.cn> In fact, I also want to move it edk2/MdeModulePkg/Include/UniversalPayload at master · tianocore/edk2 · GitHub<https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Include/UniversalPayload> to MdePkg step by step, but it another, for the mail thread we can focus on TraceHub Hob move to MdePkg responsibility. As you know, Intel silicon may also provide MMIO UART https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h This HOB need to provide by silicon code in the future will be made sense. We can review patch one by one and consider whether it’s make sense or not. In past, we discuss it with Mike, TraceHub can support UPL enable case and UPL disable case. So recommend us to put it into common area. It’s background. Past PR: MdeModulePkg: Add Trace Hub Debug Library by hsuc1x · Pull Request #3613 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3613/files> * MdeModulePkg/Include/UniversalPayload/TraceHubDebugInfo.h [cid:image003.png@01D9A8D9.28D18690] Thanks, Gua From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo, Gua Sent: Tuesday, June 27, 2023 9:17 AM To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> Cc: 'Chan Laura' <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg In past, we discuss it with Mike, TraceHub can support UPL enable case and UPL disable case. So recommend us to put it into common area. It’s background. Thanks, Gua From: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> Sent: Tuesday, June 27, 2023 9:12 AM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: 'Chan Laura' <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: Now, UniversalPayload definitions are in MdeModulePkg\Include\UniversalPayload directory. For example, PCI Root Bridges HOB is defined in MdeModulePkg\Include\UniversalPayload\PciRootBridges.h. So, I think this definition should be placed in the same place. Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> 发送时间: 2023年6月26日 11:42 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> 抄送: 'Chan Laura' <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg @Gao, Liming<mailto:gaoliming@byosoft.com.cn> It’s defined on https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information [cid:image001.png@01D9A8D8.B7A8DE00] Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of gaoliming via groups.io Sent: Sunday, June 25, 2023 9:22 AM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: 'Chan Laura' <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> 发送时间: 2023年6月21日 22:25 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> 抄送: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? [cid:image002.png@01D9A8D8.B7A8DE00] Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. ________________________________ From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>> > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>>; Gao, Liming > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Chan Laura > <laura.chan@intel.com<mailto:laura.chan@intel.com>>; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>>; K N, Karthik > <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Cc: Guo Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> > Cc: Chan Laura <laura.chan@intel.com<mailto:laura.chan@intel.com>> > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com<mailto:krishnadas.veliyathuparambil.prakashan@intel.com>> > Cc: K N Karthik <karthik.k.n@intel.com<mailto:karthik.k.n@intel.com>> > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com<mailto:victorx.hsu@intel.com>> > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 30086 bytes --] [-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --] [-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --] [-- Attachment #4: image003.png --] [-- Type: image/png, Size: 10213 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg 2023-06-27 1:24 ` Guo, Gua @ 2023-06-29 8:57 ` gaoliming 0 siblings, 0 replies; 14+ messages in thread From: gaoliming @ 2023-06-29 8:57 UTC (permalink / raw) To: 'Guo, Gua', devel, 'Ni, Ray', 'Hsu, VictorX', 'Kinney, Michael D' Cc: 'Chan Laura', 'Prakashan, Krishnadas Veliyathuparambil', 'K N, Karthik' [-- Attachment #1.1: Type: text/plain, Size: 14823 bytes --] Mike: Do you think it is OK to move UniversalPayload definitions from MdeModulePkg to MdePkg? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com> 发送时间: 2023年6月27日 9:25 收件人: devel@edk2.groups.io; Guo, Gua <gua.guo@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Hsu, VictorX <victorx.hsu@intel.com> 抄送: 'Chan Laura' <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com> 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg <mailto:gaoliming@byosoft.com.cn> @Gao, Liming In fact, I also want to move it edk2/MdeModulePkg/Include/UniversalPayload at master · tianocore/edk2 · GitHub <https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Include/UniversalPayload> to MdePkg step by step, but it another, for the mail thread we can focus on TraceHub Hob move to MdePkg responsibility. As you know, Intel silicon may also provide MMIO UART https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h This HOB need to provide by silicon code in the future will be made sense. We can review patch one by one and consider whether it’s make sense or not. In past, we discuss it with Mike, TraceHub can support UPL enable case and UPL disable case. So recommend us to put it into common area. It’s background. Past PR: MdeModulePkg: Add Trace Hub Debug Library by hsuc1x · Pull Request #3613 · tianocore/edk2 (github.com) <https://github.com/tianocore/edk2/pull/3613/files> * MdeModulePkg/Include/UniversalPayload/TraceHubDebugInfo.h Thanks, Gua From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Guo, Gua Sent: Tuesday, June 27, 2023 9:17 AM To: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: 'Chan Laura' <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg In past, we discuss it with Mike, TraceHub can support UPL enable case and UPL disable case. So recommend us to put it into common area. It’s background. Thanks, Gua From: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > Sent: Tuesday, June 27, 2023 9:12 AM To: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: 'Chan Laura' <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: Now, UniversalPayload definitions are in MdeModulePkg\Include\UniversalPayload directory. For example, PCI Root Bridges HOB is defined in MdeModulePkg\Include\UniversalPayload\PciRootBridges.h. So, I think this definition should be placed in the same place. Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > 发送时间: 2023年6月26日 11:42 收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > 抄送: 'Chan Laura' <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg <mailto:gaoliming@byosoft.com.cn> @Gao, Liming It’s defined on https://universalscalablefirmware.github.io/documentation/2_universal_payload.html#trace-hub-hob-information Thanks, Gua From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of gaoliming via groups.io Sent: Sunday, June 25, 2023 9:22 AM To: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: 'Chan Laura' <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Guo: MdePkg definitions are from the industry standard. Which document defines TraceHubDebugInfoHob? Thanks Liming 发件人: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > 发送时间: 2023年6月21日 22:25 收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > 抄送: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > 主题: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Hi Victor Could you help to move below header file to MdePkg on Maintainer.txt ? Thanks, Gua From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Guo, Gua Sent: Wednesday, June 21, 2023 9:27 PM To: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg SiliconPkg can build the hob so have the HOB interface is enough. Platform can use TraceHubLib to consume the HOB. _____ From: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> > Sent: Wednesday, June 21, 2023 9:25:08 PM To: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg I don’t think that’s the solution to resolve pkg dependencies by adding interfaces to mdePkg. From: Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > Sent: Wednesday, June 21, 2023 9:23 PM To: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Based on Green H, we need to let the HOB can be consumed by SiliconPkg so move it from MdeModulePkg to MdePkg. _____ From: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> > Sent: Wednesday, June 21, 2023 9:20:23 PM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > Subject: RE: [edk2-devel] [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg Why is this GUID moved to MdePkg? > -----Original Message----- > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Guo, Gua > Sent: Wednesday, June 21, 2023 3:02 PM > To: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Cc: Gao, Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Chan Laura > <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik > <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Subject: Re: [edk2-devel] [PATCH] MdePkg: Move > gTraceHubDebugInfoHobGuid to MdePkg > > Reviewed-by: Gua Guo <gua.guo@intel.com <mailto:gua.guo@intel.com> > > > -----Original Message----- > From: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > Sent: Wednesday, June 21, 2023 3:01 PM > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Cc: Hsu, VictorX <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> >; Gao, Liming > <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Guo, Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> >; Chan Laura > <laura.chan@intel.com <mailto:laura.chan@intel.com> >; Prakashan, Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> >; K N, Karthik > <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Subject: [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg > > From: VictorX Hsu <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 > > Move gTraceHubDebugInfoHobGuid to MdePkg. > > Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > > Cc: Guo Gua <gua.guo@intel.com <mailto:gua.guo@intel.com> > > Cc: Chan Laura <laura.chan@intel.com <mailto:laura.chan@intel.com> > > Cc: Prakashan Krishnadas Veliyathuparambil > <krishnadas.veliyathuparambil.prakashan@intel.com <mailto:krishnadas.veliyathuparambil.prakashan@intel.com> > > Cc: K N Karthik <karthik.k.n@intel.com <mailto:karthik.k.n@intel.com> > > Signed-off-by: VictorX Hsu <victorx.hsu@intel.com <mailto:victorx.hsu@intel.com> > > --- > MdeModulePkg/MdeModulePkg.dec | 3 --- > .../Include/Guid/TraceHubDebugInfoHob.h | 0 > MdePkg/MdePkg.dec | 6 ++++++ > 3 files changed, 6 insertions(+), 3 deletions(-) rename {MdeModulePkg => > MdePkg}/Include/Guid/TraceHubDebugInfoHob.h (100%) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 95dd077e19..5b022b1f9f > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -439,9 +439,6 @@ > ## Include/UniversalPayload/SerialPortInfo.h > gUniversalPayloadSerialPortInfoGuid = { 0xaa7e190d, 0xbe21, 0x4409, { 0x8e, > 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } - ## > Include/Guid/TraceHubDebugInfoHob.h- gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }- ## GUID used for Boot Discovery Policy FormSet guid and related > variables. gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, > 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } diff --git > a/MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > b/MdePkg/Include/Guid/TraceHubDebugInfoHob.h > similarity index 100% > rename from MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > rename to MdePkg/Include/Guid/TraceHubDebugInfoHob.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > b85614992b..3b5d1bac13 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h gEfiCcFinalEventsTableGuid = > { 0xdd4a4648, 0x2de7, 0x4665, { 0x96, 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, > 0x46 }} + #+ # GUID used to store Trace Hub Debug information+ #+ ## > Include/Guid/TraceHubDebugInfoHob.h+ gTraceHubDebugInfoHobGuid = > { 0xf88c9c23, 0x646c, 0x4f6c, { 0x8e, 0x3d, 0x36, 0xa9, 0x43, 0xc1, 0x08, > 0x35 } }+ [Guids.IA32, Guids.X64] ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}-- > 2.40.0.windows.1 > > > > > [-- Attachment #1.2: Type: text/html, Size: 35632 bytes --] [-- Attachment #2: image003.png --] [-- Type: image/png, Size: 10213 bytes --] [-- Attachment #3: image004.png --] [-- Type: image/png, Size: 39448 bytes --] [-- Attachment #4: image005.png --] [-- Type: image/png, Size: 240189 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
![[-- Attachment #2: image001.png --] [-- Type: image/png, Size: 98081 bytes --]](../../BL1PR11MB5478698BDA939B58FBD7C001EF5DA@BL1PR11MB5478.namprd11.prod.outlook.com/2-image001.png){kind=link}
![[-- Attachment #2: image002.png --] [-- Type: image/png, Size: 240189 bytes --]](../../03ab01d9a703$74a6f6e0$5df4e4a0$@byosoft.com.cn/2-image002.png){kind=link}
![[-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --]](../../BL1PR11MB547898C3E735B5AB3E369C78EF26A@BL1PR11MB5478.namprd11.prod.outlook.com/2-image001.png){kind=link}
![[-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --]](../../BL1PR11MB547898C3E735B5AB3E369C78EF26A@BL1PR11MB5478.namprd11.prod.outlook.com/3-image002.png){kind=link}
![[-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --]](../../BL1PR11MB5478661D14E97E74A1921E24EF26A@BL1PR11MB5478.namprd11.prod.outlook.com/2-image001.png){kind=link}
![[-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --]](../../BL1PR11MB5478661D14E97E74A1921E24EF26A@BL1PR11MB5478.namprd11.prod.outlook.com/3-image002.png){kind=link}
![[-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --]](../../00f101d9a894$684db6d0$38e92470$@byosoft.com.cn/2-image001.png){kind=link}
![[-- Attachment #3: image003.png --] [-- Type: image/png, Size: 240189 bytes --]](../../00f101d9a894$684db6d0$38e92470$@byosoft.com.cn/3-image003.png){kind=link}
![[-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --]](../../BL1PR11MB54786F17A87B2E66F79AACAEEF27A@BL1PR11MB5478.namprd11.prod.outlook.com/2-image001.png){kind=link}
![[-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --]](../../BL1PR11MB54786F17A87B2E66F79AACAEEF27A@BL1PR11MB5478.namprd11.prod.outlook.com/3-image002.png){kind=link}
![[-- Attachment #2: image001.png --] [-- Type: image/png, Size: 39448 bytes --]](../../BL1PR11MB54782D1D66889EB79873F94BEF27A@BL1PR11MB5478.namprd11.prod.outlook.com/2-image001.png){kind=link}
![[-- Attachment #3: image002.png --] [-- Type: image/png, Size: 240189 bytes --]](../../BL1PR11MB54782D1D66889EB79873F94BEF27A@BL1PR11MB5478.namprd11.prod.outlook.com/3-image002.png){kind=link}
![[-- Attachment #4: image003.png --] [-- Type: image/png, Size: 10213 bytes --]](../../BL1PR11MB54782D1D66889EB79873F94BEF27A@BL1PR11MB5478.namprd11.prod.outlook.com/4-image003.png){kind=link}
![[-- Attachment #2: image003.png --] [-- Type: image/png, Size: 10213 bytes --]](../../000801d9aa67$b55f10c0$201d3240$@byosoft.com.cn/2-image003.png){kind=link}
![[-- Attachment #3: image004.png --] [-- Type: image/png, Size: 39448 bytes --]](../../000801d9aa67$b55f10c0$201d3240$@byosoft.com.cn/3-image004.png){kind=link}
![[-- Attachment #4: image005.png --] [-- Type: image/png, Size: 240189 bytes --]](../../000801d9aa67$b55f10c0$201d3240$@byosoft.com.cn/4-image005.png){kind=link}
end of thread, other threads:[~2023-06-29 8:57 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 7:00 [PATCH] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg victorx.hsu
2023-06-21 7:01 ` Guo, Gua
2023-06-21 13:20 ` [edk2-devel] " Ni, Ray
2023-06-21 13:22 ` Guo, Gua
2023-06-21 13:25 ` Ni, Ray
2023-06-21 13:27 ` Guo, Gua
[not found] ` <176AAF9465ECA5FA.18647@groups.io>
2023-06-21 14:24 ` Guo, Gua
2023-06-25 1:22 ` 回复: " gaoliming
2023-06-26 3:42 ` Guo, Gua
2023-06-26 3:55 ` Guo, Gua
2023-06-27 1:12 ` 回复: " gaoliming
2023-06-27 1:17 ` Guo, Gua
[not found] ` <176C5F37E374D57C.4004@groups.io>
2023-06-27 1:24 ` Guo, Gua
2023-06-29 8:57 ` 回复: " gaoliming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox