From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.10288.1682558596227732048 for ; Wed, 26 Apr 2023 18:23:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gRsBTFHr; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682558596; x=1714094596; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=orKcS730YeV+b9BRTzDt0JauiJ3fPRRCPRPP4d6wuv8=; b=gRsBTFHrc/dPaCgOFo1h4/W+4OfGCpsv1a12tvhtULWrsLLRqKCnQx4u P8MBx++GRyvle/S/8q7cemaKP5YqLnLZIDHdqdtB+1m7sSQe0SV3fVwmx jZmks8ywoJrNQkrSBxB/R9OqbY/6QkqnHfP7k7hOglfMDeKHYF6DBRFcI OntNyK5RF6pzdh9s5AWuI2FRPD0hpr8l6f1LjQQMoE4r5zsGzyRGdPju6 KMNKZQcBSxxY31el1OPJlg65xX9SffiaMSEVqm7v8dJ7izO0DtMh+NVb4 L3mxlPiCfqfJG9UOIuf2/j6AYtbp8J2xAQ4qk8QY/nvBpQ4bMOFjeNWH1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="410314217" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208,217";a="410314217" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 18:23:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="1023873428" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208,217";a="1023873428" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 26 Apr 2023 18:23:15 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 26 Apr 2023 18:23:15 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 26 Apr 2023 18:23:15 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 26 Apr 2023 18:23:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EFXp4s4+aGzozDE4cGq1EE9jk884HAhA11pUsR0+Zvxk1DjQLRE+DB2GCxntJ7SUgFjZzVP9hh6uOxd39w6sZ0ZWZsDUUI5I/kFIyyGVKBos88eIY7pfnWSS6kJKi2liG1WGVIYs9LDwnBSHZYqnQFQh8s4Jm6eYgTXcG//v7w7BEu1f62dJ4vyxE/IpzsX6Nj2yhuiq8YFXVK/yli6Fd6CxbQj+KyH0xBCG2fynrbKAbEpJDHd//cbScDUO3a8z5R5SouHWSCFnwiu0Inn1/G9vf5eCpcMe8YvBvE4hJxIjQA/MCu3YDUEdt3vHl8lC0sBY8qDKgaSFBKTy13JVSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Gw4jUIYUjaJR1iPwZxA/TchKQHApPEk8gTWEkXCypw=; b=oCbn4qTw6geinJayQ8FzkT/eMEqPqa5hMawMIVyWxESlrQje64kL6oSSEPklfnVWIj8ghueyy3zmfJKxzXwpF6F4FpzoHOOHXMnw9lm+NwTToHWu4GdafLN1y6ZGg0Cg9OzUcPgIc3TJc99vc7mQ6xbIqa6KhMfEiRFGUJ5n111j4MlsF9aBzMY/plrErDV3UpNr0nTG+pIRGfWYW7MClYMi/8NNniTcZOLQZRg+UWway+jmQncrcqA626j8sAt+OOIbQ/kHDFqVZcW8hyO302id8fvVvrdn17B8fKu+NRSomLTY7ChFmFYbtoU+oAaBQiIxSa+IQwl1PnD97troQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by DM4PR11MB5518.namprd11.prod.outlook.com (2603:10b6:5:39a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Thu, 27 Apr 2023 01:23:12 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::c7e7:7b20:9a8b:aa59]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::c7e7:7b20:9a8b:aa59%5]) with mapi id 15.20.6340.021; Thu, 27 Apr 2023 01:23:12 +0000 From: "Guo, Gua" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan , Michael Kubacki , Oliver Steffen , "fernald, chris" , "Kinney, Michael D" Subject: Re: [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov Thread-Topic: [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov Thread-Index: AQHZeKAM2tSsenZp10Wf2arBi0rh4q8+U+IAgAAIauc= Date: Thu, 27 Apr 2023 01:23:12 +0000 Message-ID: References: <20230427003416.315-1-gua.guo@intel.com> <20230427003416.315-2-gua.guo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|DM4PR11MB5518:EE_ x-ms-office365-filtering-correlation-id: 52bc6673-754e-4802-880b-08db46bdf7af x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IH4Gnl3iM3G3lb9XP+wepFIdx9ZDWaMPnKEuap59aetHVsYoCFwEdThtGsQ9wpsTlf9e5Bu4R5ouO6g5rGmESOf8PkkIqPyA17C9ZJfjdAhTSF1JC0+OHdKBnvlaQWUrhE1VFyxxBUuHAKSzyWLlQ1ZYi6p0dhh3N9Tj8kBSDDNcInyjohmAJ8vAu42kThMNWEU+mg34LdqUpfbdxfct8TsGvDE2qyUCI7UkC+E2prZCDfLzLFZomn9hf2vLMDLnHUKQ8dgPswRC7x/rszCQ2mxMtUGP3/UNhnu/JemvxSAPFj+IvkO/Yzwdx4hy+SWYwByF0+OJTDZwzB8NeVKYvHT58YHi7qbF2KQEKSr7k4e5NQ/Ora9ndoFnqqvoKSy47GX65Q5mX25ejsWCwAOPAHJHn+VkzGoXW5+keR8jcgqiwIvKPUmyICqDLagsmlfMCiVYy49GOpI9PzEIzntnoz+J0s51RFhrflxxrt4SxrCbZ581seGXr4MrI4rr0VVQbkXYykkMD/dskeG09P6VEvfl2rLkHJHAamfvZhdXPfnD5hNDGuzRpDGfMfYA+kjFnr/dsOvEL8aSwaqihBxtRBykN3bVvTnZ3sZh3xW8Kb29+ZOC3iLaf9LoLwD2bu3r x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(396003)(376002)(136003)(39860400002)(451199021)(52536014)(41300700001)(122000001)(26005)(53546011)(6506007)(9686003)(82960400001)(5660300002)(38070700005)(8936002)(8676002)(83380400001)(2906002)(38100700002)(4326008)(316002)(91956017)(66556008)(66446008)(66946007)(76116006)(66476007)(64756008)(478600001)(86362001)(55016003)(33656002)(186003)(107886003)(54906003)(110136005)(71200400001)(45080400002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j7S3cuVcUWhnJAcpXTdegE+Swtsk4jp5Ds0y+5E3ch9WLWUYV5N7Ogm4jlPU?= =?us-ascii?Q?iVcIibnSxAZN8RGbz9oTQjETzDjK64pRzGhCi0Zjfghhtx1x2izThPdspIle?= =?us-ascii?Q?Cy1Ehyz2B4BvdKs25Ze+XRMt/iU7KSVqb0ZuYTabQuEwTNSddXHujPcEqEoU?= =?us-ascii?Q?6aDcfz+KNwFKJkuDOemDhbCWH+NPABLEuhDh8aC9U9lSl0btIS8VKSQHm1ga?= =?us-ascii?Q?WfZhXwrZtDPs0kHLfd8Fuo6sk7wx9L8wOWzOTdv1jTP4EibPt+IHiCc3KJlM?= =?us-ascii?Q?8UrWHDerbSvt1LHO8LcpxHJ0f/rOu0rm+n5BWYgDK0w7YxCFiPQRsCHxKmLp?= =?us-ascii?Q?J2f4nxp+3WEM/KET8ficOkMbn3hnogTqro7buyrKGs/PwYjYmwubWSq11HbS?= =?us-ascii?Q?cjbNEjuuTcD9EC5yIwM5AAxvMkspLtM2E7mziZaCkpRChaKCPu73b1aL5G27?= =?us-ascii?Q?riNdaAjbGFASR0KyBXqbVLrU+514x/8uAQ/t2tfX0VCGv7oLeMleiifX+hJE?= =?us-ascii?Q?slD2mmwtnlQq/Y9Rd5X7m5Jc9+psTMQTT1BeB1kjXhlvfy3rpgj6u7agGlOC?= =?us-ascii?Q?nQcU8K8ymOyStxpk2jWmX0bjSTpN+qVQfyFpHN4DwL/1zUh8UuPgoMYr9ubQ?= =?us-ascii?Q?fHseAeus+ZxZX5bT3VE7Z7Ff2NT//+QkDa2VacOfSWHsnhk8cgjrYT6yuIuc?= =?us-ascii?Q?d0lqkcR52+ckkZ0a7ASdpbrvWUtXE3BXWw2pAHX6mfnghjhsjVUlQlE62dJ0?= =?us-ascii?Q?p8YEtk5Lh+bcssputBqSpif3cSuLWlfbqhx3fiWpSOnwSoHUvdXL86rQrjsW?= =?us-ascii?Q?mkeN9uXq/kjBjccEsK4tCRf5J11z7zzALVAShzDn5zenrNqVvWCeucYxB/9q?= =?us-ascii?Q?hBs0gqW1UYeFfucxhT3Rr1Y3ZjIPUHjsbjvidEI/VK30gSs06QX/FnmmxL04?= =?us-ascii?Q?SwGD2gCwz0P+DytI5rugD32xj7XOAxK49Q8MNmQ2L1zGZoJcOa/2xI/3T4FC?= =?us-ascii?Q?9h/Tr90HE6i5zTbnge+g8bOeu7oCJRAA1NRWFlPdq0XKHSot0MsARrfMR+/h?= =?us-ascii?Q?N0qOXh8ZCrvHvJzGrUsXW/pjGWn6SOh2VCOZxQDNAOKUtuzPhxnSemFV1fBq?= =?us-ascii?Q?Z64QgeNJcOsl1kxaz5uPccryqst4drCo10D1T1zX98f0WyOz6zuESDGcn1fR?= =?us-ascii?Q?Ns/LgiTc1zPr0b1SbYH8Mjwg9PW1YpzTNPjOyiBUG63g7ooyg+zvY8LJ9Ij8?= =?us-ascii?Q?Q19mXN22P7dInR8AbXP3lgx6j0x8svVRMs796tLL3uQcfvFI1BmEzryXhxHw?= =?us-ascii?Q?UFe/3HdTf51aDeLbVjjZGYf+YhSM+NetYb6+LrbUMV9wcIDy5ORZc27dnjf6?= =?us-ascii?Q?BRjR/uFrCZs/Bp/CZMKxg6EMm9/QindX9x5XDJPNNxRH+j87TJMS0FxiwhTi?= =?us-ascii?Q?e/Iqbsyb/SDT88JJ0H+nrv7JWn/iM7inj2cvnz/NBPTjIb2bSHPOwXYw39jz?= =?us-ascii?Q?bGeQyjh0uBy12tRJiWX2wM+QDvk9j891ALec1FfyEjzsWp+Xdd/2jGRnrZHR?= =?us-ascii?Q?COaOiTAf60ostZQs8SMU0DVPy+k/Z9sIJ6o66dNw7Q79FLAbXQz0KLTABKoW?= =?us-ascii?Q?dA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52bc6673-754e-4802-880b-08db46bdf7af X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 01:23:12.0817 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HxU2JdM3n87LMtTnbiQiorlXqjI2X/1D0eodDWvNaTh9P6F3naLyRV7POP9PtkXcs6/endd/0YgB6xnc5McOXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5518 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BL1PR11MB54789E29AC0FFEA9502B5919EF6A9BL1PR11MB5478namp_" --_000_BL1PR11MB54789E29AC0FFEA9502B5919EF6A9BL1PR11MB5478namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure, I will update the commit message. ________________________________ From: Kinney, Michael D Sent: Thursday, April 27, 2023 8:52:40 AM To: Guo, Gua ; devel@edk2.groups.io Cc: Sean Brogan ; Michael Kubacki ; Oliver Steffen ; fernald, chris ; Kinney, Michael D Subject: RE: [PATCH v2 2/2] .azurepipelines: Choose container that have ins= talled lcov Hi Gua, It is hard to review this type of patch without more context. Can you provide a link to the PR or branch where the docker image was updat= ed? That information should be part of the commit message. Thanks, Mike > -----Original Message----- > From: Guo, Gua > Sent: Wednesday, April 26, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Kinney, Michael D > ; Sean Brogan ; > Michael Kubacki ; Oliver Steffen > ; fernald, chris > Subject: [PATCH v2 2/2] .azurepipelines: Choose container that have insta= lled > lcov > > From: Gua Guo > > Azure should install code coverage tool (lcov), it didn't > exist on Fedora and Ubuntu by default. > > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Oliver Steffen > Cc: Chris Fernald > Signed-off-by: Gua Guo > --- > .azurepipelines/templates/defaults.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.azurepipelines/templates/defaults.yml > b/.azurepipelines/templates/defaults.yml > index 74d6b41783..8412a43cad 100644 > --- a/.azurepipelines/templates/defaults.yml > +++ b/.azurepipelines/templates/defaults.yml > @@ -9,4 +9,4 @@ > > > variables: > > default_python_version: ">=3D3.10.6" > > - default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:47ad= dc9" > > + default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:3b3e= b8f" > > -- > 2.39.2.windows.1 --_000_BL1PR11MB54789E29AC0FFEA9502B5919EF6A9BL1PR11MB5478namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure, I will update the commit message.
From: Kinney, Michael D <= ;michael.d.kinney@intel.com>
Sent: Thursday, April 27, 2023 8:52:40 AM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io <dev= el@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki &= lt;mikuback@linux.microsoft.com>; Oliver Steffen <osteffen@redhat.com= >; fernald, chris <chfernal@microsoft.com>; Kinney, Michael D <= michael.d.kinney@intel.com>
Subject: RE: [PATCH v2 2/2] .azurepipelines: Choose container that h= ave installed lcov
 
Hi Gua,

It is hard to review this type of patch without more context.

Can you provide a link to the PR or branch where the docker image was updat= ed?  That information should be part of the commit message.

Thanks,

Mike

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Wednesday, April 26, 2023 5:34 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@micros= oft.com>;
> Michael Kubacki <mikuback@linux.microsoft.com>; Oliver Steffen > <osteffen@redhat.com>; fernald, chris <chfernal@microsoft.com= >
> Subject: [PATCH v2 2/2] .azurepipelines: Choose container that have in= stalled
> lcov
>
> From: Gua Guo <gua.guo@intel.com>
>
> Azure should install code coverage tool (lcov), it didn't
> exist on Fedora and Ubuntu by default.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Cc: Chris Fernald <chfernal@microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  .azurepipelines/templates/defaults.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.azurepipelines/templates/defaults.yml
> b/.azurepipelines/templates/defaults.yml
> index 74d6b41783..8412a43cad 100644
> --- a/.azurepipelines/templates/defaults.yml
> +++ b/.azurepipelines/templates/defaults.yml
> @@ -9,4 +9,4 @@
>
>
>  variables:
>
>    default_python_version: ">=3D3.10.6" >
> -  default_linux_image: "ghcr.io/tianocore/containers/fedora= -35-test:47addc9"
>
> +  default_linux_image: "ghcr.io/tianocore/containers/fedora= -35-test:3b3eb8f"
>
> --
> 2.39.2.windows.1

--_000_BL1PR11MB54789E29AC0FFEA9502B5919EF6A9BL1PR11MB5478namp_--