From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.11200.1678362503495242111 for ; Thu, 09 Mar 2023 03:48:23 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=bEAUrtj+; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678362503; x=1709898503; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MC2S1LVbwOy59+v3sL6MCjW8lSfBDL9aUwThz0nyQhA=; b=bEAUrtj+NvdBGhxye+DN9gtkp1dc6m7aQ3Vkw1t7A0eFPjDLDaSlOOlX AsjX7vW3kqlGdG5hOFetYfaDp+b2JSa3+eWV14j7SVNjQYxNZyB+zTMFo BZCsH/PTV+/OEbEuNBQni6ziZLDhIlIPwtNF6DMxy8Ni3iMyq7qXY52Or pFQk9GyAXAByQnoTUhoOtzFYJSt+qAZ4QGDI+lfp6u1pQnU8VYZ8H4c7S TPu2+TomECMqYl9ATSMX3HuLWkrELsLh+nTtk5BE7TKmubmdLvEXtwNL9 cvEFkLG5UudtUS83zmIDeelpwo2CPrYvuI68vHBqIXyRrvgA5GU7gGq7H g==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="335127832" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="335127832" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 03:48:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="654723369" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="654723369" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 09 Mar 2023 03:48:22 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 03:48:21 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 9 Mar 2023 03:48:21 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 9 Mar 2023 03:48:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NUMJtD2xDyR79d5i3Zq/spM/2IyjuFM+9mRMmaZCvHOlc1b0F7yh+TcxWGwnuyVsuOI+gv0C0pgQwt0rV9ai3OYMpEQRESx5f8MFmTRFvXOruxM1qEzw90sC8p3ttjgtUiykq3ZXl9UjhWLpjnUhqGEDrFBbmveyjT/eOhvSzY/Uw3b+96zLIfXaomu7+OwpKZLem9LQKORuCPPWD0XMeGh227z0jL3gVP+zSaDUoCLrd3cGfQgQMt+qyqZsm3fEM7KlQeDpscIUjlOu04Sf3eQ8Ry28LgPf7CGs/WekXoGN5Qw6XCTpyQrRKtbS1oFUbJtL1OoCyrksXiua1nOA/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XcGuhmQI0VDJhPghswQX/iuB4kpE927XRqe0qb6Azxg=; b=XPkfLwpf/2R1YXpBDygfNdXb+M9hJ4sz1yshcz2+jjLyUGRiSncNnmHcRqLz2go9MpHc3rDZRnZCGHQioRaDecQN/ho4d5nzDBPg7Zp1Jvff9zSbHFuL5k6FWZpDZzJZkvgpYNlRXMNdFruWcCjKIJae+5Z5Z7RrwZMUmJnExK6D9quEFi6Hu/rj9dSb4mCcQDhfAiUn0Xj918ABetzbaGRRxbc0hhHoPgEEDQ3X0YOupm9FpJHnqn1z5und6vIbTqqXqtzmiclvIJpXbA9GlLKBJKXXXsr9IeG0YokcpX3QjMdVKfh4SEorCH96i+lFnN+wC7VmlQ7TmvSLUSFqAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by DS7PR11MB7888.namprd11.prod.outlook.com (2603:10b6:8:e2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Thu, 9 Mar 2023 11:48:19 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::828:a400:e971:c953]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::828:a400:e971:c953%4]) with mapi id 15.20.6178.019; Thu, 9 Mar 2023 11:48:18 +0000 From: "Guo, Gua" To: Dhaval Sharma , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ni, Ray" , "Sean Rhodes" , "Lu, James" Subject: Re: [PATCH v3 2/2] UefiPayloadPkg: Move INT prog outside common flow Thread-Topic: [PATCH v3 2/2] UefiPayloadPkg: Move INT prog outside common flow Thread-Index: AQHZUnMvGTiLz9pOy0qXp4alEc9eK67yS4yg Date: Thu, 9 Mar 2023 11:48:18 +0000 Message-ID: References: <20230309103721.1869468-1-dhaval@rivosinc.com> <20230309103721.1869468-3-dhaval@rivosinc.com> In-Reply-To: <20230309103721.1869468-3-dhaval@rivosinc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|DS7PR11MB7888:EE_ x-ms-office365-filtering-correlation-id: 2d2a7b4e-b596-4564-1fd8-08db20942cc3 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Do84eZeIGxePHAN5FMsJLPcxzW2V76hi0cpWq9/Iq8L/PBHhazo05wmstB2r0A426nslAoX1h2xs39uYK7S+Ww40NMSKDQOioy1bSq++xBk0ssLmWbH+VRA9LQgrHQpzbEfCU5FrfCRgloRJ0hc9SvT6lF7nzGD6Lr+VX1rZ/gyn1+fN0eKVssd1tZRExiyCiwnLDT+8uxxvse2zQKOvlQzodbLYmnpvX/7jIPlNUZk9It6u3l0sUeqyQEEIH8TQiWtXhuFl6VeZFJ8qRUTfeS71O2JuJzj7Kn3SZBNwgRl3D5kSF7bEPlZQwl1gj0ZJ86XKEBe/5ab5YsKMRzQAnjO607vg4WChiZe1pN8sdcC1YA9aAVLrVtFrBwueG6tgkAW+M7Qn1bqDcIvBVp8OBjQkX4vPj1rH6wPg+zKF7ONDnMxIaQzAxRav2edeEjONRqJZIHVlY6FtxegInjfsps7anHnORZyfNFk0K0q6UJT2YHo1dYvdeKvCwSO8jQ1kUVFFrgQ/nvoClfiHCui8vA24B4t31k49uD3Kanf18tFyhm7P8MiqxqzIlKf7eHv4EIKAkOzD9fHfkHgmFzIlBs2jNTfnqijihHtk9g5PG6BYcoQK9jDdZJjdBqjGidgUInG8t8loCHVzf3QfDGHMyU3pBvDXMfZR0ETRzfOff/n2LhPmWVDL+5eLPaJVMptrZaWMHiMpn0XWPNpnvTHD5w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199018)(38070700005)(2906002)(5660300002)(26005)(8936002)(52536014)(41300700001)(110136005)(66446008)(66476007)(66556008)(66946007)(76116006)(4326008)(33656002)(64756008)(8676002)(316002)(55016003)(19627235002)(86362001)(54906003)(71200400001)(7696005)(478600001)(122000001)(82960400001)(38100700002)(107886003)(6506007)(9686003)(53546011)(186003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aCCbWJYGrCiWl2Wzj0zcU5vsikWnjt0Mhj0fGfNbOR1ED0QyPAHJ8mZIZlVr?= =?us-ascii?Q?JYPQ0Mvz5vR14W3CnijnVL7MhwfSgLm7mhN20rPAe6jr573TUJEuVR2dMghe?= =?us-ascii?Q?QcO0vs3uNj8zQ+xkfSplSxLG3Z9Uh0mniaEQo2LEp/j9ahXXsBhITbd0wMYD?= =?us-ascii?Q?T9zHtt93RFsa53WIMLVtKvZi4abaZXqvFl7hNb0p3WJnzFhyEvUKVt/YlyVv?= =?us-ascii?Q?NP2JbSqRtHFQddVDHVYJPBEoVkWoI/WaRUjyW9FT+DGnvop5UoIWJrt/IsMu?= =?us-ascii?Q?2OJm76GVklQ4/qZHO9XqYmnXQ2QY4lOfal5DYhh7L/Pa4wVHPjY/Z2qSQvLK?= =?us-ascii?Q?sJjfLvhaPgfPOnUlrDnAebb8RV3KGBscBNMmhuN4k5R+Kvik34AHXrgHlBpJ?= =?us-ascii?Q?hi8w+Aubk0ydiwPvzLhem+F7VmdcULdt1CAdk7RbVXjCdRTq8EgTPFQ3wQlO?= =?us-ascii?Q?qRtfXsEDwNp3ieXvQ1uISxmwXhJ/oJvkpLUcJfp5v9hWsN9GQVWpIINFEDhu?= =?us-ascii?Q?gYiqxGERvLmxGMqKYduZ1kBOovxd2/ghbA4ZdPnfSxMdBuHtowJb0qmYqTZa?= =?us-ascii?Q?2cUK6aOzu8JYGZnTFU1rFJD9r3QqpimxzO4yL2v2ACW+NOho7axMVm//rrQq?= =?us-ascii?Q?2w4IBIqBsbs5HuGBf2Om0EgpWBC0SvnIO50ANfcXueGVdyJ6aysb3VqsPQiG?= =?us-ascii?Q?D3pi3nTHjj7Ht7xzlkaaQQgr6wDw8m8gDkrK0usbz5cHDAxFz8IlIy4IExb9?= =?us-ascii?Q?t1gWrEbd9WNSHH/jM+tlHpv5KoYB7K9EOampmZdtt57ECvV/kqzVoDQBdirR?= =?us-ascii?Q?ZlmygNz+fAXAWI8xG3fWF5YHgf0futG5G0yeu25YQ1oUe/K1MjF3SpSIkcxM?= =?us-ascii?Q?46PfkyuZ2h6wXrYX8tL55o+b7L0z05yjaJuUY7PS6kIfSYd+LWuD39ifKqyp?= =?us-ascii?Q?CcDQeguD5VjscnCig7BnxKN+kvwVnyTvZ5PhJkMDTsgM+acFzTQWfyjkoYwa?= =?us-ascii?Q?tMWEiTgwP3uf9g1/H1wEiajK4RzPhop40RDFtPT7Y9VhM98XwzK//t6eCzsP?= =?us-ascii?Q?MQ2QPpX+0f8ydy0dF5F5OLOyKhYgdJVkWYm+UuWGVAWlwRenySIOqUlQZavR?= =?us-ascii?Q?jbztARjrRQV4WRJq85V2pdX04rlhJXAHs3s7ykiy+7i1L/fXr1KiwfvaZJRN?= =?us-ascii?Q?Ep8D++qmZKA9XIaTSRIS85XZKCL1OpncbvYGOtlFHpeXo1fu+TMmC0BKp60c?= =?us-ascii?Q?K1vSqtrqr0KL637MGVyb+CkgiQImmmzPAMdp259gjOu4Sj8fyeuhSMGKye5x?= =?us-ascii?Q?85Qb8kdudo9GkFv+AHLuqEs/Nm5dceoy4nQJCq3dcKAmtrjkj4GG7IAuARFb?= =?us-ascii?Q?8q5ptyCCgXiWeZEv9g9ZpwPilgWTG7/eSwnDKpXHPm54PuNCu9+RHzZQtpz6?= =?us-ascii?Q?kPXEoHqQsuicV2UTlKvVfUf+8Bg6vLzMxmrretJ8VWb+bq8q/kaxhqwgywtC?= =?us-ascii?Q?RGG+rMKVZzaydIwKtWz+5Hk7usvzg+zB5bXxbHP6aYNejU9Ks0UogDXDYbPU?= =?us-ascii?Q?Yg7a6s0JQJZf9TymQec=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d2a7b4e-b596-4564-1fd8-08db20942cc3 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2023 11:48:18.0821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mOr0sHumrC8/Rrd8V0u68CyhgOnbfFU4iHgu5MkHXVIH1vqyDwAUvPqF27GGIYl9PpXieJy0Qkb3sx2OygOMVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7888 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Gua Guo =20 -----Original Message----- From: Dhaval Sharma =20 Sent: Thursday, March 9, 2023 6:37 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Sean Rhodes= ; Lu, James ; Guo, Gua Subject: [PATCH v3 2/2] UefiPayloadPkg: Move INT prog outside common flow 8259 is very arch specific programming. It needs to be moved out to the res= pective arch flow. Added in both x64 and x32 paths Test: Able to boot UEFI shell with Coreboot Tianocore payload on x86 qemu Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Dhaval Sharma --- Notes: v3: - Added legacy INT intialization to X64 path as well UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c | 6 ++++++ UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 6 ------ UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c b/UefiPaylo= adPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c index 9d2bfb2fa654..d41e5024b4a1 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c +++ b/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c @@ -271,6 +271,12 @@ HandOffToDxeCore ( // Initialize floating point operating environment to be compliant with = UEFI spec. InitializeFloatingPointUnits (); + //+ // Mask off all legac= y 8259 interrupt sources+ //+ IoWrite8 (LEGACY_8259_MASK_REGISTER_MASTER,= 0xFF);+ IoWrite8 (LEGACY_8259_MASK_REGISTER_SLAVE, 0xFF);+ // // Clea= r page 0 and mark it as allocated if NULL pointer detection is enabled. /= /diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/Uef= iPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c index 07f4c1d29686..45127689a24b 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -478,12 +478,6 @@ _ModuleEntryPoint ( Status =3D UniversalLoadDxeCore (DxeFv, &DxeCoreEntryPoint); ASSERT_EF= I_ERROR (Status); - //- // Mask off all legacy 8259 interrupt sources- /= /- IoWrite8 (LEGACY_8259_MASK_REGISTER_MASTER, 0xFF);- IoWrite8 (LEGACY_8= 259_MASK_REGISTER_SLAVE, 0xFF);- Hob.HandoffInformationTable =3D (EFI_HOB= _HANDOFF_INFO_TABLE *)GetFirstHob (EFI_HOB_TYPE_HANDOFF); HandOffToDxeCor= e (DxeCoreEntryPoint, Hob); diff --git a/UefiPayloadPkg/UefiPayloadEntry/X6= 4/DxeLoadFunc.c b/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c index 84a6112ce64a..1dfb7459e85a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c +++ b/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c @@ -43,6 +43,12 @@ HandOffToDxeCore ( // Initialize floating point operating environment to be compliant with = UEFI spec. InitializeFloatingPointUnits (); + //+ // Mask off all legac= y 8259 interrupt sources+ //+ IoWrite8 (LEGACY_8259_MASK_REGISTER_MASTER,= 0xFF);+ IoWrite8 (LEGACY_8259_MASK_REGISTER_SLAVE, 0xFF);+ // // Clea= r page 0 and mark it as allocated if NULL pointer detection is enabled. /= /--=20 2.40.0.rc0.57.g454dfcbddf