From: "Guo, Gua" <gua.guo@intel.com>
To: Jiading Zhang <jdzhang@kunluntech.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
Date: Mon, 19 Dec 2022 01:04:11 +0000 [thread overview]
Message-ID: <BL1PR11MB5478B56D448D3346FB05037BEFE59@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <12037.1671340906790506789@groups.io>
[-- Attachment #1.1: Type: text/plain, Size: 873 bytes --]
@Jiading Zhang<mailto:jdzhang@kunluntech.com.cn>
See the PR have below format issue violate Edk2 check in rule.
PR: https://github.com/tianocore/edk2/pull/3785/
1. The commit message is weird for me.
Could you help to use rebase instead merge ?
[cid:image002.png@01D91388.D15F3D20]
1. See the CI failure, please help to run py -3 BaseTools\Scripts\PaychCheck.py on your local.
It will report same failure like CI for commit message format.
[cid:image001.png@01D91388.871DD6E0]
From: Jiading Zhang <jdzhang@kunluntech.com.cn>
Sent: Sunday, December 18, 2022 1:22 PM
To: Guo; Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
OK. I Commit a PR for the change:
UefiPayloadPkg: Define default values for the DynamicEX PCDs #3785
Thanks!
[-- Attachment #1.2: Type: text/html, Size: 6426 bytes --]
[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 59649 bytes --]
[-- Attachment #3: image002.png --]
[-- Type: image/png, Size: 72274 bytes --]
next prev parent reply other threads:[~2022-12-19 1:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 0:56 [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs Jiading Zhang
2022-11-11 1:39 ` [edk2-devel] " Guo, Gua
2022-12-01 2:01 ` Guo, Gua
2022-12-18 5:21 ` Jiading Zhang
2022-12-19 1:04 ` Guo, Gua [this message]
2022-12-19 12:55 ` Jiading Zhang
2022-12-20 1:24 ` Guo, Gua
2022-12-20 4:08 ` Guo, Gua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR11MB5478B56D448D3346FB05037BEFE59@BL1PR11MB5478.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox