From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.4348.1660208223468185262 for ; Thu, 11 Aug 2022 01:57:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QifN3+Hb; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660208223; x=1691744223; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hgyD2e3Muoq1oYnzPvzRgGSnJIJJWCteBKLw4BqA+IQ=; b=QifN3+HbuGQlJu0ufx/zUamhbWfD8jSl3b8dzj63iGImUIXjDIAov6ND Vy4VCyRW18NNSmTmiSpD5XsFUiHjK1Iv6RSSSDsdQfSKcIzlUFl5UagLH 5HbWbZubd1+/Df+3ho+UnVXqa5sVxbDyk8uhnJJKuFMJ2h0DtcNvxVDzq 7kswfEARE2Q6RH/YTHU6L5KWn6DOEUdAndI9KSML0wtQJ0iofgluUBLE5 LbJnZvmwIsci3ZDoszn90GMLcPkaXTgqYthT/VSwhi3ufwYisEAz5UrEU 7XICFteBFVrmLvTbr/b1CU97QECdrBwPRkCbSbkSwoldheEf+YY9iDxA7 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="288866383" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="288866383" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 01:57:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="634141727" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 11 Aug 2022 01:57:02 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 01:57:01 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 01:57:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 11 Aug 2022 01:57:01 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 11 Aug 2022 01:57:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JFKG1wdHzcbH2cDqlYmzRikPXmPkIGjENSK4GpsmPqOocsRq/DUKeWiSZVyexz+jdNL2UhL1Mg7hsiEX2MbZROEI1miAHs92jhcvQGME8c3xQrWwYNXYnRSJRP1E31qs22mhMmcu0u8JtkDgOsBvcdWanNHanhjYLXAQ0DI8hk4Zxy+C2ZUXVagQMnxMxa3GJJGfdqRnQZbZf6S4+KVJRmo2HofnSBTf1SZ6cZSW9aDMQ1xJ9qpnjp8z9NluXbfq0Y7DPuE8wJvE1409Z1X8OkFPx8zEJXIP8YvSgqr6auIiDif9NxydsgSH5FqZFWac1mKWG4TAO6iKgl7CNdCBog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jZ/oIL0BG3d6eOX08wWD4kpJrBUFbkmP5N5ybrYLSPY=; b=LT3R7UpuIxW9YSDJe6JMx7IMuHj4cBGIi3m44zojkVuAQhddq2hMnjGvOEN/dM1el0S0oDifbNtHRVZAqGlZCKFzJPNQbRsjXvldXNaaWbAUR1mGe911zxVsmzAQZBivLHAKxlBUmxOVD4ky2Wdi3I3mMEyL9Am+w3PJqeoK5fM+K9lSjVTJBy8QMteNY43WYIqfwY+O5XbYw+OIaagU0aOP7R81gcwUGRI6Z1weswH+oQDeX1o9C7PPuGjAt6Ta3pXqtEFXWJmIww0gSZEscUHYaFxdYUUUpttwf5vWBhVk5s/CbhWRZZqcIIVCI+8F5pGbIRFBH/0Mjz/eETjfoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by BN6PR11MB1827.namprd11.prod.outlook.com (2603:10b6:404:fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Thu, 11 Aug 2022 08:56:47 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::47a:29ec:5955:96c0]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::47a:29ec:5955:96c0%7]) with mapi id 15.20.5525.010; Thu, 11 Aug 2022 08:56:47 +0000 From: "Guo, Gua" To: "Sravanthi, K KavyaX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ni, Ray" , "Rhodes, Sean" Subject: Re: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL Thread-Topic: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL Thread-Index: AQHYrVKEgXp6XUP3REC/08Ddpsk9062pZbxA Date: Thu, 11 Aug 2022 08:56:47 +0000 Message-ID: References: <20220811070739.1973-1-k.kavyax.sravanthi@intel.com> In-Reply-To: <20220811070739.1973-1-k.kavyax.sravanthi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0e1d6ef-47ee-46c1-56da-08da7b776c57 x-ms-traffictypediagnostic: BN6PR11MB1827:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MI1KGQHElsUQTSQvSBJe0lqYE2r/Yaj6tQDattEWmcCLc+KfLnnWwLeAOfzGYbBGFGT7fkZ/e32I/wfjJm+sZNtuebL3OJLosa2mBNjHAhaMA3VpqAZ14+vNn2O8PZtECYgToQ17t+Lv/c1zNEv0pnJ9zDHOLj49bTqEbzTza+1LLysPrX/4uX5KfeqVwv+Mv5yLNNqeXpmjG1rEsny7Kc3yO0JcqCFLGEr9OxbKDrUaoo16HO+P8nUMyhS17NOxLXnffIjjHoGOEHnpxTbKHWNTmsldKJkO/cJQQqUHqpJvo2p4s+x0KRJf2+yMZrEcjKs4i3S+hIAjUpD0re6zqRsaJpDGN2ucMzxp0Le/+2EqCq5Blmbx2P9mk2qO7R/DUuIatcKmphMKDCHT+XLVUPW01jh5t0uywi3lcl51dHAiUxIT1IpscYJL64fNjSSJ4VdrtFZmrYS2oHSrg5gGuM9h4c6LP4Av7hAbqLLi5O7YLBGvPZUC3dQ2y2H16WRkdlsG87p2rAljLXDZ4dDVJZF06W07prtvCmIxOVXaG3BbN/pHWNCCq73GTFXwUNMrq+Rvky1DWXFjukuZNqBbkXndRjzUD7d1evBG+jGaTlMADJhHG4Jd19d8ryuy0Dc+o8dejmnLWAhJCCXkhqzMd8FbeYqxHqhXHmgpmfn/mviIJTHpGBUXXKIGYaRvrDR15q0OGz7oWyslDc5g88f9aoXoHPo0lSD8YE31g+p+Bozk2vwvrBfBafwLDYZ7YxPKdke1ewajK2wUMZgyE19Ycy5PHSRdQAf4FaQJecmDfAQAflVGZK83LANlEFoYD8/F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(366004)(346002)(136003)(396003)(33656002)(86362001)(122000001)(9686003)(53546011)(7696005)(6506007)(83380400001)(82960400001)(38070700005)(186003)(478600001)(41300700001)(54906003)(316002)(26005)(71200400001)(8676002)(66446008)(66946007)(66476007)(64756008)(66556008)(76116006)(52536014)(8936002)(5660300002)(38100700002)(4326008)(2906002)(110136005)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?13Y3lLe0iC2K7zl54sHNo8cuK3ZCLeX2hyPBpUWcM3yuLtUSA7OgNLA3PVc/?= =?us-ascii?Q?kISgUonAA+fc8BrbYFhNK5fGfamu3QvC3901XO5z/4IXVgQcuCd8/5gfu9Pz?= =?us-ascii?Q?RN52npPbRkAA+CsKpduifSjFo+TmO1qMM+bgP/99LxncQpFod4wt7y2mJ0KH?= =?us-ascii?Q?JbPSFJ9TPFdPqpl7H0ExmCvimqWY3EyGMXWV4dF0wZsAEua6EXDMlpNBf9Ht?= =?us-ascii?Q?0XwH3lX61h99MSCMuTL8dFLO2f8Znnt+SaebIfXlO8R27wjPCDbu7kFA+zle?= =?us-ascii?Q?j5p0D5tGkpFciIzOwv1jO7FObzIH1BvsRHtQmYod/qfN5vs9UI/w3zw+YPm+?= =?us-ascii?Q?HgYqEoe8FZntIAr7BxRKDEUugtdhI3+QMWJduCBSt+gS7Fw0I5hjV3Xr98n3?= =?us-ascii?Q?eWRAePvchrpDJ++NAomqO8Pe+5oMfu1S8RDyFXpyaPND0LcDtItcjuzaQg0W?= =?us-ascii?Q?Vu1OPlRV3ZmotH1JR1NC30bCwYPrSr3aM8R0hwg1HPEyoCcvuAEI837Otk6u?= =?us-ascii?Q?1YST2oILGGc3C/48Pic24bLKKMm8E5k+G08JqCV7EkYBAtvNBM9g47rjnSRj?= =?us-ascii?Q?Yem78G5IKzYK5NcGGSUWiw3whgTT8Sv/UfuK9oOlMrIbg+V8p/2vYgD12hGz?= =?us-ascii?Q?ccl6yqQatT8UA5b4n60qvW484y/3VpHFSOkalffRhCi/6BV+0SryELNyFabU?= =?us-ascii?Q?LsIVuG4JoR/Vs6GJgI1WeagFMJ1GfUuUefhUULW0pZvpuYIZ//WfBQidtINf?= =?us-ascii?Q?BE4nZIRhETeP0Md5hpagNehFax/h6qHmC9Y9giNHR3OJ8ZIIi4cCR8WPPRYs?= =?us-ascii?Q?4ZlpnyQGnB5agIMv28lvfoJnjKk4MRSAeYuSLoemHoW8TtkTWCHlwC5cSVwS?= =?us-ascii?Q?0+pHjv0Sn3EAYz7tVJSetqP4ceJhpoXyPTBIUutABn5dKp4s3R+62jA2J5TI?= =?us-ascii?Q?FQRNL/PIh1SLLUxMLKeCax+vH2OBk69rCrf9Mal28GYFoQPTM1J03CgwdMog?= =?us-ascii?Q?c9GfP/MO9eYg9vZmlziIbQ7hCJIMKjyOvChf+DoBG6nz5MhFPR1tjQViA0YA?= =?us-ascii?Q?Y8WuK2Lg0eT9qgUieAl6MoH0Gqdtm2drIHent7Nw/TceZz+EhE4hrKjRnHqY?= =?us-ascii?Q?CwDwrg0eM6TzS/yMbVnhVmq/lSa5SI2stkMiNFhVayW8rBc0cDNrV8235Ph6?= =?us-ascii?Q?XNaV1j+1ZYFdnQ/LZZ5la/AmNX4hVpMD+Xsbf7mN9Hj/Cd0sTO1dKW7o7TB/?= =?us-ascii?Q?GRFHATVWWUI31RJRaQPwrtJaMaBjQEiN2gbggYVvxpgBCqK2tH5o55Q5jhCs?= =?us-ascii?Q?6YBeTRsAPaQ4CdN+atFSs1PL5vlwe59KwVAztTTc539OAcI/6uYHTn1g7or3?= =?us-ascii?Q?/E+cajetGqVkvtlaCHL9YTsAEBOg1uwXocrwqR+lavM/HN0nN3XlOqT6tajT?= =?us-ascii?Q?+wyK1Cw952hN5S7FW8wqVM1EFf7/a7Q8Aup28cPKh7MzCFbWg5WU8WuT579Y?= =?us-ascii?Q?h65Qcb7vOuDzYLCyTGEXuRMOtBO9FkRxeqqYlcOqAPetrixrEqpSxOz10/5c?= =?us-ascii?Q?IWVOuDXxvrn0b09mPLQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0e1d6ef-47ee-46c1-56da-08da7b776c57 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2022 08:56:47.4709 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZqxdK9OxrUx+TOe0DGSKLqpbCYb/SadmE3wyi2V5o0P6BjmdNj5d81O4fYLzvan5VaEnaS4yD7Pa+NGg96CF7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1827 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewd-by: Gua Guo -----Original Message----- From: Sravanthi, K KavyaX =20 Sent: Thursday, August 11, 2022 3:08 PM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration t= o FALSE when root bridge count is zero. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Signed-off-by: Kavya --- UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c= b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c index e1faa24ae7..fb76853072 100644 --- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c +++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c @@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob ( } =20 if (PciRootBridgeInfo->Count =3D=3D 0) { + PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE); return NULL; } =20 @@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob ( if (PciRootBridgeInfo->ResourceAssigned) { PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE); } else { - DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is F= ALSE\n")); + DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is=20 + FALSE\n")); PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE); - return NULL; } =20 return PciRootBridges; -- 2.30.2.windows.1