From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.40157.1671499970144867314 for ; Mon, 19 Dec 2022 17:32:50 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EW1GgN5v; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671499970; x=1703035970; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vm4ip1xAbElOLMfD0tAp4rZr5yBoSdHLTXxYjf0/itc=; b=EW1GgN5vUYvEenKn23gpTJhmpvdDHBfBE/83WxBx3OB7rl8J+rpNxCee YJO0S6sKCeDc9V3nEZ3fV/KhlXYWYI/72dxRuwi8oZaV6pgOl4p/UgbiE Wr3HuR1SGZppz3KBmkszugXTAKkCdTFqT38CSGuQdg8F+BvWnhFM5hEpq q4zbC1G8jIk4PsGbZgbOoUeG8fySMCXQGQWP1uJG3bOAnZNWIFXwtdnKB 4o4KwUzrrO2fb8jcn6T6l43dEpeSXd3vdnJRnjVMqiIUzV+SzQ1FsdaT9 SdlUTXiZd00zH6zZY0cBDcrXCZ2deT6eGk8l6xr/eGBJSiF4mbuLbq3+A w==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="302920228" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="302920228" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 17:32:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="644229078" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="644229078" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 19 Dec 2022 17:32:49 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 19 Dec 2022 17:32:48 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 19 Dec 2022 17:32:48 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 19 Dec 2022 17:32:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/V57Qc0wYmoAAZMlvbJOz3swZ7oLCTfR+fItmf1DXd9k6OW0XLfLftmzfUueuO8d4oq8g5TvJSkW5+anYkFIxinIim3R+WYGgvKq1l65pX9293cns2Oa3eR7kq0dyORW+fWmhH4UcIq/r7yCloKZs9MI7yVWZ1tXMgjB8EAiuyfcmzoJL9Dk5zOOpQKRJi9R4VRzQC0kDCSGziNsPUPKvuVieopEQ7V4aBSZo71KQBtdKRKW34oSoI8OM83L5xylu4OjIR/C9RNKOqovROV8yR8Nic7novpqwDvwDx+BdgVyHfHoOTIahm1/TUyj8H3cZ+xyF73Px4bm0+yqRru/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N3A+NItalDBmCfzTn1P5asg6jw5y6eU/SgGDPT4zuWw=; b=kA3mkFIRAPKFYhj/nTgIHPpGkbDkZVhffbmRNMmSwhFtaBkpNRpHRatYj4s3L9hDXzPoM7fiIJsAqpKlgDe4fe07sEbJSpolHLyRToymzr8Pm2iTRAz6CmDSAjKbbCV+34fq95absngsk+yANfwNMRFBWh/fbiqafxDCcyTTpApzUL5ncwL6/zkv+qgWTQwzeXbBJDE5Id7T8t89yXMhnc8SDunKN4gb9xIdN18poS6vc9Dmi50AMGuFQszNjPMhl+pnYYFBMaPS0KIFzJQlN5IHZ3Nlgx5/APk7kEABxk4UfncXzhB3NXIHJ+uaQqoWH3GUZoexkDtf+lRAM6qHFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by PH0PR11MB5831.namprd11.prod.outlook.com (2603:10b6:510:14b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Tue, 20 Dec 2022 01:32:44 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::eb2d:a316:8bcd:3fb6]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::eb2d:a316:8bcd:3fb6%8]) with mapi id 15.20.5924.016; Tue, 20 Dec 2022 01:32:44 +0000 From: "Guo, Gua" To: "Ni, Ray" , "Liu, KasimX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Lu, James" Subject: Re: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD Thread-Topic: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD Thread-Index: AQHZE30YCY6djuIDZE6XOqoMzvOYTK501CYAgAEpS8A= Date: Tue, 20 Dec 2022 01:32:44 +0000 Message-ID: References: <20221219073944.3142-1-kasimx.liu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|PH0PR11MB5831:EE_ x-ms-office365-filtering-correlation-id: a5ba1932-8ded-4fac-5a95-08dae22a17b8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TUz0u4q8KCPh11ie3ryayw1L9mA0Oa1FBLjryPv8OZpTEvDVuTIdNDeQFNIg9f1nLyZY26mqLUXDDkVQ27E+TO/s049pc2bi06Nd2Kr0gA4cjJEgPH5TTASKbU3fkGoIMm+dgzfS5FP+uI5fV9DwKe7gVzBEpjGpeM0UY73GX/+8C4/0fih89eijksn8m/4cLqOfmttubj05kTrr53rF6D2bK+oliAVe+N6UcD1AJX152OxGUy3Xg5/k/a/j6G1vbwuOyOsZRCQrrdK7amhiWlglTcWWI1cIsXd+FY8elbYBNxH6x1nhRg/3gOHbksrzoXLdwD6xR9mjuyFAHKvGZgwt1SjxiiuXW9IYXFZIk0xPKYpTJzoabxp/5nNwe/RiLKc7lefw8khuc3/N6sK1xsbDL4Tqy0NYv6bld4e3ThF+AKtRJ+fMW9gNc/0GL6duOsfenIue69ty7pWPll8UKgk2LwyXpC+ukbZ5N56aqoPw60LwwIJLv6Tfy3qm3ArgDhyhzBKrkqiLtjERGZ0W+FNl0b+52Fulkcfd+CUxJUQ0WPOxmsOICnxJ+yfN+KdNUhc5c8tvy6jMkdSal+qCRMxXy7AQD7+PtiMm/+lnIIKR67N7YERvQf/yIqXjIlS8fj+gQmrTf3QzXcXnVGurwtJICvymKpHX2AR9ff2K4SaspSIenTaaWAvRyexvEmLKgfPYYnKJJ1ATwA8ZJDAEDQBWjTktX7Gkjg0mCfqITPY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(136003)(39860400002)(346002)(376002)(366004)(396003)(451199015)(2906002)(8676002)(55016003)(86362001)(66446008)(66946007)(76116006)(66476007)(4326008)(186003)(26005)(52536014)(71200400001)(33656002)(478600001)(41300700001)(966005)(110136005)(54906003)(6506007)(316002)(7696005)(107886003)(122000001)(38070700005)(82960400001)(38100700002)(8936002)(5660300002)(53546011)(9686003)(66556008)(64756008)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p3vBysLcmL2/JSnwQtZHmGRSzET5DBWJLZHStkhu9Bj9n6FjKpdFEiqFjH1p?= =?us-ascii?Q?iuQnAM8+KoFJRGu86rZ7TbeMKFkuOlWAgf9bdyhv25PWNVehNDsEOkKMoqf+?= =?us-ascii?Q?WPdC8g+lCnFFBWsaZjN5FpxnjCxSS8481lOVr4Z/3kIefZmQjVKYDhoNAmjC?= =?us-ascii?Q?zT1UKUkKSdZpoQyWeO/KafI3+1ZpU/uWYj6pAxwWFARA615JZrtIaWVS4Xy0?= =?us-ascii?Q?8+x2YVSJNmueCDM62UzTTUVr5qJ6nXcVFLAzCtQoFd7tjXOnHpYSuibtNUi1?= =?us-ascii?Q?qlwXW4pu5Bxy65TwrWbaO/WS42Q8FFKwFbKpmL2HMHU7fdc4phVcfQLFZnys?= =?us-ascii?Q?7DSIC9UgtSWVns4pips0Cg0MdOTBGlRODuDymn0n+DyedlYEulPmPYYyuK9O?= =?us-ascii?Q?ozsIGkaZLB5Gl8sO8iwf2y+8KicabWHytVSrAH0quCRG+rWx9OKvFyl1wwXf?= =?us-ascii?Q?DdBFh/E/vFy3k+NMUMofE3T/oo1dq3B/XiFVXO3X9IP0ti8abhExCmEmsbXk?= =?us-ascii?Q?ybp+nHjjuVqEF90G36bY6vgNGkBi3Jjid9qfENa0kJSoghKzB8GrEkJ3TPQr?= =?us-ascii?Q?xocni5b2BC11vbqu6zb5aWRQ+ob/X/9fxZH5NrR84PN24KqlQXF41zHWawQ1?= =?us-ascii?Q?WI5eEeUAtPlYHgIyT8CqBS8QltwxsPgb0QbKbQT7cvR9MMgvakAj49aWAcvT?= =?us-ascii?Q?ePQkcJBckxj86k3aa3jq/ZhY9TZnV8xRdt+wfbXQafRc+6KxxI4sjB1SbbQ9?= =?us-ascii?Q?iPMiM83SCdWS3hFlw+a4z3uertCNE1CoA7B+sBVxLPYADEOBdjZntjbpYM/4?= =?us-ascii?Q?jrO6D86vDDNTJkhfeZSAiL+0o9XcDpGMBhIW7FrrVmWMaWYWyC2rUHnRvXNP?= =?us-ascii?Q?DrNRf3EqrX2swmC15DK5FzWpJbXxfzPnjGenest6KfiKJis9rKaQfd7d3UfP?= =?us-ascii?Q?D1l9IzZf3vLC+WRrg/HbunRvr8Gep/W5uYQBrWDpWwluK2vZIxoktq93DINQ?= =?us-ascii?Q?YvyiYpw0Olps3UKFqkL/arB4fFnKmU5NBDy6M/bl0U4GSK0MVBLHG6zsfEC0?= =?us-ascii?Q?CGDCC9SrPaK7ZgePVNJDax8OQZZDMM0r9CrOKFrryygsVNQ9Sa9FAoKIzX13?= =?us-ascii?Q?EqyHH+a2xP15cfrXNFRY4wJOnSLAzGlfMBNkJtnYwzebTZ/CebtF/vzytNvR?= =?us-ascii?Q?LXpsxJf5nqh8TT04vwrSvoKPSdMbVLMvSYg7TUZkZAesVib7G1sZXhst3s4F?= =?us-ascii?Q?n1MR4Ku8jbVyqJA9cwJ5FpUKgjYnDnM7c8JYKC/M0IPKh0gV6uUcD/Q9QLV7?= =?us-ascii?Q?YzvvhfQbrZssq5TItLKEW10XpmWhhIuLHy7VvpUD+uxw7zkqE7AQt/nsc9Hq?= =?us-ascii?Q?PmYPo5n281VsRuRKaHlwXtUouMVYhBe85ITEGz2tyXiXH64wQKqu+ZzV74ZX?= =?us-ascii?Q?FIAy74zI9D8d4ogAllM93iRaLHf01gTR5IvI2LkPPO70o4jgXhOuSXJbTHN3?= =?us-ascii?Q?rXBZOlyzTlQrki7kLR9EjNO0UniSP6LzcfLQEC+zmTSgwguRsNx+1wibVFji?= =?us-ascii?Q?ec2kXy6O3+sQqlKoa1E=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5ba1932-8ded-4fac-5a95-08dae22a17b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2022 01:32:44.0651 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y+SSNkN9JiKSizYpufh43wKI1bcD42bUpPlCU2HotrgdszPMzAIA2lWANGDNPNjyoOcwhkVTAaUAQfdOx5oxuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5831 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The goal reduce macro requirement to build UniversalPayloadBuild.py. For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and genera= te HOB data. So the change is move these PCD have compatibility FixedAtBuild only to Fix= edAtBuild + Dynamic. Thanks, Gua Guo -----Original Message----- From: Ni, Ray =20 Sent: Monday, December 19, 2022 3:43 PM To: Liu, KasimX ; devel@edk2.groups.io Cc: Dong, Guo ; Lu, James ; Guo, Gu= a Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD The initial goal was to remove dynamic PCD dependency from bootloader. Is that still the goal? If yes, maybe depending on dynamic PCD is not a good idea. Thanks, Ray > -----Original Message----- > From: Liu, KasimX > Sent: Monday, December 19, 2022 3:40 PM > To: devel@edk2.groups.io > Cc: Liu, KasimX ; Dong, Guo=20 > ; Ni, Ray ; Lu, James=20 > ; Guo, Gua > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD >=20 > From: KasimX Liu >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4193 >=20 > In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro=20 > list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to=20 > PcdsDynamicEx >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: James Lu > Cc: Gua Guo > Signed-off-by: KasimX Liu > --- > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec=20 > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > index ed2d95550b..a53ca777e8 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > @@ -84,6 +84,14 @@ > # @Prompt RTC Target Register address >=20 > =20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0000 > 0023 >=20 >=20 >=20 > + ## Specifies RTC Index Register address in I/O space. >=20 > + # @Prompt RTC Index Register address >=20 > + =20 > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x00000 > + 01E >=20 > + >=20 > + ## Specifies RTC Target Register address in I/O space. >=20 > + # @Prompt RTC Target Register address >=20 > + =20 > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000 > + 001F >=20 > + >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule] >=20 > ## Defines the ACPI register set base address. >=20 > # The invalid 0xFFFF is as its default value. It must be configured t= o the real value. >=20 > @@ -146,14 +154,6 @@ > # @Prompt Initial value for Register_D in RTC. >=20 > =20 > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0 > x0000001D >=20 >=20 >=20 > - ## Specifies RTC Index Register address in I/O space. >=20 > - # @Prompt RTC Index Register address >=20 > - =20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001 > E >=20 > - >=20 > - ## Specifies RTC Target Register address in I/O space. >=20 > - # @Prompt RTC Target Register address >=20 > - =20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000 > 1F >=20 > - >=20 > ## RTC Update Timeout Value(microsecond). >=20 > # @Prompt RTC Update Timeout Value. >=20 > =20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UIN > T32|0x00000020 >=20 > -- > 2.32.0.windows.2