* [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD @ 2022-12-19 7:39 kasimx.liu 2022-12-19 7:43 ` Ni, Ray 0 siblings, 1 reply; 5+ messages in thread From: kasimx.liu @ 2022-12-19 7:39 UTC (permalink / raw) To: devel; +Cc: KasimX Liu, Guo Dong, Ray Ni, James Lu, Gua Guo From: KasimX Liu <kasimx.liu@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx Cc: Guo Dong <guo.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: James Lu <james.lu@intel.com> Cc: Gua Guo <gua.guo@intel.com> Signed-off-by: KasimX Liu <kasimx.liu@intel.com> --- PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec b/PcAtChipsetPkg/PcAtChipsetPkg.dec index ed2d95550b..a53ca777e8 100644 --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec @@ -84,6 +84,14 @@ # @Prompt RTC Target Register address gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x00000023 + ## Specifies RTC Index Register address in I/O space. + # @Prompt RTC Index Register address + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001E + + ## Specifies RTC Target Register address in I/O space. + # @Prompt RTC Target Register address + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000001F + [PcdsFixedAtBuild, PcdsPatchableInModule] ## Defines the ACPI register set base address. # The invalid 0xFFFF is as its default value. It must be configured to the real value. @@ -146,14 +154,6 @@ # @Prompt Initial value for Register_D in RTC. gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0x0000001D - ## Specifies RTC Index Register address in I/O space. - # @Prompt RTC Index Register address - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001E - - ## Specifies RTC Target Register address in I/O space. - # @Prompt RTC Target Register address - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000001F - ## RTC Update Timeout Value(microsecond). # @Prompt RTC Update Timeout Value. gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UINT32|0x00000020 -- 2.32.0.windows.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD 2022-12-19 7:39 [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD kasimx.liu @ 2022-12-19 7:43 ` Ni, Ray 2022-12-20 1:32 ` Guo, Gua 0 siblings, 1 reply; 5+ messages in thread From: Ni, Ray @ 2022-12-19 7:43 UTC (permalink / raw) To: Liu, KasimX, devel@edk2.groups.io; +Cc: Dong, Guo, Lu, James, Guo, Gua The initial goal was to remove dynamic PCD dependency from bootloader. Is that still the goal? If yes, maybe depending on dynamic PCD is not a good idea. Thanks, Ray > -----Original Message----- > From: Liu, KasimX <kasimx.liu@intel.com> > Sent: Monday, December 19, 2022 3:40 PM > To: devel@edk2.groups.io > Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James > <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > From: KasimX Liu <kasimx.liu@intel.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 > > In order to remove RTC_INDEX/RTC_TARGET from > the UplBuild macro list,change the RTC_INDEX > /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx > > Cc: Guo Dong <guo.dong@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: James Lu <james.lu@intel.com> > Cc: Gua Guo <gua.guo@intel.com> > Signed-off-by: KasimX Liu <kasimx.liu@intel.com> > --- > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec b/PcAtChipsetPkg/PcAtChipsetPkg.dec > index ed2d95550b..a53ca777e8 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > @@ -84,6 +84,14 @@ > # @Prompt RTC Target Register address > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x00000023 > > > > + ## Specifies RTC Index Register address in I/O space. > > + # @Prompt RTC Index Register address > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001E > > + > > + ## Specifies RTC Target Register address in I/O space. > > + # @Prompt RTC Target Register address > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000001F > > + > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > ## Defines the ACPI register set base address. > > # The invalid 0xFFFF is as its default value. It must be configured to the real value. > > @@ -146,14 +154,6 @@ > # @Prompt Initial value for Register_D in RTC. > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0x0000001D > > > > - ## Specifies RTC Index Register address in I/O space. > > - # @Prompt RTC Index Register address > > - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001E > > - > > - ## Specifies RTC Target Register address in I/O space. > > - # @Prompt RTC Target Register address > > - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000001F > > - > > ## RTC Update Timeout Value(microsecond). > > # @Prompt RTC Update Timeout Value. > > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UINT32|0x00000020 > > -- > 2.32.0.windows.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD 2022-12-19 7:43 ` Ni, Ray @ 2022-12-20 1:32 ` Guo, Gua 2022-12-20 8:54 ` Ni, Ray 0 siblings, 1 reply; 5+ messages in thread From: Guo, Gua @ 2022-12-20 1:32 UTC (permalink / raw) To: Ni, Ray, Liu, KasimX, devel@edk2.groups.io; +Cc: Dong, Guo, Lu, James The goal reduce macro requirement to build UniversalPayloadBuild.py. For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate HOB data. So the change is move these PCD have compatibility FixedAtBuild only to FixedAtBuild + Dynamic. Thanks, Gua Guo -----Original Message----- From: Ni, Ray <ray.ni@intel.com> Sent: Monday, December 19, 2022 3:43 PM To: Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD The initial goal was to remove dynamic PCD dependency from bootloader. Is that still the goal? If yes, maybe depending on dynamic PCD is not a good idea. Thanks, Ray > -----Original Message----- > From: Liu, KasimX <kasimx.liu@intel.com> > Sent: Monday, December 19, 2022 3:40 PM > To: devel@edk2.groups.io > Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo > <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James > <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > From: KasimX Liu <kasimx.liu@intel.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 > > In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro > list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to > PcdsDynamicEx > > Cc: Guo Dong <guo.dong@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: James Lu <james.lu@intel.com> > Cc: Gua Guo <gua.guo@intel.com> > Signed-off-by: KasimX Liu <kasimx.liu@intel.com> > --- > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > index ed2d95550b..a53ca777e8 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > @@ -84,6 +84,14 @@ > # @Prompt RTC Target Register address > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0000 > 0023 > > > > + ## Specifies RTC Index Register address in I/O space. > > + # @Prompt RTC Index Register address > > + > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x00000 > + 01E > > + > > + ## Specifies RTC Target Register address in I/O space. > > + # @Prompt RTC Target Register address > > + > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000 > + 001F > > + > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > ## Defines the ACPI register set base address. > > # The invalid 0xFFFF is as its default value. It must be configured to the real value. > > @@ -146,14 +154,6 @@ > # @Prompt Initial value for Register_D in RTC. > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0 > x0000001D > > > > - ## Specifies RTC Index Register address in I/O space. > > - # @Prompt RTC Index Register address > > - > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001 > E > > - > > - ## Specifies RTC Target Register address in I/O space. > > - # @Prompt RTC Target Register address > > - > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000 > 1F > > - > > ## RTC Update Timeout Value(microsecond). > > # @Prompt RTC Update Timeout Value. > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UIN > T32|0x00000020 > > -- > 2.32.0.windows.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD 2022-12-20 1:32 ` Guo, Gua @ 2022-12-20 8:54 ` Ni, Ray 2022-12-21 2:55 ` 回覆: " Liu, KasimX 0 siblings, 1 reply; 5+ messages in thread From: Ni, Ray @ 2022-12-20 8:54 UTC (permalink / raw) To: Guo, Gua, Liu, KasimX, devel@edk2.groups.io; +Cc: Dong, Guo, Lu, James OK. I see. I am fine with that. Reviewed-by: Ray Ni <ray.ni@intel.com> > -----Original Message----- > From: Guo, Gua <gua.guo@intel.com> > Sent: Tuesday, December 20, 2022 9:33 AM > To: Ni, Ray <ray.ni@intel.com>; Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com> > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > The goal reduce macro requirement to build UniversalPayloadBuild.py. > > For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. > > For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate HOB data. > > So the change is move these PCD have compatibility FixedAtBuild only to FixedAtBuild + Dynamic. > > Thanks, > Gua Guo > > -----Original Message----- > From: Ni, Ray <ray.ni@intel.com> > Sent: Monday, December 19, 2022 3:43 PM > To: Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > The initial goal was to remove dynamic PCD dependency from bootloader. > Is that still the goal? > If yes, maybe depending on dynamic PCD is not a good idea. > > Thanks, > Ray > > > -----Original Message----- > > From: Liu, KasimX <kasimx.liu@intel.com> > > Sent: Monday, December 19, 2022 3:40 PM > > To: devel@edk2.groups.io > > Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo > > <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James > > <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> > > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > > > From: KasimX Liu <kasimx.liu@intel.com> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 > > > > In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro > > list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to > > PcdsDynamicEx > > > > Cc: Guo Dong <guo.dong@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: James Lu <james.lu@intel.com> > > Cc: Gua Guo <gua.guo@intel.com> > > Signed-off-by: KasimX Liu <kasimx.liu@intel.com> > > --- > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > index ed2d95550b..a53ca777e8 100644 > > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > @@ -84,6 +84,14 @@ > > # @Prompt RTC Target Register address > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0000 > > 0023 > > > > > > > > + ## Specifies RTC Index Register address in I/O space. > > > > + # @Prompt RTC Index Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x00000 > > + 01E > > > > + > > > > + ## Specifies RTC Target Register address in I/O space. > > > > + # @Prompt RTC Target Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000 > > + 001F > > > > + > > > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > > > ## Defines the ACPI register set base address. > > > > # The invalid 0xFFFF is as its default value. It must be configured to the real value. > > > > @@ -146,14 +154,6 @@ > > # @Prompt Initial value for Register_D in RTC. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0 > > x0000001D > > > > > > > > - ## Specifies RTC Index Register address in I/O space. > > > > - # @Prompt RTC Index Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001 > > E > > > > - > > > > - ## Specifies RTC Target Register address in I/O space. > > > > - # @Prompt RTC Target Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000 > > 1F > > > > - > > > > ## RTC Update Timeout Value(microsecond). > > > > # @Prompt RTC Update Timeout Value. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UIN > > T32|0x00000020 > > > > -- > > 2.32.0.windows.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* 回覆: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD 2022-12-20 8:54 ` Ni, Ray @ 2022-12-21 2:55 ` Liu, KasimX 0 siblings, 0 replies; 5+ messages in thread From: Liu, KasimX @ 2022-12-21 2:55 UTC (permalink / raw) To: Ni, Ray, Guo, Gua, devel@edk2.groups.io; +Cc: Dong, Guo, Lu, James [-- Attachment #1: Type: text/plain, Size: 5392 bytes --] Hi @Ni, Ray<mailto:ray.ni@intel.com> I've created the PR, could you help me add push label when you're available. https://github.com/tianocore/edk2/pull/3804 Thanks. [https://opengraph.githubassets.com/3850aa42841dc80e2908f3ef5866e2d1f35925baaf2b87c6c38d33bc42564239/tianocore/edk2/pull/3804]<https://github.com/tianocore/edk2/pull/3804> PcAtChipsetPkg: Move RTC PCD to dynamic PCD by kasimxliu · Pull Request #3804 · tianocore/edk2<https://github.com/tianocore/edk2/pull/3804> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDyna... github.com ________________________________ 寄件者: Ni, Ray <ray.ni@intel.com> 寄件日期: 2022年12月20日 下午 04:54 收件者: Guo, Gua <gua.guo@intel.com>; Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io> 副本: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com> 主旨: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD OK. I see. I am fine with that. Reviewed-by: Ray Ni <ray.ni@intel.com> > -----Original Message----- > From: Guo, Gua <gua.guo@intel.com> > Sent: Tuesday, December 20, 2022 9:33 AM > To: Ni, Ray <ray.ni@intel.com>; Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com> > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > The goal reduce macro requirement to build UniversalPayloadBuild.py. > > For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. > > For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate HOB data. > > So the change is move these PCD have compatibility FixedAtBuild only to FixedAtBuild + Dynamic. > > Thanks, > Gua Guo > > -----Original Message----- > From: Ni, Ray <ray.ni@intel.com> > Sent: Monday, December 19, 2022 3:43 PM > To: Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > The initial goal was to remove dynamic PCD dependency from bootloader. > Is that still the goal? > If yes, maybe depending on dynamic PCD is not a good idea. > > Thanks, > Ray > > > -----Original Message----- > > From: Liu, KasimX <kasimx.liu@intel.com> > > Sent: Monday, December 19, 2022 3:40 PM > > To: devel@edk2.groups.io > > Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo > > <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James > > <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> > > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > > > From: KasimX Liu <kasimx.liu@intel.com> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 > > > > In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro > > list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to > > PcdsDynamicEx > > > > Cc: Guo Dong <guo.dong@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: James Lu <james.lu@intel.com> > > Cc: Gua Guo <gua.guo@intel.com> > > Signed-off-by: KasimX Liu <kasimx.liu@intel.com> > > --- > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > index ed2d95550b..a53ca777e8 100644 > > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > @@ -84,6 +84,14 @@ > > # @Prompt RTC Target Register address > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0000 > > 0023 > > > > > > > > + ## Specifies RTC Index Register address in I/O space. > > > > + # @Prompt RTC Index Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x00000 > > + 01E > > > > + > > > > + ## Specifies RTC Target Register address in I/O space. > > > > + # @Prompt RTC Target Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000 > > + 001F > > > > + > > > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > > > ## Defines the ACPI register set base address. > > > > # The invalid 0xFFFF is as its default value. It must be configured to the real value. > > > > @@ -146,14 +154,6 @@ > > # @Prompt Initial value for Register_D in RTC. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0 > > x0000001D > > > > > > > > - ## Specifies RTC Index Register address in I/O space. > > > > - # @Prompt RTC Index Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001 > > E > > > > - > > > > - ## Specifies RTC Target Register address in I/O space. > > > > - # @Prompt RTC Target Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000 > > 1F > > > > - > > > > ## RTC Update Timeout Value(microsecond). > > > > # @Prompt RTC Update Timeout Value. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UIN > > T32|0x00000020 > > > > -- > > 2.32.0.windows.2 [-- Attachment #2: Type: text/html, Size: 11658 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-21 2:55 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-19 7:39 [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD kasimx.liu 2022-12-19 7:43 ` Ni, Ray 2022-12-20 1:32 ` Guo, Gua 2022-12-20 8:54 ` Ni, Ray 2022-12-21 2:55 ` 回覆: " Liu, KasimX
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox