* [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
@ 2022-11-11 0:56 Jiading Zhang
2022-11-11 1:39 ` [edk2-devel] " Guo, Gua
0 siblings, 1 reply; 8+ messages in thread
From: Jiading Zhang @ 2022-11-11 0:56 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 2273 bytes --]
The following PCDs have no value in UefiPayloadPkg.dsc，and they can not pass the Ecc tool check, so assign the default values the same as they are in *.dec file.
gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize
gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds
gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
Signed-off-by: jdzhang <jdzhang@kunluntech.com.cn>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 1150be6acd..ce7d3a7f89 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -530,14 +530,14 @@
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY)
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS)
gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE)
- gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize
- gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds
- gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode
- gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
- gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|TRUE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport|FALSE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|TRUE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|50000
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode|1
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0
!if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE)
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
!else
--
2.38.1.windows.1
[-- Attachment #2: Type: text/html, Size: 2996 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
2022-11-11 0:56 [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs Jiading Zhang
@ 2022-11-11 1:39 ` Guo, Gua
2022-12-01 2:01 ` Guo, Gua
0 siblings, 1 reply; 8+ messages in thread
From: Guo, Gua @ 2022-11-11 1:39 UTC (permalink / raw)
To: devel@edk2.groups.io, jdzhang@kunluntech.com.cn
[-- Attachment #1: Type: text/plain, Size: 2703 bytes --]
Due to hardware freeze, it needs to wait after hardware freeze.
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jiading Zhang
Sent: Friday, November 11, 2022 8:56 AM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
The following PCDs have no value in UefiPayloadPkg.dsc，and they can not pass the Ecc tool check, so assign the default values the same as they are in *.dec file.
gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize
gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds
gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
Signed-off-by: jdzhang <jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 1150be6acd..ce7d3a7f89 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -530,14 +530,14 @@
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY)
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS)
gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE)
- gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize
- gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds
- gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode
- gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
- gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|TRUE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport|FALSE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|TRUE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|50000
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode|1
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0
!if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE)
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
!else
--
2.38.1.windows.1
[-- Attachment #2: Type: text/html, Size: 7573 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
2022-11-11 1:39 ` [edk2-devel] " Guo, Gua
@ 2022-12-01 2:01 ` Guo, Gua
2022-12-18 5:21 ` Jiading Zhang
0 siblings, 1 reply; 8+ messages in thread
From: Guo, Gua @ 2022-12-01 2:01 UTC (permalink / raw)
To: devel@edk2.groups.io, jdzhang@kunluntech.com.cn
[-- Attachment #1: Type: text/plain, Size: 3205 bytes --]
@jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>
Edk2 hardware freeze in unlock, Could you help send the Edk2 PR for it ? We can help to check in it to unlock the ECC failure.
Thanks
Gua
From: Guo, Gua
Sent: Friday, November 11, 2022 9:40 AM
To: devel@edk2.groups.io; jdzhang@kunluntech.com.cn
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
Due to hardware freeze, it needs to wait after hardware freeze.
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Jiading Zhang
Sent: Friday, November 11, 2022 8:56 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
The following PCDs have no value in UefiPayloadPkg.dsc，and they can not pass the Ecc tool check, so assign the default values the same as they are in *.dec file.
gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport
gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize
gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds
gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
Signed-off-by: jdzhang <jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 1150be6acd..ce7d3a7f89 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -530,14 +530,14 @@
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY)
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS)
gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE)
- gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport
- gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize
- gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds
- gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode
- gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
- gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|TRUE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport|FALSE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|TRUE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|50000
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode|1
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0
!if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE)
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
!else
--
2.38.1.windows.1
[-- Attachment #2: Type: text/html, Size: 8692 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
2022-12-01 2:01 ` Guo, Gua
@ 2022-12-18 5:21 ` Jiading Zhang
2022-12-19 1:04 ` Guo, Gua
0 siblings, 1 reply; 8+ messages in thread
From: Jiading Zhang @ 2022-12-18 5:21 UTC (permalink / raw)
To: Guo, Gua, devel
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
OK. I Commit a PR for the change:
UefiPayloadPkg: Define default values for the DynamicEX PCDs #3785
Thanks!
[-- Attachment #2: Type: text/html, Size: 132 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
2022-12-18 5:21 ` Jiading Zhang
@ 2022-12-19 1:04 ` Guo, Gua
2022-12-19 12:55 ` Jiading Zhang
0 siblings, 1 reply; 8+ messages in thread
From: Guo, Gua @ 2022-12-19 1:04 UTC (permalink / raw)
To: Jiading Zhang, devel@edk2.groups.io
[-- Attachment #1.1: Type: text/plain, Size: 873 bytes --]
@Jiading Zhang<mailto:jdzhang@kunluntech.com.cn>
See the PR have below format issue violate Edk2 check in rule.
PR: https://github.com/tianocore/edk2/pull/3785/
1. The commit message is weird for me.
Could you help to use rebase instead merge ?
[cid:image002.png@01D91388.D15F3D20]
1. See the CI failure, please help to run py -3 BaseTools\Scripts\PaychCheck.py on your local.
It will report same failure like CI for commit message format.
[cid:image001.png@01D91388.871DD6E0]
From: Jiading Zhang <jdzhang@kunluntech.com.cn>
Sent: Sunday, December 18, 2022 1:22 PM
To: Guo; Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
OK. I Commit a PR for the change:
UefiPayloadPkg: Define default values for the DynamicEX PCDs #3785
Thanks!
[-- Attachment #1.2: Type: text/html, Size: 6426 bytes --]
[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 59649 bytes --]
[-- Attachment #3: image002.png --]
[-- Type: image/png, Size: 72274 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
2022-12-19 1:04 ` Guo, Gua
@ 2022-12-19 12:55 ` Jiading Zhang
2022-12-20 1:24 ` Guo, Gua
0 siblings, 1 reply; 8+ messages in thread
From: Jiading Zhang @ 2022-12-19 12:55 UTC (permalink / raw)
To: Guo, Gua, devel
[-- Attachment #1: Type: text/plain, Size: 125 bytes --]
Hi.
I commit a PR again, and the PR passed all the test.
https://github.com/tianocore/edk2/pull/3792/commits
Thanks!
[-- Attachment #2: Type: text/html, Size: 249 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
2022-12-19 12:55 ` Jiading Zhang
@ 2022-12-20 1:24 ` Guo, Gua
2022-12-20 4:08 ` Guo, Gua
0 siblings, 1 reply; 8+ messages in thread
From: Guo, Gua @ 2022-12-20 1:24 UTC (permalink / raw)
To: devel@edk2.groups.io, jdzhang@kunluntech.com.cn, Lu, James
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
@Lu, James<mailto:james.lu@intel.com>
Could you help us to add push label on it ?
UefiPayloadPkg: Define default values for the DynamicEX PCDs by jiadingzhang · Pull Request #3792 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3792>
The change purpose is for resolving ECC issue.
@jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>
Thanks for the change.
Thanks,
Gua
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jiading Zhang
Sent: Monday, December 19, 2022 8:56 PM
To: Guo; Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
Hi.
I commit a PR again, and the PR passed all the test.
https://github.com/tianocore/edk2/pull/3792/commits
Thanks!
[-- Attachment #2: Type: text/html, Size: 4002 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
2022-12-20 1:24 ` Guo, Gua
@ 2022-12-20 4:08 ` Guo, Gua
0 siblings, 0 replies; 8+ messages in thread
From: Guo, Gua @ 2022-12-20 4:08 UTC (permalink / raw)
To: devel@edk2.groups.io, jdzhang@kunluntech.com.cn, Lu, James
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
@jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>
It’s checked in by below PR.
UefiPayloadPkg: Define default values for the DynamicEX PCDs by gguo11837463 · Pull Request #3798 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3798>
Thanks,
Gua
From: Guo, Gua
Sent: Tuesday, December 20, 2022 9:25 AM
To: devel@edk2.groups.io; jdzhang@kunluntech.com.cn; Lu, James <james.lu@intel.com>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
@Lu, James<mailto:james.lu@intel.com>
Could you help us to add push label on it ?
UefiPayloadPkg: Define default values for the DynamicEX PCDs by jiadingzhang · Pull Request #3792 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3792>
The change purpose is for resolving ECC issue.
@jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>
Thanks for the change.
Thanks,
Gua
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Jiading Zhang
Sent: Monday, December 19, 2022 8:56 PM
To: Guo; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
Hi.
I commit a PR again, and the PR passed all the test.
https://github.com/tianocore/edk2/pull/3792/commits
Thanks!
[-- Attachment #2: Type: text/html, Size: 5470 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-12-20 4:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-11 0:56 [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs Jiading Zhang
2022-11-11 1:39 ` [edk2-devel] " Guo, Gua
2022-12-01 2:01 ` Guo, Gua
2022-12-18 5:21 ` Jiading Zhang
2022-12-19 1:04 ` Guo, Gua
2022-12-19 12:55 ` Jiading Zhang
2022-12-20 1:24 ` Guo, Gua
2022-12-20 4:08 ` Guo, Gua
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
![[-- Attachment #2: image001.png --] [-- Type: image/png, Size: 59649 bytes --]](../../BL1PR11MB5478B56D448D3346FB05037BEFE59@BL1PR11MB5478.namprd11.prod.outlook.com/2-image001.png){kind=link}
![[-- Attachment #3: image002.png --] [-- Type: image/png, Size: 72274 bytes --]](../../BL1PR11MB5478B56D448D3346FB05037BEFE59@BL1PR11MB5478.namprd11.prod.outlook.com/3-image002.png){kind=link}