From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.17220.1667466859661040708 for ; Thu, 03 Nov 2022 02:14:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=iDr6LxQC; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667466859; x=1699002859; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RCd/8tmCx3pJrkIzALAA2m0wo/thDvY2Lh9/jcH5pBE=; b=iDr6LxQCc6WZfOoezCjjl0DoqQP+bkdaUQx3uVw+NrOb0wEOJJj3KEwY B3G5j69ajVs9OZSJ3CVQx8oBvxWbvuBYF4CViByYGoDaTUjzt4A7a22yd VME5Nmrxm7XJmzb7zzpCVfXBTAZc528iam4rvS/0WI6wJ46djOgxMbzJ0 6auHmjKKVVDSgDs0Qmbbma5jqx8mGZwuhcts//NzMAV979c285OBhpAp/ wmzz8ABgaurjSF31nYfGZ8UlxYKOt+QDob/7cQG7JgugK3xkNSiSSJoog PjGlHIAm4PD5x96ptCa3L2PlqfcKjYDY4WZlffh2QSqPY4jqM7Uo1fklo A==; X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="373860598" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="373860598" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 02:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="637101298" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="637101298" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 03 Nov 2022 02:14:18 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 02:14:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 3 Nov 2022 02:14:18 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 3 Nov 2022 02:14:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1VWNMZHSVKk8kHkBmAaeJWy9ZzNe6v26WhNfl/1WHWlplmf9BuMMmCbr8pQBkM0G4Xm1rZdzZ2d9FYKaGpAJ5+SdezIoYNxeYthUnhZHO9FU1vW8rShge4eq27ncaFpTBxcGy7U4oqNXvf+LBjGN7QmWARfiWftx3GvtxM7aMjmHzURJ23t0BoHIoPR7mY+Asb4lUV2aPg1vA/KLKM4LHGAaYgAO964Kve4Ka+S8sEm11Bnj31qMIQuMhruYZoxpbE3N9D1H5cd1RCrchGqim3mWIjEjKWwNmV3u7tFCYUv9Oym/Ma93ND9ugVhtauoSE6eWXNuWABnjLA7TNw45A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BaghOiqITlC0fHw4zLu56s69UlGujd4MyWVchQBBul0=; b=Hf74URGNouKJmvn02sJXlF9SMyn9X2nt50zaZ/0sT9RDRXcHgTlZhss0zpKj6QubET0vLG44jb0de6Aih1LAsCZ80ojQX4FagzlEdSQa76Bi0mPH+pw8J7ER3vXjNrq+CjLRpvJXwPk28j3tr67C01/Pj25o0K4I8eugyQdYffSGfLydY/osA8WIVqXzZkdxh+Qac5Lp2g49+u0RYXpELK0NocSI0ufA/XECpLRDWsE/abrgu+4PnkE2L4zb8Eu3dOeZkcwqeeekwjqyjjNFZId6iELNS1Oru6O1KszNrBExWB8jYpp4UlLvXKR+cUOwxn4/Yc2ejNByO0NsxU9oPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by IA0PR11MB7187.namprd11.prod.outlook.com (2603:10b6:208:441::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Thu, 3 Nov 2022 09:14:06 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::554c:33dd:f4b5:6c7b]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::554c:33dd:f4b5:6c7b%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 09:14:06 +0000 From: "Guo, Gua" To: "Hsu, VictorX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ni, Ray" , "Lu, James" Subject: Re: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated Thread-Topic: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated Thread-Index: AQHY72RI1l/c4hG940KJkJVtqRXuB64s6fPw Date: Thu, 3 Nov 2022 09:14:06 +0000 Message-ID: References: <97e245cdf713c239f9354a79fc9aa81c7fc72a6d.1667465986.git.victorx.hsu@intel.com> In-Reply-To: <97e245cdf713c239f9354a79fc9aa81c7fc72a6d.1667465986.git.victorx.hsu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|IA0PR11MB7187:EE_ x-ms-office365-filtering-correlation-id: 69d605ce-6d50-4ff9-d94c-08dabd7bc277 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sDZjPwYTGnnFnnIrTfdpDWyCd9sGcCE5AnxyrRHu7QmWXJAzoFye4ZmcOa6YIlgpFEVDzH28nE2yotoHAqoZ70ipBQ4Ulcd3lNS4lfXi4g1nCi2Y0wUy+3f1Wdg3lzpcoVq9R+GuotBYuRM4fK9+K9f6TSg6w+pu/1uecEehWtZbpfglBAjNccbI1gFpuNeqDMJoqm0YUr0AcYBaiekLA0qPnEljhIqj42Tr6FqXLIZhZYzGW5yQ3t0nxJN4iZwUV9uhsP6O6IPOv4SSJrSx+whoAafAt5153h7Sy8AI3Vuj+VgUlQPCiNZlBKezykII3v9aTMkwyJYzKmF3eVytwQIIPbpRLaoiVXMFU8qFLO5Qis/zDJIxQm3PU3pSA4K7H6vvC3xd2NkjSDcmrFRoj2sMxoNCdoQIB/XBjdGq4nYXwFOfAzU1eVV6mekYdVWcF5zz7d3/fzalfB3bnVeItnJZdhsof/oCgnNEABJc3tP1i3vhPwCry+BWMzOG7/XreRYKWUL0fedMa4Hc7CHAywpD376APVvEhYjKTLfok80Jl9Efi648idKWztyYUAgJ/C7mGqEM4rTbYIdgPN0FTikLYKE89coC/vvi5FWSF9M7oXI+vccdRhr7o7zgBrXLsVpfr2Lw5fA8ub7J9M0F+HbucyZ5SXK75O7iS19GvTWsJI2mdRNpOk+4Ys6j95vE5tJdIQ52beX7BxkGE3r3u8/IPQ98hcZQQV8G7GMnhGUh0LN0l0iySu0R3XYJHMxO+UuDpXWGpF9IILRdKXqdnTnNfdzx/IY/zONvsAdgEFo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199015)(2906002)(83380400001)(15650500001)(64756008)(82960400001)(316002)(5660300002)(4326008)(54906003)(9686003)(110136005)(966005)(8936002)(52536014)(71200400001)(33656002)(478600001)(26005)(66946007)(86362001)(186003)(41300700001)(55016003)(76116006)(38100700002)(6506007)(53546011)(8676002)(66476007)(66446008)(38070700005)(66556008)(107886003)(122000001)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?05Jq85qszaDh25vSV32Y4n6yK1Y57TufRoIQxgZRo4OvSCuAQtq19XY0JFQi?= =?us-ascii?Q?yiJXw7gHWvmNyfGY2eGGEu9rbyNNMfnApdUIxI0MrHNcnPfmyqmEz8Bj5PuE?= =?us-ascii?Q?FfjamlbQOemqhWqJsRThEemtrpSPeU45A0eUS5nqMHdUMQhMRMcSXX3PMCrE?= =?us-ascii?Q?e2gSwhWo3qETh0nYvHCzYyF6CQUZ4bJaPka0OIplgXnWgtiIQZS4s+XGMD+K?= =?us-ascii?Q?THwTHhoYN5qRNrIy9r1enoDG0vrnHQZpNmRukaYD/jv6pB/MXHM3jwKhRLDv?= =?us-ascii?Q?5s6nLtRdLnlqRif+V/H4Cx0MJ7MQQOgaJCmWKQ1OPQbmz+B2uUmgUa1HnSon?= =?us-ascii?Q?vU2fI876mJEQ1GlIiSXW5JrbO5puQU1LCIj0DYYixlVSj+CNgrmsmJfcm6jT?= =?us-ascii?Q?uuYgNTWqf3sX3jkfyyGL5kNfnqunGI/+LQkAOu8nD1r7v/MD4sx7goXWGZPv?= =?us-ascii?Q?lSDjjC9SwIMWryJFPH/0BgySN2mURcHjoQmfyWiLk4uXU8iFqy44FYWNPbS2?= =?us-ascii?Q?m6BHNhAv8TzASEPsf+5C0NmVdOe7Luy8uxNkaw3hHZmmRryGt0Xnp0ins7MZ?= =?us-ascii?Q?R7FfzJscH28rz/C+KXNIYySAON1b6HBzgsy9/6pvNom925m8RQ6QujAoXBsY?= =?us-ascii?Q?CQCgfXW/J5wROo7JTFxvZ8iG7uvz/lRTQ43AJdKrJWdGLRjgJNtXl7RkzRoR?= =?us-ascii?Q?lXbPwBe3E2OF5chaIZ1u9jCBtJOK5hCjCFtALmhPGVaceS1Ln2cwhJmLhViK?= =?us-ascii?Q?jbeqwqB3v7UXgrD7G6NOeL4YGKFD7kIiq0xGQMTtV//i14O2IveRrfXL4nPM?= =?us-ascii?Q?X9LshZdtXfaO/tW7s52o+dQDHD/cVDof4otA/RgpeWtrEnITT90UVjNgPEsA?= =?us-ascii?Q?bWgSpzmwxlF6iH54G1UoE9XTphRpn5YbxJ3132510a5fXwUVoy91SPUUdivP?= =?us-ascii?Q?A70mDhtlMVJNT+DClAKtiUTPDdsM7CWK98gPEGN+EsNrjVAbWWRSzBJ03NHv?= =?us-ascii?Q?1gL8D08pAJcXSGBtidoC3EM6VIRlyA3H1ZY6/27hsxnmhrRlotW7yprrp05C?= =?us-ascii?Q?4FAe4ZF7B5L4Ft4C1r3fPHwDQyYrCM5klgZAz1co40fuIiejYLokTAi+SKwD?= =?us-ascii?Q?dQCkA1XlK52DDqR1oELX08HD67xgKtC35ROY3y9FBcj1CSfctCAo4wpyoBw9?= =?us-ascii?Q?3n39DefBYLYgISVh+9ZGPiDj11a5WuEwlLHwqDpF0SKAQseQfD+4e+qn1ILN?= =?us-ascii?Q?9MbZzLWHrxd7yK9lseOJvCoq2sJlocugS0n0fVJobZb8MACkvtdSeX0uLJX0?= =?us-ascii?Q?3g6o1W2729yXe8VeGK3L2PiL8ZreZmnNuuYIzZ24RwxhK2uuIANoQ/yYNzfQ?= =?us-ascii?Q?TZ75YoOt4q8eN8WlewdXqWpS0aDg4BZ12Te+uMprEqMJUvRzv4cZrzDGYYXG?= =?us-ascii?Q?1PcYgBXpRtxjqb7ExbOO+omlg5oOoPlQgBep5AyB2NXdRl6BJGZhNhaJH+4Y?= =?us-ascii?Q?0sVry9MMFHU6DC32/OVbCksCDSv4m0lrnxHx1VpP1AW6nXyr+ay1cL22BvjU?= =?us-ascii?Q?PMakCUpttkHTF7pb8lg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69d605ce-6d50-4ff9-d94c-08dabd7bc277 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 09:14:06.6983 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XcfbI9LKcCMyTpVD+SkU1hXtVYSXPx1oAZ2ds7SRa44dVT9yvkD+uceGKiy0TnaFzMLGzBxaUFTXlk8FBgufTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7187 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Give + 1, it can help to unlock Capsule Update through have correct Boot Mo= de value. Reviewed-by: Gua Guo -----Original Message----- From: Hsu, VictorX =20 Sent: Thursday, November 3, 2022 5:11 PM To: devel@edk2.groups.io Cc: Hsu, VictorX ; Dong, Guo ; N= i, Ray ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated From: VictorX Hsu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4136 System will depend on Boot Mode value to do different behavior Update durin= g Capsule Update process. So UPL need to support update boot mode. Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: VictorX Hsu --- UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/Uefi= PayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c index edb3c20471..2ae6b088ab 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -309,6 +309,7 @@ BuildHobs ( EFI_HOB_FIRMWARE_VOLUME *FvHob; UNIVERSAL_PAYLOAD_ACPI_TABLE *A= cpiTable; ACPI_BOARD_INFO *AcpiBoardInfo;+ EFI_HOB_HANDOFF= _INFO_TABLE *HobInfo; Hob.Raw =3D (UINT8 *)BootloaderParame= ter; MinimalNeededSize =3D FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);= @@ -368,7 +369,8 @@ BuildHobs ( MemoryTop =3D FreeMemoryTop; } - HobConstructor ((VOID *)(UI= NTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom= , (VOID *)(UINTN)FreeMemoryTop);+ HobInfo =3D HobConstructor ((VOID *)(UIN= TN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom,= (VOID *)(UINTN)FreeMemoryTop);+ HobInfo->BootMode =3D Hob.HandoffInformat= ionTable->BootMode; // // From now on, mHobList will point to the new H= ob range. //--=20 2.28.0.windows.1