From: "Guo, Gua" <gua.guo@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD
Date: Wed, 24 May 2023 08:43:41 +0000 [thread overview]
Message-ID: <BL1PR11MB5478E6BD8466FA5AE1869791EF419@BL1PR11MB5478.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230524084239.1223-1-gua.guo@intel.com>
V4 patch can locate all previous comment.
-----Original Message-----
From: Guo, Gua <gua.guo@intel.com>
Sent: Wednesday, May 24, 2023 4:43 PM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>
Subject: [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD
From: Gua Guo <gua.guo@intel.com>
PR: https://github.com/tianocore/edk2/pull/4416
V4: merge mRtcIndexRegisterIo and mRtcTargetRegisterIo into mRtcIndexRegister and mRtcTargetRegister
V3: change UINTN to UINT8 on global data
mRtcIndexRegisterIo
mRtcTargetRegisterIo
V2: Add more dynamic PCD for runtime service support instead of taking for FixedAtBuild case
V1: After https://bugzilla.tianocore.org/show_bug.cgi?id=4193
RTC Runtime Services unable to get correct RTC time.
Solution: Cache RTC data, update RTC driver not to use PcdGet after driver init.
Gua Guo (1):
PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD
.../PcatRealTimeClockRuntimeDxe/PcRtc.c | 36 ++++++++++---------
.../PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 14 ++++++--
2 files changed, 31 insertions(+), 19 deletions(-)
--
2.39.2.windows.1
prev parent reply other threads:[~2023-05-24 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 8:42 [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD Guo, Gua
2023-05-24 8:42 ` [PATCH v4 1/1] " Guo, Gua
2023-05-24 9:44 ` Ni, Ray
2023-05-24 9:47 ` Guo, Gua
2023-05-24 8:43 ` Guo, Gua [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR11MB5478E6BD8466FA5AE1869791EF419@BL1PR11MB5478.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox