From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.4178.1684917825241246156 for ; Wed, 24 May 2023 01:43:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HvZ3zPoR; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684917825; x=1716453825; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=mzFOl/P8lsmU10/3N0l9HKsaWhlx9hVy9p5tj2e4Dqw=; b=HvZ3zPoR9x6Kbt7YvSUJSMEl2K3hDud4REa/pF/jn3knLiaOFaNVRSx8 OnvGiLZpuJUJqS/LKMfB9RI0iixH3HSfrcAYWjHL8zNWMRMdoacCvD2Wt l3UhbfHOq9XPBCIRKeC1WKGG9qkVTe7On/7Lt+B+QWs74laLDb7qMOPzF zTrocnvWk8SNF8i54qPn2Hdrm0ZkOnUV8a27Yjkg31DPYTOGCuNKmS+so khM3wbgrjh2XL/YkaxYsjwwze3yT5wLEnb10osK876v15vh4qAnOHSSZM Aq8/q4rN2QM5fYmXiYE1rFmlZIKbSpliVtMQ1eeKN2GOjlX+GggZ3bHCh Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="342963235" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="342963235" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 01:43:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="737210417" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="737210417" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 24 May 2023 01:43:44 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 01:43:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 01:43:44 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 01:43:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgfNdcXYPA+FUl6gjOpe1BgHPRzFVIEoQX36BUI61FgWjeO5qZrdEqzgF1MyO2/d+bBX6BHEKtJCXLKmPkz+e5X72DuVGpqCCFs4BjlCug/zP4C/AqRvcJMfDY1xFFXN/+w6fq1JkUBHJFNx9uytv1W4hNFAIncxUY0PeauS7g+aPUuiZkIDGrlEFtqsZTYtt+SCP/b9kufbGoNdZX5EkINQ3b6FxSvCoJlR42z9MqdWBFrhXKFveF8wgdre67vVAOAI1goRkB62IQJSjLNKu28OjbbesiRwqvjf60xqIRzA7LSObHiSPkFeZrk/Oq38Bu7O4JVEBd+dwk0opClAhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zNZWumTvCuGvHB7JUGvLMwmTwQSQtRfKDowrVc6oXaA=; b=GImrYdiG2RaWWuzMWbHkEoZuhG/Botv9CiAid8j4m+D/mYuckUPxIoH+IwWpUpZK7nC/ToV52+d89NQvhhdopGRIy91TJzjd7RHHHLuY5AsnOTpr0BvWHXMtTOtPjcHfVP0tzu8l7PiIDxRdW5PJ9cHWN5omfIzg/C9qSoYJq2HC5QVL/XUFWOlA68p3i46VZfc/VBgI3IReQmJRX+bbfyLgIBEgMovZDrya9aUJ7t6RYK5zNXd0cPuRHf7n2zWc/ot0I0X0g8ne9pAo08vf1pPVHaAL5qATtwWFGK2rNFVF6M7JwaUUACeih/kHqTbZ8Yb98LnpBDgbPP/rUPlPnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) by MW4PR11MB5871.namprd11.prod.outlook.com (2603:10b6:303:188::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 08:43:41 +0000 Received: from BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::f50b:35fe:b26f:ec5d]) by BL1PR11MB5478.namprd11.prod.outlook.com ([fe80::f50b:35fe:b26f:ec5d%6]) with mapi id 15.20.6433.015; Wed, 24 May 2023 08:43:41 +0000 From: "Guo, Gua" To: "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD Thread-Topic: [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD Thread-Index: AQHZjhu5gNJHB7S0SkCgxuE9UbOKma9pG1LQ Date: Wed, 24 May 2023 08:43:41 +0000 Message-ID: References: <20230524084239.1223-1-gua.guo@intel.com> In-Reply-To: <20230524084239.1223-1-gua.guo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5478:EE_|MW4PR11MB5871:EE_ x-ms-office365-filtering-correlation-id: 6d6f867d-a629-4027-82d6-08db5c32f9ef x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FR8fm4KKeiCF4pKRl+7mVL2rsBdEHERdDdOQWHhgRXJg8ueRfCRf3k+tmY8JNRuqB0DET+4DRD8/ATqLc/xeCBfVXAzowewkxpFYreBZozyUWHnnVMVMBtVN08Sxext8A416jXW/Du2NnqMSgntpq4qHCan26ARF1lBWx5hI8v63P3xwJ8OT1eWCRPLXm+pBLBq1WWESNyHs/Yr8wUvKu/24ILqiDvY7KONUfH3mpj8KxlxLFVGKGxOmcJGysojdh4/pXoj8YCDSXoc5oJKNFDvSaVf4RdEKVoU+fGsOyldmcRCH047mfZzpFoc1S8P/V1JKKEMxcHEbPCE/27GNzARkBYw4lxDDKoj60uiYxRUewcbNnup4usufjjbjlMZYLxLCu2mXvaAb/MAVZOnwZF9ss+4/ExV9NFbv3Wss6nG/k7npL5QT9D0hYA1AwWrXZxS8L2Z83GHgDvnY0LSpcoQorqL0SYc++SUgCYddPm0OQg+cRsFrpmbZ1w3PMYAdPWP222IMn7tPo1o3P8wIsIcSYr8eSaa3K5page/9H4PilQIa1yRjNGeOb5eyBlbJPIJtHQ8MrTl+tNtm5rr4iK8nW+O5k6gsl9e+D54lc3amBCcwIVb3RPzMx4z1F/4hjGtx+LkfOluvCVGiAGbZKw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5478.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(366004)(346002)(136003)(396003)(39860400002)(376002)(451199021)(38100700002)(66556008)(66946007)(76116006)(66476007)(64756008)(6916009)(478600001)(66446008)(7696005)(966005)(316002)(71200400001)(41300700001)(52536014)(38070700005)(4326008)(86362001)(8676002)(5660300002)(8936002)(107886003)(186003)(33656002)(122000001)(53546011)(55016003)(9686003)(6506007)(82960400001)(83380400001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o0bPWpiWHAtUvQtjQID22t2+S7ZLK34PthsebKZtIVtxWlNuZP/Ewz+6twhW?= =?us-ascii?Q?3S/4ewAc5G5ucUimcrA85GA8qGvwjobUaqoXlj/H4tvQemJurqoHiHWAG1VQ?= =?us-ascii?Q?ohUyjhIgWCxSJdw7iFI0w2M2KBecnFiappOXDRFrl5Df3uSO5ypm3ooAT3lc?= =?us-ascii?Q?V7dsDjwRMGv2XU9qu0eklYCWvZlXBpBWqim7Y2Bfi22fk3lbjjc3aEalUdP3?= =?us-ascii?Q?c1o9EubUpxW3c4OGByVOIw01pjBfiOXlv5NrWt4wzygLyJavFiLHpKrH1rSE?= =?us-ascii?Q?iVvH9XvlqZ6afT2ILZYqnUloFlO2qKST0gWBjbKzUTcn1QLW8/VN3CbzoU4X?= =?us-ascii?Q?VjiD2TgouxZ1CSK2OvmCUhF9ICAwqYJ3uwjRa+kWmVrZylpCZeW7gtZiD3SF?= =?us-ascii?Q?9ZpKFDYFoNFPUpsAXklvtg2yKpCH7so1unJqw+ciCe0SYi+VBZ04NmBDaT4F?= =?us-ascii?Q?M0XknGH2CprCMnhZWYzc7Ep1LsurM3hMU0qn3tnl/0QXZNgm16HZjJtuN2h4?= =?us-ascii?Q?BMjByc5G+4g+RLZWlDAggD1jYaYMfl+rNGAHwE063AtUuBW/iiQVetMg+TZc?= =?us-ascii?Q?iNpk8gARNgc3HFS3pfnxhRQVBN+huZLkItJF3H+80tig/6xLXRiCYIWWHQ5h?= =?us-ascii?Q?ON/h4strJJvxSzNK+E71CMfl6FpzprL9XGcAf4BM6WNUArRu4K5AWs7AmVib?= =?us-ascii?Q?lASv/wid1BYCJUpu8VxX6rFRpOQxHJl9k++od+S2xb9SAfh/sM0cBDs+WL5p?= =?us-ascii?Q?Euwb0n38PxLBdBqnqayv8tcw/qoCo9vIA+SbUce10p+1lS/12+A+hk4vbsSa?= =?us-ascii?Q?mGNeMBIivsaKf8dNKlt94J5HOV/tDoc1WUrqnWnr2ujLSLr/1HO6pG03BrKi?= =?us-ascii?Q?9Zjte3tGw86DU3OC1VpYzc2WwPQst1pnf2hSdz9H3Z7vXX0ezVp7DOepwB78?= =?us-ascii?Q?a3rSpAHBfBa+l530aXkZD6cjbqIxDmYYCQDP94pyuDLTUMGAsWTy946bPVGY?= =?us-ascii?Q?unEvzmp2Nnz4IBVt6TYwkbHc2opM9VZ2mdL+kskD5jjqMeqQlZpVKXXdJLWl?= =?us-ascii?Q?FmQshtCsPtSyTAoNBERZDWTDG+0bLhWUqqzn7eebed6jucmgBxsqUuoBMQKF?= =?us-ascii?Q?Q1P9XaY4aXret9smNarCEt8DKj7mXy4O1b5pGtnjXBK3Ts9azQVgs7ohdtrR?= =?us-ascii?Q?QuRFNDI+QlPTGwh2fOpX8KVEDZjAvggc38lZad6vraymzIV/EJ8ekMrrZUUA?= =?us-ascii?Q?DDL2CXnPWrbkm+QnjhTd5j7h1srykwNdYLIufq0Z4mz72OdxganXr5KMPpiF?= =?us-ascii?Q?9s9hvP1jjD0grJz9bOnKl5rqD+SKWRUUpp42CtPph0ov2oN3j+zUeIqaVB1G?= =?us-ascii?Q?eNbdAzyp8Ukp/e1BKaIsm/aXUBc5qS3vDNZ/IoOxTl1J0cYGEz0p019VEiAR?= =?us-ascii?Q?XBNcvPU2oOfAPg/ydQJ81k2933WbvqrH83MmXmHvYywxqOkWsm/TATAOwiN5?= =?us-ascii?Q?kg+1Kun6Aa/7D5983/OPgoHWrqAIdCZ/DQsXSLNmPxdKQo00uBP7mr+IBA?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d6f867d-a629-4027-82d6-08db5c32f9ef X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 08:43:41.4370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1cQKdYvHrVLZNyOqE+EBHvXo+GroTVLQaWsRmLF44HDCjmUW8QMXlijUiS+enr6plZnXve6bKEDJtZUfK0qqHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5871 Return-Path: gua.guo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable V4 patch can locate all previous comment. -----Original Message----- From: Guo, Gua =20 Sent: Wednesday, May 24, 2023 4:43 PM To: devel@edk2.groups.io Cc: Guo, Gua Subject: [PATCH v4 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct I= O port by PCD From: Gua Guo PR: https://github.com/tianocore/edk2/pull/4416 V4: merge mRtcIndexRegisterIo and mRtcTargetRegisterIo into mRtcIndexRegist= er and mRtcTargetRegister V3: change UINTN to UINT8 on global data mRtcIndexRegisterIo mRtcTargetRegisterIo V2: Add more dynamic PCD for runtime service support instead of taking for = FixedAtBuild case V1: After https://bugzilla.tianocore.org/show_bug.cgi?id=3D4193 RTC Runtime Services unable to get correct RTC time. Solution: Cache RTC data, update RTC driver not to use PcdGet after driver = init. Gua Guo (1): PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD .../PcatRealTimeClockRuntimeDxe/PcRtc.c | 36 ++++++++++--------- .../PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 14 ++++++-- 2 files changed, 31 insertions(+), 19 deletions(-) -- 2.39.2.windows.1