From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7C4BCAC12AB for ; Fri, 17 May 2024 17:54:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=e/qtqcB07aRftr6UKn0eP0/SWN2WPI41my9wCVvtE+4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715968494; v=1; b=On1gY5aC39muXK1oOE4lwKWMvsQf3JQjiBgM3vl/SV5aOaxkTMXWBI7zfXlr3sPSfVoBsw8p K4/UuPSHN7sqQ/+gppy7714r78DLPS29D1Xoj8tgTsajUupyUfLC5DSgWW1ulXZrMGFlhz4czHE azXskfEC6XMbGmd/4S/PGaHyJYDwZSFYP9zpAvZ4oAtvkcos7uTwspX9NfJf5tSRUilvySu1BkX Ts13e4rFcKOSOp/3PZzVkJiGahs7oYcHaVUZaJiHfOwnyNuuEsyhPUQBa7vdE0919eEwAGmLnCh Wlq/vBC0VAJfCDidyDRuB3E8wn/RqottkCTIhxeqEc4Mw== X-Received: by 127.0.0.2 with SMTP id Pd7jYY7687511xkLBEQCeIag; Fri, 17 May 2024 10:54:54 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.55]) by mx.groups.io with SMTP id smtpd.web10.29568.1715906349271657660 for ; Thu, 16 May 2024 17:39:09 -0700 X-Received: from BL1PR12MB5288.namprd12.prod.outlook.com (2603:10b6:208:314::23) by MW4PR12MB7240.namprd12.prod.outlook.com (2603:10b6:303:226::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.45; Fri, 17 May 2024 00:39:06 +0000 X-Received: from BL1PR12MB5288.namprd12.prod.outlook.com ([fe80::b2d4:5bff:834d:9c59]) by BL1PR12MB5288.namprd12.prod.outlook.com ([fe80::b2d4:5bff:834d:9c59%6]) with mapi id 15.20.7587.028; Fri, 17 May 2024 00:39:05 +0000 From: "Ding, Feng (Sunnyvale) via groups.io" To: "Ni, Ray" , "Hsueh, Hong-Chih (Neo)" , Laszlo Ersek , "devel@edk2.groups.io" CC: "He, Jiangang" , "Chang, Abner" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Topic: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Index: AQHaZaw/u+6udaw1wEaHEizZxZn+grEbGkMAgGZxw4CAC5dmgIAN9hhQ Date: Fri, 17 May 2024 00:39:05 +0000 Message-ID: References: <3a640aa0f5555ccc327588ef7bb8d4ba5941442d.1708619173.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=6af39b66-5ad1-462c-8800-a8b98572128d;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-17T00:37:44Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR12MB5288:EE_|MW4PR12MB7240:EE_ x-ms-office365-filtering-correlation-id: 5773d493-9545-4a81-dbe0-08dc7609c1a7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?wHcZrF6P3oGbRByJlDi0OIcfzjqB16wb12jPDlDdLepaH/FUDVPyNO2ohEi7?= =?us-ascii?Q?YhzlWnPxjq/AFDAX4sSyMM10zQeoWNxdAjx7fPieM2D/ZSMkTliPYAGN1BKe?= =?us-ascii?Q?goLmpgzZpP9Fzzfuk1H5xYMWEbi0eAhyWKWVfFAZrlJZgp5BHxiHy5I62uDz?= =?us-ascii?Q?TzUGe7S/qcWyNDPGLyMOGzYxNA851Qo1SDtnbr9xSeOClcMmONPC0QMyc4y8?= =?us-ascii?Q?V8L6RVroV8AtkBbcvNyTc8qcDAJxkKmQVR+F64dQRAU4pqwvpccsIABl2uhl?= =?us-ascii?Q?5cCIsTXeKWmBvzl2yrEmdgtRS+vcV2kmZmjfsKXRIrCgwDGnBZAplBAIZQaZ?= =?us-ascii?Q?gfqyXbbVJS0r+hLHp5oaUTWDKrZsTzYcuhSuefUv5gIiHHgp+aVXvVB9uw6e?= =?us-ascii?Q?gCy9A655mdahMI5S4LvhNDBzyDHuVeDc+ukQnv9W8J0warq7wSsropS+UQr/?= =?us-ascii?Q?N1s0bcAX3nBtfpZZU0XgWxmYMeIH0F3VER1GRH2K5oArJTuEBVaBO0EUS2Ln?= =?us-ascii?Q?ElclXMg1tPXiiJaDnd1+1CVJKvt3CxZiFR4DNkyrNJwMdIeF1QzKLbVRJkXA?= =?us-ascii?Q?6/CqsinJGiAOMCTrKJzASYBrYeMUVODoDnVlZhj70+QtR0qlyDnfCTUDA02H?= =?us-ascii?Q?2cqwf2aXkzVf55ZPY/FMV9fNEquEiENqkMVqTNHXgCfaO4cEX36Bh9/+1Rqh?= =?us-ascii?Q?ubXrB4ciUw8h4jbFdAa567jOioxPu7wQNuKR+/qcDK53c93jcrjvYIwNbQnW?= =?us-ascii?Q?/jcPPyhmUjySR/o+eXS1cxYFxhkII5xtUA2wAYOkK1eQIFNTXnv+njn6O2F6?= =?us-ascii?Q?3xHGntJ8OUG3Qf1QWAA+D6dztPQkmfBODXnh1WiWWz6vy20M+R9soVQn/tdD?= =?us-ascii?Q?f8LaUzxKhH28Ceq1DEhFM0ruS0w+ruHmp60x7EDY82gvHfVu24XehTzOpNdi?= =?us-ascii?Q?4KtPeMXMSlwA1xNNKEyAVDgSWiJUIi6aegcospPdzUFCZb+TFq0KweZ7unBW?= =?us-ascii?Q?rmV2e8qDqI8h6vEh9l4DuK01e0n9pj3p6f9lTTff5+/B5QpqAS7csAUxwCmu?= =?us-ascii?Q?Jc/WoAYks8vpvIbvgYin7dazRpLcMiw4qu9yExNKPB6hEgXG1hmoC5WDznyf?= =?us-ascii?Q?3yYr78HJOg//omTDfAtevTvcFGc3QmOZNdaCK9fzFXqxFF1F7NaU1iWmij+N?= =?us-ascii?Q?LvaCS5qol6EaYW/e7gNJ9BnpQuZvQzLHTMHNuN6qZs4baj4cclxnqj00G86b?= =?us-ascii?Q?5i0lrb4SaJir+IQonsA3yWYlhCeSDOjV6RNiODEuqa27tek7AW/RBaeoDFaG?= =?us-ascii?Q?PQNa49MxHgFST0yy6Q3JbWOMzU9USdqEBKAgIT2E7wBJ1A=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C6A6I+Dt+mYjZyJ3b7ZM6Rb+YJ2MYu/g9RcugT+9R/N6Jy42dOqsyu12vRfP?= =?us-ascii?Q?WjKojRrwM/Dyr/IMduxVXWyR0cNIa19p83FiwA1Jamxl0lkoszmubhxW5mgQ?= =?us-ascii?Q?8+OUOi/59n/IZJbL7JsfP/xmfPx59afsnxIjFwAQovZ0Rzb9JuqFGzOhEHH6?= =?us-ascii?Q?zt3Y2w6TDT66L95tAhieauWPXzJOnpBH6tR4M1DnR1V6VgzLhUlK59FFZ7J+?= =?us-ascii?Q?KeQpAjOlXfiMwLHHSg6gSAZ1pwyRQNbAnkEvmN8NHeBvif7zaOMRNI7+0HRq?= =?us-ascii?Q?Fz5KpCQXXbKtm/VnFpnrkACQZhwzouTGSQUMYk8Ly5RIeW46CXiCqqcR31ns?= =?us-ascii?Q?wqhQIKHjGuHPM7yfp8k2Un/3cX+KtNzI8boMy45n+x0kcHhfOZUpwJvcoyjz?= =?us-ascii?Q?PEt6GWxVFHHY6cgBklw13AM21qFQioGo3ALCYPPq1O9jpvxHZi/l16Bwv03U?= =?us-ascii?Q?5ZgJvdL8OkW80V2pNScw8eYfETCy6HD7ixVYkn5mNmtP08Xt6K/79bLlE/DA?= =?us-ascii?Q?cM/WgNrj9TRLP/s+v8rIosmLl9DMW8okwhZ6yK5hs13rmfBuUB6yv3ph1a2W?= =?us-ascii?Q?Q2rJhhh7KdTUX5Pb2Uwe2A4w2MeocJ5omY8jQb/B9QVVwPY85QWhaPyhpju/?= =?us-ascii?Q?dpUIAW4le1Hm90weLQtWYdnjjaq1P0o9XGaAzNLkVmXDEGalvpFwMd0amTTw?= =?us-ascii?Q?qLYi34SRGdLsTHHJl9I6Pxw3XCwXTs/lkAu56MruaVimmObDBN6tw33bU6Mf?= =?us-ascii?Q?klk6W/jHHtWo26QPXn/rAZnj8acrGaTIGLpRZhiWaP20qXCV6VRStVomlc9e?= =?us-ascii?Q?tU9qcKYuk+ERcL/isV7Uxi9sygcSXB4bANoqLyLVVljatR+zuTnDaDd7qbZz?= =?us-ascii?Q?uYO4rK9LvJpT6Ow7A2xp9kqRsBeCtFN6cOS4tf1Hym7aDiWgcrWP7ztDru91?= =?us-ascii?Q?COxVFqfsxzE23hC6dmKKJZykCZVrpOgbdGtaqum8rPUJyDwc2O9bYxZOPhWL?= =?us-ascii?Q?ZzHrHITrcHhL93fUn2k7OoF7lkPtWh9tqqPh4TUgqNITKzJqmP2m5R+g2cbZ?= =?us-ascii?Q?r6tVDGs0HzV/tSLC/9i7SuqTlPVxeG6m9TlNVZTljg+vlawwFj0o0s+waz8H?= =?us-ascii?Q?trR47/K/APxfNup3skPQxs0zQOXMToDNZvHeYY++Bxy10btqjpbWYDG2gO2i?= =?us-ascii?Q?NFXZf8TA4iBH5VpwdIalq992D2eZcUD2/AUYHwe1FCxL4cmUFPXOI7RKNuEo?= =?us-ascii?Q?4zN8Ni0ZEwda4LX/nvfFhjqjN1Euv3Lw0SUqHQJgRpWqOz7kIB0eLFUpdSHa?= =?us-ascii?Q?iJ7r6yWbedRCTE1F1UObWKa2x4j0bE1R+XTiAREgAOZkv0Pn+8oqY1VXOmgH?= =?us-ascii?Q?2MXKQNl/e82JPLWdU+7zYhrIrKxO2bhi5labVp65JjyOf9iCBy6NCiIekyQf?= =?us-ascii?Q?lqFwXn6Y+uH0KSElSyWs1n+f1pJqsHDl/XiacimfQcFRJq+dpQTsRBgZllX2?= =?us-ascii?Q?M3pcpWRJ1S9pbbBRZLnpLTfdmbHLg9A0SVXva8sYx4OxpskKOmXe4FrpADrf?= =?us-ascii?Q?psYkmn39GRoII05iTp0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5288.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5773d493-9545-4a81-dbe0-08dc7609c1a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2024 00:39:05.5349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DrjcZJ7//zMDg6rbNMLoojr2LqXjCdgPCKoZkZDIxkalgtCBBHGQim2zGjb2INP1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7240 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 17 May 2024 10:54:53 -0700 Resent-From: feng1.ding@amd.com Reply-To: devel@edk2.groups.io,feng1.ding@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0KI88cU67znaDL3DBu7DnYoWx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BL1PR12MB528864B10CE8416BC70E52C9CCEE2BL1PR12MB5288namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=On1gY5aC; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_BL1PR12MB528864B10CE8416BC70E52C9CCEE2BL1PR12MB5288namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - AMD Internal Distribution Only] Hi Ray, You are right. The change is NOT necessary. Thanks feng From: Ni, Ray Sent: Tuesday, May 7, 2024 8:26 PM To: Hsueh, Hong-Chih (Neo) ; Laszlo Ersek ; devel@edk2.groups.io Cc: Ding, Feng (Sunnyvale) ; He, Jiangang ; Chang, Abner ; gaoliming@byosoft.com.cn Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Neo, I don't think your change is needed because of the following existing logic= where RemoveAllPciDeviceOnBridge() is called to destroy/free all PCI nodes= . if (Operation =3D=3D EfiPciHotplugRequestRemove) { if (*NumberOfChildren =3D=3D 0) { // // Remove all devices on the bridge // RemoveAllPciDeviceOnBridge (RootBridgeHandle, Bridge); return EFI_SUCCESS; } Thanks, Ray ________________________________ From: Hsueh, Hong-Chih (Neo) > Sent: Wednesday, May 1, 2024 2:24 To: Laszlo Ersek >; devel@edk2.= groups.io >; Ni, Ray > Cc: Ding, Feng (Sunnyvale) >;= He, Jiangang >; Chang, Abn= er >; gaoliming@byosoft.com= .cn > Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug [AMD Official Use Only - General] Hi @ray.ni@intel.com, Sorry you bother you, may I have your feedback for this patch? If it looks good to you could you help to give me an R-b ? Thank you. Regards, Neo ________________________________ From: Laszlo Ersek > Sent: Sunday, February 25, 2024 7:59 AM To: Hsueh, Hong-Chih (Neo) >; devel@edk2.groups.io > Cc: Ding, Feng (Sunnyvale) >;= He, Jiangang >; Chang, Abn= er >; ray.ni@intel.com >; gaoliming= @byosoft.com.cn > Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. On 2/22/24 17:28, Neo Hsueh wrote: > A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The action= s require PciHotPlugRequestNotify to add a root bridge or remove a root bri= dge completely. > In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return wit= h no-action on second plug because bridge tree shows configured. > Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug ev= ent to fix this issue. > > Cc: Feng Ding > > Cc: Jiangang He > > Signed-off-by: Neo Hsueh > > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModulePk= g/Bus/Pci/PciBusDxe/PciEnumerator.c > index 3f8c6e6da7..2b7af60e0a 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify ( > } > } > > + DestroyPciDeviceTree (Bridge); > + > // > // End for > // This looks convincing to me, but I don't now nearly enough about PciBusDxe internals (resource management in particular) to confidently approve this patch. I can give an Acked-by: Laszlo Ersek > but the patch should not be merged until Ray provides an R-b. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119051): https://edk2.groups.io/g/devel/message/119051 Mute This Topic: https://groups.io/mt/104511503/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BL1PR12MB528864B10CE8416BC70E52C9CCEE2BL1PR12MB5288namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - AMD Internal Distribution Only]


Hi Ray,

 

You are right. The change is NOT necessary.

 

Thanks

feng

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, May 7, 2024 8:26 PM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Laszlo E= rsek <lersek@redhat.com>; devel@edk2.groups.io
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jiangang = <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; gaol= iming@byosoft.com.cn
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarch= y leak upon bridge hot-unplug

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Neo,

I don't think your change is needed because of the followi= ng existing logic where RemoveAllPciDeviceOnBridge() is called to destroy/f= ree all PCI nodes.

 



 

  if (Operation =3D=3D = EfiPciHotplugRequestRemove) {

 

    if (*NumberOfC= hildren =3D=3D 0) {

 

      //=

 

      // Remo= ve all devices on the bridge

 

      //=

 

      RemoveA= llPciDeviceOnBridge (RootBridgeHandle, Bridge);

 

      return = EFI_SUCCESS;

 

    }

 

 

Thanks,

Ray

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Wednesday, May 1, 2024 2:24
To: Laszlo Ersek <lersek@red= hat.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Ni, Ray <= ;ray.ni@intel.com>
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jiangang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; gaoliming@byosoft.com.cn &l= t;gaoliming@byosoft.com.cn&= gt;
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarch= y leak upon bridge hot-unplug

 

[AMD Official Use Only - General]<= /o:p>

 

 

Sorry you bother you, may I have your fee= dback for this patch?

If it looks good to you could you help to= give me an R-b ?

 

Thank you.

 

Regards,

Neo

 

From: Laszlo Ersek <lersek@redhat.com>
Sent: Sunday, February 25, 2024 7:59 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jiangang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; ray.ni@intel.com <ray.ni@intel.com>; gaoliming@byosoft.com.cn &l= t;gaoliming@byosoft.com.cn&= gt;
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hie= rarchy leak upon bridge hot-unplug

 

Caution: This message= originated from an External Source. Use proper caution when opening attach= ments, clicking links, or responding.


On 2/22/24 17:28, Neo Hsueh wrote:
> A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The act= ions require PciHotPlugRequestNotify to add a root bridge or remove a root = bridge completely.
> In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return = with no-action on second plug because bridge tree shows configured.
> Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug= event to fix this issue.
>
> Cc: Feng Ding <feng1.ding@amd= .com>
> Cc: Jiangang He <jiangang.he= @amd.com>
> Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModul= ePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> index 3f8c6e6da7..2b7af60e0a 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify (
>        }
>      }
>
> +    DestroyPciDeviceTree (Bridge);
> +
>      //
>      // End for
>      //

This looks convincing to me, but I don't now nearly enough about
PciBusDxe internals (resource management in particular) to confidently
approve this patch. I can give an

Acked-by: Laszlo Ersek <lersek@redh= at.com>

but the patch should not be merged until Ray provides an R-b.

Laszlo

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119051) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BL1PR12MB528864B10CE8416BC70E52C9CCEE2BL1PR12MB5288namp_--